- 24 Jan, 2018 40 commits
-
-
Wai-Hong Tam authored
The extension needs autotestPrivate permission to change the display settings, like screen resolution and rotation. BUG=803543 R=rdevlin.cronin@chromium.org Change-Id: I835fd549730dfa8e7ceaebc96737c4b957f802d5 Reviewed-on: https://chromium-review.googlesource.com/877326Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Wai-Hong Tam <waihong@google.com> Cr-Commit-Position: refs/heads/master@{#531741}
-
Peter Kotwicz authored
BUG=797999 Change-Id: I7545418680181af1c47fb5cd6578299be5f3deba Reviewed-on: https://chromium-review.googlesource.com/872572 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531740}
-
Jungshik Shin authored
Bug: 803571 Test: components_unittests --gtest_filter=*IDN* Change-Id: I8cc473d0e74208076a2aa17c1869d14bbfaa20ed Reviewed-on: https://chromium-review.googlesource.com/882006 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531739}
-
Khushal authored
For images not pre-decoded using a task, they are always assumed to be at-raster and don't count against the cache budget for locking beyond the duration of the op that uses them. Allowing them to be budgeted would help canvas use-cases which repeatedly use the same image by avoiding the lock/unlock churn for every op, since canvas never performs any pre-decoding. R=ericrk@chromium.org Bug: 804325 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia316121af3fcfbe1e87c5750bf92357888c678bb Reviewed-on: https://chromium-review.googlesource.com/882553Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#531738}
-
Pedro Amaral authored
There is a race condition where a user makes an insertion handle and then long-presses some text to make a selection. This can result in the |INSERTION_HANDLE_CLEARED| coming after the call to |SelectionPopupControllerImpl#showSelectionMenu()| which resets the menu position set by |showSelectionMenu()|. This CL fixes that by first making sure there is no range selection before trying to clear the insertion handle. Bug: 773515 Change-Id: I16b1e845b3960420f424dd04d418464a26bc5f1b Reviewed-on: https://chromium-review.googlesource.com/884508Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#531737}
-
Albert Chaulk authored
A CastWebViewExtension gets created when hosting these pages, which handles integration with the extension system Handlers for the chrome-extension: scheme are installed during startup allowing URLs to reference pages Bug: b/70571389 Test: Local build, testing flinging chrome-extension URL Merge-With: eureka-internal/126605 Change-Id: I5cefca57bb5b8d6bee21a17ef89b602bca5411c2 Reviewed-on: https://chromium-review.googlesource.com/868312 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531736}
-
Siddhartha authored
Add details about number of resources and type of bitmap in UI resource memory dump. BUG=780547 Change-Id: Iaea7854db074a74a2a1340881ae3450756e74525 Reviewed-on: https://chromium-review.googlesource.com/879593 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#531735}
-
Jiaquan He authored
StateFullscreen and TabletMode is no longer needed in chrome. Bug: 733662 Change-Id: Ib25f89745e989042e321c597fe62ded72bc0cffa Reviewed-on: https://chromium-review.googlesource.com/884376 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531734}
-
Joe Downing authored
I see sporadic failures going back several days so I am going to disable this test. TBR=jbudorick@chromium.org BUG=804892 Change-Id: I55f9af5935e7eb200c3cf963df2d7ce05dc3b991 Reviewed-on: https://chromium-review.googlesource.com/884392Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#531733}
-
Andrey Lushnikov authored
This patch moves binding validation from Persistence/ into Automapping/. The validation was used in both default mappings and automapping. Since default mapping is gone, we can safely move it to automapping. This consolidates all the binding-creation logic in one place, making it easier to report and manage binding errors. R=dgozman Change-Id: Ie969c0b42468cfc863723311bf920510cf587560 Reviewed-on: https://chromium-review.googlesource.com/882486Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#531732}
-
Jay Civelli authored
My recent CL https://chromium-review.googlesource.com/c/chromium/src/+/870744 caused a leak in ExternalProviderImplChromeOSTest as the test shuts down with some extension installation pending. Make sure we wait for all extensions to be installed before we exit the test. Bug: 805591 Change-Id: I89c1187d9e32ce0ab859689286c6283b0316d602 Reviewed-on: https://chromium-review.googlesource.com/884270Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#531731}
-
Mike Klein authored
At head this test adds 2 extra bytes of padding to each row of an 8888 (4 byte per pixel) bitmap. This misaligns all the odd rows. Through some sort of combination of lack of testing and luck of code generation, eraseColor() is not crashing on Chromium's tree, but it's within its rights to do so. The attached bug shows such a crash on a 32-bit ARM build running on a Nexus5x. To fix this, I think we can just pad each row by 4 extra bytes. This keeps every row aligned, and I think the spirit of the test intact. Bug: chromium:779715 Change-Id: I58e98e9d7dfe55dbe3512d287158449e21e25d2d Reviewed-on: https://chromium-review.googlesource.com/883741Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#531730}
-
James Cook authored
* Eliminate references to Windows * Specify the binary to run * Document GN args Bug: none Test: markdown preview Change-Id: I29b3179b4b74289a35e53cf2cd2ff5658ef7df6e Reviewed-on: https://chromium-review.googlesource.com/884321Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#531729}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/373e08f921e5..742ae4b24d28 $ git log 373e08f92..742ae4b24 --date=short --no-merges --format='%ad %ae %s' 2018-01-23 jzern vpx_codec_enc_init_multi: fix segfault w/vp9 2018-01-23 johannkoenig update .clang-format for v5.0.0 2018-01-23 linfengz Add vp9_highbd_iht16x16_256_add_sse4_1() 2018-01-23 linfengz Add "vpx_" prefix to 2 idct x86 functions 2018-01-23 yinshiyou-hf vp8: [loongson] fix bug of type conflict. 2018-01-22 jianj Fix frame sizes in pkt to support spatial layers. 2018-01-17 jianj Fix crash invalid params for vp8 multres. Add test. 2018-01-18 linfengz Add vp9_highbd_iht8x8_64_add_sse4_1() 2018-01-12 johannkoenig clang-format v5.0.0 vp9/ 2018-01-12 johannkoenig remove spurious comments 2018-01-12 johannkoenig clang-format v5.0.0 vp8/ 2018-01-12 johannkoenig clang-format v5.0.0 vpx_dsp/ 2018-01-16 marpan vp8: Fix to multi-res-encoder for skipping streams. 2018-01-11 johannkoenig clang-format v5.0.0 mem_ops.h 2018-01-11 johannkoenig clang-format v5.0.0 vpx_util/vpx_atomic.h 2018-01-11 johannkoenig clang-format v5.0.0 y4minput.c 2018-01-11 johannkoenig clang-format v5.0.0 vpxenc.c 2018-01-11 johannkoenig clang-format v5.0.0 examples/ 2018-01-11 johannkoenig clang-format v5.0.0 test/ Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=webm:1485 Change-Id: I8fa8e20b1d69a13ed07e9a5a6ac37a86650bba79 Reviewed-on: https://chromium-review.googlesource.com/883779Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#531728}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/c3373753de40..0e7663c0ec66 $ git log c3373753d..0e7663c0e --date=short --no-merges --format='%ad %ae %s' 2018-01-24 perezju [Telemetry] Move cros startup args to its possible-browser 2018-01-24 maruel chromeperf: update Swarming API calls to go through webapp2 adaptor 2018-01-23 dtu [pinpoint] Fix retrieval of isolated JSONs. 2018-01-24 perezju [Telemetry] Remove unused outuput_profile_path 2018-01-24 simonhatch Dashboard - Fix flaky create_health_report tests. 2018-01-24 perezju [Telemetry] Move desktop startup args to its possible-browser 2018-01-24 nednguyen Use explit timeout in method to wait for wprgo start Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3e0856d079b1a9b669c7e90b4345fc74ad7d2b8f Reviewed-on: https://chromium-review.googlesource.com/884107 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531727}
-
Alexander Alekseev authored
Remove "Back" button after UI review. Bug: 805505 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95e343cd0e0626e39b2b8b3919ca5a773f25a2dc Reviewed-on: https://chromium-review.googlesource.com/884436Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#531726}
-
Robert Liao authored
From https://chromium-review.googlesource.com/c/chromium/src/+/882384/2/base/task_scheduler/task_tracker.h#117 BUG= TBR=gab@chromium.org, fdoray@chromium.org Change-Id: Ie829149755f519a08eb5583070bf4a623a2f9316 Reviewed-on: https://chromium-review.googlesource.com/884264 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#531725}
-
Marijn Kruisselbrink authored
With the future mojo code path BlobRegistry will no longer be involved in blob URLs, so this makes sure that even in that case URLOriginMap is still properly populated. Also some refactoring of Blob related test helper code to make it possible to reuse some of that in PublicURLManager tests. Bug: 756743 Change-Id: I80dd0ea551a3e05134995a380b118be48b11571c Reviewed-on: https://chromium-review.googlesource.com/832936Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531724}
-
Justin Novosad authored
This CL returns to the simple direct blit code path we had before. In CL https://chromium-review.googlesource.com/c/chromium/src/+/758562 the implementation of Canvas2DLayerBridge::WritePixels was changed to go through the PaintCanvas interface, which required making an extra copy and force the pixels through an alternate color correction code path that handles alpha blending correctly. It turns out that this detour is unnecessary since alpha blending does not come into play in putImageData since it is a straight blit. BUG=802081 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3af99cc56745f6db52921282d905f73981675926 Reviewed-on: https://chromium-review.googlesource.com/883770Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#531723}
-
Chris Blume authored
base::Optional has a negative expression to represent if a value is being stored: storage_.is_null_. Because of this, memset(0) on a base::Optional will mark that optional as actually storing a value (when it clearly doesn't). Using memset(0) on base::Optional sounds a bit dirty but it can easily happen indirectly. Someone might memset(0) a class with a private member of base::Optional. Change the expression to be affirmative to preserve memset(0) intention using storage_.is_populated_. BUG=805565 Change-Id: I9c5b85cdaa58960f15809160f2d0de6d0cc52c7b Reviewed-on: https://chromium-review.googlesource.com/883946Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#531722}
-
Kush Sinha authored
Clearing cookies for child accounts on Chrome OS does not sign them out of Google services. Make this expectation clear on the settings UI. Bug: 803109 Change-Id: Ib11e86dd253790edc75cc5169a03e14d8f939057 Reviewed-on: https://chromium-review.googlesource.com/884083Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#531721}
-
George Burgess IV authored
Including autorollers. This also removes an entry for the now-deleted android.ensure file. Bug: 803632 Test: None Change-Id: I481b0e2822aee2ac0b6d919aa0ee4a84954f12ed Reviewed-on: https://chromium-review.googlesource.com/884233Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#531720}
-
Robert Liao authored
This performs a task flush similar to TaskTracker::Flush() except it is async. It calls the callback when TaskTracker::Flush() would have returned. BUG=804930 Change-Id: I428fd822104a3c5c0663a05852d7ecc47680c2ae Reviewed-on: https://chromium-review.googlesource.com/882384 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#531719}
-
Troy Hildebrandt authored
NewApi warnings were suppressed accidentally and an AssertionError constructor that requires API 19 was used. The NewApi warnings are back, so this fix avoids using the AssertionError, and throws the exceptions as they are. Bug: 805509,803484 Change-Id: Ibf17400b5703a92f98bf647ef01cc7e819d6e323 Reviewed-on: https://chromium-review.googlesource.com/884364Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531718}
-
Xiaocheng Hu authored
The existing implementation assumes logical fragment ordering in line boxes, which is incorrect for rtl text direction. It also assumes "flat" structure in line boxes, which is incorrect when we have other inline container fragments, e.g., SPAN with border. This patch fixe the issues by using NGPhysicalLineBox::First/LastLogicalLeaf instead of hacking into the child list of the line box. Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iaa3c5f2d3812929c58d80c15e067fe6e1f60f314 Reviewed-on: https://chromium-review.googlesource.com/882292Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531717}
-
Sidney San Martín authored
The old logic wasn't prepared to lay out a dangerous download when when the button was too small to contain it, which happens when a download animates in. This change lays out the dangerous download view like other views in the download item (other than the menu button): give it its final frame and anchor it to the leading edge of the button. That way, it's gracefully uncovered as the button's width animates up from zero. Bug: 805647 Change-Id: Ic7c75cfc0675674e15694670858b6673c5f4b39b Reviewed-on: https://chromium-review.googlesource.com/884442Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531716}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c341d3829d47..04f8b79acbec $ git log c341d3829..04f8b79ac --date=short --no-merges --format='%ad %ae %s' 2018-01-24 reed fix serializing shadowrec 2018-01-24 mtklein allow 4444 sw surfaces 2018-01-24 egdaniel Add return value to doLazyInstantiation to know if it succeedes. 2018-01-24 angle-skia-autoroll Roll skia/third_party/externals/angle2/ c081020c7..7e9b13b5b (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I6274b003e51a866786b6594cea820326e174d41d Reviewed-on: https://chromium-review.googlesource.com/884106Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531715}
-
Wei Li authored
Add new IPC messages and change a couple existing ones to allow subframe printing for OOPIFs and return relevant information. There are two major changes: -- Print subframe content and return it; -- For existing printing calls, return its subframe info as well. BUG=455764 Change-Id: I41dd21f494b8c393ec40636498d053660c336c27 Reviewed-on: https://chromium-review.googlesource.com/769351 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#531714}
-
Saman Sami authored
In order to be able to tell the difference between the graphical output of the renderer before and after navigation, we should allocate a new LocalSurfaceId. Currently we rely on content_source_id to achieve this, but that is not compatible with Viz. When navigation happens, browser allocates a new id for the child and immediately embeds it. After 4 seconds it drops the fallback SurfaceId if it was generated before navigation. TBR=lazyboy@chromium.org Bug: 695579,775030,777881 Change-Id: I8ae11dd3de2e8d6cc889ad31f94bdb0bb5f6a5d4 Reviewed-on: https://chromium-review.googlesource.com/855256 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531713}
-
Matt Reynolds authored
A gamepad may be enumerated twice while its active state is still marked as GAMEPAD_NEWLY_ACTIVE. If this happens, a new XInputHapticGamepadWin instance will be created without properly shutting down the previous instance, causing a DCHECK failure. This situation can occur when a gamepad is enumerated twice before the polling thread polls the gamepad state, which resets all gamepads to GAMEPAD_INACTIVE. To avoid the DCHECK failure, this CL modifies the newly active gamepad logic so the XInputHapticGamepadWin instance is only created if it was previously null. BUG=749295 Change-Id: I1afbe0f6e4f6757384dd37a3491ab6a9cd4313c5 Reviewed-on: https://chromium-review.googlesource.com/883780Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#531712}
-
Elliot Glaysher authored
Previous attempts at trying to fix the cursor lifetime issue assumed that it was related to ownership while passing refcounted objects across thread boundaries. This patch, instead, frees the passed cursor depending on how it was created. Bug: 800219 Change-Id: Iaee3748716b155dfd180923712838870cfb21c47 Reviewed-on: https://chromium-review.googlesource.com/864833Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#531711}
-
sebsg authored
The current code creates a new card instance and sets all the values form the settings page. It then replaces the existing card instance in the DB. This is dangerous because it's easy to forget some. It would also reset all the metadata associated with this card. More specifically in this example, the settings don't have a way to set the billing address id. Instead of passing the value along in the settings to set it back on save, using the existing card and updating it is much more simple. Bug: 800829 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia6ce196c16295961bb6536a609ea866f953e1590 Reviewed-on: https://chromium-review.googlesource.com/860200 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#531710}
-
Charles Harrison authored
Bug: 804347 Change-Id: Ibf66a09132c328da35c006e3a29472c20144c56f Reviewed-on: https://chromium-review.googlesource.com/879329Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#531709}
-
Ted Choc authored
Accidentally broken by this refactoring: https://chromium-review.googlesource.com/582338 Added tests to ensure the metric does not regress in the future. BUG=800625 Change-Id: Iae1e29d11f62f177cea1200fa24befa64b77f559 Reviewed-on: https://chromium-review.googlesource.com/879433 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531708}
-
Lei Zhang authored
On some official build bots, r531606 causes a -Wunused-result error. BUG=805615 Change-Id: I0f4f51a6eb07d67f3b4c552af7d5f115b5852095 Reviewed-on: https://chromium-review.googlesource.com/884505 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531707}
-
Lei Tian authored
BrowserActionActivity could be shown even FRE is not finished but if FRE is not finished, predefined item would not shown. It only shows the custom item which looks like fallback dialog. Bug: 801264 Change-Id: I1d723e413fa06a7cd28d897620ed22f986887a5f Reviewed-on: https://chromium-review.googlesource.com/875190 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#531706}
-
Troy Hildebrandt authored
NewApi warnings were suppressed accidentally and an AssertionError constructor that requires API 19 was used. The NewApi warnings are back, so this fix avoids using the AssertionError and throws the exceptions as they are. Bug: 805509,803484 Change-Id: I1f342d06cb7e4e24ea816803d0e97dbeab6f59d9 Reviewed-on: https://chromium-review.googlesource.com/884385 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531705}
-
Chris Kuiper authored
This address issues pointed out in the previous change. Additionally it tweaks the low-pass filter coefficients slightly and adds an additional logic to ignore timestamps that are clearly incorrect due to them deviating from the reference time by a large amount. Bug: [internal] b/72341571 Test: Running multizone certification test cases on a mix of speakers. Change-Id: I52cfdd88f4d1f989823cab791986a2bce6dd810c Reviewed-on: https://chromium-review.googlesource.com/883406Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#531704}
-
Xiaocheng Hu authored
This patch introduces the two helper functions as a preparation for crrev.com/c/882292, where we need to check if an inline fragment is the logically first/last leaf in its line to resolve caret position around line wrap. Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I905ddc8923417da7178f8962db9c01e6fdf24754 Reviewed-on: https://chromium-review.googlesource.com/884381Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531703}
-
Richard Coles authored
This reverts commit 29f4d37f. Reason for revert: New test ContextCacheControllerTest.CheckSkiaResourcePurgeAPI is flaky on multiple android builders. See crbug.com/805575 Original change's description: > Use new Skia resource purging API when we go idle > > This avoids clearing some longer-lived Skia caches, hopefully avoiding > an UMA latency regression we experienced when the idle clearing was > initially added. > > R=danakj > TBR=brettw@chromium.org for DEPS change relying on third_party/skia. Got review from third_party/skia owner, bsalomon@. > > Bug: 664181 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I801f63b7b3ff6386303b582b7ae1f503425e1bb0 > Reviewed-on: https://chromium-review.googlesource.com/741454 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530949} TBR=bsalomon@chromium.org,danakj@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 664181 Change-Id: Ia811c891f91965caa6a702839b6cf65fd482f366 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/883664 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#531702}
-