- 19 Oct, 2017 40 commits
-
-
Nico Weber authored
Also a stepping stone in getting deps from .rc files correct automatically. The driver script rc.py works like rc.exe; it supports printing resource names on /showIncludes: $ cat test.rc 4 ICON "icon.ico" $ build/toolchain/win/rc/rc.py /showIncludes test.rc Note: including file: ./foo.h Note: including file: /Users/thakis/src/chrome/src/icon.ico $ file test.res test.res: MSVC .res The driver script behind the scenes calls a deps'd-in "rc" binary. This CL includes a script to build new versions of that binary. It's ~150kB on Mac and Linux, and ~600kb on Windows. The compiler isn't hooked up to anything yet. I plan to change tool_wrapper.py to call both it and rc.exe in ExecRcWrapper() when on Windows (and compare the two outputs and make sure they're identical), and to call only rc.py when on non-Windows. Eventually I also want to make ExecRcWrapper() use rc.py's /showIncludes to get dependencies for .rc files right. The README.md has some more details. We're in the process of slowly upstreaming this to LLVM, but it looks like that'll take a while longer, so in the meantime let's do this until the LLVM version is ready. Bug: 774193,132660 Change-Id: I9a9ee1e271bf403ddb7f8d18ecd97730762c6cbc Reviewed-on: https://chromium-review.googlesource.com/727110 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#510244}
-
Xianzhu Wang authored
Previously some compositing layout tests used references which contained styles and elements which were not enough different from the test. This increased chances that the same bug affects both the test and the reference and the test still passes. This CL removes unnecessary styles and elements from references to make them more different from the tests. Change-Id: I7c452c27f44fb34460217697ce1dd9bf98456d48 Reviewed-on: https://chromium-review.googlesource.com/726542 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510243}
-
Sergey Ulanov authored
NOTRY=true Bug: 776575 Change-Id: I986136822ee7d835f94af1dffd48399be03ce43a Reviewed-on: https://chromium-review.googlesource.com/729439 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510242}
-
Henrik Boström authored
These are behavior-driven tests, each test testing a specific behavior: - addTrack() with a track and no stream should fire ontrack with a remote track with the same ID and no streams. - addTrack() with a track and a stream should fire ontrack with a remote track and stream with matching IDs. - addTrack() with two tracks and a shared stream should fire ontrack twice with remote tracks and a shared remote stream, with matching IDs. - addTrack() with a track and two streams should fire ontrack with a track and two streams with matching IDs. - ontrack should fire before setRemoteDescription()'s promise resolves. - ontrack's receiver should match getReceivers(). - removeTrack() should not result in a receiver being removed. Unlike RTCPeerConnection-ontrack.https.html, these tests do not rely on transceiver support. When testing a behavior like "fires an event with a track" the test does not test unrelated things like the event being a complete implementation of RTCTrackEvent with transceivers and all. In a follow-up, I will add tests for other behavior associated with the removal of a track, including onmute events firing and the track being removed from the remote streams. Bug: 774303 Change-Id: I87d8a79d9e2e385610f749a9146b740cc649cf3f Reviewed-on: https://chromium-review.googlesource.com/719615 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#510241}
-
Patricia Lor authored
Whenever the Page Info bubble needs to update the number of cookies being used on a site, it will update the text in the Page Info bubble to reflect this, which will then trigger a layout update and reanchor the bubble. However, if this occurs while the browser window is moving into full screen mode, the Page Info parent window will be null and this operation will crash. Fix by checking whether the parent window exists before trying to reanchor. Moving into full screen will also close the Page Info bubble, so the reanchor is unnecessary anyway - it will be correctly positioned the next time it is opened. Bug: 773283 Change-Id: I6f7418fcc96a95b8e3f0a3276ac009cef6eda92e Reviewed-on: https://chromium-review.googlesource.com/720579 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#510240}
-
Antoine Labour authored
At this point, the id_mapping functionality is only used for GetSynciv (and IsSync, but it's a noop there), whereas this can be simplified by using a Do function that does the same thing (and is much smaller code than the corresponding autogen logic). Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I65128d736ea07f034ac3f5c93eb3d0445095ee27 Reviewed-on: https://chromium-review.googlesource.com/728703Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510239}
-
Wez authored
In addition to registering the name with the global ThreadIdManager, the platform thread object's name is set with zx_object_set_property(), so that it will be reflected in logging from e.g. the platform's crash handler. Bug: 725726 Change-Id: Id47efa77857b35c2317b5eed05aa2e630a044113 Reviewed-on: https://chromium-review.googlesource.com/727699Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Eugene Ostroukhov authored
Bug: 768782 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7fd7a16c3c4493c71662ed5ddc4a7906b6bafeee Reviewed-on: https://chromium-review.googlesource.com/727188Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#510237}
-
Tommy Steimel authored
Updating the comment per miu@'s comments on crrev.com/c/713406 Bug: 765337 Change-Id: I80a1ebaabfa70479f724cb2b86697fc3231db61e Reviewed-on: https://chromium-review.googlesource.com/726385Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#510236}
-
Mitsuru Oshima authored
UpdateInternalDisplay should register the display info only if 1) no internal display info is registered. (it'll be treated as new display) 2) it's disconnected BUG=774383 TEST=covered by unit test. manually tested on kevin. Change-Id: Ifdf74ad7e61a0d5ffa617e0a72622e2ddb9bbebd Reviewed-on: https://chromium-review.googlesource.com/726262 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#510235}
-
Ella Ge authored
The OnDragEnd coordinates was incorrect at mac, because the api we are using: draggedImage:endedAt:operation (https://developer.apple.com/documentation/appkit/ nsdraggingsource/1806949-draggedimage?language=objc) The endedAt location is the image’s origin in screen coordinate, but we used it as dragend coordinate. In this patch, I added a offset similar to startDrag to correct the coordinates. Bug: 762701 Change-Id: Ie92e84998d076c58f099215a548ab1934c973958 Reviewed-on: https://chromium-review.googlesource.com/655977Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#510234}
-
Lei Zhang authored
Change-Id: Ied26e0a5eeed8ed2f4ca572f1d43bb27a126fa3a Reviewed-on: https://chromium-review.googlesource.com/704020Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#510233}
-
Bret Sepulveda authored
This reverts commit 14aa2e0e. Reason for revert: <select> tags non-functional (both web and chrome:// pages). See http://crbug.com/776548 Original change's description: > Fix crash with MojoInputMessages > > Once WillShutdown is called the InputHandlerProxy object should be destroyed > since it is no longer valid. > > BUG=775483 > > Change-Id: I3dc1cf7d7295ff08bbcec3d8ee2b12690961af2e > Reviewed-on: https://chromium-review.googlesource.com/725860 > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509894} TBR=dtapuska@chromium.org,mustaq@chromium.org Change-Id: I7e8f0d3f6a8e41acf12bda09993aac1b2cbfccf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775483 Reviewed-on: https://chromium-review.googlesource.com/729206Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#510232}
-
Misha Efimov authored
Bug: 774814 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I442f55b957017119b5241993ee0f90ae63a86557 Reviewed-on: https://chromium-review.googlesource.com/729126Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#510231}
-
Daniel Cheng authored
TraceWrappers() is simple enough to just declare and define directly. This avoids potential issues with the chrome clang plugin checks for virtual and the final/override specifiers, and makes it consistent with how Oilpan tracing methods are now declared/defined. Replacement was automated using perl regex to expand the macros. Bug: 775741 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I315a1a57d082ece7750d8223ddd1c4f5e7a535d9 Reviewed-on: https://chromium-review.googlesource.com/727533 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#510230}
-
Alexei Filippov authored
BUG=751892 Change-Id: I8323075c239ba3a1abc785c4b6b14c6ae9c8e144 Reviewed-on: https://chromium-review.googlesource.com/726966Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#510229}
-
Scott Violet authored
AFAICT it's not used BUG=none TEST=none Change-Id: I170fc14bdb064524cecb8f90c17b35fac3f7f2b5 Reviewed-on: https://chromium-review.googlesource.com/728867Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#510228}
-
Lei Zhang authored
- Use base::TimeDelta for timers. - Initialize more members in headers. - Put some members near related members. - Add FormFillTimerData which is more readable than a std::pair. Change-Id: Ifc2ad1004abe3d83b66b68f678ef7ebb04098c3c Reviewed-on: https://chromium-review.googlesource.com/727409 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#510227}
-
Vlad Tsyrklevich authored
Blacklist the remaining icall buildbot failures in NaCl. I've avoided categorizing the failures as NaCl is deprecated. Bug: 772906 Change-Id: I824a763bc86d64ab83c55774bcee03d24efb4376 Reviewed-on: https://chromium-review.googlesource.com/728304Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#510226}
-
Wei-Yin Chen (陳威尹) authored
Change-Id: I28b772e92fdf05013ee4fc95e76e370c81daed52 Reviewed-on: https://chromium-review.googlesource.com/726946Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510225}
-
Ian Kilpatrick authored
This isn't ideal, but it does make things faster. A few more tests pass (don't timeout) only 1-2 additional failure. So a net win? Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id95bdd4ebcfd2534dbbf07b50a730c9961349713 Reviewed-on: https://chromium-review.googlesource.com/726846 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#510224}
-
Takashi Toyoshima authored
Dependency from platform/loader to url/mojo/url.mojom-shared-internal.h was still missed in the previous change. This is a reland of ab4da6c8 Original change's description: > Reland "Reland "Reland "Split WebKit platform build file""" > > blobs.mojom-blink.h internally depends on url.mojom-blink.h. > So, we should have //url/mojo:url_mojom_gurl_blink__generator > dependency in blob:generator target on which other test_support > source_set depends. > > confirmed that generated ninja files, i.e. > ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja > has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp > > This is a reland of 1cf9f36e > Original change's description: > > Reland "Reland "Split WebKit platform build file"" > > > > test_support of platform/loader and platform/network should > > depends on //storage/public/interfaces:interfaces_blink__generator > > because it indirectly includes generated mojo interface headers. > > > > This is the root cause of the original issue, and it seems > > BUILD file splitting makes it happens more easily. > > > > This is a reland of 997ce7ad > > Original change's description: > > > Reland "Split WebKit platform build file" > > > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > > This caused a race on compiling. > > > > > > This is a reland of 080c70a7 > > > Original change's description: > > > > Split WebKit platform build file > > > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > > All of these done in this CL. > > > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > > > Bug: 754600 > > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > > Test: gn check out/Release && ninja -C out/Release > > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > > > TBR=engedy@chromium.org > > > > > > Bug: 754600 > > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508993} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > > Reviewed-on: https://chromium-review.googlesource.com/720542 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#509359} > > TBR=jam@chromium.org > > Bug: 754600 > Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e > Reviewed-on: https://chromium-review.googlesource.com/725139 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509749} TBR=ccameron@chromium.org Bug: 754600 Change-Id: Id13528a0181a589ad85dc67ea2c57fa384c68b36 Reviewed-on: https://chromium-review.googlesource.com/727443 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#510223}
-
Sergey Ulanov authored
Previously GetNetworkList was calling getifaddrs(), but it isn't implemented on Fuchsia yet. Replaced it with a GetNetworkList() implementation that calls Fuchsia-specific ioctl. Bug: 768916 Change-Id: I5e6e5c2f06867c3d4a3ec08cf2526bb24f4b7e60 Reviewed-on: https://chromium-review.googlesource.com/728919Reviewed-by:
-
kylechar authored
Needed to set |enable_surface_synchronization| correctly in the ClientLayerTreeFrameSink::InitParams. Bug: 770833 Change-Id: Ibfbb810a1d787e6736e0522998175252977e7bee Reviewed-on: https://chromium-review.googlesource.com/728706Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#510221}
-
Scott Graham authored
Release non-official builds are used for dev purposes, so it's useful to have backtraces. Bug: Internal 67965579 Change-Id: I91f2642ed27acb06255aa4d43db1e39e50c863f3 Reviewed-on: https://chromium-review.googlesource.com/728727Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#510220}
-
Roberto Carrillo authored
This reverts commit 37d5fc56. Reason for revert: Speculative revert for SOLINK failure in https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/46752 Original change's description: > Add speech recognition API wrapper in VR > > This CL adds an invisible button which should trigger voice search. > Note that the UI will change significantly. The main purpose of this > CL is to add speech recognition API wrapper. > > Bug: 773767 > Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b > Reviewed-on: https://chromium-review.googlesource.com/701174 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510182} TBR=vollick@chromium.org,bshe@chromium.org Change-Id: I2943d46e3d7d160852371a33f16e44ba1d62fbb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773767 Reviewed-on: https://chromium-review.googlesource.com/729319Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#510219}
-
Navid Zolghadr authored
Remove old touch scrolling metrics that were replaced back in M56. Bug: 649754 Change-Id: If47392ac6902bd9cf4e8a001752943e0f615ba70 Reviewed-on: https://chromium-review.googlesource.com/728714Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510218}
-
Evan Stade authored
For all cases where it returned the non-default value (true), replace with setting the clickable field in Notification. Bug: 776187 Change-Id: I24c99a651a0753b8ab474102ed50ee94b72b0d90 Reviewed-on: https://chromium-review.googlesource.com/727468Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#510217}
-
Minh X. Nguyen authored
Bug: 722942 Change-Id: If2151274f2cfd1eaddd3a0cbeaf99636b8534a05 Reviewed-on: https://chromium-review.googlesource.com/726976 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510216}
-
Annie Sullivan authored
Change-Id: I07e088d2b98be4bb7872e69a730b618b9258d734 Reviewed-on: https://chromium-review.googlesource.com/728367Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510215}
-
Scott Chen authored
Bug: 769572 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I87beab786bcc3644290ff555994af980f3dbe59d Reviewed-on: https://chromium-review.googlesource.com/723610Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510214}
-
Jérôme Lebel authored
Removing dead code and for loop not used. Bug: Change-Id: Id562defd8b748bdf5f984e3a0f4850e6acef0ad2 Reviewed-on: https://chromium-review.googlesource.com/727199Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510213}
-
Nate Fischer authored
This adjusts the precedence for the --webview-enable-safebrowsing-support switch, ensuring that application opt-out always has higher precedence. The switch value will only be used if the application specifies no opt-in preference. Bug: 773798 Test: Manual - apply flag, start application with opt-out & with no opt-in preference Change-Id: I514179e6b51ec90dc0bfefe13236d66e9bfbc14b Reviewed-on: https://chromium-review.googlesource.com/726950Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510212}
-
Michael Martis authored
This doesn't currently change any application behaviour, but correctly places the factories in the dependency graph and allows for automatic preference registration. Change-Id: I02ec98d4817dffb72f0b317b37ac434d8a083190 Reviewed-on: https://chromium-review.googlesource.com/727482Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Scott Chen authored
Bug: 776483 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia2679f9900910141d8c998619963b0a140ff6633 Reviewed-on: https://chromium-review.googlesource.com/728862Reviewed-by:
-
Alexander Alekseev authored
This CL adds NULL checks to BootTimesRecorder so that it won't crash on renderer crash. TBR=oshima@chromium.org Bug: 768446 Change-Id: I989b4096b452da0c92765143f05139413deb10b8 Reviewed-on: https://chromium-review.googlesource.com/728920Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#510209}
-
Shimi Zhang authored
Doing so for adding logging for Smart Selection http://crrev/c/720270. We need to distinguish the showSelectionMenu() event to know if it comes from selection expansion/reset/dragging etc. Bug: 731644 Change-Id: I5d9e69c4fcecd60ed2e92268cd2f5c9b91bc5b28 Reviewed-on: https://chromium-review.googlesource.com/723784Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
-
Bruce Dawson authored
This change switches the VS 2017 package to use VS 2017 Update 4 while still using the 10.0.15063.468 SDK. Update 4 fixes at least one code-gen bug (crbug.com/759402) but the 10.0.16299.0 SDK is still incompatible with Chrome (crbug.com/773476). Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading VS 2017 Update 4, from https://www.visualstudio.com/vs/, and then passing these parameters to the installer: --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.468 SDK installer was run and everything was installed except for the Windows Performance Toolkit, .Net Framework, and the arm SDKs. Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 Bug: 773476,759402 Change-Id: Ie2176b5ff765d9e5497f51a7b00c02fad04fb973 Reviewed-on: https://chromium-review.googlesource.com/727523Reviewed-by:
-
Dominic Mazzoni authored
The map of AXTreeIDs was constantly growing. Bug: 72816 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I2ef601f54ae77930abea34bfc19c8ebae09705fd Reviewed-on: https://chromium-review.googlesource.com/706136 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510206}
-
Andrew Grieve authored
If a symbol was found in multiple object files, we would previously have changed its object path to be the common ancestor of all paths it appeared in. This is a problem because it would cause queries based on path to not find these symbols. On the flip side, we were creating string literal aliases for every path a string literal appeared in. For small strings such as "", or "\n", this would lead to an unreasonable number of aliases. This changes supersize to first create symbols for all paths, and then collapse groups with a large number of aliases into a single symbol with ancestor paths. Before this change: .text: 48998 symbols have shared ownership (1553806 bytes) .rodata: 541 symbols have shared ownership (285728 bytes) After: .text: 1586 symbols have shared ownership (48252 bytes) .rodata: 141 symbols have shared ownership (2828 bytes) This increases the symbol count 702115->912322 and the file size 9.67mb->10.39mb. This increases the runtime on my machine from ~40s -> ~42s. Bug: 776032 Change-Id: I457361762b1f241f114b52464812e6035e881538 Reviewed-on: https://chromium-review.googlesource.com/726460 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#510205}
-
