- 25 Jan, 2019 40 commits
-
-
Andrew Grieve authored
When changing GN arg "use_signing_keys", rebuilding would not result in a resigned apk. Change fixes this by removing use of md5_check. Using md5_check is generally only advantageous when one or more inputs are from outside of the out/ directory, and thus can change when checkout out different branches. Inputs to apkbuilder.py are entirely from within the out/ directory (except for the script itself, which doesn't change much). Change-Id: Ic93d559cc2fffb2fabe8af7152038be76f1e71c0 Reviewed-on: https://chromium-review.googlesource.com/c/1435677Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#626134}
-
Nick Harper authored
This is a partial revert of https://codereview.chromium.org/2109303002, since QuicStreamFactory being an SSLConfigService::Observer was only needed for Channel ID and Token Binding support so that if the Channel ID or Token Binding ID changed, connections using the old IDs would be torn down. Change-Id: I69a78e6841378cd279091b7f6b05c3f2c22cbf78 Reviewed-on: https://chromium-review.googlesource.com/c/1435620 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#626133}
-
James Cook authored
Bug: none Change-Id: Ie7988b2eaae114aa961c9beca5d23a0071753bec Reviewed-on: https://chromium-review.googlesource.com/c/1435820 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#626132}
-
Theresa authored
BUG=925277 Change-Id: I98f26b6625f399110624b0580ff191f7d55a40fa Reviewed-on: https://chromium-review.googlesource.com/c/1437337Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#626131}
-
Miguel Casas authored
crrev.com/c/1412856 disabled tests those two tests for Mac. This CL does the first part of rebaselining those: - Marks the pixel test as failing without platform condition - Increases the revision in the pixel_test_pages.py Bug: 922218 Change-Id: Ic27f6a04b1362df820f0abb648b9c23699aa0fc7 Reviewed-on: https://chromium-review.googlesource.com/c/1436081Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#626130}
-
Xiaocheng Hu authored
The function is dead for pretty long time. So this CL removes it. Bug: 924616 Change-Id: I33d0d377add5f6ada2a4e25fab6d086561874d86 Reviewed-on: https://chromium-review.googlesource.com/c/1436674 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626129}
-
Xiaocheng Hu authored
As discussed, it's not worthy to support legacy layout with bidi caret affinity. Hence, this patch removes the support. Bug: 925192 Change-Id: Ie01927432c1fa446e37424a3cd71d59fad088207 Reviewed-on: https://chromium-review.googlesource.com/c/1436356Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Stronger typing to assert that we know what we're doing. Change-Id: I1412dd12f34a2bc0310c4f057575cbbe84267f08 Reviewed-on: https://chromium-review.googlesource.com/c/1437154Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#626127}
-
Elly Fong-Jones authored
This reverts commit 7c4d49a6. Reason for revert: broke "Google Chrome Mac": https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/40824 Original change's description: > Reland "mac: roll to 10.13 SDK" > > This is a reland of d86a6561 > > Original change's description: > > mac: roll to 10.13 SDK > > > > This change causes the default hermetic SDK to be version 10.13 (aka Xcode 9.3). > > This also bumps the minimum build host version to 10.13.2, since that > > is the earliest version on which Xcode 9.3 runs. > > > > Bug: 780980 > > Change-Id: I6da3f7d3a060a22d71d5ee18bb88f51d5aedb0a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1394742 > > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#620032} > > Bug: 780980 > Change-Id: Iea403cc2dcbfc56ce54a6ad72ca4d2729b520fd0 > Reviewed-on: https://chromium-review.googlesource.com/c/1436942 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626106} TBR=ellyjones@chromium.org,thakis@chromium.org Change-Id: I3d16cd8185d4b96932ee5b9c140c60c47f80bee8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780980 Reviewed-on: https://chromium-review.googlesource.com/c/1437259Reviewed-by:
-
Weidong Guo authored
Bug: 854836 Change-Id: Ifecd33e89ce96a7f4314ed70d2d3df1f5dc03ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1434286Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626125}
-
Matthew Jones authored
This patch changes WebappActivity to use the status bar theming methods in the parent ChromeActivity rather than directly calling the api compat method. As a result, webapps will have status bar theming logic consistent with other chrome activities. The overrides now ignore incoming theme colors in favor of it's own brand color. Bug: 801474 Change-Id: I1f21de0465aea5262ea30d1912153461f71e41bc Reviewed-on: https://chromium-review.googlesource.com/c/1435914Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#626124}
-
Elly Fong-Jones authored
This change deletes --mhtml-generator-option and the logic that was gated on it. Bug: 912131 Change-Id: Ic7700caa6b7ba35c70b2c92fc92afe501cd1e7d5 Reviewed-on: https://chromium-review.googlesource.com/c/1427465Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#626123}
-
Nate Fischer authored
No change to logic, just a refactor. This swaps out hardcoded string literals for the newly added ABI constants for a few scripts in chromium. This updates pydeps for the scripts this transitively affects, which conveniently includes the pydeps files which previously blocked a catapult autoroll. Bug: 922854, 925237, 924778 Test: vpython android_webview/tools/run_cts_test.py Test: vpython build/android/list_class_verification_failures_test.py Change-Id: I9c754809f00606bad19120e869d5c7f47b8dba02 Reviewed-on: https://chromium-review.googlesource.com/c/1436876Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626122}
-
chrome://bookmarksNicolas Ouellet-payeur authored
8px => 12px to match the mocks. Change-Id: I801542001f7c2d73da62e47870c856509097fda4 Reviewed-on: https://chromium-review.googlesource.com/c/1425479 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626121}
-
Anatoliy Potapchuk authored
In the condition when the device is disabled by policy it was referencing a yet uninitialized LoginScreenClient leading to SYSSEGV and boot/login loop in Chromebooks. Bug: 884127 Change-Id: If99d945777e56cbc1299f5094afd32cee1872f3a Reviewed-on: https://chromium-review.googlesource.com/c/1435436 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#626120}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/8e8f250422663106d478f6927beefba289a95b37..6c1b376e1d502eff365028fe054115f1b46d19b5 The following commits have Chromium bugs associated: 823effe97 Revert "Fix protos_len size in SSL_set_alpn_protos and SSL_CTX_set_alpn_protos" de3c1f69c Fix header file for _byteswap_ulong and _byteswap_uint64 from MSVC CRT 35771ff8a Fix protos_len size in SSL_set_alpn_protos and SSL_CTX_set_alpn_protos Bug: 879657, 893460 Change-Id: I2305e6588719ffb1ddf31e3c40df8bc4aecb8c29 Reviewed-on: https://chromium-review.googlesource.com/c/1436397 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#626119}
-
Leonardo Padilha authored
This information will be used to collect metrics on events that trigger status reports. We need to know whether the call to schedule a report was successful or not. Bug: 919132 Change-Id: If0be7c5d7d11a686707a1a20a2a6d6ad519a31ba Reviewed-on: https://chromium-review.googlesource.com/c/1418272Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#626118}
-
Avi Drissman authored
BUG=913314 Change-Id: I01de2642638dde55945f41dfa58da41a30b2c095 Reviewed-on: https://chromium-review.googlesource.com/c/1435957 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Andrew Xu authored
In current code, notification may be removed before animation which is triggered by the previous operation on MessagePopupCollection ends. As result, when a new notification with the same ID is created, calling MessagePopupCollection::Update will not update the popup's content. Then the new notification popup fails to show. The CL fixes this bug. Test: message_center_unittests Bug: 921402 Change-Id: I56743b5e17487d3f5bf52ef934b0a53d8f6471d0 Reviewed-on: https://chromium-review.googlesource.com/c/1422738Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626116}
-
chaopeng authored
The device scale factor is not properly applied in CrossProcessFrameConnector::TransformPointToLocalCoordSpaceLegacy We're using current_surface_scale_factor() which does not seem to provide the correct value. We want GetDeviceScaleFactor(). Test: SitePerProcessInternalsHitTestBrowserTest.ScrollNestedLocalNonFastScrollableDiv after crrev.com/c/1427607 landed Bug: 923069 Change-Id: Iae748780d0657d7674cf4ba76a276ad03cc28a74 Reviewed-on: https://chromium-review.googlesource.com/c/1435834Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change replaces @available(macOS 10.10, *) with true and removes API_AVAILABLE(macos(10.10)) annotations, then simplifies code where possible as a result. Bug: 841631 Change-Id: I55e0fbf23d836951354506f2058a419ebc95bb8b Reviewed-on: https://chromium-review.googlesource.com/c/1437254Reviewed-by:
-
Ken Rockot authored
JSON manifests are deprecated. Also removes unnecessary use of test catalogs in favor of inline test service manifests. Bug: 895616 Change-Id: I1fb3263c351c01a4edc56238d65cffa3e6dd68d3 Reviewed-on: https://chromium-review.googlesource.com/c/1436696Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#626113}
-
Maksim Moskvitin authored
The old migration way requires changing of sync settings to complete the migration (https://codereview.chromium.org/11961030/). That way also blocks updates in SyncPrefs class required for crbug.com/906611 since it uses SyncPrefs internal logic. New way is implemented outside of SyncPrefs and force the migration on browser start. Bug: 906611 Change-Id: I0518798c5246e6436449ab79ddd648e68a52507c Reviewed-on: https://chromium-review.googlesource.com/c/1434281Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#626112}
-
Ken Rockot authored
JSON manifests are deprecated. This also removes an unnecessary test catalog in favor of defining test service manifests inline. Bug: 895616 Change-Id: I5bd634654bdef124b61e97bb232eeb29114073a1 Reviewed-on: https://chromium-review.googlesource.com/c/1436875Reviewed-by:
-
Moe Ahmadi authored
Renames translate_popup_menu_coordinator and translate_popup_menu_mediator to translate_infobar_coordinator and translate_infobar_mediator as they have more responsiblities than only displaying/dismissing the translate infobar popup menus, e.g., handling translate options notifications. Bug: 910994 Change-Id: Id6e0df35ee8216b3d498ab407f58e08c4314ae40 Reviewed-on: https://chromium-review.googlesource.com/c/1436941 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626110}
-
Peng Huang authored
The presentation feedback is currently synthesized from the swap-end time, and the work to get the real presentation-feedback is tracked in https://crbug.com/c/925010 Bug: 919882, 925010 Change-Id: I1d3f7853d5578252ffd96fa63efb59882dccce82 Reviewed-on: https://chromium-review.googlesource.com/c/1434076 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#626109}
-
Chris Lu authored
Implements logic for FindInPageSearch option to search and highlight matches. Searching for non-ascii not currently supported. Bug: 896867 Change-Id: I362d3cebacfced1537742fbbab9ad323d6edeafd Reviewed-on: https://chromium-review.googlesource.com/c/1407665Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#626108}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/91ef1c316730..19ec8ef577ff git log 91ef1c316730..19ec8ef577ff --date=short --no-merges --format='%ad %ae %s' 2019-01-25 ahassani@chromium.org Revert "paygen: improve GenrateStatefulPayload's implementation" Created with: gclient setdep -r src/third_party/chromite@19ec8ef577ff The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8a4f27ed98f319db586ff36cca9eebf190ee54ee Reviewed-on: https://chromium-review.googlesource.com/c/1437004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626107}
-
Elly Fong-Jones authored
This is a reland of d86a6561 Original change's description: > mac: roll to 10.13 SDK > > This change causes the default hermetic SDK to be version 10.13 (aka Xcode 9.3). > This also bumps the minimum build host version to 10.13.2, since that > is the earliest version on which Xcode 9.3 runs. > > Bug: 780980 > Change-Id: I6da3f7d3a060a22d71d5ee18bb88f51d5aedb0a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1394742 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620032} Bug: 780980 Change-Id: Iea403cc2dcbfc56ce54a6ad72ca4d2729b520fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1436942 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626106}
-
Vlad Tsyrklevich authored
In r624120 I reduced the number of allocations used by GWP-ASan from MaxAllocations/TotalPages 32/128 to 6/20. These are good parameters for widespread use to limit the amount of memory/perf regression on stable; however, it makes it much less likely GWP-ASan will catch newly introduced bugs on canary/dev. Add a multiplier by which to increase the GWP-ASan parameters on canary/dev to ensure we maintain good coverage of new code. Bug: 896019 Change-Id: I1ce59c25878ef0c066e04a0dedeba1f3aa97ec0d Reviewed-on: https://chromium-review.googlesource.com/c/1429240 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#626105}
-
Matt Menke authored
Windows 10 now maps audio/webm to *.weba by default. This CL fixes a test that change broken (MimeUtilTest.GetPreferredExtensionForMimeType), and adds a secondary mapping for audio/webm to weba. Bug: 923502 Change-Id: Ia2e3344c5bf270a6bcfe5154ce8a4e28285821fc Reviewed-on: https://chromium-review.googlesource.com/c/1436939Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#626104}
-
Oskar Sundbom authored
The current generator is maintaining a value of 0 when silent and varying between 0 and 128 when beeping. As it generates unsigned 8 bit audio, this means it's stuck at the lowest value when silent, rather than at the mid-point. This has confused a test. Bug: 892534 Change-Id: I4bf5d676ef58e0443716213a5650baacf3f11b8c Reviewed-on: https://chromium-review.googlesource.com/c/1430074Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626103}
-
Christian O. Andersson authored
Design doc: https://docs.google.com/document/d/188BbgvTdhKf8bXikCL-JMduEclJOd9GxhKu79hmSVdo/edit We wish to provide a means of optionally suppressing the display of the webview error page so that applications that wish to display their own error content may do so without presenting a poor user experience. Test: run_webview_instrumentation_test_apk -f AwSettingsTest#testShouldSuppressErrorPage Change-Id: I15c42acd7d562e7d37bb4f84d92267db49f0a55a Reviewed-on: https://chromium-review.googlesource.com/c/1185001 Auto-Submit: Christian O. Andersson <cricke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Christian O. Andersson <cricke@chromium.org> Cr-Commit-Position: refs/heads/master@{#626102}
-
Xida Chen authored
This CL creates a CrossThreadKeywordValue, and use it in the CrossThreadStyleValueFromComputedStyle. Unit tests are added to ensure the correctness. Bug: 895579 Change-Id: Id5972634732489473dcb49dd54e8856e93d8752c Reviewed-on: https://chromium-review.googlesource.com/c/1427780 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#626101}
-
David 'Digit' Turner authored
When the input is a tiny empty .jar file (e.g. 22 bytes that only include an empty End Of Central Directory record) as shown below, ijar generated an invalid output, which was supposed to only contain a single 'empty' file with length 0. The problem was due to the fact that MappedOutputFile did the following: - First call ftruncate(fd, 22) to size the output file from an estimate of the input file (blindly assuming the result would be smaller). - Later call ftruncate(fd, 108) to size the output with its 'final' size. Unfortunately, the kernel interpreted that as _extending_ the file size, and overwriting the new bytes with zero. In practice, this means that the buffer's content before the second ftruncate() was: 00000000: 50 4b 03 04 0a 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 05 00 00 00 64 75 00000020: 6d 6d 79 50 4b 01 02 00 00 0a 00 00 00 00 00 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 05 00000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000050: 00 64 75 6d 6d 79 50 4b 05 06 00 00 00 00 01 00 00000060: 01 00 33 00 00 00 23 00 00 00 00 00 And after ftruncate() became: 00000000: 50 4b 03 04 0a 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000060: 00 00 00 00 00 00 00 00 00 00 00 00 The result only contains a Local File Header record, but has no longer a final End Of Central Directory record, and is thus no longer a valid zip archive! This is fixed by this CL by ensuring that the initial ftruncate() is at least one page long. A sanity check is also added to return an error if the output file is larger than its input for some unexpected reason. This is not needed on Windows, which closes the file then later changes its size. -- example tiny input zip file of 22 00000000: 504b 0506 0000 0000 0000 0000 0000 0000 PK.............. 00000010: 0000 0000 0000 BUG=925257 R=agrieve@chromium.org,dpranke@chromium.org,benmason@chromium.org Change-Id: If06b3ca88fee2dceaebacb427741ef48311cb38d Reviewed-on: https://chromium-review.googlesource.com/c/1436361Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#626100}
-
edchin authored
The preferred pattern for TabHelpers is to create them in AttachTabHelpers(), then set any necessary delegate in BVC or elsewhere. A DCHECK should be placed anywhere the delegate is used so that there aren't silent failures. This CL makes SadTabTabHelper conform to the preferred pattern. Change-Id: If6d7b5287c99835f950e6dfc0aaac7c595dd16e5 Reviewed-on: https://chromium-review.googlesource.com/c/1404578Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626099}
-
Sebastien Marchand authored
This also adds it to the whitelist used in third_party/blink/renderer/DEPS Gab/Francois, I've used your refactoring script for this, the rule is: matches = re.compile(r'(\n *[^/\n][^/\n]*base::Bind(Once|Repeating)?\b[^*])', re.DOTALL).findall(content) if not matches: return False updated_content = refactor_lib.AddInclude(file_path, content, "base/bind.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) TBR=fdoray@chromium.org Change-Id: I7a9a991255a560c6ebedaade47cffe1ac1c7baff Reviewed-on: https://chromium-review.googlesource.com/c/1437069 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#626098}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: I14ca95a063835d72ca48d9c49c4a45f816e5fb55 Reviewed-on: https://chromium-review.googlesource.com/c/1424881 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Geoff Lang authored
Since https://chromium-review.googlesource.com/c/chromium/src/+/1005017/ EGL is enabled on Mac but not used by default. The disable_es3_gl_context workaround removes the kGLImplementationDesktopGLCoreProfile GL implementation from the list of allowed implementations which now defaults to using EGL when the intention is that it falls back to a non-core desktop GL profile. Reorder the implementations so that the fallback happens as expected. BUG=918365 Change-Id: Ibf9ae089897f32508dd83fed41cfdc8412e9c7bb Reviewed-on: https://chromium-review.googlesource.com/c/1437060Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#626096}
-
Sam Maier authored
Pre-native Java tasks are now having their priority set when started. Also switches dynamicmodule's ModuleLoader to use the TaskTrait's priority setting instead of manually setting the thread priority. Bug: 863457 Change-Id: Iee601ca1e18e2637f8e930c6d212c8115e682fc3 Reviewed-on: https://chromium-review.googlesource.com/c/1407374Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#626095}
-
