- 10 Aug, 2018 40 commits
-
-
Thomas Tangl authored
This CL rolls back the unified consent preferences when the installation is excluded from the experiment. This is needed in case the unified consent feature has to be disabled due to some reason and rolled out again later. During rollback, the following is done: - All unified consent prefs are cleared. - Sync-everything is turned back on if all datatypes are turned on and if the consent bump was supposed to be presented. Bug: 863937 Change-Id: Icb58fad008069c0b38a1ef952ed19e48f8cd3fe6 Reviewed-on: https://chromium-review.googlesource.com/1165226 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#582263}
-
Kyle Horimoto authored
This CL updates the kSuiteEnabledPrefName and kAndroidMessagesFeatureEnabledPrefName preferences to true when they are registered. These values should be set to true so that once the setup flow completes, the toggles will be turned on. Without this change, users would complete the setup flow only to discover that MultiDevice features are disabled. Note that this change does not mean that these features will be available without completing setup; these preferences are not used until after setup has completed. Bug: 824568 Change-Id: Ib14434a320a6dc9b1091e8e246f6924835a03763 Reviewed-on: https://chromium-review.googlesource.com/1170176Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#582262}
-
Peter Kasting authored
This reverts commit 94a8710d. Reason for revert: Seems to have caused significant flakiness of many WebRtc tests: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRhODcxMGRjZmViMjFhNDUxNjBjOTY4NmVkZWVjN2RlN2UzMjVjNAw Original change's description: > Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy" > > This is a reland of 7dae0f63 > > The original CL caused flakiness because, in production code, > WebRtcEventLogManager is torn down during Chrome shutdown, after > all threads other the the UI thread have quit. For unit tests, this > was not the case, and so the tests hit some use-after-destruction. > This was fixed by making the tests stop the non-UI threads before > tearing down WebRtcEventLogManager. > > Original change's description: > > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > > 1. If the policy was disabled before, and becomes enabled, > > subsequent calls to StartRemoteLogging() will succeed (barring > > unrelated issues), even for peer connections created while the > > policy was disabled. > > 2. If the policy was enabled before, and becomes disabled: > > a. Peer connections associated with the profile reject > > calls to StartRemoteLogging(). > > b. Active logs (associated with the profile) are stopped, > > and those log files deleted. > > c. Pending log files (associated with the profile) are deleted. > > d. If a log file associated with the relevant profile is > > currently being uploaded, the upload will be cancelled, > > and the file deleted. > > > > Bug: 775415 > > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > > Reviewed-on: https://chromium-review.googlesource.com/1162168 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Elad Alon <eladalon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581167} > > TBR=guidou@chromium.org > > Bug: 775415 > Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff > Reviewed-on: https://chromium-review.googlesource.com/1168962 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582162} TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org Change-Id: I39bd5b6ac26325522f068e78846dde2443f067ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415 Reviewed-on: https://chromium-review.googlesource.com/1171263Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582261}
-
Christopher Thompson authored
This tweaks the policy templates and examples to be clearer about affects on the "Not Secure" UI and how wildcard hostname patterns work. Bug: 844885 Change-Id: I49eba85762272a0bfedb4163cecad1b8e6df513a Reviewed-on: https://chromium-review.googlesource.com/1166247Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582260}
-
Jacob Dufault authored
ShelfBackgroundAnimator determined color by looking at both ShelfBackgroundType and also the session state. ShelfBackgroundType was set from ShelfLayoutManager. Both ShelfLayoutManager and ShelfBackgroundAnimator observed session state changes and updated the shelf colors from that. This means that there were multiple color updates, and beyond that the rendered background type could diverge from what was requested by ShelfLayoutManager in the time between the two callbacks. Remove the ability for ShelfLayoutManager to observe session state changes, and encode the needed information in ShelfBackgroundType. This simplifies control flow and reduces complexity. Bug: 857221 Change-Id: I173e8cc47d7f6f22123814d341a94749472f7932 Reviewed-on: https://chromium-review.googlesource.com/1168028 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#582259}
-
Matthew Cary authored
Adds --pregenerated-profiles and --profile-save-dir to orderfile_generator_backend.py. These allow for precise comparisons between different versions of profile processing, that are not affected by variations in the symbols seen during device profiling. Bug: 869997 Change-Id: I9dd734a77ea4a738e22f20f095e76879e71f3c0c Reviewed-on: https://chromium-review.googlesource.com/1162179 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582258}
-
Jun Mukai authored
Previously the device id was extracted from the offline policy, but that means all of the offline-enrolled device shared the same device id (since the offline policy data is stored on the device). This isn't a big issue as long as the device stays offline, but we should use the generated ID to allow making the transition to the online demo mode after the offline enrollment is conducted. BUG=827369 TEST=manually walked through the offline enrollment Change-Id: I0d9713d78c08fabcd0fb49326e1acca9ee578b98 Reviewed-on: https://chromium-review.googlesource.com/1147336Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#582257}
-
Changwan Ryu authored
We are unnecessarily adding this permission for standalone WebView: com.google.android.c2dm.permission.RECEIVE This was added in rolling a new version of GMS core through BackgroundTaskScheduler. WebView is only using TaskIds in BTS, just to avoid collision with Chrome (which is using the same UID). Therefore, this CL splits TaskIds from the rest of BTS and have WebView depend on it. Bug: 872977 Change-Id: I424659366b2af661d83ad19590c4a76bca37a2ad Reviewed-on: https://chromium-review.googlesource.com/1170426Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582256}
-
Thomas Guilbert authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/de23348fef6f..5659adb8fc6f $ git log de23348fe..5659adb8f --date=short --no-merges --format='%ad %ae %s' 2018-07-24 tguilbert Uncommit script changes 2018-07-24 tguilbert GN Configuration 2018-07-24 tguilbert M70 Chromium patches GN Configuration 2018-07-04 cus avformat/mxfdec: drop invalid index table segments when sorting them 2018-07-16 minasamy_ avfilter: Add colorconstancy filter 2018-07-23 liberato Start robosushi auto-merge. 2018-07-15 michael avcodec/cdgraphics: Clear first frame only once 2018-07-15 michael avcodec/tscc: Do not duplicate images 2018-07-15 michael avcodec/tscc: Move reading the side data palette before other checks 2018-07-22 onemda avcodec/bink: set color range (...) Created with: roll-dep src/third_party/ffmpeg BUG=864711 Change-Id: Ib256516b28b0b2095b52b3ac58c71f5fea8f2f60 Reviewed-on: https://chromium-review.googlesource.com/1159479Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#582255}
-
Michael Spang authored
After 6fc38604 ("ozone: drm: Move DrmFramebuffer from GbmBuffer to GbmPixmap"), if a buffer's format is supported for scanout but cannot be added as a framebuffer, we fail the import. This broke CTS tests, so relax this test and add a note. Bug: 872681 Test: ozone_unittests Change-Id: I35e18f043abe21f5554369129da05448f990bfd4 Reviewed-on: https://chromium-review.googlesource.com/1169595 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#582254}
-
sunxd authored
This patch attempts to fix the flaky content browsertest. The suspected reason of the test being flaky is that the subframe content is not fully loaded and processed when hit test data is collected. This patch force the test to wait until all subframes receive their hit test query entries, and retrieve hit test data directly from root frame hit test query. Bug: 869314 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iccace2dfd11b613cccf67a23cf5fc8552f31544d Reviewed-on: https://chromium-review.googlesource.com/1161972Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#582253}
-
Jacob Dufault authored
Also extend chromeos_login to ash/login/* Change-Id: Ie7632e02892cdee3b8c1aa6131ec27171c06cd62 Reviewed-on: https://chromium-review.googlesource.com/1171210Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582252}
-
Morten Stenshorne authored
Objects with an intrinsic ratio (such as images) whose block size is percent based will actually have their min/max inline size affected by the block size of the container. Some special code is required for this. Similar code exists for legacy layout in LayoutBlock::ComputeBlockPreferredLogicalWidths(). Additionally, we need to clear the override containing block size when done with legacy layout, or subsequent min/max calculations will fail (e.g. in LayoutBox::ContainingBlockLogicalHeightForContent()). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I22ee962eddca44586e2cb4e83039f829bd9d5997 Reviewed-on: https://chromium-review.googlesource.com/1167182Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#582251}
-
Kyle Horimoto authored
Bug: 824568 Change-Id: I810dfe67df49453139f992f55b58744d65031497 Reviewed-on: https://chromium-review.googlesource.com/1170178 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#582250}
-
Sam Maier authored
We would like to get rid of all usages of execute() since it is unclear whether it goes to SERIAL_EXECUTOR or THREAD_POOL_EXECUTOR (many assume THREAD_POOL_EXECUTOR, but it actually goes to SERIAL_EXECUTOR). This is just cleaning up this test usage. Bug: 869907 Change-Id: I7564a0cc743f803b07aa04651337c857b7eb6d87 Reviewed-on: https://chromium-review.googlesource.com/1162704Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#582249}
-
Yue Li authored
Bug: None Test: Manual Test Change-Id: I46c5eb1efdc1ea9ac730f0a76d0e83903e8a86d9 Reviewed-on: https://chromium-review.googlesource.com/1170307Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#582248}
-
David Black authored
Previously, we always anchored to the primary display. Now, we'll check for where new windows will be opened. We match a display against the bounds for that window and anchor there. Bug: b:111445270 Change-Id: Ice37359fe61937d452d7a908a609d1b60d913a37 Reviewed-on: https://chromium-review.googlesource.com/1150920 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582247}
-
Vladislav Kaznacheev authored
Bug: 872823 Test: manual, steps in the bug Change-Id: I4d900b08cd9ae391639c4e4789caf1b0eb1f79ae Reviewed-on: https://chromium-review.googlesource.com/1169692 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582246}
-
Jacob Dufault authored
Bug: 872923 Change-Id: I7071921895fcd017a65286fce4b565ad8f96de76 Reviewed-on: https://chromium-review.googlesource.com/1170035 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#582245}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9e22c54..c47cd43 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3ae0ca29a797b35cfe2926ded1eb6222e20e77c5 Reviewed-on: https://chromium-review.googlesource.com/1170983Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582244}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. This CL is the beginning of a refactor to separate the two types of consumers of MemoryDetails: * Those that want a human readable string that shows a mapping from [process : memory usage]. * Those that want to emit non-memory related metrics. Bug: 864352 Change-Id: I0f2a968ef63b3c9fcb658898a2f3f55f68867285 Reviewed-on: https://chromium-review.googlesource.com/1170587Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582243}
-
Weilun Shi authored
Only double click on the "SelectedTile" can apply that as the custom background. In that case, when we double click on the collection tile the click count will not apply to the image tile underneath it, so that it will not apply the underneath custom background. Bug: 872953 Change-Id: I897be7aa93040e1e819ceb762e4d4c78f9f0b1ce Reviewed-on: https://chromium-review.googlesource.com/1170134 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#582242}
-
Quan Nguyen authored
This also fixes the crash when we click on the "Learn More" button in views lock screen. Bug: 872699, 872692 Change-Id: I3172cae0a9a86e28a6f154eb000e270eaf9352dd Reviewed-on: https://chromium-review.googlesource.com/1169764 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582241}
-
Kevin McNee authored
The associated bug which required this extra tab is fixed. Bug: 147644 Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343 Reviewed-on: https://chromium-review.googlesource.com/1170986Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582240}
-
Sam Maier authored
Change-Id: I6e3603ad89eca72a3cdd481dfb1667105b6ef0ed Reviewed-on: https://chromium-review.googlesource.com/1169128Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#582239}
-
Christopher Cameron authored
Move the interfaces FocusChangeListener and InputMethodDelegate from being implemented by BridgedNativeWidget to being implemented in BridgedNativeWidgetHostImpl. This has the effect of moving them from the app shim process to the browser process. This is in preparaton for removing access to TextInputClient from BridgedContentView (that operation is delicate). Add a temporary method on BridgedNativeWidget to set the TextInputClient for BridgedContentView from BridgedNativeWidgetHostImpl (where we now receive the OnDidChangeFocus notification). Bug: 859152 Change-Id: I1f5639448cc9f7b4b00058444ab64914b9193df3 Reviewed-on: https://chromium-review.googlesource.com/1170582Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#582238}
-
chrome://flagsJan Krcal authored
Bug: 853688 Change-Id: I4069581ed4eea46c04351593a595102783bac438 Reviewed-on: https://chromium-review.googlesource.com/1169479 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582237}
-
Charlie Andrews authored
It looks like this file has * listed as its owner, so it doesn't need any specific owner review. Bug: 859514 Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: I9afd700a6a36f00b5fb46847fbc5d01d08646db8 Reviewed-on: https://chromium-review.googlesource.com/1169437 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582236}
-
Evan Stade authored
Bug: none Change-Id: I3aadd1d6c94c27dd9bdf2648ea241412d5a71078 Reviewed-on: https://chromium-review.googlesource.com/1167954 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582235}
-
Becca Hughes authored
The sound setting is only applied at a WebContents level so we should make sure it is registered with TOP_LEVEL_ORIGIN_ONLY_SCOPE. BUG=865548 Change-Id: Ia0e02f2201665b14a59e8c38b8dcfcde8e99ed67 Reviewed-on: https://chromium-review.googlesource.com/1169522 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582234}
-
Etienne Pierre-doray authored
Creates Disassembler that recognises and parses ELF format. For now, it only supports Intel architeture. Support for Arm will be added in follow-up CLs. Change-Id: Ibdcf113b573f22844b6a1611c5ff6df46829b9b3 Reviewed-on: https://chromium-review.googlesource.com/1136841 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582233}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c97933fb82f8..f5f537337258 git log c97933fb82f8..f5f537337258 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 nisse@webrtc.org Delete unused member MediaSenderInfo::packets_cached. 2018-08-10 phoglund@webrtc.org Temporarily skip linux_internal on autoroller tryjobs. Created with: gclient setdep -r src/third_party/webrtc@f5f537337258 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I401e8192beca5bd0160859d037944014dcfad7bf Reviewed-on: https://chromium-review.googlesource.com/1169706Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582232}
-
Adam Langley authored
This change aligns Chromium with the current state of the spec[1]: the “appid” extension output will only be returned when the caller requested the appid extension, and it'll be true iff the AppID value was actually used when getting the assertion. [1] https://w3c.github.io/webauthn/#sctn-appid-extension BUG=853770 Change-Id: I6ac9470c71bfc0cc3b38f6e91c5e8f00b0586405 Reviewed-on: https://chromium-review.googlesource.com/1162823Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582231}
-
Toni Barzic authored
Update CrOSComponentManager to handle the case when an installed compatible component is found during component registration started by CrOSComponentManager::Load. Previously, CrOSComponentManager would start OnDemandUpdate whenever no compatible component path was registered when Load() was called - this did not account for cases where Load was called early on, before registration of installed components finished. This means that CrOSComponentManager could end up starting foreground on demand update even if a compatible version of component was already installed. This CL moves decision whether an update should be requested later on - after the component registration was done. Update will be run if it's forced, or if there is no compatible component version after component registration finishes (which should check for any installed components). Note - this also moves ComponentInstaller::Register callback after OnComponentReady is called, to ensure that any potential compatible component path is registered before CrOSComponentManager::StartInstall is called. (This is more in line with order OnComponentReady and the callback are invoked during Install request, and no other callers seem to depend on this ordering). BUG=872871 Change-Id: I33ff01b5d127d17cd9016b012fc400562c03d9c1 Reviewed-on: https://chromium-review.googlesource.com/1170172Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582230}
-
Sujie Zhu authored
Since we only offer local cards migration to signed-in and synced user, we have to get the syncStatus in the payments_section in order to check the migration requirements in the payments_section.js. We use the similar code from the people_page.js to add the syncStatus property from SyncBrowserProxy in the payments_section. Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i Bug: 852904 Change-Id: I9786fd491780a6daf71d19da94da4b048ad59ed2 Reviewed-on: https://chromium-review.googlesource.com/1168386Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#582229}
-
Elly Fong-Jones authored
TBR=pkasting@chromium.org Bug: 872705 Change-Id: I72edb9f5b1d07baf898fe8aa97231df5d76424a4 Reviewed-on: https://chromium-review.googlesource.com/1171106Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582228}
-
Fabio Tirelo authored
The current CVC placeholder string is translated to the full form in some languages and doesn't look well on the card unmask dialog (for example, it looks like "Crypto..." in French). This adds a restraint to the number of characters it should be translated to and add a "meaning" tag to ensure the translation is not shared with other properties. Bug: 873158 Change-Id: I1ffd5154ef94705efe86dae842fbf913b09b6a36 Reviewed-on: https://chromium-review.googlesource.com/1170586 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582227}
-
James Cook authored
The serialized AX node locations need to be adjusted by the display device scale factor. This is similar to how AXTreeSourceArc handles remote ARC++ apps. Bug: 851578 Test: added to views_mus_unittests Change-Id: Ibf17c76584e1ec54e5b214866a7cd1abbcc88f7f Reviewed-on: https://chromium-review.googlesource.com/1168120 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582226}
-
Anna Malova authored
Bug: 873098 Change-Id: Ifafc4edec8ddae8da621908f69fdf3a39e9e8f8a Reviewed-on: https://chromium-review.googlesource.com/1170698 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582225}
-
Alexander Hendrich authored
This CL adds detailed warning/errors messages from the ONC value validation to chrome://policy. Bug: 855057 Change-Id: I6d6bca90d074bc6b5c6be3b416fe25f216b5b7cb Reviewed-on: https://chromium-review.googlesource.com/1118555Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582224}
-