- 13 Oct, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change gracefully handles a null PasswordManagerDriver in PasswordGenerationPopupControllerImpl::PasswordAccepted instead of forcing a CHECK failure. Bug: 1133635 Change-Id: Ife83a3c8c78b5dff18c3252c3beb0092750d4420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463834 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816536}
-
v8-ci-autoroll-builder authored
This is a reland of 052bc3e7 Original change's description: > Update V8 to version 8.8.74. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/ba88e59b..7bb48090 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I95a61574ebdaa9fcab1866231cd4a46092517bd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462181 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#816339} Change-Id: I019e65713c57c6e78a87dcfc117b79a09a483c29 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465857 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#816535}
-
Marc Treib authored
This reverts commit d7c5c1d5. Reason for reland: Mac flakiness was hopefully resolved by https://crrev.com/c/2463562 Original change's description: > Revert "Add fieldtrial testing config for ButterForPasswords" > > This reverts commit 8e4ad533. > > Reason for revert: crbug.com/1136758 test failures on macOS > > Original change's description: > > Add fieldtrial testing config for ButterForPasswords > > > > Bug: 991510 > > Change-Id: I447e99f11c322478f007557ab268823ed2616042 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455446 > > Commit-Queue: Jesse Doherty <jwd@chromium.org> > > Auto-Submit: Marc Treib <treib@chromium.org> > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815355} > > TBR=jwd@chromium.org,treib@chromium.org > > Change-Id: I41a6d02cb9dce80e5bc41e087c53f8b6b5be0335 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 991510 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462884 > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815507} TBR=jwd@chromium.org since this is unchanged from the previous version # Not skipping CQ checks because this is a reland. Bug: 991510 Change-Id: Id09347649546b2d7ca102ba839be17fe8cd13166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462081Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816534}
-
Matt Jones authored
This patch adds resets the Y offset of the infobar container on navigation to clear any stale values from the previous page. Bug: 1012695, 1069955 Change-Id: Idccc26471c178850f2ed820e3b567bd6d5970819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461708 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#816533}
-
Thiemo Nagel authored
... due to flakiness on Builder Linux Tests [1]. [1] https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/94497 TBR=dominickn Bug: 1137759 Change-Id: Ib3fe9800b017b311a32cebad46154aca5323bacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466246Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816532}
-
Rob Buis authored
The codepoint U+266D was used in this test and part of the MathML3 operator dictionary, however it is not part anymore of the MathML Core operator dictionary. Therefore pick a postfix operator that is part of the MathML Core operator dictionary. Bug: 6606 Change-Id: I253909a13a3d1ce34ca597342a706c05d35d3d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466243Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#816531}
-
Harald Alvestrand authored
It's now in the API directory of third_party/webrtc Bug: webrtc:11967 Change-Id: I752ffa3261fa4080bac565c58d544f900a0bd890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463609Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#816530}
-
Andrey Zaytsev authored
Mocks: https://docs.google.com/presentation/d/1r1wHrb1NnYKEQieWAxeHymsJs__u30yLJ5lJ-BzCm3E/edit?usp=sharing Screenshots: https://screenshot.googleplex.com/AUtj24CvvLBEUzq.png and https://screenshot.googleplex.com/848cwBXgdaXSyGk.png UI deck: go/metrics-settings-clank Bug: 1132805 Change-Id: I220dab3231ed070c26a3a5500c0acf35bba2660f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450190 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#816529}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4b8d27d96b7..a08dc37d19e5 2020-10-13 treehugger-gerrit@google.com Merge "tracing: Don't reuse trace writers across connections" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I95c3ae8a5d9cdffba9cc90a70274d55a70ca8da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816528}
-
Luciano Pacheco authored
Change the use of cr.defineProperty() to Object.defineProperty() + type declaration. This is basically what Closure ChromePass was doing [1], but we don't want to depend on ChromePass when using JS modules. NOTE that this changes the property definition for both module and non-module versions, but they should have the same behaviour, because it uses the same getters and setters. [1] - https://github.com/google/closure-compiler/blob/master/test/com/google/javascript/jscomp/ChromePassTest.java#L415-L427 Bug: 1133198, 1134497 Change-Id: I787dc3d7f2fa8dc290f7839c76c347b5695a0038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440331 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816527}
-
Boris Sazonov authored
Changes the text used for the primary button in sync promo that is shown in the signed out state. The text is changed from "Continue as ..." to "Turn on sync". Applied only if MobileIdentityConsistency flag is enabled. Screenshot: https://crbug.com/1136905#c1. Bug: 1136905 Change-Id: I967768061e26a01a4d34cdedee463fd8276dc969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462267 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#816526}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. In this case, all users (and constants) used "supports," so swap the definition to that, too. Bug: 1136209 Change-Id: I38c98419a0ffdcd5c521b40f065ab9f609194521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458893Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#816525}
-
Maksim Moskvitin authored
There were only few minor expectations relying on verifier profile in preferences tests. This CL removes them together with verifier profile notion in preferences_helper. Bug: 1137746 Change-Id: I7d74ad99feaf1dfa7c4a0eb856fcf94263a681bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467521 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#816524}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ffd66905c46a..599fe36ca9b3 2020-10-13 sigurds@chromium.org Allow undefined for lineNumber in (maybe)LinkifyScriptLocation 2020-10-13 tonykostowny@gmail.com Devtools: Network panel search clear command resets search results message. 2020-10-13 sigurds@chromium.org Fix typo in variable name 2020-10-13 sigurds@chromium.org [ts] Type-check sdk/SecurityModel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1102761,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibcc7eb55c2a323e67cf5a46d16c02c10694578e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466849Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df6b7298bb41..06b956fe4525 2020-10-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from efbcef25 to a6b7134c (408 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: I7d46bad9602c02e35139c28b5bfc87148be7b2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466844Reviewed-by:
-
Thiemo Nagel authored
MetricIntegrationTest.LargestContentfulPaint_SubframeInput is flaky on Linux, so disabling there (and for Chrome OS as well). TBR=skobes Bug: 1135527 Change-Id: I876e3e1d174edca0b5bd17f3cc53f3cb61ef4c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467522Reviewed-by:
-
Miyoung Shin authored
This CL implements RemoteObjectInjector#removeInterface which should call the RemoveNamedObject method on a RemoteObjectGateway remote. This CL changes to removing the unnamed object on only the browser side to secure that the object is injected again on the renderer. It is consistent with the old code, and fixes JavaBridgeBasicsTest#testRemovalNotReflectedUntilReload. Bug: 1105925 Change-Id: I7a304dba05f4e09b190658f684c13632497481d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379270Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#816520}
-
Jérôme Lebel authored
Removing ChromeTrustedVaultService::AddKeysChangedObserver() and temporary code introduced in: crrev.com/c/2461007. Related to: crrev.com/i/3323592 Bug: 1081649, 1100278 Change-Id: Iada56e4b25f5d51ab89263d7fa09f5317d26c63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461124 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
ChromeIdentityService::GetCanonicalizeEmailsForAllIdentities() is unused. And also removing GetCanonicalizedEmailForIdentity(), this function is only used in AuthenticationService. This method can use the user email instead of the canonicalize email. The implementation is removed with: crrev.com/i/3326972. Change-Id: I9f74f5bfffb2fec77bc4ee3fd220a1ae403fe60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465854Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816518}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I81007ddb043ef8182e39c282465a1188ba9fad14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466845Reviewed-by:
-
Mitsuru Oshima authored
Use these scale factor when 2.25, 1.77 and 2.66 are given from command line. Bug: None Change-Id: I20f227a80ed38eb3643a63abb50ba6c454036b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448651Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#816516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1df9e9aac9d3..e2dfd01ded55 2020-10-13 jleconte@google.com Fix 'Unknown git hash' when repository is not chromium. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: nuskos@google.com Change-Id: Ifd87cae8526bb14bc204095441e6f2e5e6f8ccb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467541Reviewed-by:
-
Paula Vidas authored
This CL adds a test that checks the following: - When sync is disabled for a data type, it won't show up in interested data types. - When sync gets enabled again for that data type, it will appear in interested data types, and the device will receive invalidations for that type. The test uses only sync invalidations. Bug: 1135167 Change-Id: Ibe118a8281a332ebe64713d9dffdf1e9935e6262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466760 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816514}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ce65f04. With Chromium commits locally applied on WPT: cfa13307 "Revert "Enable "Immersive-AR" session for OpenXR runtime"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ie431e137de412c6946083c712892b507c3e9a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466440Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816513}
-
Weilun Shi authored
Bug: 758782 Change-Id: I4b7ff5cd8116d9b88ae1e9fe12adb7532a6ecf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466840 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816512}
-
Mikel Astiz authored
The concept of registered datatypes is somewhat advanced and should not be part of SyncService's public API. Instead, this patch moves it to the subclass, ProfileSyncService, and makes it private except for testing. Change-Id: I0934a6a97009bf6589f1075ba37fdc1a52490643 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463832Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816511}
-
Jacobo Aragunde Pérez authored
This bubble is modal: it takes focus when shown up and does not let users manipulate other UI until having explicitly dealt with it. For this reason, the dialog role is more appropriate. As a result of this change, the bug where the bubble content was not always read is gone. The deleted code was supposed to fix crbug.com/849910, but now this bubble is properly announced by JAWS 2020 in addition to NVDA. Bug: 1123107 Change-Id: I371523a4384b7338e35ba30f897bade1d3ba2ee5 AX-relnotes: always announce add extension bubble correctly. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461276 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816510}
-
Eric Seckler authored
As it turns out, the per-core time_in_state data from /sys/devices/system/cpu/cpuX/cpufreq/stats/time_in_state is wall time rather than CPU time and includes time the cores spend in idle states. Consequently, the data we currently report into Power.Approx* metrics isn't correct. We have to correct for the idle time when computing each core type + frequency state's proportional part of the execution. This patch adds a way to do so by polling per-core idle times from /sys/devices/system/cpu/cpuX/cpuidle/stateY/time (via a helper in base::CPU) and updates the CpuTimeMetrics code to account for idle time. Bug: 1081760 Change-Id: I7b8168b47b1e4d118bc7569aebb07952fa78693e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462088 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#816509}
-
Mikel Astiz authored
It was only used for a DCHECK that always returned true and was not important anyway. Change-Id: I87fd0a856420e035cbd6381f79fa9cdd04f87b1f Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467520 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#816508}
-
Jaeyong Bae authored
This patch implements showing confirmation dialog for removing address. It makes easy user to recognize removing address. It is similar in looks and functionality to the already confirmation dialog of history. Change-Id: Idf7b819279b314d7ba85c6099302b4924e9155f9 Bug: 935227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009165 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Weilun Shi authored
The original cl is in https://chromium-review.googlesource.com/c/chromium/src/+/2246233 Change-Id: Ifeee8eb6c01c914b3f71c16feb1b44d602688b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467357 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Titouan Rigoudy authored
This browser test asserts failures we want to fix for crbug.com/1134601. As such it is important to re-enable and de-flake. I hope that by splitting the loop into individual tests, the strange check failure in DidCommitNavigation() that afflicted the old test will no longer happen. The old test is extended to cover is_web_secure_context as well as ip_address_space. This allows us to remove redundant assertions from the tests below that actually perform private network requests and check for success or failure. Bug: chromium:1134601 Change-Id: I11d783027a67087d50d8c6ff3d358777b72bf935 Fixed: chromium:1014325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454718Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816505}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df42b9a729b5..8567edac4fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: Ib1bd2e877ed242b17e3585538af162637c0ab000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816504}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8900cd2cdaec..ffd66905c46a 2020-10-13 wolfi@chromium.org Add dedicated workers to frame tree 2020-10-13 petermarshall@chromium.org Don't instantiate a SourceFormatter when modules are imported 2020-10-13 yangguo@chromium.org [ts] Type-checkk har_importer/HARImporter.js 2020-10-13 wolfi@chromium.org Fix overlapping text for COOP policy in frame details 2020-10-13 wolfi@chromium.org Add whitespace to frame details->secure context 2020-10-13 szuend@chromium.org Update DevTools protocol If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093247,chromium:1122507,chromium:1136848 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bdfc6027bc3fcb16a8f6bf2fd43c2cdcbe347cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467539Reviewed-by:
-
Henrique Ferreiro authored
Ash limits the cursor scale factor to the available resource scale factors, currently 100P and 200P. Lacros should follow this behavior; otherwise, the cursor may change sizes when hovering a Lacros window. Bug: 1127962 Change-Id: I17c0ded04153dd10efb7b90665e1426634c9a7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461227 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816502}
-
Nohemi Fernandez authored
Adds a comment explaining the flexibility of the AuthenticationFlow service and how this may cause issues in sign-in UI expectations. Bug: 1125631 Change-Id: Ia2f5aa12a7092c57a2c91f8eae1df6079ddd980d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461345 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
If the pseudo_id is set, the SelectorChecker::MatchSelector call for each subselector will fail completely because the dynamic_pseudo of the inner result will not match context.pseudo_id. This check does not make sense to perform for nested complex selectors, since pseudo elements are not valid in nested complex selectors. Hence, we can just set the pseudo_id to kPseudoIdNone at the :is/:where boundary. This fixes a bug where selectors such as ":is(.a .b)::before" would never match. This CL also adds a basic test for pseudo classes. (Not related to the fix). Bug: 568705 Change-Id: I119265836ac0f1b77868537c7685690300c265fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466278Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#816500}
-
Mario Sanchez Prada authored
Currently, the code in RFHI::SetEmbeddingToken() (which gets called as the result of a document being loaded in a renderer's RenderFrame for the first time) takes care of locating the correct RenderFrameProxyHost representing the parent frame remotely to send it the embedding token, so that the parent-child relationship can get established. However, there is a race condition for the particular case of inner web contents in that such propagation will only work if SetEmbeddingToken() gets called *after* the inner web contents are attached to the outer one. In that case, since the outer delegater proxy has not been created yet, SetEmbeddingToken() will fail to find the RenderFrameProxyHost and the remote frame representing the parent frame in one renderer will not have its embedding token properly set, breaking things such as the accessibility tree, for instance. To fix that, this CL splits RFHI::SetEmbeddingToken() in two parts: one that actually sets the embedding token and another one that takes care of propagating it to the parent frame. And with that in place, this CL does also make sure that such propagation is requested also after inner web contents get attached, so that the parent-child relationship is always guaranteed to be set. Bug: 1135691, 1094150 Change-Id: Ie3ddd24acb3ad224a08a31c622e319cd69affba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462128 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816499}
-
Joel Hockey authored
It is helpful to use linux-chromeos to see parts of the settings and FilesApp UI which relate to Plugin VM. Change-Id: I4f51642e87d52fd35b125df540173c72d4022ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466545 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816498}
-
Francois Beaufort authored
This CL adds the camera pan tilt zoom permission to devtools browser protocol. Spec: https://github.com/w3c/permissions/pull/204 Bug: 1136778 Change-Id: Ic11990413e2ceeeceb7da5c03930cd4049189b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460898Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
