- 17 Jan, 2020 40 commits
-
-
Charlie Hu authored
This CL refactors build script code that generates feature_policy_helper.cc, so that the logic could be reused for document policy. - Simplifies make_runtime_features_utilities.py API. - Makes most util functions pure. - Adds more unittests The output of make_feature_policy_helper is verified to be the same as before. Bug: 993790 Change-Id: I0f0e07888f5b9e02727e3f210bbfb4cd871ecc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003255Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#733063}
-
Scott Violet authored
At the time this function is called kUserDataDir shouldn't be set. BUG=none TEST=none Change-Id: I5226da00d5943b57e611b25bc6c417ad5fbd3c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008052Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#733062}
-
dalyk authored
Binding new HostResolvers asynchronously gives them slightly longer to set up before they might be used by a consumer. Some host resolvers may need to obtain the system config asynchronously during setup. Bug: 1041045 Change-Id: Ia238e7eb77ac0551d4bfa282c2dcde14cc279fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995369 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#733061}
-
Jinsuk Kim authored
Preview Tab based on ThinWebView/BottomSheet is designed to reuse the WebContents until the sheet is closed. But it was actually being recreated for every new url due to how OverlayPanelContent works. When preview tab displays an interstitial page with security state change, the access to WebContents is made while it is in the destroyed state, hence the reported crash occurred. This CL adds a new public method in OverlayPanelContent so it has a way to reuse the WebContents. Bug: 1030616 Change-Id: If9ed28dfefd83720ccd08fc6ef9fd6ffce92aa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006836Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#733060}
-
Mustafa Emre Acer authored
This CL adds a list of Myanmar characters that look like Latin characters. A domain consisting only of these characters and not having a .mm ccTLD or other Burmese TLDs will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. No popular domain is affected by this change. Bug: 722167 Change-Id: I8d099e716f79ef42ab3205fe590e5e9b9a1db7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005869Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#733059}
-
Donn Denman authored
Adds support for a new Contextual Search Resolve request parameter: "ctxsl_exact" boolean used to restrict the server to only resolve a search for the exact selection. This means the returned Search Term is restricted to the exact selection and the selection will not be expanded. This is needed for user-adjusted selections as part of the Long-press triggering experiment. BUG=956277 Change-Id: I5f1285ce04bd4afff7250fbc76bca79c4da0dbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994265 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#733058}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d95467ec4e30..d6d0edc24fdf git log d95467ec4e30..d6d0edc24fdf --date=short --first-parent --format='%ad %ae %s' 2020-01-17 capn@google.com Enable filtering of YCbCr formats Created with: gclient setdep -r src/third_party/swiftshader@d6d0edc24fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5db8ae6c04d179fd625fc83979f9c42d1e203ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008185Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733057}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I7c575c445f467fc852115925274221cf0f763bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007870Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#733056}
-
Robbie McElrath authored
This adds logging on debug builds of android for the following events: * Requesting a new seed from the service * Scheduling a new download job within the service * Downloading a new seed * Copying a seed to an app's data directory * Loading a seed and its age I believe this will be enough information to verify that the system is behaving as expected and to narrow down where the problem is if things aren't working. Test: Manually verify the logs are being printed. Bug: 1042895 Change-Id: I1f6ec28c2cdc970db419bcc9b73ee0375221f2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006109 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733055}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c7d63f97f8d2..af4130aace70 git log c7d63f97f8d2..af4130aace70 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 michael.liao@microsoft.com [Request Blocking]: Adding error strings in list widget input Created with: gclient setdep -r src/third_party/devtools-frontend/src@af4130aace70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic27e8c6a1b96584ac552cb3e20494e8ab555a5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008408Reviewed-by:
-
Daniel Clark authored
This change fixes a couple of related issues about keyboard input the standalone month picker control and the month switcher menu embedded in other calendar picker controls. - The standalone month picker didn't close when the user hits Escape. The code for this was just missing (the month picker was built by reusing the YearListView for embedded month switcher menus embedded in other calendar popups, for which Escape is handled by the outer control). I've added the code to handle Escape. - I noticed that the escape was also not working to dismiss the month switcher menu when opened in a datetime-local. One problem with fixing this was was that the top-level DateTimeLocalPicker had no way to distinguish whether a EventTypeYearListViewDidHide was triggered by an Escape or Enter, where Escape would mean that the display should go back to the previously selected month. I reworked how the YearListView dispatches events to make this work; it now sends EventTypeYearListViewDidSelectMonth to indicate that a month was chosen and that the control should be dismissed, sends EventTypeYearListViewDidHide to indicate that the month switcher should be dismissed without changes, and sends nothing when the user arrow-key-navigates between months. One side-effect is that the month displayed on the month switcher button no longer updates as the user navigates between months, but this is consistent with the no-live-update behavior of our standalone month/week/date pickers. If we switch those to live-update, we should consider switching this behavior correspondingly. These changes are gated behind isFormControlsRefresh so that the old picker keeps the old behavior. - While working on the above I also noticed that clicking the body of a datetime-local or or on the month switcher or previous/next month buttons would cause the popup's value to be pushed to the in-page control. I fixed this by getting rid of the approach where parts of the calendar control suppress events so that they are not seen by the top level control, and instead equip the top-level DateTimePicker class to filter the keyboard and click events it receives so that it only acts on the ones with the relevant event.targets (time and date cells and the Today button). Tests are included for all of the above. Bug: 1026489 Change-Id: I0e66dae98d891c79ea7e1fe2821c948eb9aef499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003431Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#733053}
-
Wenyu Fu authored
According to proposal, when the feature flag is enabled, the context menu for Homebutton will be changed from "Remove" to "Edit Homepage", and launch HomeSettings. Change-Id: If416a585200a7b854cdd66f4c0b1f0982983fef9 Bug: 1036470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994099Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733052}
-
kylechar authored
CompositorFrameSinkSupportTest.OnFrameTokenUpdate covers the same functionality as a now deleted HostFrameSinkManagerLocalTest. Bug: 1033683 Change-Id: I4783febb64da93f2d77e4bd6e1d80665e09313b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008060Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#733051}
-
Piotr Bialecki authored
This adds a new test case that should ensure that `frame.getViewerPose(refSpace)` matches the pose returned by `frame.getPose(viewerSpace, refSpace)`. Change-Id: I0836649ed4911d714a6319bddc83f01ca3d8dd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008133 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#733050}
-
Peng Huang authored
For empty swap case, SchedulePrimaryPlane() will re-schedule the last submitted image. Bug: 1041035 Change-Id: Ic2994b3596e8919bf8f7a1828bcc73274e561470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007475 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#733049}
-
Dominic Mazzoni authored
r701284 (http://crrev.com/c/1825104) made a change that synced to the selection's deep equivalent in editables. That had the side effect that when linear-navigating to an editable text field, ChromeVox might be synced to an element inside the editable text field, rather than the element itself. That meant ChromeVox didn't trigger its logic to force a click and open the virtual keyboard when getting a double-tap. The fix is to ensure that logic runs anywhere inside editable text, not just on the root editable text element. See also b/143969599 Bug: 1042902 Change-Id: Ib047ec5b5897653df8266517ac29e00c062c4cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007973 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#733048}
-
Guido Urdaneta authored
Affected histograms are: * WebRTC.webkitApiCount * WebRTC.webkitApiCountPerSession * WebRTC.DesktopCaptureCounters Fixed: 1037409,1037394 Change-Id: I8a74bb5b7274bfaf39234f68fe4e7355beab9350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007729 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#733047}
-
Mounir Lamouri authored
Bug: 1043219 Change-Id: If901e5edb0f3db7d25cea5bf7ed361e0ffe4cf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008248 Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f70786126c8b..352a589fe08b git log f70786126c8b..352a589fe08b --date=short --first-parent --format='%ad %ae %s' 2020-01-17 rharrison@chromium.org Add code path to use spvc in Metal backend Created with: gclient setdep -r src/third_party/dawn@352a589fe08b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic71ae98b94f8b219f18e872bebf5288742793c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008359Reviewed-by:
-
Nate Fischer authored
No change to logic. This implements 2 histograms: - Android.WebView.DevUi.DeveloperModeEnabled tracks whether or not Developer Mode is enabled. - Android.WebView.DevUi.ToggledFlagCount tracks the number of flags we will toggle on this run of WebView. Bug: 1001185 Test: None (this is in the glue layer, so it's not testable) Change-Id: Ic2872e96005a0d24061b678e19e7d5f81bd0f27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004064 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733044}
-
Kenneth Russell authored
This is a reland of d54dd097 Several days have gone by without a new image being produced by the tests. Original change's description: > Reland "Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation"" > > This is a reland of f3a7d44e > > No new images for a few days, should no longer fail when re-enabled. > > Original change's description: > > Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > > > This reverts commit b4099b2c. > > > > Reason for revert: new image has been triaged in Skia Gold. > > > > Original change's description: > > > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > > > > > This reverts commit 7076daa4. > > > > > > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 > > > > > > Original change's description: > > > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > > > > > > > Test was producing a minor image diff, has been triaged. > > > > > > > > Bug: 1040202 > > > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > > > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > > > Commit-Queue: Brandon Jones <bajones@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#729597} > > > > > > TBR=kbr@chromium.org,bajones@chromium.org > > > > > > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1040202 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367 > > > Reviewed-by: sebsg <sebsg@chromium.org> > > > Commit-Queue: sebsg <sebsg@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#729736} > > > > TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org > > > > Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1040202 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: Kenneth Russell <kbr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729838} > > TBR=kbr@chromium.org > > Bug: 1040202 > Change-Id: I1045d7601496b271faf1ca41dd7a7707889ec733 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001225 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731755} TBR=kbr@chromium.org Bug: 1040202 Change-Id: Ide3d31df7067399a5eceb5c5b4e02f82d29bf372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008323Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733043}
-
Robbie McElrath authored
This moves a flag from CommandLineUtil to AwSwitches with the others, and removes the //aw:common_commandline_java build target, which isn't needed. Test: ninja -C out/aw system_webview_apk Bug: 1035235 Change-Id: Ib58d4269b8dc845948bc83a8ad788dc074376a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005609 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
TextScalePreference is the only SeekBarPreference used in Settings, so merge it with SeekBarPreference for more organized and readable logic. (Note: If a common SeekBarPreference widget is needed in future, the SeekBarPreference class now available in AndroidX is likely a better choice, although not suited to this particular usage.) Fixed: 977206 Change-Id: I4a4751ba96bd5b4f8d007546dd6db00884eeaf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003215 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#733041}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I1c0bea6950d1a52d4213d11d421d89ce3b87ea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003454 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Klaus Weidner authored
It took me a while to figure out what was wrong with my valid-looking new IDL file, this diagnostic would have saved me some time. However, I don't know if it's potentially confusing for other errors people might make, or if there are better ways to address this. Bug: 1041101 Change-Id: Ifae76b7d77e558f1888be0b70ae52fd53fc7514a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995712Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#733039}
-
Adithya Srinivasan authored
This should fix an existing issue where a DCHECK is hit when the test runner/browser is being torn down. Also cleans up portals-create-orphaned.html. Bug: 1018940 Change-Id: I35d1a842923e7302b308b57856e4c165bd07bd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007473Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#733038}
-
Jeroen Dhollander authored
If the on-screen keyboard is visible and we open the Assistant UI with "OK Google", the keyboard should be dismissed but it remains visible. Bug: b/147835595 Change-Id: I00050ce36c28f84c18cc8e6d8af0d157f22c1cd2 Tests: new ash_unittest AssistantPageViewTabletModeTest.ShouldDismissKeyboardWhenOpeningUiInVoiceMode Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006212 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733037}
-
Matt Menke authored
The test makes sure that HostCache entries aren't shared between NetworkContexts. To do this, it does a DNS lookup in one NetworkContext, which succeeds, and then cache-only DNS lookups in other NetworkContexts, which should fail. At the end of the test, it does a cache-only lookup in the first NetworkContext, which should succeed. It's generally best to do this at the end of the test, since it makes sure that entries aren't only usable once, or somesuch. Unfortunately, sometimes the DNS cache entry is timing out before the last lookup. To fix that, this CL moves the final cache-only lookup to be right after the initial lookup that populates the cache. This does mean the test can still flakily pass, however, flaky successes are more tolerable than flaky failures, and the test currently passes often enough, even with the flake, that I think we can live with it. Bug: 1043084 Change-Id: Ibdcf77e7775943e18c21a9ddd2cd3d5bf127c248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008058 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Robin Lewis authored
Uploads event viewer logs to cloud storage for easier debugging and auditing on every online login. The severity level of the logs that are exported can be controlled by a registry entry. Bug: 978691 Change-Id: Ibb1010eaea6d04e36bb07d06448d2b86a62f8a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990448 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#733035}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44509036060c..100fe639b230 git log 44509036060c..100fe639b230 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 yvesg@webrtc.org Fix race condition around rtc::ScopedFakeClock. Created with: gclient setdep -r src/third_party/webrtc@100fe639b230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8fa56764d375ae2c26302587f68ef6d9d8f3c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008187Reviewed-by:
-
Kyle Milka authored
Use a custom divider to correctly match the spec. http://screen/cGXhXz0KcAX.png Bug: 1009124 Change-Id: Idd4711681485cfa6d9ea0a77f6e3f6308f338e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008357Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#733033}
-
Alex Turner authored
Updates it to reflect that the speculative fix of handling ERR_CACHE_RACE in DoDoneHeadersAddToEntryComplete appears to have fixed the rare crashes observed. Bug: 959194 Change-Id: I68df784e286b3f667a0c5714f3dc881a209a2bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003406Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#733032}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1b7afc8f3a1..bd5ee543633f git log e1b7afc8f3a1..bd5ee543633f --date=short --first-parent --format='%ad %ae %s' 2020-01-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@bd5ee543633f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Ib7e9e11df6fdb4cb0a90bce3304ea93fdbced25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008186Reviewed-by:
-
Eric Willigers authored
Web app windows, including 'Open in window' shortcuts, do not have their tabs discarded. Bug: 1041743 Change-Id: I4f055fb470d484896f0eba059f0525cef41aa75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999896 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#733030}
-
Nicolás Peña Moreno authored
Currently, the TimingAllowPassed() check is used regardless of whether the OutOfBlinkCors flag is enabled or not. However, the check is only computed when the flag is enabled, so in this CL we revert back to the old behavior from before when the flag is disabled. See related change: https://chromium-review.googlesource.com/c/chromium/src/+/1992590 Bug: 1003943, 1042580 Change-Id: Ifafbae93aaa58166fbb8007d30a3f18620029b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003754 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#733029}
-
David Trainor authored
These methods are baseline utilities for interacting with the Android OS and should be usable by all other targets/directories within Chrome. Bug: 1042967 Change-Id: I10afd77c25a98c2bd04295eca1a91fe6bb390565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008316Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#733028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b0e33db0c16..516d0d786f27 Created with: gclient setdep -r src-internal@516d0d786f27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1042660,chromium:984162,chromium:989667 Tbr: jbudorick@google.com Change-Id: I041b825bc86a1ee195ae3a51b2084c69523949ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008183Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733027}
-
Annie Sullivan authored
Whenever we make a change to a metric, or see an unexpected regression, my team will make a change to this directory. This auto-ccs rviscomi so that he can update the corresponding CrUX documentation. Change-Id: I204e6a674fd1cb9e385605b0c1331965ccadfbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008352Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733026}
-
Guillaume Jenkins authored
Just going over all spell check files and making sure they all have the necessary includes for using spell check build flags. I did not look at other includes; just "build/build_config.h" and "components/spellcheck/spellcheck_buildflags.h" Change-Id: Icf3becebcb9ef6186a9ffffbd5438742d41a8b15 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007518Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#733025}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/05b001c28df8..98cfac11bd02 git log 05b001c28df8..98cfac11bd02 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 ehmaldonado@google.com scm: Add GetAllFiles method. 2020-01-17 ehmaldonado@google.com presubmit_support: Use single quotes and convert to ArgumentParser. Created with: gclient setdep -r src/third_party/depot_tools@98cfac11bd02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: Ib75d2eadaf2c601c2e70b14230c93f95ca18e1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008181Reviewed-by:
-
