GitLab

1. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData (found in in_memory_url_index_types.h).
2. Move most of the support types, including the new URLIndexPrivateData class, into in_memory_url_index_types.h. 
3. Correctly handle the adding and removing of page title words when a URL change is detected. 
4. Replace static class member functions with non-friend, non-class functions for better flexibility. 
5. Move convenience types out from InMemoryURLIndex class up into history namespace. 
6. Rename convenience types to generalize their intent. 

BUG=92718
TEST=Enhanced unit tests.
Review URL: http://codereview.chromium.org/8359019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107893 0039d316-1c4b-4281-b951-d872f2087c98

issued by a VeriSign intermediate CA.

Change the CertVerifier cache to identify a certificate chain by the
hash of the entire chain rather than just the server certificate.

This requires adding X509Certificate::chain_fingerprint(), and the
X509Certificate::CalculateChainFingerprint() method to compute the
chain fingerprint.

R=agl@chromium.org,rsleevi@chromium.org
BUG=101555
TEST=X509CertificateTest.ChainFingerprints and
CertVerifierTest.DifferentCACerts in net_unittests

Review URL: http://codereview.chromium.org/8400075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8418046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107887 0039d316-1c4b-4281-b951-d872f2087c98

This CL also tells all Chrome users who have SafeBrowsing turned on to
download this new whitelist.

BUG=
TEST=SafeBrowsingProtocolParsingTest


Review URL: http://codereview.chromium.org/8417040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8341137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107884 0039d316-1c4b-4281-b951-d872f2087c98

Before we were ending up with different preferences set in
different locations.

I'm not sure if this approach is right from the content-team's
point of view.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8403024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8399028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8403023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102134
TBR=hbono
TEST=TSan bots mostly green
Review URL: http://codereview.chromium.org/8341136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102255,102256,10227
TEST=Memory FYI waterfall is so much greener
TBR=hbono
Review URL: http://codereview.chromium.org/8416062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107876 0039d316-1c4b-4281-b951-d872f2087c98

Revert 107846 - Suppress failure for downloads.DownloadsTest.testPauseAndResume, as it is failing sporadically on pyauto win vista, and cause is not understood.

BUG=102228
Review URL: http://codereview.chromium.org/8413065

TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/8341134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/8400050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107867 0039d316-1c4b-4281-b951-d872f2087c98

As they are now virtual.

BUG=chromium-os:22197
TEST=chrome and tests build

Review URL: http://codereview.chromium.org/8400077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107866 0039d316-1c4b-4281-b951-d872f2087c98

These tests have been failing since crrev.com/107314 due to the hacky
workaround I added.

Along the way, rework other tests to use MockDBusThreadManager. These
weren't failing but using the mock would make the tests faster and more
reliable.

For signed_settings_unittest.cc to pass, add expectations for StorePolicy().
We didn't need this before, as we were using stub implementation that
always ran callback.Run(true), but we are now using mocks, so we should
add this behavior manually.

BUG=chromium-os:22183
TEST=Run UpdateScreenTest, NetworkScreenTest, ExistingUserControllerTest, SignedSettingsHelperTest with the debug build.

Review URL: http://codereview.chromium.org/8418037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107864 0039d316-1c4b-4281-b951-d872f2087c98

Expose the sandbox related code through the content API. I did a bit of cleanup while I was doing this.

-got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo
-got rid of the duplicated code to initialize the broker
-since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs.

BUG=98716
Review URL: http://codereview.chromium.org/8414020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107862 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7981004/

BUG=95714
TEST=base_unittests

Review URL: http://codereview.chromium.org/8418044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107861 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8418043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try, WebGL conformance tests

Review URL: http://codereview.chromium.org/8413053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107856 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=caseq
Review URL: http://codereview.chromium.org/8416059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107854 0039d316-1c4b-4281-b951-d872f2087c98

I thought we wouldn't need a mock for this, but I was wrong.
To properly fix crosbug.com/22183, we need to mock out DBusThreadManager.
As always, it's never too late to do the right thing.

BUG=chromium-os:22197
TEST=D-Bus functions work as before (brightness change keys work)

Review URL: http://codereview.chromium.org/8343069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107853 0039d316-1c4b-4281-b951-d872f2087c98

[ Re-land of 107815 ]
Review URL: http://codereview.chromium.org/8416055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=hans

Review URL: http://codereview.chromium.org/8413055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107851 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8392025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8395031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107849 0039d316-1c4b-4281-b951-d872f2087c98

Suppress failure for downloads.DownloadsTest.testPauseAndResume, as it is failing sporadically on pyauto win vista, and cause is not understood.

BUG=102228
Review URL: http://codereview.chromium.org/8413065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107846 0039d316-1c4b-4281-b951-d872f2087c98

Revert 107813 - add classes trace_analyzer::Query and TraceAnalyzer to make it easy to search through trace data.

This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code.

BUG=95714
TEST=base_unittests

Review URL: http://codereview.chromium.org/7981004

TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/8413063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101853
TEST=none
Review URL: http://codereview.chromium.org/8343048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107844 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman

Review URL: http://codereview.chromium.org/8400079

TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/8400081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107843 0039d316-1c4b-4281-b951-d872f2087c98

CL 8162015 failed the trybot and was reverted.
But I could not reproduce the issue in my local machine, so I just make a new CL and test it on trybot again.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8361031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107842 0039d316-1c4b-4281-b951-d872f2087c98

The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission.

BUG=101835
TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page.


Review URL: http://codereview.chromium.org/8399017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8351008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8353025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:101435
TEST=manual


Review URL: http://codereview.chromium.org/8413050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107838 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the bug where you're able to click on the wrench of panels whose originating extension has been unloaded, resulting in a crash.

BUG=101118
TEST=PanelBrowserTest.NonExtensionDomainPanelsCloseOnUninstall


Review URL: http://codereview.chromium.org/8387010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107837 0039d316-1c4b-4281-b951-d872f2087c98

Fix history importing by delaying DownloadManager creation. Replace GetNextIdThunkType with DownloadIdFactory (RefCountedThreadSafe, created by DownloadService).

DownloadService uses the same DownloadIdFactory for an OTR profile as its original profile.

DownloadService passes the DownloadIdFactory into the DownloadManager so that the DownloadManager can allocate new valid ids for items loaded from the history or downloads started on the ui thread.

Since the DownloadService precedes and outlives its DownloadManager, DownloadManager does not have a scoped_refptr<DownloadIdFactory>. Objects that do have a scoped_refptr<DownloadIdFactory>: DownloadService, ProfileIOData, ShellBrowserContext, ShellResourceContext.

The DownloadIdFactory must be RefCountedThreadSafe because ProfileIOData outlives Profile and because it's used in both the OTR and original profiles.

Longer term, the import process should strictly precede profile initialization, and the next_download_id counter should be loaded from the History db strictly before DownloadService is created and creates a DownloadIdFactory.

BUG=98966

Review URL: http://codereview.chromium.org/8401001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107836 0039d316-1c4b-4281-b951-d872f2087c98