- 11 Dec, 2018 40 commits
-
-
Friedrich Horschig [CET] authored
This reverts commit 3b3db143. Reason for revert: Strongest suspect for the last 40 failures of telemetry_perf_unittests and telemetry_unittests which failed being unable to find some shared libraries. Bug:913070 Original change's description: > Add RPATH to shared libraries > > Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so: > > $ ldd libfontconfig.so | grep freetype_harfbuzz > libfreetype_harfbuzz.so => not found > $ ls libfreetype_harfbuzz.so > libfreetype_harfbuzz.so > > R=thakis > > Bug: 911836,912366 > Change-Id: Ia0aaed8fc2c745b02cecf9ee3ce9888c1d8ccf77 > Reviewed-on: https://chromium-review.googlesource.com/c/1362457 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614255} TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911836, 912366 Change-Id: Ief4c7258208a2903bb06685d4edc76f482f7a0bf Reviewed-on: https://chromium-review.googlesource.com/c/1371385Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615492}
-
Friedrich Horschig [CET] authored
In addition to timeouts, the mentioned test shows gpu crashes. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913865, 900641 TBR=gogerald@chromium.org Change-Id: Id1d59744cbd3fb50df822789e1332d77d778756e Reviewed-on: https://chromium-review.googlesource.com/c/1371444 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
-
Thomas Tangl authored
All sync data type toggles are moved into one polymer element. Note: There is no structural change in this CL. In a follow-up CL the toggles are moved to a subpage which is accessible from the sync page. Bug: 912598 Change-Id: I7d07a7051d34840d94a1229c7dae92fa2c1e680c Reviewed-on: https://chromium-review.googlesource.com/c/1367648 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615490}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a0082b847f..bfb8c97cb567 git log 53a0082b847f..bfb8c97cb567 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 primiano@google.com Merge "Fix build using system clang." Created with: gclient setdep -r src/third_party/perfetto@bfb8c97cb567 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idece3bb67663352d473355928df1eb1f50745ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1371040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615489}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ca85e30..ff281cc4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I934f41f3d3db43dcf98058ca1e971b20a2a20505 Reviewed-on: https://chromium-review.googlesource.com/c/1370900Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615488}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a49242766a10..d86edb310a70 git log a49242766a10..d86edb310a70 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 brandon1.jones@intel.com Implement BufferCopyView.imageHeight Parameter Created with: gclient setdep -r src/third_party/dawn@d86edb310a70 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib46668179950f949baeb3af01a530df6669f9139 Reviewed-on: https://chromium-review.googlesource.com/c/1371042Reviewed-by:
-
Roberto Carrillo authored
This change adds a single fuzzer target to the continuous code coverage bot and the matching trybot. R=stgao,liaoyuke,jbudorick,mmoroz Change-Id: Iab4af3dbfcfbce608b42a3089913f30d6753382d Reviewed-on: https://chromium-review.googlesource.com/c/1364690 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615486}
-
Friedrich Horschig [CET] authored
This reverts commit 464fae69. Reason for revert: Causes heavy flakiness (14/17 on Mac 10.11) and attempted fix showed no effect: https://crrev.com/c/1369136 TBR=ccameron@chromium.org Bug: 902583 Original change's description: > RemoteMacViews: Fix hang at command-Q > > When we call -[NSApp terminate] in the app shim process, this does > not immediately terminate. Rather, it > 0. Sends the message appShimController_->host()->QuitApp() and waits > for a reply before actually terminating. > 1. In the browser, this call hits ExtensionAppShimHandler:: > CloseBrowsersForApp > 2. Which will end up calling NativeWidgetMac::Close > 3. Which will then politely request that the app shim process close > the corresponding window via > views_bridge_mac::mojom::BridgedNativeWidget::CloseWindow > 4. Which will send an ack back to the browser via > views_bridge_mac::mojom::BridgedNativeWidgetHost::OnWindowHasClosed > 5. Whereupon the browser window will be registered as closed, and a > close message will be sent to the app shim, and the wait for > termination will break > > This ends up not working at step 3. Our suspended terminate ends up > running a nested message loop inside a mojo message handler, and so > it will never execute the CloseWindow message, and therefore never > close. > > Change the logic at [0] to send the QuitApp message, and then > immediately terminate the application. > > Bug: 902583 > Change-Id: I60fd7b5fdf9f145369d06219e8ebef36cdcd0f44 > Reviewed-on: https://chromium-review.googlesource.com/c/1364220 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614922} TBR=ccameron@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902583 Change-Id: I34a3300dc188cdd0de58692042ce131a8639117f Reviewed-on: https://chromium-review.googlesource.com/c/1371475Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 154ccf48. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I33fe622c06b23e31831704dae9817fb2a54120ce Reviewed-on: https://chromium-review.googlesource.com/c/1370899Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615484}
-
Eric Seckler authored
Adds a new DataSource for the ARC++ system tracing agent. Each ArcTracingBridge registers with the data source and keeps track of its state, so that the data source can coordinate tracing between all the bridges. TBR=oysteine@google.com Test: Manually capture a trace with and without perfetto backend. Bug: 900603 Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3 Reviewed-on: https://chromium-review.googlesource.com/c/1360736Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#615483}
-
Elad Alon authored
Bug: 775415 Change-Id: I44d028c36558df47c0dd33cc853d4e50938c49bc Reviewed-on: https://chromium-review.googlesource.com/c/1370945Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#615482}
-
Edward Jung authored
Bug: 900536 Change-Id: Ia48b90e99c52cdb3ab35b952f8647007698048d8 Reviewed-on: https://chromium-review.googlesource.com/c/1370366Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#615481}
-
Yuki Shiino authored
Make IDL callback interface not hold a ScriptState of its creation context when it's cross origin from the incumbent realm. This is the same fix as https://crrev.com/c/1314023 for IDL callback interface. Bug: 886588, 883643 Change-Id: I38887c8d460d2b6879818bb31427f04a15dcf815 Reviewed-on: https://chromium-review.googlesource.com/c/1343816 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#615480}
-
Matt Falkenhagen authored
This adds a test that a stylesheet that failed to load is considered cross-origin. That is, accessing |styleSheet.rules| throws a SecurityError. This aligns with the specifications: - cssRules checks the `origin-clean` flag: https://drafts.csswg.org/cssom/#dom-cssstylesheet-cssrules - This is set to true iff CORS-same-origin: https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet - CORS-same-origin is false for "error" responses: https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-same-origin Bug: 911974 Change-Id: I558e6d3dfa564b15284c393ffc35b80f54a9bc4e Reviewed-on: https://chromium-review.googlesource.com/c/1371307 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615479}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b04ad33a6ff2..fabd12d5c959 Created with: gclient setdep -r src-internal@fabd12d5c959 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie3b83e657bf7f7fce7655cd2a4450b7a80e754cb Reviewed-on: https://chromium-review.googlesource.com/c/1371041Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615478}
-
Yi Su authored
This CL fixes a logic defect of a while-loop in the "isElementVisible_" function of find_in_page.js. This defect may cause a Js exception of trying to get "ownerDocument" property on "null". Bug: 912717 Change-Id: I32b39315983004b28fd6a2000b9ff7317225f8bf Reviewed-on: https://chromium-review.googlesource.com/c/1370173Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615477}
-
Yi Su authored
This CL removes the remaining comments about scrolling in find_in_page.js. Bug: 911780 Change-Id: Ie2ce2c4c45e2f829dba2338446943da63da13946 Reviewed-on: https://chromium-review.googlesource.com/c/1365896Reviewed-by:
-
Matt Falkenhagen authored
This adds tests that stylesheets that result from requests that were redirected cross-origin are considered cross-origin. Note that A->B->A redirects, which redirect from cross-origin to same-origin, are considered cross-origin. See https://github.com/whatwg/fetch/issues/737 and https://github.com/whatwg/fetch/pull/834. In Blink, we have redirect tests at http/tests/security/cannot-read-cssrules-redirect.html. This WPT addition will supersede that test, but I won't yet remove it since it asserts the opposite for the A->B->A case. I can remove the test when Blink changes to pass this WPT test. Bug: 911974 Change-Id: Ie015c0390829299de7c29cff6685ddfcd774c66f Reviewed-on: https://chromium-review.googlesource.com/c/1370162Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/264843e30745..9cabb4f98e99 git log 264843e30745..9cabb4f98e99 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@9cabb4f98e99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I2de3c5dc1c1a5b17947f8be476eac57818ee2d24 Reviewed-on: https://chromium-review.googlesource.com/c/1371256Reviewed-by:
-
Koji Ishii authored
This patch removes a comment in a test that is not needed. It was a left over in r615053 (CL:1366472). Bug: 904291 Change-Id: I785080fd401426261d6259c22f5f20059fdcba1f Reviewed-on: https://chromium-review.googlesource.com/c/1370148Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#615473}
-
Boris Sazonov authored
This CL addsSigninTestUtil.resetSigninState call to OAuth2TokenServiceIntegrationTest.tearDown, so all signin-related prefs are wiped and the state doesn't leak from the test. Bug: 908542 Change-Id: I43b37d76bd24e14687a4e9d0ab35d2e88d283f6f Reviewed-on: https://chromium-review.googlesource.com/c/1369940Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615472}
-
Gauthier Ambard authored
This CL increases the switch compression resistance priority to make sure that it doesn't get too compressed by the label. Bug: 912698 Change-Id: Ib8926b6fbcc60394506a9b348e9f79e4a11fae5d Reviewed-on: https://chromium-review.googlesource.com/c/1370274Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615471}
-
Tsuyoshi Horo authored
Currently if the default favicon request is caught by the testing service worker the test fails. This is causing the test flakiness. To fix this flakiness, this CL change the fetch event handler of the service worker to ignore the default favicon request. Bug: 912543 Change-Id: Icdddd902a4547361320f43db5b9090270ba74509 Reviewed-on: https://chromium-review.googlesource.com/c/1370160 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a7be9d55a9c..b04ad33a6ff2 Created with: gclient setdep -r src-internal@b04ad33a6ff2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I07ce2495c2f1f849b57cbc435a5a865bbd1522f6 Reviewed-on: https://chromium-review.googlesource.com/c/1371255Reviewed-by:
-
Leszek Swirski authored
There are some edge cases where IsLoaded is true but IsFinishedInternal is not (yet) true, so remove that check and expand the comment. Bug: 865098 Bug: 899217 Bug: 909858 Change-Id: I886df54c9a373e7431938aadd4a6a1a4d256d7dc Reviewed-on: https://chromium-review.googlesource.com/c/1369789Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#615468}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I74bc59cee5321321971257c15ddf89fe9773c1a9 Reviewed-on: https://chromium-review.googlesource.com/c/1371039Reviewed-by:
-
Gauthier Ambard authored
This CL changes the view displayed when the TabGrid is empty to add a scroll view. The scroll view allows the user to display the whole text even with large fonts. Bug: 896302 Change-Id: I94696f969aa1f7ae05be626bde2c10248f00b6df Reviewed-on: https://chromium-review.googlesource.com/c/1363281 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615466}
-
Friedrich Horschig [CET] authored
This reverts commit d080cfa6. Reason for revert: Suspected culprit for ExtensionApiTabTest.UpdateWindowResize failure on network_service_browser_tests (failing on chromium.mac/Mac10.12 Tests). Bug: 913848 Original change's description: > Move toolbar to new FlexLayout, demonstrating new layout manager. > > Vastly simplifies layout in the toolbar and makes it mostly declarative with a > single init function, rather than complex, bespoke - and sometimes incorrect - > Layout(), GetMinimumSize(), etc. methods. > > Because of a logical change in the way the UI works when an extension is > uninstalled, we uncovered a possible read-after-free in the extension install > UI (shows up in some ASAN tests). So we plumbed the scoped_refptr through from > crx_installer to the UI so that the memory would be valid until the bubble is > closed. > > See parent CL for FlexLayout details and future work. > > Bug: 898632 > Change-Id: I2cfe5b6119dc2886f88ae12675f8184cf90d56fd > Reviewed-on: https://chromium-review.googlesource.com/c/1331041 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615372} TBR=rdevlin.cronin@chromium.org,bsep@chromium.org,dfried@chromium.org Change-Id: Ie93f170c2c6048072820f2d6dc9950f75bc4aa94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898632 Reviewed-on: https://chromium-review.googlesource.com/c/1371384Reviewed-by:
-
David Jean authored
Bug: 886583 Change-Id: I107a11cdcd9d299533789cffed8c3446561f4968 Reviewed-on: https://chromium-review.googlesource.com/c/1365432Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#615464}
-
Takuto Ikuta authored
Bug: 576864 Change-Id: I3290cb0876f3ca84ec0efb13922b2756138b9492 Reviewed-on: https://chromium-review.googlesource.com/c/1369763Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615463}
-
Lei Zhang authored
Read and parse the plist, and tell Print Preview about the custom paper sizes. BUG=477699 Change-Id: Ia22e2d95e627d1796b1346ab6e3baeef89a9f2ae Reviewed-on: https://chromium-review.googlesource.com/c/1364228 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615462}
-
Marc Treib authored
The new test is similar to the existing PersonalDataManagerSanity test, but adds checks for the Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE histogram. Compared to PersonalDataManagerSanity, the new test skips the step of adding a duplicate profile, since that seems to produce flaky results. Bug: 904390 Change-Id: Ic85050dcab80e53ea1a5e1fa63f61db5e6c2cb09 Reviewed-on: https://chromium-review.googlesource.com/c/1369778Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#615461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae0d860ba31b..264843e30745 git log ae0d860ba31b..264843e30745 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@264843e30745 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ie41dd4f4977bf51bd0d31225f555d62f0a6dafde Reviewed-on: https://chromium-review.googlesource.com/c/1371252Reviewed-by:
-
Rob Buis authored
Openssl does not take --subj parameter, but -subj. Bug: 803774 Change-Id: Ie5e1da18941468fc66ea567134a49178b4260aba Reviewed-on: https://chromium-review.googlesource.com/c/1370177Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d31d9e9af460..8a7be9d55a9c Created with: gclient setdep -r src-internal@8a7be9d55a9c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iac716d778c5208ad7431b0daa4cdb1cde8f832fb Reviewed-on: https://chromium-review.googlesource.com/c/1371251Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 911415 Change-Id: I8f4a0e452bb508fa5ccb2c9f9701e1b9834b8b81 Reviewed-on: https://chromium-review.googlesource.com/c/1370163Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615457}
-
François Beaufort authored
Following Chris Palmer's email[1], this CL removes apacible from Picture-in-Picture related OWNERS as she is not actively working on Chromium. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZgEddsRE6do/UPcD-sptBgAJ Change-Id: I77f12a916c359c92dc329a5b59076983ecd86269 Reviewed-on: https://chromium-review.googlesource.com/c/1361729Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#615456}
-
Cathy Li authored
We limit the maximum number of rows shown by how many sites each category had to begin with (before any blacklisting occurs). Bug: 911362 Change-Id: I35ac39870422248ae830050bb6ccf4f405960f4d Reviewed-on: https://chromium-review.googlesource.com/c/1359694 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615455}
-
Reka Norman authored
This CL updates the FakePageHandler to use generated Mojo types. Bug: 906508 Change-Id: Ib04a9118e7ad7de6ac1aa9dfdf2d232c3280034a Reviewed-on: https://chromium-review.googlesource.com/c/1370232 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615454}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/768c73895b2f..bdff670a66b9 git log 768c73895b2f..bdff670a66b9 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 athilenius@google.com Added a find_project_path script, updated repo_manifest lib Created with: gclient setdep -r src/third_party/chromite@bdff670a66b9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0d317d3eb531673796b8aa47ed41a98b4c2e69ca Reviewed-on: https://chromium-review.googlesource.com/c/1371250Reviewed-by:
-
![Friedrich Horschig [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich Horschig [CET]")
