- 08 Jun, 2018 40 commits
-
-
Matt Falkenhagen authored
Bug: 848786 Change-Id: Ie53fbf644afdd76d7c65649a05c939c63d89b4ec Reviewed-on: https://chromium-review.googlesource.com/1088335Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565537}
-
Nigel Tao authored
It (chrome.fileManagerPrivate.installWebstoreItem) seems superseded by chrome.webstoreWidgetPrivate.installWebstoreItem (note the middle term changed from fMP to wWP), defined in ui/file_manager/externs/chrome_webstore_widget_private.js Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ca1049baef3a4cf7a66170092179bfef0af4c49 Reviewed-on: https://chromium-review.googlesource.com/1089593Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565536}
-
Yutaka Hirano authored
virtual/outofblink-cors/http/tests/xmlhttprequest/[workers/]upload-* crashes are fixed by https://crrev.com/a10c485c474fe0d212ed4d43ecc6f52712577823 . Bug: 836387 Change-Id: I179f52745effb1e66c5558f920bf08d71a4fca61 Reviewed-on: https://chromium-review.googlesource.com/1092213Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#565535}
-
Christopher Lam authored
This CL removes the old HistoryUI file and moves the icon retrieval functionality to the ChromeWebUIControllerFactory. Bug: 696821 Change-Id: I198c44bbfa86bd3b56cac01f3ecaa3f38254f285 Reviewed-on: https://chromium-review.googlesource.com/1069963Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#565534}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/531d6f8..81db3d6 git log 531d6f8..81db3d6 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 derat@chromium.org cbuildbot: Stop building Tast infra packages. Created with: gclient setdep -r src/third_party/chromite@81db3d6 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845289,chromium:782515 TBR=chrome-os-gardeners@chromium.org Change-Id: Ie76c8995b11c83dfb3a61c796437a7a8207d4c13 Reviewed-on: https://chromium-review.googlesource.com/1092046Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565533}
-
Darren Shen authored
Part of several patches to remove KeyboardController::container_. When we remove KeyboardController::container_, |GetContainerWindow| will no longer make sense, so we need to remove all of its callers. A lot of calls to GetContainerWindow merely use it to get the root window. We can simply add a new method on KeyboardController to get the root window and change callers to directly call that. Bug: 849980 Change-Id: I505a3a8d6483eabaa571c3d5bedf07dc0902c320 Reviewed-on: https://chromium-review.googlesource.com/1088359 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#565532}
-
Lei Zhang authored
This reverts commit 11732507. Reason for revert: New browser_test is failing on linux-chromeos-rel. Original change's description: > Display confirmation dialog before proceeding to Demo Mode Setup flow. > > The dialog is not styled yet. > UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHKwkUMyliQOe9oB6rGBuYSwMSJbxAVNpw > > Test: Run DemoSetupTest. > Bug: 827376 > Change-Id: I58a051e3b9149472ff616aca791e7d8798f9b9fa > Reviewed-on: https://chromium-review.googlesource.com/1087594 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565518} TBR=xiyuan@chromium.org,jcivelli@chromium.org,agawronska@chromium.org Change-Id: I51160678e1952a3fbb0e0f048c00e2eda5a9f2c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827376 Reviewed-on: https://chromium-review.googlesource.com/1092330Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565531}
-
Lei Zhang authored
This reverts commit 83dadc4b. Reason for revert: Broke Linux CFI bot https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8420 Original change's description: > Update fontconfig > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > and [4] to fix a bug and clean up some log spam. > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > dependency since we statically link fontconfig. > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..7ad010e80bdf8e41303e322882ece908f5e04c74 > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > > BUG=831146 > > Change-Id: I5b9ae95e4b0ab03735a9adc5582eabeb45241ce8 > Reviewed-on: https://chromium-review.googlesource.com/1009071 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565514} TBR=thestig@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org Change-Id: Ieffcdeaeea22e5617adeac593d3df1127e3d1062 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831146 Reviewed-on: https://chromium-review.googlesource.com/1091478Reviewed-by:
-
Lei Zhang authored
This reverts commit edff5481. Reason for revert: This CL depends on r565449, but FindIt reverted r565449 because it caused MSAN errors. So revert this CL as well. Original change's description: > Display Cutout: Add controller and factory to Android > > Add a DisplayCutoutController that will decide when > to adjust the layout based on the cutout. This depends > on Android P APIs which are called by reflection. > > BUG=838400 > > Change-Id: Iaf808709ded2f3c1b3d7a060942ea8c65396ad9f > Reviewed-on: https://chromium-review.googlesource.com/1043248 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565494} TBR=mlamouri@chromium.org,tedchoc@chromium.org,beccahughes@chromium.org Change-Id: If626817c04b52541d486881b207a259eabf433fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838400 Reviewed-on: https://chromium-review.googlesource.com/1092047Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1a057e..81970bc git log e1a057e..81970bc --date=short --no-merges --format='%ad %ae %s' 2018-06-08 jiawei.shao@intel.com Use ShaderMap in DynamicHLSL and StateManager11 - Part I Created with: gclient setdep -r src/third_party/angle@81970bc The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic8244fe2b0ee70fd7b8cda79ea3d441e93c20af0 Reviewed-on: https://chromium-review.googlesource.com/1092131Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565528}
-
Tatsuhisa Yamaguchi authored
"Saved" also appears as IDS_DATA_REDUCTION_BREAKDOWN_SAVED_TITLE in src/chrome/android/java/strings/android_chrome_strings.grd. It has caused that Gallery app say "amount reduced" in Japanese whereas it should say "storing done". After this change we can put separate translations for those two phrases. Bug: 850385 Change-Id: Ie8204c023df771fcf22dac2fb9e177408097e880 Reviewed-on: https://chromium-review.googlesource.com/1090518Reviewed-by:
-
Hiroshige Hayashizaki authored
These tests are slow just because they set a long timeouts. Bug: 626703 Change-Id: Ia02beac96bf163b30df5c77eb05ec1038a5b346e Reviewed-on: https://chromium-review.googlesource.com/1091655 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 82f18579. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 565449 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgyZjE4NTc5MmI2MmY2MThkYWM0NGViZTExYzNiZjZlYTRmYWE3ZWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7501 Sample Failed Step: content_browsertests Original change's description: > Display Cutout: Track ViewportFit in WCO > > Adds a DisplayCutoutHost mojo interface that is implemented > by WebContentsImpl. When ViewportFitChanged is called by > the renderer we fire the ViewportFitChanged method on > WCO. This allows the browser to change the UI based on > the ViewportFit state. > > On the Blink side changes to ViewportFit bubble up through > Document which will call the DisplayCutoutHost Mojo > interface. > > BUG=838400 > > Change-Id: I701f8c367167c5d630800f9d41004b88d95f63f3 > Reviewed-on: https://chromium-review.googlesource.com/1038786 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565449} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=838400 Change-Id: I58be29b1a136e195f01af31dee27a06a9a997341 Reviewed-on: https://chromium-review.googlesource.com/1092270 Cr-Commit-Position: refs/heads/master@{#565525}
-
Scott Chen authored
Bug: 837177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84600d1e162db6994e56c99297645393aeab43d8 Reviewed-on: https://chromium-review.googlesource.com/1091652 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#565524}
-
Mathieu Perreault authored
As per mocks and new style, should be Google Blue 600. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: Ib9ee2112eb0efac2bbbd816dc7c9bd6f53e82471 Reviewed-on: https://chromium-review.googlesource.com/1089577Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565523}
-
Scott Chen authored
Tests were still testing for paper-input, which is why the tests were failing. Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70abd95c2da6c54f46a522c039ed28fda0c3b67c Reviewed-on: https://chromium-review.googlesource.com/1089863 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efe4f89..8e6f58c git log efe4f89..8e6f58c --date=short --no-merges --format='%ad %ae %s' 2018-06-08 sdy@chromium.org Add an `--ignore-current` flag to `git cl owners` to start from scratch. Created with: gclient setdep -r src/third_party/depot_tools@8e6f58c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib7a29c82a4978bf01beb6b8bf8a8f05c5d77c9fe Reviewed-on: https://chromium-review.googlesource.com/1092130Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565521}
-
Pedro Amaral authored
The bottom toolbar will need to be shown before native libraries are loaded so we cache the toolbar flag. Bug: 850804 Change-Id: I4699207e5d14cbaa2787479dec86dda9b4a51e79 Reviewed-on: https://chromium-review.googlesource.com/1091918Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#565520}
-
Mathieu Perreault authored
Also, set the light grey in the Footer section as per mocks. Replaces hardcoded text color values with the GetColor API. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: I4850f65be55df0c4283e194866cfaa54da72fdd3 Reviewed-on: https://chromium-review.googlesource.com/1083015Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565519}
-
Aga Wronska authored
The dialog is not styled yet. UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHKwkUMyliQOe9oB6rGBuYSwMSJbxAVNpw Test: Run DemoSetupTest. Bug: 827376 Change-Id: I58a051e3b9149472ff616aca791e7d8798f9b9fa Reviewed-on: https://chromium-review.googlesource.com/1087594 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565518}
-
Kyle Horimoto authored
Bug: 824568, 752273 Change-Id: I7a58651e9a137ae0c35c7a8085d931ad3cf28647 Reviewed-on: https://chromium-review.googlesource.com/1092161Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565517}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71e9aae..fcf6e2b Created with: gclient setdep -r src-internal@fcf6e2b The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850461 TBR=mmoss@chromium.org Change-Id: I27fda7014f68ca6acbe681d7d67709c507bce096 Reviewed-on: https://chromium-review.googlesource.com/1091570Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565516}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/72a8685..09b82f4 git log 72a8685..09b82f4 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 benjhayden@chromium.org Plumb story tags through Telemetry Values. 2018-06-07 sadrul@chromium.org tabs: Ignore the duration for the new metric. Created with: gclient setdep -r src/third_party/catapult@09b82f4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363,chromium:849182 TBR=sullivan@chromium.org Change-Id: I025e96839825a8303a7108a11c23604b7fa3f6c3 Reviewed-on: https://chromium-review.googlesource.com/1091931Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565515}
-
Tom Anderson authored
Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, and [4] to fix a bug and clean up some log spam. Fontconfig also now requires libuuid as a dependency, so whitelist it as a dependency since we statically link fontconfig. [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..7ad010e80bdf8e41303e322882ece908f5e04c74 [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 BUG=831146 Change-Id: I5b9ae95e4b0ab03735a9adc5582eabeb45241ce8 Reviewed-on: https://chromium-review.googlesource.com/1009071 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#565514}
-
David Benjamin authored
This cuts down on many existing uses of RenderViewHost in tests. While there are still uses of RVH that are difficult to migrate, these are easy because every caller has a WebContents available (with one exception where I just called GetMainFrame.) Bug: none Change-Id: If4a9a6642c2fee3726fc5b86e82ad71a9a9ae182 Reviewed-on: https://chromium-review.googlesource.com/1078941 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565513}
-
Sadrul Habib Chowdhury authored
Make sure the OOPIF page receives its presentation feedbacks correctly. BUG=850561 Change-Id: I5570318bc40728a1995870eb19f8fd6050bf0c02 Reviewed-on: https://chromium-review.googlesource.com/1090999 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#565512}
-
Mina Almasry authored
This VLOG(2) should really be VLOG(3), as VLOG(2) is enabled by default for us and it's quite a lot of logs. BUG= b/109897412 TEST=None Change-Id: Ia5c132e7dabb584e51442d0234e1bf814c37ae76 Reviewed-on: https://chromium-review.googlesource.com/1092158Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#565511}
-
Rintaro Kuroiwa authored
- Add ID3D11BufferMock. - Add unit tests for the decryptor. Bug: 806018 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I179ec2f84b23811674551b027e1a8d6e20b46e7f Reviewed-on: https://chromium-review.googlesource.com/1069339 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565510}
-
Tetsui Ohkubo authored
This CL * Sets shorter strings to VPN, Cast, IME. * Adjusts feature pod button label styles. Now it's eliding. * Adjusts feature pod tooltip text. In non-English locale it wasn't shown properly (See the bug). This CL fixes the bug. Screenshot (English): http://screen/fNa2Hms3YNQ Screenshot (Japanese): http://screen/n4vAjjKaDJs Remaining feature pod buttons whose UI strings are still not given from UX: Network, Bluetooth, QuietMode, RotationLock, NightLight Also, in upcoming CLs FeaturePodContainerView will be adjusted further to make the labels better. TEST=manual BUG=849525 Change-Id: I843f1927ce735be7ae645f210750911f8bcca20d Reviewed-on: https://chromium-review.googlesource.com/1090527 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#565509}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5ebfd64..798b832 git log 5ebfd64..798b832 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 rharrison@chromium.org Add expectations for xfa_node_caption.pdf 2018-06-07 rharrison@chromium.org Convert resolve_nodes.pdf into 3 test cases 2018-06-07 hnakashima@chromium.org Rename CPDF_PageObjectHolder::GetFormDict() to GetDict(). 2018-06-07 tsepez@chromium.org Remove friending in CFXJSE_Context. 2018-06-07 hnakashima@chromium.org Return from GenerateContent() if m_pObjHolder->GetFormDict() is null. 2018-06-07 art-snake@yandex-team.ru Check is first page number valid in CPDF_LinearizedHeader. 2018-06-07 rharrison@chromium.org Revert "Reland "Simplify CPDF_HintsTable."" Created with: gclient setdep -r src/third_party/pdfium@798b832 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850407,chromium:850440 TBR=dsinclair@chromium.org Change-Id: I61a7c7d21e28d4051f9959e05eae18c7b3bf9b5a Reviewed-on: https://chromium-review.googlesource.com/1092050Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565508}
-
edchin authored
This CL enables the user to open all tabs in a remote session. Bug: 850240 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5add63048d9bbe93fb7d7e574d2f072f9f6e9a21 Reviewed-on: https://chromium-review.googlesource.com/1091874 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565507}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/faef514..9f752aa git log faef514..9f752aa --date=short --no-merges --format='%ad %ae %s' 2018-06-07 mtklein@chromium.org tweak SkArenaAlloc comments, parameter names 2018-06-07 caryclark@skia.org switch fiddle examples to call MakeFromTexture with RGBA 2018-06-07 brucewang@google.com SkFontMgr_DirectWrite::onMakeFromStreamArgs works on win 7 2018-06-07 mtklein@chromium.org remove unused stat tracking from SkArenaAlloc 2018-06-07 bungeman@google.com Defer Sample setup to onOnceBeforeDraw. 2018-06-07 egdaniel@google.com Revert "Require mips to be allocated at texture creation time and disable late allocations." 2018-06-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 0fdd840..1be9889 (1 commits) 2018-06-07 jvanverth@google.com Revert "Change persp dftext to only antialiased" 2018-06-07 bsalomon@google.com Remove GrGLSLFragProcs typedef. Use unique_ptr to for GrGLSLFragmentProcessor ownership. 2018-06-07 egdaniel@google.com Require mips to be allocated at texture creation time and disable late allocations. 2018-06-07 bungeman@google.com Add SkTypeface::makeClone. 2018-06-07 mtklein@chromium.org remove "srgb" config from DM,nanobench 2018-06-07 khushalsagar@chromium.org fonts: Hook up FallbackTextHelper to font remoting. 2018-06-07 egdaniel@google.com Add checks to make sure we don't overflow 32 bit int in GPU path renderers. 2018-06-07 jvanverth@google.com Change persp dftext to only antialiased 2018-06-07 egdaniel@google.com Add guard around GrVkBackendContext::Create function. 2018-06-07 robertphillips@google.com Remove unused GrObjectMemoryPool 2018-06-07 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2bd1fab..ea17575 (1 commits) 2018-06-07 mtklein@chromium.org require std::is_trivially_destructible 2018-06-07 brucewang@google.com Implement SkFontMgr_DirectWrite::onMakeFromStreamArgs function. Created with: gclient setdep -r src/third_party/skia@9f752aa The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:848716 TBR=halcanary@chromium.org Change-Id: I060ba6ef2896dfce86b931a3802da1cadac2758e Reviewed-on: https://chromium-review.googlesource.com/1091812Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565506}
-
Shinya Kawanaka authored
Due to disk shortage, building "all" bothers chrome infra folks. Let me change to build only "chrome" to reduce disk usage. Bug: 825536 Change-Id: I2bf10e0af4c176a9cf8aac574a70d3fa4a940082 Reviewed-on: https://chromium-review.googlesource.com/1089602Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#565505}
-
Dominik Behr authored
BUG=845650 TEST=install and run Chrome on daisy, minnie and kevin Signed-off-by:
Dominik Behr <dbehr@chromium.org> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5e51236142976ab572f40ec2321f880dd168c8af Reviewed-on: https://chromium-review.googlesource.com/1077378Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Commit-Queue: Stéphane Marchesin <marcheu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565504}
-
Bin Wu authored
Deprecate FLAGS_quic_reloadable_flag_quic_one_tlp. Merge internal change: 199053556 https://chromium-review.googlesource.com/c/1090401/ Initialize is_current_packet_connectivity_probing_ to avoid undefined reads. Merge internal change: 199003415 https://chromium-review.googlesource.com/c/1090400/ Deprecate FLAGS_quic_reloadable_flag_quic_unified_send_alarm. Merge internal change: 198779139 https://chromium-review.googlesource.com/c/1090399/ Fix a bug caused by peer sending a request and RST_STREAM in the same packet. Protected by FLAGS_quic_reloadable_flag_quic_deprecate_scoped_scheduler2. Merge internal change: 198720940 https://chromium-review.googlesource.com/c/1090398/ Deprecate FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender. Also make SentPacketManager::TimeUntilSend a const function. Merge internal change: 198617533 https://chromium-review.googlesource.com/c/1090397/ Output PCC DebugState also on packet sent, for PCC's monitor-interval-based trace analysis. (It will not influence other congestion control protocols.) Merge internal change: 198606967 https://chromium-review.googlesource.com/c/1090396/ Support framing/deframing of IETF QUIC Path Challenge/Response Frames n/a - code active only if QUIC Version 99 flag is set to true. This CL provides support to frame/deframe IETF QUIC path challenge and path response frames. Logic to request transmission of the frames, and handle them when received, will be added in a following CL.r Merge internal change: 198595417 https://chromium-review.googlesource.com/c/1090395/ Deprecate feature flag FLAGS_quic_reloadable_flag_quic_handle_write_results_for_connectivity_probe. Merge internal change: 198589773 https://chromium-review.googlesource.com/c/1090394/ Add support for IETF Quic Stop Sending frame. n/a code active only if version-99 flag set to true. This CL hooks up the framer/deframer for the IETF Quic Stop Sending frame. Higher level logic is needed to cause these frames to be generated under the correct circumstances, and to be handled when received. Merge internal change: 198557228 https://chromium-review.googlesource.com/c/1090393/ Add framer support for the IETF Quic NEW CONNECTION ID frame. N/A this code is enabled only if QUIC Version 99 is enabled. This CL adds support to the IETF Framer/Deframer for the New Connection ID frame. Higher-level code (to cause such a frame to be generated or handle one correctly on reception) will be done in a later CL.r Merge internal change: 198547423 https://chromium-review.googlesource.com/c/1090392/ Add IETF MAX STREAM ID and STREAM ID BLOCKED frames N/A -- code is version-99, protected by the version-99 flag. This CL adds support to the framer so that the frames can be generated if requested and parsed if received. Higher-level support (i.e., the logic to decide when to request generation of these frames or to perform appropriate actions upon reception) is not provided in this CL. It will be in a follow-on CL. Merge internal change: 198543131 https://chromium-review.googlesource.com/c/1090391/ In QUIC, remove connection_rejected_statelessly from QuicTimeWaitList::AddConnectionIdToTimeWait. No functional change expected, not protected. Merge internal change: 198456330 https://chromium-review.googlesource.com/c/1089391/ Support IETF APPLICATION CLOSE frame for version 99 Add APPLICATION CLOSE framer, deframer, tests, and so on, so that QUIC running as version-99 can generate and receive these frames. This CL DOES NOT include the necessary API for applications using QUIC to generate APPLICATION CLOSEs N/A Code is under control of the version-99 flag Merge internal change: 198446282 https://chromium-review.googlesource.com/c/1089390/ Add IETF BLOCKED and STREAM BLOCKED frames N/A Code functional only if version 99 flag enabled This code executed only if version 99 is active. Version 99 is flag protected/disabled. Merge internal change: 198429591 https://chromium-review.googlesource.com/c/1089147/ Add IETF MAX DATA/MAX STREAM DATA frames N/A code protected by version-99 flag, not active unless version-99 enabled Merge internal change: 198424176 https://chromium-review.googlesource.com/c/1089146/ R=zhongyi@chromium.org Change-Id: Iec9de0857510f101c46a184661ff110ef1c149cf Reviewed-on: https://chromium-review.googlesource.com/1090403Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#565503}
-
Kyle Horimoto authored
The "destructor_callback" parameter now takes the DeviceIdPair corresponding to the deleted object. Bug: 824568, 752273 Change-Id: I57b9b70bd47a736d01f09802d38a1a9aefc7c604 Reviewed-on: https://chromium-review.googlesource.com/1092034Reviewed-by:
-
Martin Kreichgauer authored
Bug: 850461 Change-Id: I30d871ce3740e1e7365bb74b0d08f46b93981772 Reviewed-on: https://chromium-review.googlesource.com/1091955Reviewed-by:
-
Chris Hamilton authored
This encapsulates policy logic for the upcoming session restore refinements and the related experiments. BUG=749785 Change-Id: Ib9b26363b85d3082fd27dec6db78679a23e919a8 Reviewed-on: https://chromium-review.googlesource.com/1091239 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#565500}
-
Peng Huang authored
With SkDDL and SkiaOutputSurface, we are using a real GL context on the GPU thread to draw SkDDL recorded on the compositor thread, Consequently, the ContextProvider for compositor thread is not useful anymore, so remove it. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4691ff2dc74bc0a9d3dbcbb0be619711b727aa6d Reviewed-on: https://chromium-review.googlesource.com/1050476 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#565499}
-
Dominik Röttsches authored
For doing correct emoji segmentation for Emoji contained in Unicode 11, update our emoji data to v11 [1] until we upgrade to ICU 62. The SymbolsIterator test extracts all new sequences from https://unicode.org/emoji/charts/emoji-released.html and makes a single emoji sequence out of those. The test passes if the whole run has emoji presentation. [1] https://unicode.org/Public/emoji//11.0/emoji-data.txt Test: SymbolsIteratorTest.Emoji11Additions, CharacterTest, EmojificationV11 Bug: 850336 Change-Id: I72768a20e6dcc78bdaca67224c93e677c9ac5b70 Reviewed-on: https://chromium-review.googlesource.com/1091301 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565498}
-
