- 23 Dec, 2020 40 commits
-
-
Roman Sorokin authored
Update screen was renamed in http://crrev.com/c/2230462 in M85. If device updates from <85 to >=85 version - pending update screen (from local state) is not recognized. This makes Chromebooks start from the welcome screen again. Chromebases, Chromeboxes and Chromebits might actually suffer from the white screen on M85 and M86. Users can't bypass the screen and have to recover devices. This CL handle this rename gracefully. Fixed: 1160383 Change-Id: I1bc529791ef3072ce397cb85640416117ac85a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600910Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839152}
-
Stephen McGruer authored
This is a manual copy of an automated import, with the tools/ changed backed out due to bug 1161210. Using wpt-import in Chromium 18a0e912. With Chromium commits locally applied on WPT: fda9a53d "Replace 'dummy' with 'sample' for inclusive language" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm bokan@chromium.org: external/wpt/scroll-to-text-fragment domenic@chromium.org, hiroshige@chromium.org: external/wpt/import-maps finnur@chromium.org, peter@chromium.org, rayankans@chromium.org: external/wpt/contacts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools garykac@chromium.org, joedow@chromium.org: external/wpt/keyboard-lock jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mkwst@chromium.org: external/wpt/cookies external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mlamouri@chromium.org: external/wpt/mediasession npm@chromium.org: external/wpt/event-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true Bug: 1161210 No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ie906ab1bc036ea00b82032b377823dda97134bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601738 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839151}
-
Ahmed Fakhry authored
Since we can't have more than one recording at a time, we should disabled the video recording toggle button when the capture mode session starts while recording is in progress. BUG=1160343 TEST=Manually, added a new test. Change-Id: Ib6b169c584b1fdf84926995a94fa07000be66c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601856Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#839150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65b4827f1679..33c64a447368 2020-12-23 brianosman@google.com SkSL: Remove "null" as a type and literal value. 2020-12-23 brianosman@google.com Remove use of uint from particle random system 2020-12-23 bsalomon@google.com Remove public getter for GrSurfaceDrawContext on SkSCanvas. 2020-12-23 reed@google.com Bitmap.asImage() 2020-12-23 brianosman@google.com SkSL: Remove $gvec and $gfloatN types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Iaef13c9350bca3d8ece02c8de0346f7d8c4edff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839149}
-
Mason Freed authored
This is a reland of dbfed21f --> Patchset 2 contains the fix, just a missing initializer on an int in the test. Original change's description: > Fix several crashes when nested slots are removed from a ShadowRoot > > There were some crashes caused by nested slots (e.g. > <slot><slot>Content</slot></slot>) being removed from the tree. > These crashes were triggered by [1], which removed Shadow DOM v0, but > my theory is that due to the old V0 shadow root code, more calls were > being made to SlotAssignment::RecalcAssignment(). Now that the V0 code > is gone, it has exposed some missing code. > > Three issues are being fixed here: > 1. In Node::CheckSlotChange(), while removing the inner nested slot, > the parent_slot will have already been removed from the tree, so we > only need to call DidSlotChange if not. This used to be a DCHECK. > 2. In TreeOrderedMap::Get(), while removing a key that previously had > more than one element, we may walk the tree and find that none of > the pre-existing elements are present. I.e. we're in a RemoveScope. > In this case, the key should be removed from the map. > 3. In SlotAssignment::DidRemoveSlotInternal(), given #2 above, we can > just early-out if the slot isn't present in the map. > > I added a test for the crash conditions (variations on removing nested > named and unnamed slots), plus I added a test for the TreeOrderedMap > class, since there was none previously. The last test in the set > documents the new Get() behavior. I also tried to improve some of the > comments along the way. Finally, this CL rolls back a mitigation [2] > previously landed for this crash. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 > > Bug: 1159328, 1159727 > Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838974} Bug: 1159328 Bug: 1159727 Change-Id: I0025c0f00d6b3876de8f40a60fdc34f726ddc85c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601051 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839148}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie537aafacdd96fed47b0464c404df597a54aa5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602063Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8986f3ce67ec..61cbb8911dcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iee57e37b1c631564bfea628fa126478496279820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602223Reviewed-by:
-
Sujie Zhu authored
Clean up nicknameManagementEnabled flag and remove the legacy elements and CSS config. Local build test video after clean up(googlers only): https://drive.google.com/file/d/1uYmVuIjlThiGl-TTeGvPrZWvDtkBJwKJ/view?usp=sharing&resourcekey=0-hMW3nVLEyQ7fbLzV5RHwqg Bug: 1082013 Change-Id: Ie5ba1372cf510decb17a113c67ed5aee11eeb755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600180 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#839145}
-
Lily Chen authored
Gitiles doesn't display <pre> blocks, so switch to triple-backticks. Change-Id: Ie66c3a6633ba0f53e9e3d36c9fab2c7021232cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602357 Auto-Submit: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#839144}
-
manukh authored
Background: Rich autocompletion adds the |omnibox_additional_text_view_| label adjacent to the |omnibox_view_| in the LocationBarView. When the |omnibox_view_| displays a suggestion's contents, the label (if visible) displays its description and vice versa. The LocationBarView directs mouse button events from |omnibox_additional_text_view_| to |omnibox_view_| so that, e.g., clicking the former will focus the latter. This CL: Drag MouseEvent's have a location relative to the target view. This CL makes locationBarView adjust the drag event's location relative to the |omnibox_view_|'s origin before redirecting them. Otherwise, the event location would be incorrectly offset by about 40 px and the text selection would trail to the right of the mouse cursor when selection began on the LocationBarView. Bug: 1158649, 1062446 Change-Id: Iadbb3bc0a5742f6e5031a44175036991a55bd6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601160Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#839143}
-
Yue Zhang authored
This CL extends the functionality of ProfileProtoDB by adding functions to load one entry, load all entries and delete one entry in the DB. These will be used by database for ChromeCart. Bug: 1157892 Change-Id: Ifaf2dd049ba1a434da7e52c65987050126e30ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594440Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#839142}
-
David Tseng authored
R=dmazzoni@chromium.org, josiahk@chromium.org AX-Relnotes: n/a Test: existing browser_tests Change-Id: Ifc2b85ac0903903f8cc526e4a2154121da8346f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602108Reviewed-by:
Josiah Krutz <josiahk@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839141}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61cbb8911dcc..815ee4029d9e 2020-12-23 treehugger-gerrit@google.com Merge "Open file with CLOEXEC in deobfuscator." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9239885f98dd27d17430d95b2df703800c192e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602068Reviewed-by:
-
Krystal Loh authored
The new roughness and freezing metrics require longer playback stories. The memoryMetric is not measured for these stories. Add measure_memory parameter to allow this to be changed per story instead of needing a new subclass of _MediaPage. Reformat code per presubmit checks. Change-Id: Ia81aaa6a372596b2a27e181413035fe16c4129d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594169Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Krystal Loh <kxloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#839139}
-
Peng Huang authored
Suppose VulkanSwapChain::PostSubBuffer() and VulkanSwapChain::PostSubBufferAsync() should not be called, if previous call is pending. However we got some crash reports during shutdown, seems they are called with pending PostSubBuffer(). To fix the problem, we will always call WaitUntilPostSubBufferAsyncFinished() to make sure previous request is finished. Bug: 1155507 Change-Id: Id2456ea160c0fe0ebefabedbe2d7e915f5c97a34 Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-p-pixel-2-skv-32,gpu-fyi-try-linux-intel-skv,gpu-fyi-try-linux-nvidia-skv Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601229Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839138}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61a71c992a5a..6bf67526ef67 2020-12-23 bmeurer@chromium.org Fix Wasm location display in the Breakpoints sidebar. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3c1a60673a34a59ff45b01761efea9a0878ae215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602064Reviewed-by:
-
Danan S authored
This method will be called by the EDU Coexistence guest flow to help determine whether or not it should prompt the child's parent for permission before allowing them to add a secondary EDU account. The time delta itself is derived from the kOobeOnboardingTime user pref and the current time. Also added a test suite for EduCoexistenceController to test this functionality that can be extended to support more tests for EduCoexistenceController. Lastly, added several standard JS primitive return types to the closure signature for PostMessageAPI method implementations, which is needed to make this CL pass closure compile type checks. Bug: 1160024 Change-Id: Ie05f4bccc2db0e3127472937eed51551e864e575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596255Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839136}
-
Sophie Chang authored
Bug: 1158343,1151087 Change-Id: Icb9c055daafe808f727bc7cbd372336c37bdccf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601637Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839135}
-
Regan Hsu authored
Uses the SyncService to refresh the syncer::SESSIONS sync type. This updates the browser tabs model almost immediately instead of waiting for the server to lazily update the existing subscription. Bug: 1158480, 1106937 Change-Id: I75412b2bff0bf23e76ba7a2903d2a851680dd76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600447 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#839134}
-
Chris Thompson authored
This replaces the use of multiple EmbeddedTestServer instances with reused ports (which can be flaky if the ports become unavailable) with URLLoaderInterceptor which can simulate the legacy TLS and modern TLS connections for the same server/cert. Bug: 1150403,1153702 Change-Id: I909199c91c030648d5e81c32d2a880ca6b8a32c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601716 Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#839133}
-
Yue Zhang authored
This CL adds the header chip for chrome cart module with message "New". Right now the chip is always showing for cart modules and the visibility will later be controlled by the mojo interface. Screenshot: https://drive.google.com/file/d/18L4Q5KtyylqM7VYIjrKlA20hq4al9MI5/view?usp=sharing&resourcekey=0-Z4OayexAew1KS34UMnMeXw Bug: 1152213 Change-Id: I3a291c64c99dcdab49de2ac250f0c550d756dd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597235 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#839132}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012230600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/MIvUdF0qcP07nO7qcpskiwhrIY76sEXm3cja55KTAs4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/174714837 Tbr: help-app@grotations.appspotmail.com Change-Id: I08459b6ec8ee6d3de4ebded0e4c468aae2de0cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602237Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839131}
-
Ella Ge authored
Bug: 1152282 Change-Id: I1cecfcf7a516e97209fa8edd415be134dab2e0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601064Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839130}
-
David Maunder authored
It was found that after deserialization, fields in ShoppingPersistedTabData were set to their default values, despite the deseralization being performed correctly. I believe the reason is fields in the child can't be set in the parent constructor (although interestingly the same thing didn't happen in CriticalPersistedTabData). The problem can be solved in ShoppingPersistedTabData by deserializing in the child - not the parent. I wrote an identical unit test for CriticalPersistedTabData to guard against this popping up in the future. Bug: 1160316 Change-Id: Id7d2d257448b975fd2780ae61a19d311892ecb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598656 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8986f3ce67ec..61cbb8911dcc 2020-12-23 fmayer@google.com Fix parameters to HeapInfo_setDisabledCallback. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7b21c09343e356562a65ccfb6de846ed7944e2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602065Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0d5f1dd37c05..768022b98e45 2020-12-23 qignacio@amazon.com meson.build (ft2_defines): Fix builds on Windows. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4acbf9d1cdd6935997ea64ecefb91b97854e354a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602097Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
If the omnibox is editing when an incognito goes background, the blocker should not allow for keyboard input. Bug: 1160681 Change-Id: I55f4fa10a4ea97af01e4a96afe9d999d4a0d4cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600906 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#839126}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4121a1f12b0e..d75fb83845d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mohsen@google.com,vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mohsen@google.com,vasilii@google.com Change-Id: I8de120f731f9fa7ee4eebe824336c16860963b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602238Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4e0e8d4124f5..65b4827f1679 2020-12-23 johnstiles@google.com Code cleanup: Replace .foreach() loops with regular for loops. 2020-12-23 bsalomon@google.com Remove pixel write/read tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Iff8d9b46feed8a9eaea1d94cdfc915ec2926543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602060Reviewed-by:
-
Arthur Hemery authored
This patch is preparatory to moving some of the elements of the ClientSecurityState to the PolicyContainer. Instead of having a stored ClientSecurityState, we build it on demand with the different elements stored individually in the RenderFrameHostImpl. This also clarifies the COEP state that was previously duplicated. Bug: 1154729 Change-Id: Ic500dc9470afd2373ef3ac7b91cb2d48adff1f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587041Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#839123}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d85112ea99c6..a281380c8e26 2020-12-23 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-23 vapier@chromium.org Merge remote-tracking branch 'cros/main' into master 2020-12-23 jackneus@google.com Add --dest-bucket to chromite/scripts/pushimage.py 2020-12-23 lamontjones@chromium.org config: disable all hardware tests on eve 2020-12-22 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-22 engeg@google.com chromiumos-sdk & informational config: switch to main branch 2020-12-22 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-22 jackneus@google.com Build API: Recompile protos If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia1ba892e014318a32cc62d81aadce5e14e8ea864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602061Reviewed-by:
-
Mustaq Ahmed authored
This removes an old TODO to make the name consistent. Change-Id: I42e3c441fd1be76ae7a0c90ac75156b787ad7bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600020Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#839121}
-
David Bokan authored
These callbacks are only called from PostDelayedTask which calls them once. They're always reset to a new callback before posting a new task. Bug: 1152268 Change-Id: I5a04f6227d963982ad2f368eb9d9591668e49f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600031Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839120}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012230600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/lSR2dtMxiibk0G8cpsbKHgxUhPJId7kspY1yn5iOeZEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I2fb1f07a49b1611a8e503ceb452bdd089cf32e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602236Reviewed-by:
-
David Black authored
Section animations are disabled on initialization as holding space child bubbles will be animated in with their contents already loaded. Note that the child bubble animation has not yet been implemented. Also note that this CL also moves animation logic from HoldingSpaceItemView into HoldingSpaceItemViewsSection since a refactor has given that class visibility to the parent container of item views. Bug: 1154998 Change-Id: I32e311f8193da87b5f42e2b4a3941a22bc8a1d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599447 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839118}
-
David Bokan authored
There are two methods in this class taking a callback. - StartQueryInfo stores the callback in a queue and then calls them when a system query is done. The callbacks are always cleared after calling so these can be made OnceCallback. - InitializeProvider simply calls the given Closure and the only override in StorageInfoProvider passes it to StorageMonitor::EnsureInitialized which takes it as a OnceClosure so this is also safe to make OnceClosure. And we remove GetStorageFreeSpaceCallback since it's no longer used anywhere. Bug: 1152268 Change-Id: Ifa05987ef60c57046df4f1ee4753957a061e0edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597575Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c90fb9c33106..61a71c992a5a 2020-12-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I019fc2191913d22429398a920138a04396f94d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602058Reviewed-by:
-
adamta authored
Uses Discover feed scroll view to add overscroll menu to refactored NTP. Bug: 1114792 Change-Id: I272d50d6fc80dd50d29a973e6f5682cacc80e886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595615Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#839115}
-
Ella Ge authored
update_state_closure_ and connecting_closure_ Bug: 1152282 Change-Id: Ieef31517ef556e02b016fdbaaaf4436e87d77bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600379Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839114}
-
Sergey Ulanov authored
Previously --enable-scaling-clipped-images switch wasn't applied properly: It was used in GpuImageDecodeCache::IsCompatible(), but not in GpuImageDecodeCache::CreateImageData(). Bug: 1157548 Change-Id: I801e5237042d0ebbc8dc115c0e88f5da9dc5a9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599924 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839113}
-
