GitLab

TBR=dsinclair

Review URL: https://codereview.chromium.org/162883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251036 0039d316-1c4b-4281-b951-d872f2087c98

The trick is to leave action, username_element and password_element
fields of the form empty, this will stop the browser from autofilling
every form on the page with the credentials and will require user
interaction.
The user will have to click on the input box, select his login from
the drop down and click 'submit'. When this happens, Login Data will
be updated with the action url of the particular form.

Basically, since we don't know which form on the page is the one we 
have imported credentials for, we don't autofill anything until the 
user tells us. We'll remember his choice afterwards.

BUG=52513

Review URL: https://codereview.chromium.org/153043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331302
R=marja@chromium.org

Review URL: https://codereview.chromium.org/163073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251034 0039d316-1c4b-4281-b951-d872f2087c98

When smartcard auth is disabled we need to wipe the store and any open
sockets. By issuing a NULL cert being added this happens.

BUG=341500

Review URL: https://codereview.chromium.org/161653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251033 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329604

Review URL: https://codereview.chromium.org/162723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341224

Review URL: https://codereview.chromium.org/145813010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251031 0039d316-1c4b-4281-b951-d872f2087c98

Mavericks introduced [NSView setCanDrawSubviewsIntoLayer:] which I
suspect has changed some of the animation compositing pipeline.
Recently, the app launcher has been "tearing" the canvas while dragging
items around quickly.

This change ensures that the common ancestor view of the
NSCollectionView and the transitive layer used for custom drag
animations is layer-backed. This prevents the tearing.

BUG=341769
TEST=Drag items around the OSX app lanucher quickly - icons should
animate smoothly, without tearing.

Review URL: https://codereview.chromium.org/159573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251030 0039d316-1c4b-4281-b951-d872f2087c98

NativeAppWindowViews has Windows-specific code in #ifdefs. Move this
into derived class NativeAppWindowViewsWin.

BUG=None

Review URL: https://codereview.chromium.org/161753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251029 0039d316-1c4b-4281-b951-d872f2087c98

Applies the same renaming as http://crrev.com/142523003 and also removes obsolete methods.

Renamed methods:
- DeriveFont(size_delta, style) => Derive(size_delta, style)

Removed methods:
- DeriveFont(size_delta)
- GetAverageCharacterWidth()
  # Use GetExpectedTextWidth(1) instead.
- GetStringWidth(text)
  # Use gfx::GetStringWidth(text, font_list) instead.

BUG=265485
TEST=Run ui_unittests, views_unittests.

Review URL: https://codereview.chromium.org/138013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251028 0039d316-1c4b-4281-b951-d872f2087c98

Adding an Android repo manifest which will be used in the Android plus
ToT Chromium build setup.

BUG=None
TEST=None
NOTRY=true

Review URL: https://codereview.chromium.org/160553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251027 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251026 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167047:167065&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/162713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251025 0039d316-1c4b-4281-b951-d872f2087c98

TBR=willchan@chromium.org
BUG=341211

Review URL: https://codereview.chromium.org/143003031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251024 0039d316-1c4b-4281-b951-d872f2087c98

WebKitTestController::TimeoutHandler doesn't seem to be used anywhere.

Review URL: https://codereview.chromium.org/162903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251023 0039d316-1c4b-4281-b951-d872f2087c98

Fix mistake introduced in r247334. Webview needs more tests.

BUG=

Review URL: https://codereview.chromium.org/162523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251022 0039d316-1c4b-4281-b951-d872f2087c98

Added corresponding protocol buffer definitions for raw events, but in aggregated format.
Added EncodingEventSubscriber:
- encodes events in protocol buffer format
- (we need to test how much aggregation helps with reducing the size, if at all)
Added unit tests.

TODO in the future CLs: add event filtering, size-based windowing

Review URL: https://codereview.chromium.org/138913014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251021 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=341329

Review URL: https://codereview.chromium.org/162033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343049
R=msw@chromium.org

Review URL: https://codereview.chromium.org/152843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251019 0039d316-1c4b-4281-b951-d872f2087c98

Remove the unified IO code on the browser.

Unified IO is not used any more and it should be removed.

TBR=dalecurtis@chromium.org
BUG=337096
TEST=bots, and nothing breaks.

Review URL: https://codereview.chromium.org/163343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251018 0039d316-1c4b-4281-b951-d872f2087c98

RWHVA needs to deregister itself properly as an observer of
CompositorVSyncManager even if the compositor itself is destroyed.  Do this
properly by keeping a reference to the CompositorVSyncManager.

BUG=343199
TEST=local build, run on desktop Linux, Win7

Review URL: https://codereview.chromium.org/152983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251017 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=343565

Review URL: https://codereview.chromium.org/163783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251016 0039d316-1c4b-4281-b951-d872f2087c98

On swapping in a prerendered WebContents a new ContentViewCore is created with zero size. When showing the view with onShow(), a resize event is generated, causing Blink to relayout with zero size. This change workaround it by setting the view size in advance.

BUG=340987

Review URL: https://codereview.chromium.org/159853008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251015 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces separate ExtensionSystemFactories for app shell and for chrome; in particular, a new ShellExtensionSystemFactory. ExtensionsBrowserClient now selects between the two at the factory level. Callers can simply use ExtensionSystem::Get.

BUG=337707

Review URL: https://codereview.chromium.org/137753016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251014 0039d316-1c4b-4281-b951-d872f2087c98

For the detail, refer the associated bug tracker. In short,
I want to do this for implementing decision procedure for whether
or not to mount zip archives based on originating profiles.

Besides, I believe the new code is more clean--the old code that
constructs the volume list every time FindVolumeById called is skewed.

BUG=343038

Review URL: https://codereview.chromium.org/160483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251013 0039d316-1c4b-4281-b951-d872f2087c98

(SharedWorkerServiceImpl)

These class will be used when "enable-embedded-shared-worker" is set.

BUG=327256

Review URL: https://codereview.chromium.org/140333011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251012 0039d316-1c4b-4281-b951-d872f2087c98

Do some lint cleanups too.

Review URL: https://codereview.chromium.org/156703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251011 0039d316-1c4b-4281-b951-d872f2087c98

Allow a bit of wiggle room in highlight's bounding box. This should help reduce the noise on speed index. Previously, we were searching through the frames for when the orange highlight disappears, but with compression artifacts we might see a slight variations in each frame's highlight bounding box.


BUG=

Review URL: https://codereview.chromium.org/152643010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251010 0039d316-1c4b-4281-b951-d872f2087c98

Adds InstantExtendedEnabledParam('&espv') to the search request URL iff the query extraction flag is enabled in field trials.
- When the query extraction is turned off, InstantExtended UI is not enabled in search results page. Therefore, InstantExtendedEnabledParam is unused.
- InstantExtendedEnabledParam() need not be a part of SearchTermsData. Therefore, moved InstantExtendedEnabledParam() from SearchTermsData to search.cc.
- Added unit tests.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/151813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251009 0039d316-1c4b-4281-b951-d872f2087c98

This was broken by my recent forwarder refactor.

BUG=
Notry=true

Review URL: https://codereview.chromium.org/162433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251008 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251007 0039d316-1c4b-4281-b951-d872f2087c98

Add mvrable to activity_log OWNERS files, and add a note saying to only ask mpcomplete for review if felt and mvrable can't be reached.

BUG=none

Review URL: https://codereview.chromium.org/148003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251006 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/162703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251005 0039d316-1c4b-4281-b951-d872f2087c98

Add the following new histograms:

  Power.ShutdownReason
  Power.SuspendAttemptsBeforeCancel
  Power.SuspendAttemptsBeforeSuccess

Also deprecate Power.RetrySuspendCount, which was both
poorly-defined and broken.

BUG=337508

Review URL: https://codereview.chromium.org/161103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251004 0039d316-1c4b-4281-b951-d872f2087c98

> Exclude notification strings for builds that dont use it.
> 
> BUG=326023
> 
> Review URL: https://codereview.chromium.org/160113002

Broke win64 sync tests, e.g. output:

c:\b\build\slave\cr-win-rel-x64\build\src\chrome\browser\sync\test\integration\sync_test.cc(707): error: Value of: UTF16ToASCII(browser()->tab_strip_model()->GetActiveWebContents()-> GetTitle())
  Actual: ""
Expected: "Notifications enabled"

TBR=aurimas@chromium.org

Review URL: https://codereview.chromium.org/163713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/157383010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251002 0039d316-1c4b-4281-b951-d872f2087c98

UdpTransport is used by cast sender and receiver. When used in the cast
sender a bind cannot be done. So UdpTransport should use UdpSocket
and perform bind or connect based on the value of remote and local
address.

Tested this with cast_sender_app and cast_receiver_app.

Review URL: https://codereview.chromium.org/161913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251001 0039d316-1c4b-4281-b951-d872f2087c98

This API allows pp::Resource objects to be read and written to pp::Vars.

Moved the methods of PPB_VarResource_Dev (C API) to PPB_Var version 1.2.
Moved the methods of pp::VarResource_Dev (C++ API) to pp::Var.

Code written against the dev API will no longer compile, as references
to the API need to be updated to use Var instead of VarResource_Dev.
Binaries compiled against the dev API will now experience run-time
errors loading the old interface.

BUG=177017

Review URL: https://codereview.chromium.org/148213016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251000 0039d316-1c4b-4281-b951-d872f2087c98

Access now happens through the PasswordManagerDriver or PasswordManagerDelegate.

BUG=334670,335107

Review URL: https://codereview.chromium.org/152133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340957
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/163703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250998 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250997 0039d316-1c4b-4281-b951-d872f2087c98