GitLab

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.*

Review URL: http://codereview.chromium.org/3190010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56965 0039d316-1c4b-4281-b951-d872f2087c98

may be called from within one of the notifications
of "backend construction done". This CL makes sure
that this scenario is handled properly by invoking
the callbacks one at a time, posting a task before
moving on to the next one.

BUG=52090
TEST=netunittests

Review URL: http://codereview.chromium.org/3173030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56964 0039d316-1c4b-4281-b951-d872f2087c98

the test shows up as succeeded even though it is failing.

The test fails when the automation client instance is reused, i.e the new page loads in
the same tab. We need to set the ready state of the active document instance to ready
when we reuse the automation client instance.

TBR=amit

Review URL: http://codereview.chromium.org/3117032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56963 0039d316-1c4b-4281-b951-d872f2087c98

Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3138006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52826
TEST=Valgrind goes green.
TBR=ukai
Review URL: http://codereview.chromium.org/3112026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56961 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3146031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56960 0039d316-1c4b-4281-b951-d872f2087c98

Add separate GL version field.
Review URL: http://codereview.chromium.org/3104011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56957 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3135039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3134022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56954 0039d316-1c4b-4281-b951-d872f2087c98

Set state of a new audio stream to Paused until it start to play. Also added media layout tests in ui tests.
BUG=39825
TEST=sound is still playing (with and without autoplay).

Review URL: http://codereview.chromium.org/3160027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56953 0039d316-1c4b-4281-b951-d872f2087c98

Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky on ChromeOS. Both test fail consistently in autotest runs while manual run with --gfilter_test seems to be OK. 

BUG=52928,52929
TEST=make sure these two test don't cause autotest to fail anymore

Review URL: http://codereview.chromium.org/3150027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56952 0039d316-1c4b-4281-b951-d872f2087c98

This makes it easy to digest pass/fail status for individual tests ("OK" is more discoverable than '.' in the output log). And makes it easier to associate LOG messages from chrome with the individual tests triggering them.

BUG=42148

Review URL: http://codereview.chromium.org/3191014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56951 0039d316-1c4b-4281-b951-d872f2087c98

This test basically test another behavior of the GetVar function.
It tries to get a variable by looking for its reverse form.

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.GetVarReverse.

Review URL: http://codereview.chromium.org/3162025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56950 0039d316-1c4b-4281-b951-d872f2087c98

WebKit unit-tests using webkit_support fail with these initializations as the test executable doesn't have any packages.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3148024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38475
TEST=This is the test.

Review URL: http://codereview.chromium.org/3159030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3175031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56947 0039d316-1c4b-4281-b951-d872f2087c98

Sort the methods in template_url_model.cc to match the ordering in template_url_model.h (Only moving things around. No other changes.)

BUG=None
TEST=unit_tests --gtest_filer=TemplateURL*.*

Review URL: http://codereview.chromium.org/3171025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56946 0039d316-1c4b-4281-b951-d872f2087c98

Fix to change the sense (and name) of kRestoreBackgroundContents to be kDisableRestoreBackgroundContents

BUG=52793
TEST=none

Review URL: http://codereview.chromium.org/3202004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=it compiles

Review URL: http://codereview.chromium.org/3177020

TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/3192006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=remoting unittests

Review URL: http://codereview.chromium.org/3176023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51376
TEST=Verify proxy settings UI matches proposal when proxy settings are managed by an extension.
Review URL: http://codereview.chromium.org/3132030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=it compiles

Review URL: http://codereview.chromium.org/3177020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56939 0039d316-1c4b-4281-b951-d872f2087c98

Second take, I had off-by-one bad check in line 164

for more info see review 3142022

BUG=52682
TEST=included


Review URL: http://codereview.chromium.org/3130037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify 'Show Gears Settings' button works properly in ChromeWin via --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3187010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56937 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3122030
Patch from Eric Bidelman <ericbidelman@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify that the 'Show Passwords' button displays the passwords panel in dom-ui.
Review URL: http://codereview.chromium.org/3149025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49241

Review URL: http://codereview.chromium.org/3125031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56934 0039d316-1c4b-4281-b951-d872f2087c98

Fix the problem when force closing the tab while importing.

BUG=49095
TEST=None

Review URL: http://codereview.chromium.org/3167028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56933 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3145006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56932 0039d316-1c4b-4281-b951-d872f2087c98

Separate the password exceptions list.

BUG=49093
TEST=None

Review URL: http://codereview.chromium.org/3177023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52900
TEST=none
Review URL: http://codereview.chromium.org/3164031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52703
TEST=Start chrome, set up sync, dont crash.  ProfileSyncFactoryImplTest.

Review URL: http://codereview.chromium.org/3165046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3161033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56926 0039d316-1c4b-4281-b951-d872f2087c98

Disable the stop button when the user is hovering it and the page finishes loading, so we don't look like we stay loading forever.  This change only does this for Mac and Windows, as GTK is going to be trickier.

This also fixes a pair of other bugs on Windows and Linux:
* Because we were setting the timer after telling the browser to reload, and the browser was calling us back synchronously, the timer had no effect.
* Because the timer firing changed modes with |force| set to true, if the page finished loading before the timer fired, the timer would flip the button back to reload.

BUG=46981
TEST=Hover the reload button and hit F5.  When the page finishes loading, the stop button should become disabled.  Mousing away should change it to an enabled reload button.
Review URL: http://codereview.chromium.org/3198005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56925 0039d316-1c4b-4281-b951-d872f2087c98

Having -rdynamic breaks some plugins since it exports more symbols into
the dynamic symbol table than wanted. In particular, this breaks users of
ppapi's C++ wrappers. It was added to make StaceTraces resolve to symbols
on linux. But now we use the symbolize library from glog so it isn't needed
anymore.

BUG=52105
TEST=Compiles and StackTrace.* test in base_unittests will work.

Review URL: http://codereview.chromium.org/3119033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56924 0039d316-1c4b-4281-b951-d872f2087c98

Moving file_system_proxy to base/ and changing it to work with MessageLoopProxies instead of ChromeThreads.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3131026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56923 0039d316-1c4b-4281-b951-d872f2087c98

Reviewed by georgey in http://codereview.chromium.org/3198006/show

BUG=52769
TEST=none
Review URL: http://codereview.chromium.org/3132032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56921 0039d316-1c4b-4281-b951-d872f2087c98

Revert 56908 (CL was only submitted to merge it to the branch) - Mac: Disable first-run bubble for m6.

BUG=52726
TEST=Run chrome with a new profile. No bubble should show up.

Review URL: http://codereview.chromium.org/3132031

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3169036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56920 0039d316-1c4b-4281-b951-d872f2087c98

Add in a browser test for dialog resizing, which was catching an issue with the way we were using GTK in toolkit views.  Possibly related to 27365 or 38785.

http://code.google.com/p/chromium-os/issues/detail?id=4126

BUG=chromium-os:4126
TEST=HtmlDialogBrowserTest.SizeWindow

Review URL: http://codereview.chromium.org/2768006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56919 0039d316-1c4b-4281-b951-d872f2087c98