- 05 Oct, 2017 40 commits
-
-
Lei Zhang authored
ResourceBundle became ui::ResourceBundle in r72038 but many callers still refer to it without the namespace. Change-Id: I920e21319041cd0e2a2fa671db709a9d8483fb2e Reviewed-on: https://chromium-review.googlesource.com/701662Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506826}
-
Dmitry Skiba authored
This is a follow-up to crrev.com/c/667936 which moved MAIN/LAUNCHER handling into separate .LauncherMain activity alias. That CL caused existing Chrome app shortcuts to disappear on update. Turned out that Android launcher creates {MAIN/LAUNCHER, <component>} intents for app shortcuts (i.e. it bakes in the component), and then checks that after each update MAIN/LAUNCHER intent for the app resolves to the shortcut's component. If that check fails, launcher removes the shortcut. This means that MAIN/LAUNCHER intents must continue to be handled by .Main activity alias. This CL does two renamings: 1. Renames .Main activity alias to .IntentDispatcher alias 2. Renames .LauncherMain alias to .Main I.e. MAIN/LAUNCHER intents are now handled by .Main alias, making sure shortcuts won't be removed. Additionally this CL moves more MAIN categories from .IntentDispatcher into .Main alias, so that almost all MAIN intents are handled by .Main (one exception is NOTIFICATION_PREFERENCES, as it needs dispatching). Bug: 761606 Change-Id: I6cb926c4677758190f743260e11a85129c8863bb Reviewed-on: https://chromium-review.googlesource.com/700803 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506825}
-
Jamie Madill authored
Explicitly specifying the GPU driver version in the config will allow us to safely test new driver versions. Because the tests will pick machines of a particular driver version specified in the json, we can ask infra to upgrade a few machines, then run a try job using the new driver version. This modifies the generate script to allow use of wildcards in test dimension set specifiers. Wildcards are only supported as the last character in the dimension. This allows us to more easily match ranges of driver versions. Re-land fixes the driver version for Windows 10 bots. The current NVIDIA driver version used by the bots is 372.54 for the Windows 7 bots and 376.19 for Windows 10. R=kbr@chromium.org BUG=771654 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie06cedefa0e4c4afc598ab7148d192c3f60eca34 Reviewed-on: https://chromium-review.googlesource.com/702855Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#506824}
-
Irmak Kavasoglu authored
Other possible passwords variable of the password form is currently holding all possible passwords. See this cl: https://chromium-review.googlesource.com/c/chromium/src/+/660077 This cl renames the variable accordingly. Bug: 753806 Change-Id: Id6e19b876392039704d1f23a8b42d1ca18e79ea6 Reviewed-on: https://chromium-review.googlesource.com/693014 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506823}
-
Elly Fong-Jones authored
This change: 1) Moves the MD folder icon into //components 2) Makes the Views TreeView use it in Harmony mode Note that there is no separate "open folder" icon in MD, so the open and close icons are identical. This change was previously reviewed as <https://chromium-review.googlesource.com/c/chromium/src/+/663405>. Bug: 610428 Change-Id: Ife816d911bef2a92497bb687c5aa59345359aa74 Reviewed-on: https://chromium-review.googlesource.com/692817 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#506822}
-
John Budorick authored
This includes: - ensuring that symlinks that CIPD creates for files currently managed by update_third_party_deps.py get removed by that script. - changing switching to copy_ex in process_java_prebuilt s.t. symlinks are correctly handled by that template. Bug: 755920 Change-Id: I1a75ae3acd96ce827401d8d58f8f1127ad09eadb Reviewed-on: https://chromium-review.googlesource.com/701495Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506821}
-
Paul Miller authored
BUG=771783 Change-Id: Iba58f2ebf19d3deb04cda8e6a4d73c7bfbab1efe Reviewed-on: https://chromium-review.googlesource.com/701371Reviewed-by:
-
Scott Violet authored
The flow is: 1. browser requests WindowTreeClient from the RenderWidget of the frame to embed. 2. browser send a message to the parent RenderFrameProxy with the WindowTreeClient. 3. RenderFrameProxy forwards to RendererWindowTreeClient to create the child window and embed the WindowTreeClient in it. BUG=758387 TEST=none Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I0296e802c0f754e463c65492f38ec5a68df30eba Reviewed-on: https://chromium-review.googlesource.com/673066Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506819}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/38d0449a02f4..4ce4f5f8ab0b $ git log 38d0449a0..4ce4f5f8a --date=short --no-merges --format='%ad %ae %s' 2017-10-05 dsinclair Cleanup CPDF_RenderStatus 2017-10-04 dsinclair Remove CPDF_Object friends 2017-10-05 dsinclair Remove friends from CXML_Element 2017-10-04 dsinclair Remove CPDF_CMapParser friends Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I2981fe77ca795854246e66ba3a2d1f34063a4de6 Reviewed-on: https://chromium-review.googlesource.com/702639 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506818}
-
lgcheng authored
We enable Arc package sync datatype when user enables Arc, and call StartModels when Arc app instance is ready and Arc packages get refreshed. But There is a big time gap since we need perform provision for Arc during opt-in. And this may lead to the high config time-out rate for Arc packages. Enable the datatype when provision is successful and reduce the gap between enabling the sync data type and calling startModels. Bug: 771838 Test: Manual test and Arc pacakge related integration test. Change-Id: I4c70c9d7e3c690fc953dac981398424d166ce51f Reviewed-on: https://chromium-review.googlesource.com/702014Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#506817}
-
Lei Tian authored
Increase the maximum limit of CCT bottom bar height to display larger view. Bug: None Change-Id: I0b0a8831cbd39f299e0dafd8e0eb314e8fe9b398 Reviewed-on: https://chromium-review.googlesource.com/702687Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#506816}
-
Victor Costan authored
This CL also #defines DeleteFile as DeleteFileW on Windows for all compilation units that depend on leveldb. This definition impacts leveldb's API (leveldb::Env::DeleteFile), and is in effect in most of Chromium, because it is introduced by <windows.h>. After this CL, the definition is guaranteed to be in effect everywhere, so we don't have to reason about #include side-effects. https://chromium.googlesource.com/external/leveldb.git/+log/09a3c8e74175..4a7e7f50dcf6 $ git log 09a3c8e74..4a7e7f50d --date=short --no-merges --format='%ad %ae %s' 2017-10-04 cmumford Add LEVELDB_EXPORT macro to export public symbols. 2017-10-04 costan leveldb: Include <algorithm> in util/env_test.cc. 2017-10-03 costan Fix FD leak in POSIX Env. 2017-10-03 costan leveldb: Add tests for CL 170769101. 2017-10-03 costan Remove handling for unused LRUHandle representation special case. 2017-10-02 sanjay Fix file writing bug in CL 170738066. 2017-10-02 cmumford Fix use of uninitialized value in LRUHandle. 2017-10-02 sanjay Fix issue 474: a race between the f*_unlocked() STDIO calls in env_posix.cc and concurrent application calls to fflush(NULL). 2017-09-26 costan Use portable CRC32C from google/crc32c. 2017-09-01 costan Remove confusing and unnecessary if. 2017-09-01 costan Simplify Table::Open() flow and remove a delete call. Created with: roll-dep src/third_party/leveldatabase/src Bug: Change-Id: I0096e6b863616d14c20994d6cb9696ebc263f138 Reviewed-on: https://chromium-review.googlesource.com/699018Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#506815}
-
Aleks Totic authored
Bug: 612962 Change-Id: Idd15d1639defb4bd3cf56795b57b9f3a4f55379d Reviewed-on: https://chromium-review.googlesource.com/702676Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#506814}
-
Tom Sepez authored
Simplify moving sandbox_mac.mm itself out of content/, as it no longer includes content headers. Change-Id: I68e746fb4c003e6a4bc60ee44057b8d1ba0554d1 Reviewed-on: https://chromium-review.googlesource.com/701359Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506813}
-
Yoland Yan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: I0270db03b98377e50bcbd45ccbc972fe28e4c918 Reviewed-on: https://chromium-review.googlesource.com/699794 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506812}
-
Owen Min authored
When force-signin is enabled, profile should be able to removed even all profiles are locked so that user is able to remove any locked profile that is not able be unlocked due to policy update. Bug: Change-Id: I8c0433eaee76566f76d9a12c5a6f6883dcb94b20 Reviewed-on: https://chromium-review.googlesource.com/701397Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506811}
-
James MacLean authored
This reverts commit 5638e72c. Reason for revert: compile error on bots ... Original change's description: > Send Emulation.virtualTimeAdvanced when virtual time advances > > This helps controls scripts get a better idea of the current virtual > time. > > Bug: > Change-Id: I39433f2790cdc51c14a3c02736c9320b0bce7c0a > Reviewed-on: https://chromium-review.googlesource.com/702374 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506789} TBR=dgozman@chromium.org,skyostil@chromium.org,alexclarke@chromium.org Change-Id: Iffebedd5d1c7f303d2e02f9f32e06d750eee29eb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/702975Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#506810}
-
Ken Rockot authored
This reverts commit 5638e72c. Reason for revert: Breaking compile on Windows: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/113824 Change-Id: Ia0ca3f2bf43980eb13418c7c14deb16119d88efc TBR=dgozman@chromium.org TBR=skyostil@chromium.org Change-Id: Ia0ca3f2bf43980eb13418c7c14deb16119d88efc Reviewed-on: https://chromium-review.googlesource.com/702690Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506809}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58c1372e..4754eed2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I6f673abb4422cbb6d4ee4dcd1b772e4e43397591 Reviewed-on: https://chromium-review.googlesource.com/702516Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506808}
-
Ian Vollick authored
This reverts commit 9f6b2091. Reason for revert: The timing of the swap_chain_ destruction appears to be wrong. Reverting this until I can sort it out. Original change's description: > [vr] Enable 2x MSAA > > This increases the number of samples used in the primary framebuffer. > > Bug: 752085 > Change-Id: I869ae41943db925aff845b3d1da15e8130b14e45 > Reviewed-on: https://chromium-review.googlesource.com/680374 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505811} TBR=vollick@chromium.org,mthiesse@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 752085, 771663 Change-Id: I6150abf5840fa81cc9ce135c0746d3fd4f8bca7a Reviewed-on: https://chromium-review.googlesource.com/702517 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506807}
-
Lei Tian authored
The recent change for using ColorUtils.isUsingDefaultToolbarColor to decide emphazing htts scheme makes Chrome Home does not emphasize https properly. This is because ColorUtils.isUsingDefaultToolbarColor does not check whether BottomSheet is null. For Chrome Home, BottomSheet is not null so the toolbar should not be populated by brand color and should emphasize the https scheme. To fix the problem, revert back to use ToolbarModel.isUsingBrandColor. And also change CCT to use the same method. However, since mIsUsingBrandColor also depends of whether there is a tab, make setTab in ToolbarModelImpl also update mIsUsingBrandColor. This is needed because CCT setTab after setPrimaryColor. BUG=771559 Change-Id: Id94c811f2992ecc73b36c08d2537c63949131f2e Reviewed-on: https://chromium-review.googlesource.com/701455Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#506806}
-
Pedro Amaral authored
Changes in how selection and the action mode are triggered seem to have deflaked these tests. Each of the re-enabled tests passed 60 times on a Nexus 6P running Android O and 60 times on a Nexus 4 running Android J. Bug: 592428 Change-Id: If774d474df13e9e20e3d714f06358811a941d075 Reviewed-on: https://chromium-review.googlesource.com/701278Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#506805}
-
David Bokan authored
This is a follow-up CL to: https://crrev.com/c/690314 Currently, gpuBenchmarking takes coordinates in the root-frame coordinate space. Since input events are in the (visual) viewport space, gpuBenchmarking was trying to convert them in the presence of pinch-zoom by applying the pageScaleFactor. This is incorrect, as the transformation must also include the visual viewport offset. However, it makes a lot more sense for gpuBenchmarking to take coordinates in the viewport space to begin with, leaving the conversion to the caller. The above CL converts telemetry to pass these coordinates in viewport space. It's gated on the presence of the `gesturesExpectedInViewportCoordinates` attribute so that we can make the transition without breaking the waterfall. Bug: 610021 Change-Id: Ic6a4229e230b77427e6f1aa7ef71933c21d93106 Reviewed-on: https://chromium-review.googlesource.com/668376 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Jonathan authored
Another test is flaky on telemetry_unittests, skipping it in config. TBR=sky@chromium.org Bug: 758065 Change-Id: I49849ca1b271fcceb1976f86f8ed6225a22cc302 Reviewed-on: https://chromium-review.googlesource.com/700797Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#506803}
-
Bence Béky authored
Remove HpackStringDecoder:StartOnly(), StartAndDecoderLength(), and StartSpecialCaseShort(). This CL lands internal change 170871163 by bnc. BUG=488484 Change-Id: I5ea3d3650980816d3bd0729a277d5786b5e5e974 Reviewed-on: https://chromium-review.googlesource.com/688714Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506802}
-
Daniel Bratell authored
This patch removes a random sources block that was ignored in normal builds but triggered an assert in jumbo builds. This also changes the OWNERS file according to presubmit instructions. Bug: 771153 Change-Id: Ic32f92db25b1b4bd6e2087b95785b4934a94e120 Reviewed-on: https://chromium-review.googlesource.com/702258Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#506801}
-
Elly Fong-Jones authored
This change is needed for the Harmony treeview, but it also looks better in the non-Harmony treeview, so it's unconditional in this CL. This change also removes the special background/foreground colors from the example treeview. While those were useful as a demonstration, they are quite garish and distracting when screenshotting the treeview :). Bug: 610428 Change-Id: Icf14b2e1d5b8c20a6d72550cfe57436b3f31cce4 Reviewed-on: https://chromium-review.googlesource.com/695563Reviewed-by:
-
Ian Kilpatrick authored
... in favour of IntrinsicBlockSize(). We weren't using inline overflow size, and "overflow" was incorrect for how it was being used. This also moves it to the layout result. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idd6c63dd5e0712c69f81bed21a03ad2be4c9331a Reviewed-on: https://chromium-review.googlesource.com/701357 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506799}
-
Matt Menke authored
This reverts commit 336a0871. Reason for revert: This is breaking Cronet iOS tests. Sample trace: #0 0x0000000102c2e6b0 in net::RunCookieCallback(base::OnceCallback<void ()>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:25 #1 0x0000000102c2eb20 in net::NSHTTPSystemCookieStore::GetCookiesForURLAsync(GURL const&, base::OnceCallback<void (NSArray<NSHTTPCookie*>*)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:45 #2 0x0000000102c0f5b0 in net::CookieStoreIOS::GetCookieListWithOptionsAsync(GURL const&, net::CookieOptions const&, base::OnceCallback<void (std::__1::vector<net::CanonicalCookie, std::__1::allocator<net::CanonicalCookie> > const&)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/cookie_store_ios.mm:459 #3 0x000000010380caec in net::URLRequestHttpJob::AddCookieHeaderAndStart() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:597 #4 0x000000010380c598 in net::URLRequestHttpJob::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:321 #5 0x00000001037e87d8 in net::URLRequest::StartJob(net::URLRequestJob*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:668 #6 0x00000001037e7ec4 in net::URLRequest::BeforeRequestComplete(int) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:613 #7 0x00000001037e7738 in net::URLRequest::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:538 #8 0x0000000102c3a620 in net::HttpProtocolHandlerCore::Start(id<CRNNetworkClientProtocol>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/crn_http_protocol_handler.mm:708 #9 0x0000000102c41130 in void base::internal::FunctorTraits<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), void>::Invoke<scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:194 #10 0x0000000102c41034 in void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::HttpProtocolHandlerCore::* const&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (net::HttpProtocolHandlerCore::* const&&&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:277 #11 0x0000000102c40fc0 in void base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::RunImpl<void const(&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&, 0ul, 1ul>(void const(&&&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&&&, void const(id<CRNNetworkClientProtocol>)::integer_sequence<unsigned long, 0ul, 1ul>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:349 #12 0x0000000102c40ebc in base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::Run(base::internal::BindStateBase*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:331 Original change's description: > [Reland] Convert SystemCookieStore to Async. > > * Converts SystemCookieStore to Async > * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous > functions. > * Move creation time management to systemCookieStore. > * Update cookie_store_ios_presistent_unittest & > cookie_store_ios_unittests to account for SystemCookieStore changes > * (As CookieStoreIOS is using systemCookieStore internally). > > Another CL is in progress to add WKSystemCookieStore & unit_tests for > systemCookieStore (to handle async methods) with template for both > NSHTTP & WK systemCookieStore. > > Bug: 759229, 759227, 767948 > Change-Id: If5e1fdb8d6424085d5212a3ea867968642db554f > Reviewed-on: https://chromium-review.googlesource.com/700818 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506549} TBR=eugenebut@chromium.org,mrefaat@chromium.org Change-Id: I7c653c57501745359ecb35ff422996545b7587f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759229, 759227, 767948 Reviewed-on: https://chromium-review.googlesource.com/702974Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506798}
-
Yuki Shiino authored
Makes Supplementable/Supplement support TraceWrapperBase/ TraceWrapperMember appropriately. Supplementable<T> now holds HeapHashMap of TraceWrapperMember instead of one of Member, so that (subclasses of) Supplement<T> will be wrapper-traced. Bug: 569301,658073 Change-Id: I229eaca761d5d012b58b0aa745fb3e10c45224f6 Reviewed-on: https://chromium-review.googlesource.com/687375 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#506797}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f8ebe0eae6cb..09fca0a3600a $ git log f8ebe0eae..09fca0a36 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 johnchen Remove '.' from media metric histogram name Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I72e7f49291108626f8a35eaee9ad5a2eedff1c3a Reviewed-on: https://chromium-review.googlesource.com/702680 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506796}
-
Jan Krcal authored
This CL uses the existing status AVAILABLE_LOADING to signal to the UI that the currently available suggestions are stale and that new ones are being loaded. When the fetch is over (or when it fails or when a timeout fires), the category status is switched back to AVAILABLE. Bug: 762932 Change-Id: If34d739ab316adec95f8e4e8f4b5319479fdacd5 Reviewed-on: https://chromium-review.googlesource.com/663729 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#506795}
-
Avi Drissman authored
The SigninViewControllerDelegate, as a modal dialog manager delegate, will outlive the manager. If so, don't call through to a non-existent manager. BUG=771872,771142 TBR=wittman@chromium.org Change-Id: Ia020c026094c3092e4946155d3437c2855951595 Reviewed-on: https://chromium-review.googlesource.com/702515Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506794}
-
Hans Wennborg authored
We don't build them on Mac. Bug: none Change-Id: I8a79ef3ed837c7d1d81dc157bd4b95939f67c9d6 Reviewed-on: https://chromium-review.googlesource.com/702634Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#506793}
-
Khushal authored
For PaintShader and PaintImage, we lazily create the internally cached SkShader and SkImage. This can cause this access to be racy when later done on the raster worker threads during playback. Ensure that these objects are created during Paint object construction. R=enne@chromium.org, vmpstr@chromium.org Bug: 771156 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8538442e0459e1762a81d5fb150301621360d850 Reviewed-on: https://chromium-review.googlesource.com/701974Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506792}
-
Ben Chan authored
shill's Device.ProposeScan DBus method has been deprecated and superseded by the Device.RequestScan DBus method. BUG=763198 TEST=chromeos_unittests Change-Id: I9ae4a115ee2e0f14a10f06a5bdbe4e48b21bba83 Reviewed-on: https://chromium-review.googlesource.com/701622Reviewed-by:
-
Khushal authored
Since we strip out strings on official release builds, don't use "Check Failed" for EXPECT_DEATH asserts. R=thakis@chromium.org Bug: 771998 Change-Id: Id9e65c699fdae2fab8354ea64cae82b5d0691109 Reviewed-on: https://chromium-review.googlesource.com/702647Reviewed-by:
-
Alex Clarke authored
This helps controls scripts get a better idea of the current virtual time. Bug: Change-Id: I39433f2790cdc51c14a3c02736c9320b0bce7c0a Reviewed-on: https://chromium-review.googlesource.com/702374Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506789}
-
Alex Clarke authored
This will allow devtools protocol users to distinguish between forms that use GET and POST. Bug: Change-Id: Id27f36cb675aaea02434a76eae492faac320f01e Reviewed-on: https://chromium-review.googlesource.com/700518Reviewed-by:
-
Shane Hansen authored
Headless users may want to decode captured traffic. Bug: 767532 Change-Id: Ied7fa3ec4fb771f845d9c38eb2a476f2e5a3b018 Reviewed-on: https://chromium-review.googlesource.com/677569 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
-
