GitLab

While the use of gmock's InSequence is unfortunate (read: brittle tests), it does help capture the call sequences for various pipeline operations. You may notice in the original incarnation of these tests in http://codereview.chromium.org/10828045/ didn't need InSequence. I'm aiming to remove InSequence after I'm done rewriting the guts of Pipeline.

BUG=110228

Review URL: https://chromiumcodereview.appspot.com/10832197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles

Review URL: https://chromiumcodereview.appspot.com/10828052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150814 0039d316-1c4b-4281-b951-d872f2087c98

Failing on the ChromiumOS Dbg Bots.

BUG=141497,139117
TEST=none
TBR=jochen

Review URL: https://chromiumcodereview.appspot.com/10837188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150813 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 77592af8b97f753a7b2540e613166759c6fc314c.

TBR=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130377
TEST=chrome/ppapi/tests/test_image_data.cc
Review URL: https://chromiumcodereview.appspot.com/10823211

----
Failing on mac 10.6 bots:
http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/25635


TBR=nfullagar@google.com
Review URL: https://chromiumcodereview.appspot.com/10832218

TBR=dalecurtis@google.com
Review URL: https://chromiumcodereview.appspot.com/10826226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150809 0039d316-1c4b-4281-b951-d872f2087c98

Since the devtools server is running for each content shell browser process, the user doesn't specify a server port anymore. Instead I let the system pick. This made it necessary to plumb the data back from net::HttpServer.

For now I only added Windows and Linux UI. Mac UI will be done later.

BUG=90445
Review URL: https://chromiumcodereview.appspot.com/10837177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150808 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10837185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150807 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139699

Review URL: https://chromiumcodereview.appspot.com/10832185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150806 0039d316-1c4b-4281-b951-d872f2087c98

Revert 150799 - sync skia's gyp file directory, in preparation for sharing .gypi files between skia and chrome
Review URL: https://chromiumcodereview.appspot.com/10823256

TBR=reed@google.com
Review URL: https://chromiumcodereview.appspot.com/10837187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150805 0039d316-1c4b-4281-b951-d872f2087c98

Support navigation with keyboard shortcuts as other platform(GTK).

BUG=90445
TEST=


Review URL: https://chromiumcodereview.appspot.com/10832221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150804 0039d316-1c4b-4281-b951-d872f2087c98

refactor EnumerateDevices to make it a persistent request.
After the requester calls EnumerateDevices, it should expect new device list as initial response and whenever devices are changed.
A new method StopEnumerateDevices is also added to allow the request to stop device enumeration.

It also includes corresponding change in Pepper since EnumerateDevices contract is changed (http://codereview.chromium.org/10837064/).
This patch keeps current Pepper API, while using the new API of EnumerateDevices from MediaStreamDispatcher. 
Pepper calls StopEnumerateDevices when it receives the first enumerated result. 

A new Pepper API will be created in a separate patch to make EnumerateDevices persistent. 

BUG=137799
Review URL: https://chromiumcodereview.appspot.com/10828230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306

Review URL: https://chromiumcodereview.appspot.com/10826189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150802 0039d316-1c4b-4281-b951-d872f2087c98

Deselect should maintain previously selected wallpaper and select guest user should use default guest wallpaper


Deselect user from user pod should not set the wallpaper to a white background. It should use whatever wallpaper is showing.

It also fix the problem when selecting guest user pod, the wallpaper didn't set to default guest user wallpaper.


BUG=141259, 141226

Review URL: https://chromiumcodereview.appspot.com/10827203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150801 0039d316-1c4b-4281-b951-d872f2087c98

Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS.

Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS.

To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field.

This will simplify the process of adding a tool to check license compatibility for the Android WebView build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10830201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150800 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10823256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150799 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
TEST=fixes checkperms on Linux builder.

Review URL: https://chromiumcodereview.appspot.com/10855077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150798 0039d316-1c4b-4281-b951-d872f2087c98

I am not simply reverting 147297 because that CL included some js code for correctly handling errors in the ASP case, and that is still useful should the user decide to go back to ASPs.

Change that disabled OTP on trunk:
https://chromiumcodereview.appspot.com/10800010
http:crrev.com/147297

BUG=137772,141636
TEST=Signing in should ask for OTP instead of ASP.

Review URL: https://chromiumcodereview.appspot.com/10800010

Review URL: https://chromiumcodereview.appspot.com/10818006

TBR=rogerta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139117,141497
TEST=WebNavigationApiTest.*


Review URL: https://chromiumcodereview.appspot.com/10826224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150796 0039d316-1c4b-4281-b951-d872f2087c98

In the process, refactors the Instant code so that all logic is
centralized in the InstantController. InstantLoader now merely
forwards messages between InstantController and the renderer.

BUG=none
R=sky@chromium.org
TEST=Instant works as before when enabled from chrome://settings/.

Review URL: https://chromiumcodereview.appspot.com/10836031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150795 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10837077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150794 0039d316-1c4b-4281-b951-d872f2087c98

Add a navigation pane on the left (similar to the uber frame for history/extensions/settings pages) and apply the same style settings.

Note: the navigation pane is non-functional at the moment. For Diagnostics V1 (1st milestone), we will only have a single page for connectivity, which is always selected as the current page.

BUG=139442
TEST=lumpy


Review URL: https://chromiumcodereview.appspot.com/10824223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150793 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150792 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10836175/
Review URL: https://chromiumcodereview.appspot.com/10836174

TBR=robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/10854064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150791 0039d316-1c4b-4281-b951-d872f2087c98

(Views only) Create a separate class for the contents of the Website Settings UI that is displayed for internal Chrome pages.


BUG=113688
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10828201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150790 0039d316-1c4b-4281-b951-d872f2087c98

Small change to add correct asm break instruction for MIPS architecture.

BUG= https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome

Review URL: https://chromiumcodereview.appspot.com/10834234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150789 0039d316-1c4b-4281-b951-d872f2087c98

- Text for default action was not properly presented before
- Crash on minimize of file dialog
- Clicking in tip area of button did not do anything
- Added padding for text
- Launcher did show gray background upon maximize/minimize
- Added requested animations


BUG=140834, 140958, 140840
TEST=Visual

Review URL: https://chromiumcodereview.appspot.com/10829226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150788 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150787 0039d316-1c4b-4281-b951-d872f2087c98

We can use Tab* directly instead of using the base class BaseTab*, because that
is what tab_at returns and Tab is a subclass of BaseTab.

This is a work towards on merging BaseTab into Tab, which is also a TODO.

R=sky@chromium.org
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10825221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150786 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10836175/
Review URL: https://chromiumcodereview.appspot.com/10836174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:138227
R=joaodasilva@chromium.org, pneubeck@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125643
TEST=Ensure that the cookies dialog is still fully functional; also see bug report


Review URL: https://chromiumcodereview.appspot.com/10830221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140876


Review URL: https://chromiumcodereview.appspot.com/10829256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150782 0039d316-1c4b-4281-b951-d872f2087c98

Use Control+N to create new content shell window.

BUG=90445,120153
TEST=


Review URL: https://chromiumcodereview.appspot.com/10855070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150781 0039d316-1c4b-4281-b951-d872f2087c98

This creates a "libwebview" build target for the JNI code to power the
Android WebView. This is unfinished and can't run without additional
code that has not yet been upstreamed, but it compiles and links
successfully.

In its present state the WebViewMainDelegate reuses Chrome
implementations of other content client interfaces. This is a temporary
state of affairs until necessary refactorings can be performed.

Review URL: https://chromiumcodereview.appspot.com/10825155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150780 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=137569


Review URL: https://chromiumcodereview.appspot.com/10827214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150779 0039d316-1c4b-4281-b951-d872f2087c98

 protoc must be build for the Mac platform and not for iOS. mac_build.gypi is used to allow this.

TEST=None
BUG=None
R=stuartmorgan@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10855048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150778 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150777 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150776 0039d316-1c4b-4281-b951-d872f2087c98

Adds iOS support to crypto.gyp. Both targets now build, but the tests may not
run correctly, and not all the crypto code is correct yet for iOS.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/10830183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150775 0039d316-1c4b-4281-b951-d872f2087c98

PrerenderWebMediaPlayer derives from WebMediaPlayerImpl which is not
implemented on Android (there is a separate WebMediaPlayerAndroid which
is derived from the WebMediaPlayer interface). Stubbing this constructor
invocation is very difficult and it's only referred to in one place, so
an #ifdef is much simpler.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150774 0039d316-1c4b-4281-b951-d872f2087c98