- 26 Jan, 2020 24 commits
-
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: I570f09c12bf770f8b1f30ec527b26d0604c463df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017514Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735275}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=javierrobles@chromium.org Bug: 1042208 Change-Id: I7502c0433e13fe56e4061a63ed84c52f6a21808d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017402Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735274}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1042208 Change-Id: I6f8cd917589a022616c699d27f8f37fd0f9caf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017423Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735273}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1042208 Change-Id: Ic847e54a737366f05842c7b471cee614129d0daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014974Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=hajimehoshi@chromium.org Bug: 1042208 Change-Id: I2a3cbcc3f4c23d7ad4c644dc5cb73e0d1a9bddd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017422Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735271}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: Ia115175df1261886f83273d1997459ebc434a284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017510 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: I36033d5ab5538a9d9e3ec30235c2dcd7857bda3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017202 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=stkhapugin@chromium.org Bug: 1042208 Change-Id: If05cda0d522ef0c707f9b1e33d0631fb809843ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017542Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735268}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=stkhapugin@chromium.org Bug: 1042208 Change-Id: I8c8a68e149aa321da4b046a073f805500528cb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017302Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I6ac7cb5b57cae580bc39301c21921351869be4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015174Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735266}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I3fdefa9f1f114eaf6e3b07b1d6c474c6bfe403ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017342Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e580995f25dc..f85fe1366887 git log e580995f25dc..f85fe1366887 --date=short --first-parent --format='%ad %ae %s' 2020-01-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-01-26 reed@google.com use vsphere to control light Created with: gclient setdep -r src/third_party/skia@f85fe1366887 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: If972e14a0dfce0654d675bdfe7c4f1fb0e473042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735264}
-
Christopher Cameron authored
By doing this, we do not need to adjust the brightness of SDR content. The only time that we need to adjust content is when displaying HDR video that uses the PQ transfer function. Adjust the default SDR white level to be 100, so that it will behave correctly on macOS, now that Windows is no longer relying on the value. This fixed the bug where PDFs were double-darkened, and may also fix other filtering bugs, though that will need to be verified. Bug: 1038770 Change-Id: I22dc9d50bd65897234905390e2c2e2f8416a41eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018339 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#735263}
-
Maggie Chen authored
According to Intel, the overlay support caps might change after a monitor connection change. This CL re-queries the overlay caps when this event is observed. Refactor UpdateHardwareOverlaySupport(). Bug: 1042989 Change-Id: I84ef4ff3dca098f3778f8188fdd7157349480144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019768Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db301b73f8b7..e580995f25dc git log db301b73f8b7..e580995f25dc --date=short --first-parent --format='%ad %ae %s' 2020-01-26 reed@google.com virtual sphere Created with: gclient setdep -r src/third_party/skia@e580995f25dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I1bc34ae7874f2a0570206fc496543b8e07e61bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021733Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33bd04f34e89..58b42c77c700 Created with: gclient setdep -r src-internal@58b42c77c700 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1018427 Tbr: jbudorick@google.com Change-Id: If96a82ff2802d97c6dd6c47b4e08f019be45e4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021732Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735260}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: If8462b5978f33b93415a947ea7c6647b425a3547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020411Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735259}
-
liberato@chromium.org authored
Records the maximum number of consecutive NNRs observed during playback. "Consecutive" means "separated by at most 60s between each NNR". Adds one training example to the newly-introduced learning task per playback. Notes: NNRs are ignored if we haven't started the smoothness helper yet, and i have no idea if this will happen much. Ideally, not. NNR counts are reset when playback is paused, or we adapt, or any of the other things that reset the smoothness helper. Change-Id: I43a36cd053c7e37134dd8d6a6e83a8d3d27f44b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016197 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#735258}
-
Khushal authored
TBR=ericrk@chromium.org Bug: 1041477,1045751,1045723,1045710 Change-Id: I5bf2d39e5b40f419072c4df986c2e85c4375ecff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021888Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735257}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00a97643199a..db301b73f8b7 git log 00a97643199a..db301b73f8b7 --date=short --first-parent --format='%ad %ae %s' 2020-01-26 reed@google.com restore til I understand what changed Created with: gclient setdep -r src/third_party/skia@db301b73f8b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I6db1992898825721e70d796a38a8ce14b3180e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021730Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78d4b3052670..33bd04f34e89 Created with: gclient setdep -r src-internal@33bd04f34e89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044158 Tbr: jbudorick@google.com Change-Id: Ib55ae05f31f229d4ab1da0ae9e35f9610cf091bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021729Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 940160d8. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9bf44bfbe01adea8dbea8ca6159a37f46fbeb658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021225Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735254}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0143673111c..00a97643199a git log e0143673111c..00a97643199a --date=short --first-parent --format='%ad %ae %s' 2020-01-26 reed@google.com consolidate examples to 1 matrix type Created with: gclient setdep -r src/third_party/skia@00a97643199a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I7319f379a41eb0ce9d70066b12741ad3f722a94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021728Reviewed-by:
-
David Trainor authored
This CL moves ThumbnailProvider.java and all associated Java/C++ files to a separate chrome/browser/thumbnail directory. This CL pulls in all obvious dependencies and splits them to a modularized build target. Files moved: download.DownloadMediaData.java download.DownloadMediaParserBridge.java download.DownloadMediaParserTest.java widget.ThumbnailDiskStorage.java widget.ThumbnailGenerator.java widget.ThumbnailGeneratorCallback.java widget.ThumbnailProvider.java widget.ThumbnailProviderImpl.java widget.ThumbnailStorageDelegate.java widget.ThumbnailDiskStorageTest.java widget.ThumbnailProviderImplTest.java widget.thumbnail_cache_entry.proto download/download_media_parser.cc download/download_media_parser.h download/download_media_parser_bridge.cc download/download_media_parser_bridge.h download/image_thumbnail_request.cc download/image_thumbnail_request.h download/local_media_data_source_factory.cc download/local_media_data_source_factory.h download/thumbnail_util.cc download/thumbnail_util.h thumbnail/scoped_ptr_expiring_cache.h thumbnail/scoped_ptr_expiring_cache_unittest.cc thumbnail/thumbnail.cc thumbnail/thumbnail.h thumbnail/thumbnail_cache.cc thumbnail/thumbnail_cache.h widget/thumbnail_generator.cc widget/thumbnail_generator.h chrome/browser/image_decoder.cc chrome/browser/image_decoder.h chrome/browser/image_decoder_browsertest.cc data/android/thumbnail_provider/test_image_10x10.jpg data/android/thumbnail_provider/test_image_10x20.jpg data/android/thumbnail_provider/test_image_20x10.jpg data/android/thumbnail_provider/test_image_20x20.jpg Conceptual targets pulled into chrome/browser/thumbnail: - C++ target - Java target - proto target - JNI target - javatests - junit tests - browsertests - unit tests - test data Extra notes: - chrome/browser/thumbnail/generator/stats.h/cc contains functions/enums from download_stats.h/cc - Fixed presubmit warnings on NULL vs. nullptr - Fixed presubmit warnings on using content::MessageLoopRunner vs. base::RunLoop. Bug:1018427 Change-Id: I81c48e427fd135c7b4e9e0791b5e74ca951fa62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865624 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735252}
-
- 25 Jan, 2020 16 commits
-
-
David Tseng authored
Original change containing changes: https://chromium-review.googlesource.com/c/chromium/src/+/2018385 This change reverts changes to PRESUBMIT.py above. TBR=dtseng@chromium.org Change-Id: I0bce283cd413319e371fae3908e50eb5b39cb369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021845Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735251}
-
Victor Vasiliev authored
This moves nearly all net/third_party/quiche source files into //net/third_party/quiche/BUILD.gn, so that they can be given visibility for absl later. Change-Id: Ifa2902002f5f7a2b1b5005f6c3f337439af69ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020686Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#735250}
-
Theresa Wellington authored
Add interfaces to //ui/android/ that allow observation of VR mode. This is in preparation for moving selectable list widgets to //components/browser_ui/, which requires breaking dependencies on chrome_java classes. BUG=1003939 Change-Id: If09ea543a79631c57fbe0a44c58afd5cc4c75b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020547 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#735249}
-
David Tseng authored
This is a semi-script-automated conversion of all production (non-test) files under c/b/r/c/a/chromevox to ES6 classes. Beyond the automated changes: (<after script conversion> -> <after script conversion + manual edit>). - classes needed to be exported to Closure: goog.provide('Foo'); ... class Foo {} -> Foo = class {} (the goog.provide declares Foo on window, and the definition sets the anonymous class). Some parts of ChromeVox reference class objects on window e.g. the panel script accesses window.ChromeVox, where window is the background script's window instance. - super calls needed to be added. Foo.call(this) -> super() - editing.js this.someVar = ...; super(); -> var someVar = ...; super(); this.someVar = someVar; (ES6 classes disallow setting properties on |this| before calling super. - some goog.scopes were removed This change does not do the following which should come in follow ups: - new Closure compiler errors (these are all preexisting and are only signaled in the upload PRESUBMIT). This seem to be presented now because they are within an ES6 class. - some more fields/methods in some files are not included in the class definition but could probably be with the static modifier. - additional readability / style conventions to make these files further compliant with the latest style standards for js. - some files appeared to have been missed by the automated script (likely due to the way the files formatted the old-styled prototype class). - test files are not converted Test: all browser_tests pass. Change-Id: Ida7896b6e1435891ccb8f523f61aec2262516763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018385 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#735248}
-
Rouslan Solomakhin authored
This patch adds payment app factory for service worker based payment handlers, in accordance with the design at: https://bit.ly/cross-platform-pay-app-factory. The factory is responsible for finding the payment apps (ServiceWorkerPaymentApp), filtering out apps that don't support the requested method names, verifying ability to use the method names, and firing "canmakepayment" events when necessary. Since deduplication is important for service worker payment apps, the deduplication logic is now moved from the old PaymentAppFactory to the new PaymentAppService. Bug: 1022512 Change-Id: I75e6d9f7eaeac20e8cac9e0ebd2784c424694727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988215 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#735247}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad1c1347. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ericwilligers@chromium.org: external/wpt/css/motion NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie0c52222479772924365675600bd2e9ad1899125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020843Reviewed-by:
-
Ted Choc authored
When switching tabs in the tab switcher, the new tab isn't interactable until you leave the switcher. Thus, we should ignore resetting the state of the tab until we leave the switcher. BUG=1040033 Change-Id: Ida4c27c00cd6b3bb6a6ae517555c2bcac30ac612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021286Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735245}
-
Theresa Wellington authored
BUG=1030785 Change-Id: I09a6cc7a20b48567c23e76b8657ff90536c8b000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016663 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52ef28dcfe09..fcef6dcb6ab2 git log 52ef28dcfe09..fcef6dcb6ab2 --date=short --first-parent --format='%ad %ae %s' 2020-01-25 flibitijibibo@gmail.com For GGP builds, define __ggp__ manually. Created with: gclient setdep -r src/third_party/angle@fcef6dcb6ab2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I15f40ba0694d217a040356a10ca67ad3f2a663b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021766Reviewed-by:
-
Anton Bikineev authored
Since in incremental/concurrent marking the stack is considered white, there is no need to issue write barriers for stack pointers. Therefore, stack allocated classes don't need to wrap Members and can simply use raw pointers or references to heap objects. This is consistent with regular uses of raw pointers on stack. This CL updates all classes marked as STACK_ALLOCATED to use raw pointers instead of members. The main reason is to greatly reduce the number of write barriers. Since default initialization of raw pointers doesn't imply zero-initialization, it must be ensured that pointers are always initialized with a value or zero. As suggested in Chromium C++ Dos and Don'ts, a member is not initialized with in-class initializer in case all the constructors explicitly initialize it. Bug: 1044611 Change-Id: I15587eeb407a624d499978fd3dfb7b8034d02056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014940 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735242}
-
Theresa Wellington authored
This is needed to allow TextBubble to move to //components/browser_ui/. AccessibilityUtil isn't valid outside of //chrome/ because it uses ApplicationStatus, which isn't applicable to WebView/WebLayer. BUG=1030785 Change-Id: I3133bb062f520deed3d9994bbfe1b60561060d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017930 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
sandromaggi authored
This change tries to make the filter logic clearer. The existing method is left functionally unchanged. It works with an inclusive filter (i.e. only errors present in the filter will be reported). The helper functions and parameter names have been adapted to reflect that. A new method has been added that works the opposite way. Fields included in the filter will not be reported. This CL also adds unit tests for both methods. Bug: none Change-Id: Id9f23e5e5259d6d97e4ce148e13892931dd67f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019205Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#735240}
-
Michael Ludwig authored
Bug: 1045050 Change-Id: I3e1f09e32335ee7d5913b74e82d92632f38ee0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021002 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#735239}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/564eb6f2a98c..52ef28dcfe09 git log 564eb6f2a98c..52ef28dcfe09 --date=short --first-parent --format='%ad %ae %s' 2020-01-25 jmadill@chromium.org Vulkan: Update active textures before setupDraw(). Created with: gclient setdep -r src/third_party/angle@52ef28dcfe09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ib8519afaad7d6744399e66d3669f790ad2eafde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021723Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78184a3ce63d..e0143673111c git log 78184a3ce63d..e0143673111c --date=short --first-parent --format='%ad %ae %s' 2020-01-25 bsalomon@google.com Revert "Revert "Use bitmap subset for comparison in texture_domain_effect GMs."" Created with: gclient setdep -r src/third_party/skia@e0143673111c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I0c8445c260c68baeb11d0ba38cf60443695a05f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021725Reviewed-by:
-
Maksim Sisov authored
Changes: 1) Do not create own host and change widget type to TYPE_WINDOW_FRAMELESS as was suggested by sky@. 2) Do not use DesktopWindowTreeHostObserverX11, but just call widget_->Show() once initialization is complete. That's more than enough to start drawing frames. 3) Move StatusIconButtonLinux under is_desktop_linux includes. Bug: 1043089 Change-Id: I5ec732f0395c7bfe7cf69152ae791d7636f3030d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017331 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
