Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 27 May, 2020 6 commits
    • Tsuyoshi Horo's avatar
      Support history navigation of iframe within a Web Bundle file. · 0c60578a
      Tsuyoshi Horo authored 
      FrameNavigationEntry's |web_bundle_navigation_info_| is used for history
navigations inside a web bundle. But it is set in
NavigationControllerImpl::RendererDidNavigateToNewPage() only when the
navigation type is NAVIGATION_TYPE_NEW_PAGE. It must be updated for
other navigation types. So currently history navigations of iframe
inside web bundle are broken. To fix this problem, this CL changes
NavigationControllerImpl to update the |web_bundle_navigation_info_| of
the FrameNavigationEntry for other navigation types.

And also, this CL changes NavigationRequest::CommitNavigation() not to
pass |web_bundle_handle_| to |render_frame_host_| when the navigation
was not served from a web bundle. This is intended not to keep
the |web_bundle_handle_| in RenderFrameHostImpl when the page is not
served from the web bundle and to make RenderFrameHostImpl::
MaybeCreateWebBundleHandleTracker() checks the parent frame's
|web_bundle_handle_| even after navigating the iframe out of web bundle.
(ex: WebBundleNetworkBrowserTest.IframeOutOfBundleNavigation)

Unfortunately remote iframe navigations can't load pages from parent
frame's web bundle (ex: IframeParentInitiatedOutOfBundleNavigation of
WebBundleFileBrowserTest and WebBundleTrustableFileBrowserTest). We
need to change NavigationControllerImpl::NavigateFromFrameProxy() to
correctly handle the WebBundleHandleTracker. But this CL keeps this
problem as TODO.

Bug: 1040800
Change-Id: Id416155502582e7f075cf7ceeb8dfa1bc2caac1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014625
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772031}
      0c60578a
    • Wez's avatar
      [fuchsia] Only provide //sdk/bundles:tools in cache packages. · 2fb215b1
      Wez authored 
      This fixes local-sdk.py SDK builds to match Fuchsia's 'terminal'
SDK images.

Bug: fuchsia:50751
Change-Id: I49bbd26eb94f438029f62f971ee823eb40e1435b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215329
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772030}
      2fb215b1
    • Mounir Lamouri's avatar
      Picture-in-Picture: move all logic to the PictureInPictureWindowControllerImpl. · 324ae62d
      Mounir Lamouri authored 
      This removes the duality between PictureInPictureServiceImpl and
PictureInPictureWindowControllerImpl that made handling the
PictureInPictureSession object more complicated than it should. Now, the service
is simply a shell passing the requests to the controller which then handles the
current session at the WebContents level.

This CL also introduces a content_browsertest test in order to allow for
integration tests that do not include the //chrome layer. Follow-ups may include
moving some browser_tests to it as they tend to be flaky and they are not
testing the actual UI.

Also adds a check for surface_id being null when the session creation is
requested.

Bug: 1067152, 1069858
FIXES: 1067152, 1069858
Change-Id: I1c389c513cc227e6d0f9d5e447926186600cdc2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197996
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarBecca Hughes <beccahughes@chromium.org>
Reviewed-by: default avatarFrançois Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#772029}
      324ae62d
    • Wez's avatar
      [fuchsia] Distinguish exit-by-signal from normal exit in runner scripts. · d5a923d3
      Wez authored 
      Negative |Popen.returncode| values indicate that the process was
terminated by a signal (e.g. SIGSEGV) under POSIX systems.

Check for -ve |returncode| values and report them with a different
message text, to make it clearer when things are crashing.

Change-Id: I84a3e30d5babea9d630347e10fbd5b21df5f0706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213539
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772028}
      d5a923d3
    • Haoyue Wang's avatar
      Roll src/net/third_party/quiche/src/ 8aff71f6f..517beaa47 (5 commits) · 4ae1ea63
      Haoyue Wang authored 
          https://quiche.googlesource.com/quiche.git/+log/8aff71f6f3e1..517beaa4782d

    $ git log 8aff71f6f..517beaa47 --date=short --no-merges --format='%ad %ae %s'
    2020-05-26 ianswett Check has_handshake in quicpacketcreator::consumedata rather than delegate to shouldgeneratepacket.  no functional change, not flag protected.
    2020-05-26 quiche-dev Fix errors found by Clang warning -Wdangling-gsl
    2020-05-25 ianswett Add a new 'b2hi' connection option which limits the reduction of inflight_hi based on cwnd instead of target inflight.  protected by gfe2_reloadable_flag_quic_bbr2_limit_inflight_hi.
    2020-05-22 wub In quic loss detection tuner, do not give feedback if a connection 1) has no packets lost, 2) would still have no packets lost if the reordering_shift increased by one. protected by existing flag --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe.
    2020-05-21 dschinazi Rename some transport parameters

    Created with:
      roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Roll src/net/third_party/quiche/src/ 8aff71f6f..517beaa47 (5 commits)

https://quiche.googlesource.com/quiche.git/+log/8aff71f6f3e1..517beaa4782d

$ git log 8aff71f6f..517beaa47 --date=short --no-merges --format='%ad %ae %s'
2020-05-26 ianswett Check has_handshake in quicpacketcreator::consumedata rather than delegate to shouldgeneratepacket.  no functional change, not flag protected.
2020-05-26 quiche-dev Fix errors found by Clang warning -Wdangling-gsl
2020-05-25 ianswett Add a new 'b2hi' connection option which limits the reduction of inflight_hi based on cwnd instead of target inflight.  protected by gfe2_reloadable_flag_quic_bbr2_limit_inflight_hi.
2020-05-22 wub In quic loss detection tuner, do not give feedback if a connection 1) has no packets lost, 2) would still have no packets lost if the reordering_shift increased by one. protected by existing flag --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe.
2020-05-21 dschinazi Rename some transport parameters

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I4ea2e5add772e4c619f8acf87d197e96862163a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216638Reviewed-by: default avatarDavid Schinazi <dschinazi@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Haoyue Wang <haoyuewang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772027}
      4ae1ea63
    • Mounir Lamouri's avatar
      Remove flag to enable native controls for Chrome OS video player. · ab4c1e67
      Mounir Lamouri authored 
      The flag is now enabled by default.

Bug: None
Change-Id: Iab273e0d44c0e511c9e2efd1dfaa37d9dafa5a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018089
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772026}
      ab4c1e67
  3. 26 May, 2020 34 commits