GitLab

Fix gl version info check used to control texture internal
format substitutions so that it does the right thing on
ChromeOS.  Without this substitution we'd hit a Mesa bug
that prevents mipmapping from working when the internal
format is GL_BGRA

BUG=540761
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2164723003
Cr-Commit-Position: refs/heads/master@{#406924}

Changes the lines to go from always 2 to at most 2 by default, so that
we don't show empty lines on very large screens.
For smaller screens, the title can go up to 4 lines, and we then hide
the description.
On bigger screens, we add space on the side of the cards

Measures used:
< 360dp: Narrow -> 4 lines title
>= 360dp: Regular -> 2 + 2 lines
>= 600dp: Wide -> 2 + 2 lines, 48dp gutters around the cards

Preview: https://goo.gl/photos/prJ42tvP4jzwiCn3A
BUG=625628, 624333

Review-Url: https://codereview.chromium.org/2149333003
Cr-Commit-Position: refs/heads/master@{#406923}

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2122243002
Cr-Commit-Position: refs/heads/master@{#406922}

This test method was assuming that the output from NSReadPixel was in
deviceRGBColorSpace, which is not necessarily true in macOS Sierra.

BUG=629706

Review-Url: https://codereview.chromium.org/2169633004
Cr-Commit-Position: refs/heads/master@{#406921}

It will be the future home of the JavaScript dialog tab helper code, which will not be app-modal, so the name is no longer appropriate for use.

In addition, I'm the owner of the existing dialog code (components/app_modal) so I'm going to claim ownership of the new code.

BUG=629964
TEST=none

Review-Url: https://codereview.chromium.org/2169593003
Cr-Commit-Position: refs/heads/master@{#406920}

These were being defaulted to BT.709, but the colorspace is actually
identical to BT.601. See http://avisynth.nl/index.php/Colorimetry

BUG=621325

Review-Url: https://codereview.chromium.org/2165043003
Cr-Commit-Position: refs/heads/master@{#406919}

The Ozone X11 platform implements a more complete X11 backend for Ozone
and egltest is unused at this point. Delete the egltest code and all the
accompanying parts of GYP and GN build files.

BUG=none

Review-Url: https://codereview.chromium.org/2167243002
Cr-Commit-Position: refs/heads/master@{#406918}

This flips most (but not all) of the remaining Mac GYP builders
to GN:

- chromium.fyi
  - Chromium Mac 10.10 MacViews
  - Chromium Mac 10.11
  - Chromium Mac 10.11 Force Mac Toolchain
  - Chromium Mac 10.9 Goma Canary
  - Chromium Mac 10.9 Goma Canary (clobber)
  - Chromium Mac 10.9 Goma Canary (dbg)
  - Chromium Mac 10.9 Goma Canary (dbg)(clobber)
  - ClangToTMac
  - ClangToTMac (dbg)
- tryserver.chromium.mac:
  - mac_chromium_10.10_macviews

There are still some GYP builders on chromium.perf and chromium.lkgr,
but this CL is big enough as-is.

R=rsesek@chromium.org
BUG=618468

Review-Url: https://codereview.chromium.org/2169683002
Cr-Commit-Position: refs/heads/master@{#406917}

The finch experiment hasn't revealed any regressions other than in page
load times which has been deemed a blink scheduler issue (see
crbug.com/614482).

R=piman@chromium.org,rkaplow@chromium.org
BUG=612596

Review-Url: https://codereview.chromium.org/2159103008
Cr-Commit-Position: refs/heads/master@{#406916}

They're already being applied by the [actionable] attribute from
settings-shared.

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2168633003
Cr-Commit-Position: refs/heads/master@{#406915}

Right now in this method, it does a size.width() * size.height(), and
that could cause integer overflow.

This CL fix that by using CheckedNumeric<int>.

BUG=630024

Review-Url: https://codereview.chromium.org/2170693003
Cr-Commit-Position: refs/heads/master@{#406914}

BUG=629932

Review-Url: https://codereview.chromium.org/2171813002
Cr-Commit-Position: refs/heads/master@{#406913}

More work to shrink gn's chrome.dll

The three largest globals that were present in gn's chrome.dll but not in gyp's chrome.dll were eliminated by using /verbose linker output to track the object files that pulled them in and then conditionally changing source_set targets to static_library targets. Specifically:

unigram_table, in compact_enc_det.obj
- Referenced by TextResourceDecoder.obj from //third_party/WebKit/Source/core:html - some other source_set targets in this file were also modified

gpu::ApplyFramebufferAttachmentCMAAINTELResourceManager::cmaa_frag_s1_ and cmaa_frag_s2_, in gles2_cmd_apply_framebuffer_attachment_cmaa_intel.obj from //gpu/command_buffer/service:service_sources
- Referenced by gpu_command_buffer_stub.obj from //gpu/ipc/service:ipc_service_sources
- Referenced by gpu_video_decode_accelerator.obj from //media/gpu/ipc/service:service
- Referenced by gpu_child_thread.obj from //content/gpu:gpu_sources
- Referenced by gpu_video_decode_accelerator_factory.obj from //content/public/gpu:gpu_sources

As of R406709 this shrinks gn's 32-bit official chrome.dll file size from 38,907,904 bytes to 37,571,584 bytes - an unexpected 1,336,320 byte savings, mostly from the .text section. There is also ~67,000 bytes of memory-only savings in the zero-init part of the .data section.

At the same revision gyp's 32-bit official chrome.dll file size is 37,843,456 bytes - 271,872 bytes *larger* than the gn version.

There are still globals that are present in gn's chrome.dll but not gyp's chrome.dll, so the optimization technique can still be applied some more, but the priority is much lower now that gn is winning.

This is a follow-on to crrev.com/2163823002.

BUG=624274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2163933003
Cr-Commit-Position: refs/heads/master@{#406912}

Review-Url: https://codereview.chromium.org/2165913005
Cr-Commit-Position: refs/heads/master@{#406911}

Macros can be used in various namespace contexts, and macros that expand
to "logging::Something" can end up choosing some_namespace::logging
if used in a context wher ethere exists a nested namespace logging with
a conflicting name like LogMessage. It's fixable by using "::logging::"
instead of "logging::" in the macros.

No examples of such issues in chrome, but this can help downstream and
seems a good thing to do consistently.

BUG=

Review-Url: https://codereview.chromium.org/2045203004
Cr-Commit-Position: refs/heads/master@{#406910}

An include_dir setup for gmock in //ui/event/BUILD.gn is unused, and
that prevents to add another include dir to gmock dependencies.
This CL removes it for the preparation.

BUG=630299

Review-Url: https://codereview.chromium.org/2171793002
Cr-Commit-Position: refs/heads/master@{#406909}

WebViewPlugin resizes itself and actually may load a new plugin in
response to a geometry update.

Geometry updates are triggered during layout, and Blink assumes these
things can't happen during layout.

Therefore, post these actions to a task to run asynchronously. This is
the same approach that PepperPluginInstanceImpl takes.

BUG=628629

Review-Url: https://codereview.chromium.org/2164753003
Cr-Commit-Position: refs/heads/master@{#406908}

The flags /d2fastfail and /fastfail are not supported by
msvs version 2013, which is still used by V8.

BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2166253002
Cr-Commit-Position: refs/heads/master@{#406907}

This makes sure the error icon is the circle with an exclamation point on both the app menu button and any error menu items within the menu itself.

BUG=629204

Review-Url: https://codereview.chromium.org/2166853002
Cr-Commit-Position: refs/heads/master@{#406906}

BUG=None

Review-Url: https://codereview.chromium.org/2166663003
Cr-Commit-Position: refs/heads/master@{#406905}

The mouse pointer should change to indicate that you can click on the
swatch.

R=lushnikov

Review-Url: https://codereview.chromium.org/2159253006
Cr-Commit-Position: refs/heads/master@{#406904}

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2168753002
Cr-Commit-Position: refs/heads/master@{#406903}

- add window title
- add padding/adjust preview resizing algorithm
- add about:flags entry

BUG=626111
TBR=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2164803003
Cr-Commit-Position: refs/heads/master@{#406902}

This was fixed in r406861.

BUG=585194
TEST=webkit_tests on Site Isolation Linux FYI bot

Review-Url: https://codereview.chromium.org/2168763003
Cr-Commit-Position: refs/heads/master@{#406901}

The removal of the API missed the removal of these features. Removing
them now.

R=rdevlin.cronin@chromium.org
BUG=496900

Review-Url: https://codereview.chromium.org/2168583003
Cr-Commit-Position: refs/heads/master@{#406900}

iOS Autofill uses the different AutofillClientIOS

BUG=626383

Review-Url: https://codereview.chromium.org/2167233002
Cr-Commit-Position: refs/heads/master@{#406899}

https://chromium.googlesource.com/skia.git/+log/0ae097d116f4..b5dc4051f722

$ git log 0ae097d11..b5dc4051f --date=short --no-merges --format='%ad %ae %s'
2016-07-21 caryclark add pathops debugging to fuzz
2016-07-21 lsalzman limit the number of points in SkDashPathEffect::asPoints
2016-07-21 robertphillips Remove SkGrPixelRef
2016-07-21 egdaniel Add vulkan compile bot to CQ
2016-07-21 vjiaoblack Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ )
2016-07-21 robertphillips Remove DrawFace enum from GrPipelineBuilder

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2169953002
Cr-Commit-Position: refs/heads/master@{#406898}

This API change allows the MRPM to pass a Promise to the MR that represents the
outcome of a call to terminateRoute().  The result is logged in a new histogram, MediaRouter.Provider.TerminateRoute.Result.

The change is designed to be backwards compatible with MRPM versions that do not return a Promise.

The MRPM side change will be done next.

BUG=627967

Review-Url: https://codereview.chromium.org/2145983003
Cr-Commit-Position: refs/heads/master@{#406897}

R=tommycli@chromium.org
BUG=630067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2163883009
Cr-Commit-Position: refs/heads/master@{#406896}

For the Ash material design battery icon seen in
the system tray, change the |is_opaque| argument
to false when initializing its canvas. This will
force a clear and prevents unwanted artifacts
from appearing over top of / underneath the icon.

BUG=626917
TEST=manual

Review-Url: https://codereview.chromium.org/2169843003
Cr-Commit-Position: refs/heads/master@{#406895}

It brings in these changes:
  e283e47 Convert source sets to static libraries.
  8b30162 Bring pdfium file in sync with chrome, fix mac build
  3b6c7e9 Move CPDF_Annot and CPDF_AnnotList to their own header.
  cc8ae2f Pass CPDF_Document instead of CPDF_AnnotList when constructing CPDF_Annot.
  69f160d Move CSSRuleCollection class to its own file
  47228ac Clean up singleton implementation
  31f8740 Rename remaining xfa_script_* files.
  c1515ef Rename the CScript_* files to match class names.
  8ca60b2 Use smart pointers for various Jbig2 decoding contexts
  5b36f0a Split xfa_object_imp into individual class files.

BUG=627637
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2166413002
Cr-Commit-Position: refs/heads/master@{#406894}

It is valid to submit a RenderPass with an empty
|shared_quad_state_list|. We need to deal with this case so that we
don't otherwise take size() - 1, which causes a negative integer overflow.

BUG=626771
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2170603002
Cr-Commit-Position: refs/heads/master@{#406893}

BUG=586380
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2168893003
Cr-Commit-Position: refs/heads/master@{#406892}

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168

Review-Url: https://codereview.chromium.org/2170463002
Cr-Commit-Position: refs/heads/master@{#406891}

This cleanup CL does the following:
* Use dom-repeat to only include sections for existing device types.
* Use dom-if instead of display to show items with infrequent
  visibility changes.
* Minor layout / CSS cleanup.

BUG=609156,609002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2167473002
Cr-Commit-Position: refs/heads/master@{#406890}

Tests used to be there until
https://codereview.chromium.org/2086483004/, where they were
removed (since they weren't testing the right thing), to be re-added
later.

These tests don't run on the UI thread, and check that the prerender
actually starts and complete.

BUG=621919

Review-Url: https://codereview.chromium.org/2157033002
Cr-Commit-Position: refs/heads/master@{#406889}

Now that we have early trace events, remove the only instance of
android.os.Trace in Chrome.

Review-Url: https://codereview.chromium.org/2164483007
Cr-Commit-Position: refs/heads/master@{#406888}

Unused variables were found via pylint.

There are a few types of circumstances where we have unused variables,
so there are a few types of transformations:

 1. variables that are simply unused, e.g.
    a = f()  =>  <delete>

 2. functions that return tuples but only some arguments are used, e.g.
    a, b = f()  =>  a, _ = f()

 3. functions that have side effects and also a return value, e.g.
    a = do_something()  =>  do_something()

 4. exception variables that are unused
    except Exception as e:  =>  except Exception:

Review-Url: https://codereview.chromium.org/2136793002
Cr-Commit-Position: refs/heads/master@{#406887}

Revert of H264 HW encode using MediaFoundation (patchset #11 id:420001 of https://codereview.chromium.org/2058413003/ )

Reason for revert:
Build break:

https://bugs.chromium.org/p/chromium/issues/detail?id=630335

Original issue's description:
> H264 HW encode using MediaFoundation
>
> This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
> using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
> MediaFoundation classes under mf_helpers.*.
>
> Note that, this is the first CL and H264 codec is still behind a flag.
>
> Design Doc(with perf measurements): http://goo.gl/UCnwyA
>
> BUG=590060
> TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
> "--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
> Also, added WIN specific sections at vea_unittests.
>
> Committed: https://crrev.com/e75bb4429ddcf2e79ae678a544064069718ee7a0
> Cr-Commit-Position: refs/heads/master@{#406876}

TBR=ananta@chromium.org,posciak@chromium.org,wuchengli@chromium.org,sandersd@chromium.org,grt@chromium.org,avi@chromium.org,emircan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590060

Review-Url: https://codereview.chromium.org/2172703002
Cr-Commit-Position: refs/heads/master@{#406886}

Revert of Redirect users without sync passphrase to passwords.google.com (patchset #50 id:980001 of https://codereview.chromium.org/2092723002/ )

Reason for revert:
The tests are checking their expectations on the wrong thread.

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35372/steps/chrome_public_test_apk/logs/stdio

I  703.521s run_tests_on_device(0ca41989032f9f23)    java.lang.AssertionError
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.base.ThreadUtils.assertOnUiThread(ThreadUtils.java:192)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.chrome.browser.sync.ProfileSyncService.get(ProfileSyncService.java:104)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.chrome.browser.preferences.PasswordViewingTypeTest.testUserRedirectSyncSettings(PasswordViewingTypeTest.java:133)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at java.lang.reflect.Method.invokeNative(Native Method)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  703.521s run_tests_on_device(0ca41989032f9f23)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Original issue's description:
> Redirect syncing users without sync passphrase to passwords.google.com
>
> This CL redirects syncing users without a sync passphrase to https://passwords.google.com instead of natively displaying passwords. The changes created in this CL are hidden behind the ViewPasswords feature.
>
> BUG=623488
>
> Committed: https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8
> Cr-Commit-Position: refs/heads/master@{#406823}

TBR=vabr@chromium.org,bauerb@chromium.org,dozsa@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623488

Review-Url: https://codereview.chromium.org/2165333002
Cr-Commit-Position: refs/heads/master@{#406885}