- 16 Aug, 2018 40 commits
-
-
Tommy Steimel authored
This CL adds a check in MediaControlOverlayPlayButtonElement that prevents a call to ComputedStyleRef is ComputedStyle is null. This prevents a crash we're seeing in certain cases on Windows and Mac. Bug: 870490 Change-Id: Ia45a7239084b267ce8a352fc0a825b5c992c5eea Reviewed-on: https://chromium-review.googlesource.com/1173471Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583523}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/190ff372dacb..cadf57874526 git log 190ff372dacb..cadf57874526 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 dschuff@chromium.org Remove perf_test_compat_osx Created with: gclient setdep -r src/native_client@cadf57874526 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: Ie859966e762964953539565e985e5b2c484d0e38 Reviewed-on: https://chromium-review.googlesource.com/1176981Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583522}
-
Becca Hughes authored
This implements slide 13 of the spec attached to the bug on the site details page. When we enable the new unified autoplay sound settings UI the sound settings dropdown on the site details UI should have custom wording based on the state of the sound content setting and the unified autoplay enabled pref. BUG=865548 Change-Id: Id52b7cb9d1fdf06236a0094621fea9c46569cf34 Reviewed-on: https://chromium-review.googlesource.com/1160873 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583521}
-
Joey Scarr authored
These are no longer needed. The CS builder recipe is still passing in a phase argument, but I'm removing that in a separate CL (crrev.com/c/1173943) which I'll submit at the same time. Bug: 833672 Change-Id: I9b273116cc8639116d01b124b7fe3749bda2a8f3 Reviewed-on: https://chromium-review.googlesource.com/1173941Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#583520}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4197b9e8ad3472ff4f6580dba76821c95e2aff1b Reviewed-on: https://chromium-review.googlesource.com/1176634Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583519}
-
Eric Orth authored
Everything in the struct should have a reasonable default value and the struct param itself is optional. Added DNS qtype and initial priority parameters. Qtype uses a new mojo enum with mojo EnumTraits to convert to and from the net::HostResolver enum. RequestPriority already has a mojoified version in the network service. Also moved the control handle parameter to the new struct as it is an optional parameter. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1b1b9e6d77d23216b210b56885b426bc2b710155 Reviewed-on: https://chromium-review.googlesource.com/1173337 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583518}
-
Jun Choi authored
For all successful WebAuthN API transactions, notify observers of FidoRequestHandler, then AuthenticatorRequestClientDelegate of which transport protocol was used to talk to the authenticator that was used to service the request. This will be saved as Chromium preference, and used to infer which transport type to default to when user invokes WebAuthN API again. Bug: 847985 Change-Id: I9ecf27209ec959d740664e34fe088a2e4499e982 Reviewed-on: https://chromium-review.googlesource.com/1175500 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583517}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c1551dc2a7dc..156da4c911ba git log c1551dc2a7dc..156da4c911ba --date=short --no-merges --format='%ad %ae %s' 2018-08-16 jie.a.chen@intel.com ParallelCompile: Make resource tracking thread-safe Created with: gclient setdep -r src/third_party/angle@156da4c911ba The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie3614915790b75855a61ed17c590dc73015e23d6 Reviewed-on: https://chromium-review.googlesource.com/1176684Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583516}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5c9b9cb65208..f5981fb3c2b0 git log 5c9b9cb65208..f5981fb3c2b0 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 simonhatch@chromium.org Enable LUCI mac tryserver. Created with: gclient setdep -r src/third_party/catapult@f5981fb3c2b0 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825435 TBR=sullivan@chromium.org Change-Id: I8bec13a3fc1e923eb725038e83cf20bf11a978f9 Reviewed-on: https://chromium-review.googlesource.com/1176602Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583515}
-
Michael Giuffrida authored
This will allow apps whitelisted for this API (ie the Highlights app for Demo Mode) to use this API in M70 stable. Bug: 819404 Change-Id: I068684b743da01b928b2f25c326ef6166806473e Reviewed-on: https://chromium-review.googlesource.com/1176703Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583514}
-
Steven Bennetts authored
Bug: 872905 Change-Id: I86cedf0cb9eedf8d32f7385eba3a3c85b42a35a8 Reviewed-on: https://chromium-review.googlesource.com/1176430Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583513}
-
Azeem Arshad authored
This adds a CrosSmsService, a profile keyed service that manages connection and pairing for ChromeOS Android Messages for Web integration. This also includes a basic ConnectionManager class that's listens for service worker events and establishes connection. Message passing between service worker and connection manager will be included in a follow up CL. Design docs: go/awm-cros-service go/awm-cros Bug: 850823 Change-Id: I792fbdad6aff6bc9391e4b0055e8e84a36bbd56e Reviewed-on: https://chromium-review.googlesource.com/1140902 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#583512}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/48ae3075a5c8..3e360453cded git log 48ae3075a5c8..3e360453cded --date=short --no-merges --format='%ad %ae %s' 2018-08-15 tsepez@chromium.org Remove optional prepend argument from matrix transformations. 2018-08-15 tsepez@chromium.org Make CPDF_RenderStatus::Initialize() saner. Created with: gclient setdep -r src/third_party/pdfium@3e360453cded The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1e5460b3ab01e04f84e07dba5f54c92b3adf5781 Reviewed-on: https://chromium-review.googlesource.com/1176683Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583511}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/18683981505d..f7b0e1d901da $ git log 186839815..f7b0e1d90 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 costan Expose WriteBatch::Append(). 2018-06-04 costan Clean up Iterator. 2018-05-21 cmumford Corrected typo in docs: "cache" to "block_cache". Created with: roll-dep src/third_party/leveldatabase/src Bug: 862456 Change-Id: I8c618f5311d0f13fc59449be3c228b4aa63403ef Reviewed-on: https://chromium-review.googlesource.com/1174981 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#583510}
-
Giovanni Ortuño Urquidi authored
Adds a helper method to initialize a PendingBookmarkAppManager with test factories. Bug: 864904 Change-Id: Ibdaaa1d43455f19979db3cd29429844b8c661598 Reviewed-on: https://chromium-review.googlesource.com/1176881Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#583509}
-
Fady Samuel authored
This reverts commit f1a9e88d. Reason for revert: crbug.com/868605 Original change's description: > Surface Synchronization: Only defer commits if frame exists > > Right now, with surface sync off on Android, we will defer commits > any time there's a size change, even if we've evicted the current > surface. > > Change-Id: I7e1ae394e20eef2a46bca5ae9a8fc8a4cdf35e0b > Bug: 848292, 672962 > Reviewed-on: https://chromium-review.googlesource.com/1121098 > Reviewed-by: Saman Sami <samans@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575405} TBR=fsamuel@chromium.org,khushalsagar@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848292, 672962 Change-Id: Ie558844df649cea7f3560f61d7077907e73e20a9 Reviewed-on: https://chromium-review.googlesource.com/1176761Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583508}
-
Michael Giuffrida authored
Bug: 819404 Change-Id: Id1b14834ca3950359139e7ec3b11eb27fea65257 Reviewed-on: https://chromium-review.googlesource.com/1174960Reviewed-by:
-
Adam Langley authored
This matches the name in the spec[1]. However, I note that these strings might be saved in preferences now, so we might be too late here. If so, we can always create another enum for this. [1] https://w3c.github.io/webauthn/#enumdef-authenticatortransport Change-Id: Id74e1d62a72d85b0bd96c0996d4a804de5911531 Reviewed-on: https://chromium-review.googlesource.com/1176781Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#583506}
-
Eric Karl authored
Currently VR pauses/unpuases VSync during certain transitions. These calls work when the Browser's AndroidWindow is the VSync provider, but not when using a remote GPU proc VSync provider. Forward these signals to the GPU process. TBR=yfriedman for really uninteresting test-code update. Bug: 871774 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic47cb14fdf702e294db90b5ad69b8cdfb5c67403 Reviewed-on: https://chromium-review.googlesource.com/1175198Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583505}
-
Fernando Serboncini authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/21dbf06..7ca87fb TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I53d5e93d572b2b89105cce330c6d79e26caff1f3 Reviewed-on: https://chromium-review.googlesource.com/1169959 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583504}
-
yucliu authored
"dont_load_shared_libraries" is used by Cast internal build. Add it to forward list. BUG=None TEST=CQ Change-Id: I7e056a163ecf5efd2d456e4479f3bb4f82ec89ea Reviewed-on: https://chromium-review.googlesource.com/1176359Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#583503}
-
Hiroki Nakagawa authored
This reverts commit 8e335edf. Reason for revert: Speculative revert for test failures on mac bots: https://chromium-review.googlesource.com/c/chromium/src/+/1175051 I'll reland this if this is not relevant. Original change's description: > RemoteMacViews: Move DialogObserver to browser side > > Move these from BridgedNativeWidget to BridgedNativeWidgetHostImpl. > > Also move window BridgedNativeWidget::OnWindowWillClose callbacks > from directly referencing NativeWidgetHost to going through the > BridgedNativeWidgetHost interface (since they are responsible for > removing BridgedNativeWidgetHostImpl as an observer now). > > Separate out the interface that to BridgedNativeWidget that will be > turned into a mojo interface and name it BridgedNativeWidgetPublic. > These will be renamed to BridgedNativeWidgetImpl and > BridgedNativeWidget in a search-and-replace patch soon. > > Change-Id: I523aa8b3670b9432bde434af77ffd0e18a50f00e > Reviewed-on: https://chromium-review.googlesource.com/1175238 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583383} TBR=ellyjones@chromium.org,ccameron@chromium.org Change-Id: Ib4156fee617d8b80238a575e5d5524285a2a856e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1177021Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#583502}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba883cb5ed14..421bc3f84d1b git log ba883cb5ed14..421bc3f84d1b --date=short --no-merges --format='%ad %ae %s' 2018-08-16 tandrii@chromium.org Deploy git 2.18 to prod win depot_tools users. 2018-08-16 tandrii@chromium.org Register expect_tests in gclient config. 2018-08-15 rsesek@chromium.org Clarify OWNERS error if using TBR. 2018-08-15 vadimsh@chromium.org Revert "[cipd] Check CIPD client hash against pinned SHA256 during updates." 2018-08-15 jbudorick@chromium.org Grant everyone owners on README.recipes.md. Created with: gclient setdep -r src/third_party/depot_tools@421bc3f84d1b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851505,chromium:870166 TBR=agable@chromium.org Change-Id: I110a7cde5025f046174287878daebf69c48a7286 Reviewed-on: https://chromium-review.googlesource.com/1176682Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583501}
-
Jesse Selover authored
This CL handles the cases where there's no behavior change (i.e. the caller set all three load flags). Bug: 799935 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9953b8ffe907f77c3a962286b55a3e05d1d41a3a Reviewed-on: https://chromium-review.googlesource.com/1153462Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Jesse Selover <jselover@chromium.org> Cr-Commit-Position: refs/heads/master@{#583500}
-
Xiaocheng Hu authored
NGInlineFragmentTraversal::SelfFragmentsOf() traverses the entire inline formatting context's fragment tree to find fragments of a certain layout object, which is basically unnecessary since we can locate the paint fragments directly. The only exception is culled inline, where the layout object doesn't have its own fragments, in which case we still need to traverse the fragment tree. As performance optimization, this patch changes SelfFragmentsOf() to find paint fragments directly, unless the given layout object can be a culled inline. With this patch, the time spent on SelfFragmentsOf() when rendering the single-page HTML5 spec becomes negligible. Bug: 873798 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id4a9e5a8a8e416e9757916e5ae9cf589c4660688 Reviewed-on: https://chromium-review.googlesource.com/1173725 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583499}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70284b596877..eb7c6084242a git log 70284b596877..eb7c6084242a --date=short --no-merges --format='%ad %ae %s' 2018-08-15 dgarrett@google.com COMMIT-QUEUE.ini: Add cbuildbot-launch-pre-cq 2018-08-15 dgarrett@google.com prototype-firmwarebranch: Publish ebuild uprevs. 2018-08-15 vapier@chromium.org run_tests: relocate & create toplevel wrapper 2018-08-15 chrome-bot@chromium.org Update config settings by config-updater. 2018-08-15 dhanyaganesh@chromium.org CQ: Remove subsytem-based logic Created with: gclient setdep -r src/third_party/chromite@eb7c6084242a The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I130f0c040a2143c953f79c79dd3e36e0924a6438 Reviewed-on: https://chromium-review.googlesource.com/1176681Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583498}
-
Istiaque Ahmed authored
Bug: None Change-Id: Icdd29a8ee9fd005369bba60304ba4d9ea42643f8 Reviewed-on: https://chromium-review.googlesource.com/1176821Reviewed-by:
-
Andrew Grieve authored
It was using a hardcoded MAX_SYMBOLS. It now will keep adding symbols until 95% of the size is attributed. This increases the size of ndjson files for a monochrome .size file, but should reduce the size of diffs. Change-Id: I56146b20af43b0a47209943ea03bce98d562281f Reviewed-on: https://chromium-review.googlesource.com/1176177 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#583496}
-
Oriol Brufau authored
Otherwise, changes in CSSProperties.json5 may fail to invalidate parts of the build. That's why https://crrev.com/572990 had to be reverted. BUG=860761 Change-Id: I465fb8fa0970b908da2c2edd6d90efa20fe38b2b Reviewed-on: https://chromium-review.googlesource.com/1143761Reviewed-by:
-
Chase Phillips authored
Part 1 in moving the IDB Mojo file from content/common/indexed_db/ to third_party/blink/public/mojom/indexeddb/indexeddb.mojom. This commit: - adds the indexeddb.mojom file - puts the new mojom in the blink mojom namespace - updates all files that include the indexed_db.mojom.h header to include the new indexeddb.mojom.h as well - moves web_idb_types.h to blink/public/common/indexeddb/ This commit converts Chromium to the following Mojom types: - indexed_db.mojom.BlobInfo -> blink.mojom.IDBBlobInfo - indexed_db.mojom.FileInfo -> blink.mojom.IDBFileInfo - indexed_db.mojom.Value -> blink.mojom.IDBValue - indexed_db.mojom.ObserverTransaction -> blink.mojom.IDBObserverTransaction - indexed_db.mojom.OperationType -> blink.mojom.IDBOperationType - indexed_db.mojom.CursorDirection -> blink.mojom.IDBCursorDirection - indexed_db.mojom.DataLoss -> blink.mojom.IDBDataLoss - indexed_db.mojom.DatalessKeyType -> blink.mojom.IDBDatalessKeyType - indexed_db.mojom.KeyData -> blink.mojom.IDBKeyData - indexed_db.mojom.Key -> blink.mojom.IDBKey Bug: 717812 Change-Id: I8255e69a24c59a11fa68d173ce5bb31c2b7f51a0 Reviewed-on: https://chromium-review.googlesource.com/1173713Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#583494}
-
Xiaohui Chen authored
Bug: b:112281423 Test: locally build and run Change-Id: I6fc9fe7c462be053a54b48c8a6ffdc23e565bb83 Reviewed-on: https://chromium-review.googlesource.com/1173533 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583493}
-
Takumi Fujimoto authored
In a future CL, we will be removing the "Cast" button in the dialog and enabling the user to start casting just by clicking on a sink. This CL is in preparation for that. Currently, the source list only shows sources supported by the currently selected sink. This CL makes the list show all the sources. When a source is selected, we disable buttons for sinks that do not support the source. The visual design for disabled sinks is TBD; the icon/text are greyed out for now. Bug: 872509 Change-Id: I5ba719d08dd85e2b8915da22d0a2b22988b4f384 Reviewed-on: https://chromium-review.googlesource.com/1166341 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#583492}
-
Andrew Grieve authored
This should greatly reduce the amount of output generated when one alias is added/removed from a large alias group. It also simplifies Sorted(), so that it really just sorts by pss and doesn't put bss & padding-only symbols at the bottom. I think this is fine for now, and if we still find that these symbols are confusing people, we could change the diff command to explicitly print bss & padding symbols after the main list of them (via multiple Print() statements) Change-Id: I23db60de6cffa6bf8a9399cb30e46cf5d92ad0f6 Reviewed-on: https://chromium-review.googlesource.com/1176167 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/96088f46727b..190ff372dacb git log 96088f46727b..190ff372dacb --date=short --no-merges --format='%ad %ae %s' 2018-08-15 dschuff@chromium.org Don't run builds through runtest.py Created with: gclient setdep -r src/native_client@190ff372dacb The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: If34fb2a196f9399685923f3e4bc3b253a6f4efc4 Reviewed-on: https://chromium-review.googlesource.com/1176243Reviewed-by:
-
Rakina Zata Amni authored
This reverts commit fc0e1eac and adds a new function FindRequestManager::ShouldIgnoreReply. Previously the original CL wrongly removed a check to ignore stale Find replies (first part of FindRequestManager::OnFindReply). This makes some tests like FindInPageTest.CtrlEnter and SavePageOriginalVsSavedComparisonTest to become flaky. They fail when the stale replies arrives when the test hasn't ended yet. I returned the check in the form of a new function, FindRequestManager::ShouldIgnoreReply which is called by FindInPageClient::SetNumberOfMatches and FindInPageClient::SetActiveMatch. I've confirmed locally that the tests aren't flaky anymore by running them 50+ times. TBR=dcheng@chromium.org,yosin@chromium.org Bug: 819919 Change-Id: I4482a5961854ce7b3477623f204fa93c0bd79a0c Reviewed-on: https://chromium-review.googlesource.com/1174207 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583489}
-
Mike Wasserman authored
Use event.location() + ScreenPosition client in FindTargetInRootWindow: - location() is in |root_window| coordinates for the ws and clients - root_location() is *not* in |root_window| coordinates for clients: - |root_window| is the client-root (the top-level client app window) - root_location() is Ash's display-root coords (full display bounds) Add a WindowTreeTest for event locations and root locations. Add a WindowTargeterTest for FindTargetInRootWindow and regressions. Bug: 873763, 793916 Test: KSV (Ctrl-Alt-/), Arc, Mash, 2nd display, etc. touch input works. Change-Id: I7ae541203181f9fc5c65449a10ca927f90d29d96 Reviewed-on: https://chromium-review.googlesource.com/1176462 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This reverts commit cfe635ce. Reason for revert: This breaks ARC++ (App and CTS/GTS). See detail in crbug.com/874074 Original change's description: > media/gpu shared memory: update v4l2 UnalignedSharedMemory > > Uses the new WritableUnalignedMapping class, which changes the ownership > semantics. See the bug for details on the overall plan. > > Bug: 849207 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Idacc45e249291bd9d42ff7bf9a8abffe8636f6cf > Reviewed-on: https://chromium-review.googlesource.com/1117692 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Alexandr Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582270} TBR=dcastagna@chromium.org,mattcary@chromium.org,alexilin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 849207 Change-Id: I1fdf459f8b480da412854d0a86ece9a0ac86a1c8 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1176841Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583487}
-
Nico Weber authored
The test no longer makes sense after https://chromium-review.googlesource.com/c/chromium/src/+/1167913 Bug: 584880,587694 Change-Id: Idf6aab122079da6436c972ee694aab9414a626ac Reviewed-on: https://chromium-review.googlesource.com/1176444Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583486}
-
Marijn Kruisselbrink authored
This source_set target should not depend on mojom_core, as that pulls in the .cc files of the blink mojom bindings in addition to the header files, which can result in duplicate symbols and weird linking errors. Instead depend on mojom_core_headers. Bug: 717812 Change-Id: I4a359cfc1592f2557717b31966bfa8cdda9ed812 Reviewed-on: https://chromium-review.googlesource.com/1176070 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#583485}
-
Wei-Yin Chen (陳威尹) authored
This reverts the change of python/plugin_pb2.py in https://chromium.googlesource.com/chromium/dom-distiller/dist/+/bdf359537190956aabf32826bf33a0ff05b574ac. Bug: 874509 Change-Id: I6ad94a0ea2be72192b65b8c7d43edd907a6772e4 Reviewed-on: https://chromium-review.googlesource.com/1176372Reviewed-by:
-
