Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 18 Oct, 2017 5 commits
    • Eugene But's avatar
      Call RecordPageLoadStart from DidStartNavigation WSO callback. · 0c685566
      Eugene But authored 
      Before this CL RecordPageLoadStart was called from deprecated
CRWWebDelegate callbacks:
 - webWillAddPendingURL:transition:
 - webDidUpdateSessionForLoadWithURL:
 
RecordPageLoadStart is called for the following navigations:
 - typed navigation
 - link clicks
 - bookmark 
 - form submission
 - switching user agent type
 
RecordPageLoadStart is NOT called for the following navigations:
 - back forward navigation
 - client redirect
 - reload
 - opening NTP
 - opening a child window and loading URL there
 - preload tabs

Bug: 674991
Change-Id: I70d53f7e18faf8da151ae1dde35037bad124eb09
Reviewed-on: https://chromium-review.googlesource.com/707659
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avatarGregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509614}
      0c685566
    • Vlad Tsyrklevich's avatar
      Split CFI blacklist by CFI mode · e3168df0
      Vlad Tsyrklevich authored 
      Group failing casts and vcalls separately. This ensures the release
build disables CFI checking as narrowly as possible--currently only
CFI-vcall is enabled for release but checking is also disabled for bad-
cast blacklist entries as well.

Bug: 772906
Change-Id: Id8a91d1b01cbf858cf6be4f2b91fe548a521ef83
Reviewed-on: https://chromium-review.googlesource.com/706145Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509613}
      e3168df0
    • Matt Reynolds's avatar
      Allow Chrome on Mac to recognize multiple MFi gamepads · 81f233c1
      Matt Reynolds authored 
      Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated
by the GameController framework. When multiple such devices are
connected at once, Chrome fails to properly distinguish them.

GCController exposes a playerIndex field that defaults to the value
GCControllerPlayerIndexUnset (-1). The application may set this field
to a value between 0 and 3 to signal which LEDs should be lit on the
gamepad. Chrome also uses this field to distinguish gamepads, but does
not set the index to a unique value. This causes the first-connected
gamepad to shadow any other connected gamepads.

This CL ensures each connected MFi gamepad is assigned a unique player
index up to the OS-defined limit of four.

BUG=775270

Change-Id: Iaf038a910df8dc7eb2cee99d4d671a6c9ff6dba0
Reviewed-on: https://chromium-review.googlesource.com/724233
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: default avatarBrandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509612}
      81f233c1
    • James Cook's avatar
      cros: Eliminate ash::TrayItemView::DisableAnimationsForTest · 737ab673
      James Cook authored 
      crrev.com/c/723604 eliminated the only caller of this code from chrome.
The remaining calls are from tests in ash_unittests. AshTestBase
already installs a ui::ScopedAnimationDurationScaleMode::ZERO_DURATION
so the animations were already being skipped in these tests.

Bug: none
Test: ash_unittests
Change-Id: Ie95041cf03bee51b5d2786f03d3799241c75e513
Reviewed-on: https://chromium-review.googlesource.com/724221
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509611}
      737ab673
    • Zhongyi Shi's avatar
      Connection Migration: move QuicStreamFactory::MigrationSessionInner logic · 673f22ef
      Zhongyi Shi authored 
      to QuicChromiumClientSession::Migrate so that we can clean up further to 
move all migration logic to session. 
 

Bug: 775593
Change-Id: Id70c45fe7d0c05ce3fb34084c336e89d48c50500
Reviewed-on: https://chromium-review.googlesource.com/723782
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509610}
      673f22ef
  3. 17 Oct, 2017 35 commits