- 02 Oct, 2019 40 commits
-
-
Peter K. Lee authored
The 1-parameter version of CreateViewController() was deprecated by http://crrev/c/1833788 and is no longer needed or implemented. This is clean up, no functional changes. Bug: None Change-Id: I5459dcbd198333dcc421fc3107d3f075ea68559e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834876Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#702078}
-
Ella Ge authored
The PointerLockOptions was control by the browser side flag. However, to allow enable origin trial, it should be control by the blink-flag. This CL 1. Removes a check on browser side. The code path is still guarded by the blink side flags so it should be safe. 2. Makes the blink-flag be enable but not disable by the browser side flag. (so that it can be turn on from chrome://flags for testing) 3. Add origin_trial_feature_name on the blink flag config and removes the overload of requestPointerLock (Because origin trial disallowed the overloaded method) Bug: 982379 Change-Id: I1156fd3238fdbc2c533ee299c178527f23581eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832292Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#702077}
-
Alex Chau authored
- Added API in SharingSyncPreference to provide/set local and remote SharingInfo - Added GetLocalSharingInfoPrefName to implement SharingInfo pref observer in sync (separate CL) Bug: 991971 Change-Id: If1d4ce6e4b1205a46bdceeb61a4254995d490dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833821 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702076}
-
Adam Ettenberger authored
While investigating opportunities where AXRange<>::{begin|end}() can be improved, I found that AsTreePosition was one of the higher cost methods. This is because it's called many times in order to create an AXRange<>::Iterator. Both AXRange<>::AsForwardRange and the Iterator constructor via AXPosition<>::AsLeafTextPosition call AsTreePosition. The reason it's expensive is because of AXPosition<>::MaxTextOffset. For the scenario I was measuring, this CL reduced the overall amount of time spent in AXRange::begin by ~30-35%, and the overall amount of time spent in AXPosition<>::AsTreePosition by ~50%. I crafted a document where there are many inline nodes that form sentences with various levels of nesting, and used Narrator with UIA enabled to navigate 5 sentences. I used "UI for ETW" to capture perf traces, and WPA to view the data. Before : * Weight for callees of AXRange<>::begin : 7889 * Weight for callees of AXPosition<>::AsTreePosition : 20418 After : * Weight for callees of AXRange<>::begin : 5246 * Weight for callees of AXPosition<>::AsTreePosition : 10298 Bug: 928948 Change-Id: I24be1be302b9e22bc85412f091b5f464274f1dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824064 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702075}
-
Kush Sinha authored
Chrome OS Account Manager has been turned on by default on ToT, and has been launched via Finch for some time now. Clean up its flag's usages in Chrome OS OOBE / Login related code. Bug: 1009960 Change-Id: I1d999d22f515aa562fcdbf38aba11d91e5eeb0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832278 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#702074}
-
Matthew Jones authored
TBR: vasilii@chromium.org, fhorschig@chromium.org Bug: 1010540 Change-Id: Id320d8f63d89f3d078d452fc518f2991aa189506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836031Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#702073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bdb26527d65..deac9a0ff801 Created with: gclient setdep -r src-internal@deac9a0ff801 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I85afb701a912d6d5f8e599afad39c7ca22b6eb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834659Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702072}
-
Omer Katz authored
Concurrent marking relies on incremental marking, so incremental should be enabled whenever concurrent is enabled. Current features framework doesn't allow to enable incremental whenever concurrent is enabled, so instead we check that this condition is satisfied when we initialize the process heap. Bug: 986235 Change-Id: I98e464e8f5c6bea700374144dc529e1721cc6f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805650 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#702071}
-
Eric Roman authored
Add tests and documentation for when net::ProxyConfig::fallback_proxies is not a SOCKS proxy, and which proxy WebSocket URLs map to. Change-Id: I28bd80069fb3e9fa14ed2c3ea71aa1dc164d5f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825724 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#702070}
-
Nicolás Peña Moreno authored
Given that the RecordsManager is now based on LayoutObject and not on the DOMNodeId, there is no need to explicitly consider objects which do not have an Id. This will speed up ShouldWalkObject() a bit. Bug: 999264 Change-Id: I169d30c1a6187bce0e84ec8502e04e1cde9ec9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834271Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702069}
-
Tao Bai authored
Moved the functionality of PageLoadMetricsObserverTestHarness to PageLoadMetricsObserverTester which will be moved components. In following patch, we will have a new TestHarness class in components, it along with TestHarness in Chrome are derived from a wrapper of PageLoadMetrictsObserverTester to share the code as much as possible. This patch also removed PageLoadMetricsObserverTester's dependence on prerender and extension which seem not used by any tests. Bug: 995880 Change-Id: I5a945d880392e87f3eab687f40ba2ae58345e30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832523Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702068}
-
Nina Satragno authored
When resolving a webauthn request, skip the first touch when able if the only authenticator detected will require PIN entry. The touch is skipped when only one authenticator is detected. If the user clicks the back arrow and starts the request over, the touch will not be skipped. The patch changes FidoRequestHandlerBase to wait until all discoveries are ready before signalling transport availability to avoid race conditions, and the StartOver logic to keep the state on the FidoRequestHandler. Bug: 996958 Change-Id: I8c639320b5052675ae3aad7c389bff175b529bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800725 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#702067}
-
Matt Mueller authored
Bug: 1008994 Change-Id: Icd416d5336844cc83f703fde2cc6d5e617653bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830175 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702066}
-
Xiaocheng Hu authored
As discussed offline, this usage is Oilpan-safe. As I had a few other attempts without making it simpler (e.g., without using Member<>), I'll simply remove this TODO. Bug: 825895 Change-Id: Id677e59625d09a9888e98fac853da734d9d83669 NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832528Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#702065}
-
Anthony Vallee-Dubois authored
This reverts commit d22c818c. Reason for revert: Internal assets rolled out, this should not cause any more breakages. Original change's description: > Revert "Reland "Google Translate branding on desktop translate bubble"" > > This reverts commit 59a03dc3. > > Reason for revert: Causing desktop perf build failures > > Original change's description: > > Reland "Google Translate branding on desktop translate bubble" > > > > Change-Id: Id2972c13c2da888a4c7f2974b933ae190fdfe2fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756147 > > Reviewed-by: Alexandre Frechette <frechette@chromium.org> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#687664} > > TBR=oshima@chromium.org,anthonyvd@chromium.org,frechette@chromium.org,crouleau@chromium.org > > Bug: 994787 > > Change-Id: I799fb9416fa57c47c52364314b0f016cea529742 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758510 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687697} TBR=oshima@chromium.org,anthonyvd@chromium.org,johnchen@chromium.org,frechette@chromium.org Bug: 994787 Change-Id: Ibdc33d9549c7b079dd65283e53ee72a5de3f27cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835198Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702064}
-
Marialicia Villarreal Garcia authored
When navigating in the frame, the "first responder" that has focus is the view. So when trying to move from frame to web content, the first responder does not get updated, which makes VO not respond to the focus events being fired within web content. This fix is so that when a focus event is fired for the web content, set it as the first responder if it has not been set yet. This only gets called by screen readers when navigating with scan mode (arrow keys). This change has been verified in Mac with VO and in Windows with NVDA and Narrator (IA2 and UIA). AccessibilityActionBrowserTest.FocusAction already tests the main action of BrowserAccessibilityManager::SetFocus. Bug: 990014 Change-Id: Iaec036a14743c77b26f68ef10b0515aa7034cdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809943Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702063}
-
Manu Cornet authored
This applies the same change made in CL 1814222 (for the _visibility_ chain of events), to the _target visibility_ chain of events and observers. This fixes tests that are failing with pending CL 1832634. Bug: 1006013 Change-Id: I6992f16d79393b16d3813090ec3d69090335fe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834653 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702062}
-
Kush Sinha authored
Chrome OS Account Manager has been turned on by default on ToT, and has been launched via Finch for some time now. Clean up its flag's usages in Active Directory credentials manager. TBR=rsorokin@chromium.org Bug: 1009960 Change-Id: Id81addd05162e2bd911b555ab47f24248a9312e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832212Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#702061}
-
Sammie Quon authored
Replace GetTransformForRect with gfx::TransformBetweenRects. Test: manual Bug: none Change-Id: I0e699c1caa28a8c8decca18b579070cc90aa5d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834643 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#702060}
-
Ioana Pandele authored
Bug: 986317 Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#702059}
-
Boris Sazonov authored
Use for TouchToFill the same triggering logic that is used for regular suggestions. Bug: 1010233 Change-Id: I111d4eac4ce94dd94b86097b6b6c98e08875e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834230 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702058}
-
Sigurdur Asgeirsson authored
This breaks up some of the dependencies in preparation for a move to //components. Bug: 953031 Change-Id: I7955635a348d051c73178536caa8bd31b840645c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835199 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702057}
-
Adithya Srinivasan authored
Wait for adoption to complete before ending test. Bug: 990717 Change-Id: I0c4a969f89893c31872bd0fe31f66fb63397adc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834270 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702056}
-
John Budorick authored
This is a reland of crrev.com/c/1797004 Bug: 922145 Change-Id: Ic388afd4cd4303c25057ca77b38cea39d965d3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827248Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702055}
-
Yun Liu authored
asm 7.0 is needed for Robolectric using jdk 10 or 11 https://github.com/robolectric/robolectric/issues/4085 Bug: 965286, 693079 Change-Id: Ic0979741c8279601befc7508d7d055c9eb395f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832931Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#702054}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf0a9a628490..a1ea0a96f490 git log cf0a9a628490..a1ea0a96f490 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 chinmaygarde@google.com Don't build the minimal Metal app when building for Flutter. Created with: gclient setdep -r src/third_party/skia@a1ea0a96f490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I4f1edca819bc50a2fa74ad8bedea8395d2772667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702053}
-
Mikel Astiz authored
There's no point in remembering very old cache GUIDs since features anyway filter for recent devices, so let's implement a garbage-collection logic for the cache GUIDs stored in prefs. Bug: 989340 Change-Id: I1b1f84e3026471f8f687caa54922e2ea43bafaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827435Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702052}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I4252236d9cbd4452026111eaa4fbe91c5e30c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830013Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702051}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9488a16bbe3d..9b9ccf7ac88a $ git log 9488a16bb..9b9ccf7ac --date=short --no-merges --format='%ad %ae %s' 2019-09-27 yusukes system_api: Add num_cores_disabled to StartArcMiniContainerRequest 2019-09-23 nverne vm_host_tools, system_api: Add top level methods for container upgrade. 2019-09-23 lepton vm_tools: arcvm: Add support for Android fstab. 2019-09-25 ejcaruso power: add method for checking the presence of a color ALS 2019-09-06 smbarber system_api: permission_broker: add methods for loopback TCP lockdown 2019-09-24 smbarber system_api: permission_broker: remove unused VPN methods 2019-09-25 ejcaruso power: add AmbientColorTemperatureChanged signal Created with: roll-dep src/third_party/cros_system_api BUG=b:139752657 TEST=ninja Change-Id: Ie549b477b5cedf526c13c7c62c9406e5545900be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834874 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#702050}
-
Willie Koomson authored
This change addresses a comment in the previous ThrottleService CL, fixing the class definition by making the destructor virtual. Bug: 997397 Test: Run ThrottleService unit test Change-Id: Ied2f28781075f4a766aee5243698a93acb5a122b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834568Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#702049}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dbfa96532ab0..4cb8240aaec0 git log dbfa96532ab0..4cb8240aaec0 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 dberris@chromium.org Refactor all Tasks/Evaluators to new module Created with: gclient setdep -r src/third_party/catapult@4cb8240aaec0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:988912 Change-Id: Ia2276849b921a53f9a3d99a59afe102b7e98c5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702048}
-
Chris Lu authored
Whenever there are multiple non-fullscreen badges, a blue dot will show on the top right corner of the overflow badge if the menu has not been opened yet. Once it is opened, the blue dot will disappear. The dot reappears if a new badge is added. A new BadgeConsumer method markDisplayedBadgeAsRead() is added to allow for the mediator to tell the view controller when to hide/show the dot. Screenshot: https://drive.google.com/open?id=13TMm0r1mtm_tz55hiMWkr77R0rMEijPp Bug: 976901 Change-Id: I220cb865e117b19520c37cea2287757b46803df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832157 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702047}
-
Alex Clarke authored
This is needed for implementing PostTaskHere and base::CurrentThread traits. In a follow on patch SimpleTaskExecutor will be added for blink threads. Bug: 835323 Change-Id: Ice25d2a93fc7a6a10c0a4d4e43aa82a97462e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832280 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#702046}
-
Fernando Serboncini authored
TBR=khushalsagar Bug: 995235 Change-Id: Icd9cc8165836cf97a852869e296599f887ed9a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835197 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702045}
-
Lily Chen authored
This fixes a slight inaccuracy in the tooltip string describing why a cookie was blocked for being SameSite=None but not Secure. Bug: 856777 Change-Id: I529eaa67380045fa86fd421664c2824638b851c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832522Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#702044}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3dc289df..f45ddb9b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I68f290577ebefc754542902c48fb526d7107229d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835812Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702043}
-
Kush Sinha authored
Chrome OS Account Manager has been launched to Stable channel and enabled on ToT. Cleanup the flag in Chrome signin code. Bug: 1009960 Test: unit_tests --gtest_filter="*ChromeSigninHelperTest*" Change-Id: I012a6967f890febba66e1ce8e19764b46e357aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833609 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#702042}
-
Brett Kilty authored
It is possible an AudioOutputDevice is created and waiting for authorization when destruction happens. Add a stop call to ensure it gets cleaned up. Bug: b/141012708 Test: Local build, before/after manual testing. Change-Id: If454095f2d3d44d20b84a9135151248372b0a574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832727Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#702041}
-
Allen Bauer authored
Change-Id: I93162b75b817fdf8488b33009e13775da3a890df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825620 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702040}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e470360678b..3ad1e2151d99 git log 1e470360678b..3ad1e2151d99 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 lalitm@google.com Merge "trace_processor: add benchmark for resize of bitvector" 2019-10-02 lalitm@google.com Merge "trace_processor: add benchmark for sparsevector Get calls" Created with: gclient setdep -r src/third_party/perfetto@3ad1e2151d99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I038e5dd52eac5d6a35455c700824320616040d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702039}
-