GitLab

Some detached requests fail because the network changes between
requests. Retry the request in this case, only once.

Bug: 851399
Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560
Reviewed-on: https://chromium-review.googlesource.com/1118262Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571173}

https://developer.android.com/reference/android/Manifest.permission.html#FOREGROUND_SERVICE

BUG=

Change-Id: Ie3e01cea3d810373d804c2a56d42d5f4f44607f9
Reviewed-on: https://chromium-review.googlesource.com/1117135Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571172}

Bug: 854598
Change-Id: I457e8940a4ad5ff4aa89cfae4415f0addd1e6a64
Reviewed-on: https://chromium-review.googlesource.com/1118621
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571171}

This reverts commit fed0e8ec.

Reason for revert: It broke most of the chrome_informational builders at BuildPackages stage. See crbug.com/857133 for details. 

Original change's description:
> Pull GN via CIPD package
> 
> This is a reland of
> https://chromium-review.googlesource.com/c/chromium/src/+/1112840.
> 
> 
> The gn binary will be downloaded into third_party/gn. This CL rolls
> buildtools forward to a revision where the gn binary is a stub that
> prints an error message and returns 1. This is to avoid depending
> on the old location, and helping users relying on gn auto regen.
> 
> Update mb.py to use the new location.
> 
> Update explicit location in ios/web_view/BUILD.gn for the new location.
> 
> Update explicit location in
> tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new
> location.
> 
> Update explicit location in tools/licenses.py with for the new location.
> 
> Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py.
> 
> Bug: 855791
> Bug: 856883
> Bug: 856884
> Bug: 856878
> Bug: 856899
> Bug: 857107
> Bug: 857110
> Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1117264
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571031}

TBR=dpranke@chromium.org,scottmg@chromium.org

Change-Id: I28962c879b7bc24e809b29427122bb425e9450a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855791, 856883, 856884, 856878, 856899, 857107, 857110
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118825Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571170}

It was reenabled in f73246ba.
No, it is still flaky.

BUG=845267
TBR=kbr@chromium.org

Change-Id: I4ad193b01738945c63dfa12585be7b9354408b49
Reviewed-on: https://chromium-review.googlesource.com/1118528Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571169}

This reverts commit fe55ead6.

Reason for revert: UX direction change.

Original change's description:
> Revert "Omnibox UI Refresh: Align Omnibox text to new Suggestion text"
> 
> This reverts commit 0830cdf0.
> 
> Reason for revert: UX direction change.
> 
> Original change's description:
> > Omnibox UI Refresh: Align Omnibox text to new Suggestion text
> > 
> > The goal of the CL is to re-align the Omnibox text to match the new
> > Refresh spec.
> > 
> > In the new Refresh spec, the text has a different indentation depending
> > on whether or not the popup is open, so this CL resets the insets
> > of the OmniboxViewViews whenever the popup opens or closes.
> > 
> > It also updates LocationBarView to no longer ignore the left-inset
> > value of the OmniboxViewViews. We used to also ignore the right-inset
> > value, but we stopped doing that recently [1].
> > 
> > After no longer ignoring the left-inset value, we update the
> > non-Refresh value to the correct value of 0 (to keep things looking
> > the same), and update the Refresh value to 2, which matches mocks.
> > 
> > We are updating the inset of the OmniboxViewViews textfield instead of
> > the bounds of the textfield because we want the whole area to remain a
> > clickable I-beam, even if we indent the text a bit.
> > 
> > [1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc
> > 
> > Bug: 849779, 823535
> > Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4
> > Reviewed-on: https://chromium-review.googlesource.com/1096491
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> > Commit-Queue: Tommy Li <tommycli@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566834}
> 
> TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 849779, 823535
> Change-Id: Icf9e2f004042be6f25b9a86d23f269f5ebf0fd90
> Reviewed-on: https://chromium-review.googlesource.com/1117218
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570847}

TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org

Change-Id: Ib5afb6cc4e892594e3cfdd0c775ae6ef1e4f862f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849779, 823535
Reviewed-on: https://chromium-review.googlesource.com/1118785Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571168}

Bug: 855620

Change-Id: Id4da3e42581147261f706c15f3649a38fad52ff1
Reviewed-on: https://chromium-review.googlesource.com/1117031
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571167}

Move tough_compositor_cases.py into the rendering folder and refactor
classes to inherit from RenderingStory

Bug: 849392
Change-Id: I0a675d99f81a7588612e648e9ad5c3fef210e8d1
Reviewed-on: https://chromium-review.googlesource.com/1117574
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571166}

https://chromium.googlesource.com/angle/angle.git/+log/a26de2500503..dc66ef9dc48b


git log a26de2500503..dc66ef9dc48b --date=short --no-merges --format='%ad %ae %s'
2018-06-28 lucferron@chromium.org Vulkan: Add simple test to trigger issue of buffer.write tests
2018-06-28 geofflang@chromium.org VK: Support pbuffer surfaces.
2018-06-28 jmadill@chromium.org Roll SPIRV-Tools and SPIRV-headers (June 2018)


Created with:
  gclient setdep -r src/third_party/angle@dc66ef9dc48b

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I41c21a478cdae8bfb23fe992c2f8f6a53d40d12d
Reviewed-on: https://chromium-review.googlesource.com/1118569Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571165}

https://skia.googlesource.com/skia.git/+log/385804514edf..fcb04d853ec4


git log 385804514edf..fcb04d853ec4 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 26581113047a..a26de2500503 (2 commits)
2018-06-28 senorblanco@chromium.org GrTessellator: handle collinear final vertex.
2018-06-28 caryclark@skia.org fix doc catalog
2018-06-28 brianosman@google.com Revert "Revert "Temporary fix for SkImage_Lazy handling of color spaces""


Created with:
  gclient setdep -r src/third_party/skia@fcb04d853ec4

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:851409
TBR=jcgregorio@chromium.org

Change-Id: Id3edcb82a300a5a5a2eadb463682fb24b7ba1fb7
Reviewed-on: https://chromium-review.googlesource.com/1118505Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571164}

TBR=carlosk@chromium.org
NOTRY=true

Bug: 857520
Change-Id: I585202f174ab0cd9376ec38b41a3de4cd2f5927c
Reviewed-on: https://chromium-review.googlesource.com/1118746Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571163}

This is a preparation patch for crrev.com/c/1117716, which reveals
some LayoutNG bugs in non-standards mode.

Since non-standards mode is of low priority for now, this patch
converts these tests to standards mode to unblock the pending CL.

Note: fast/css/first-letter-first-line-hover.html is a ref test,
whose ref file is also modified.

Bug: 851075
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Icd62340740c52efd62cf6a36a06442a336639476
Reviewed-on: https://chromium-review.googlesource.com/1117919Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571162}

Render: https://screenshot.googleplex.com/nvBOZqHXENq

Bug: 849351
Change-Id: I8004424ed05d0b424fd9918c0e36d49d954bcabc
Reviewed-on: https://chromium-review.googlesource.com/1117443
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571161}

Move key_noop_cases.py into rendering folder and refactor to inherit
from RenderingStory class

Bug: 849393
Change-Id: I5db6ea904ac82b23eaf8abac0203b2552a43f364
Reviewed-on: https://chromium-review.googlesource.com/1118281Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571160}

This is a reland of 0c2015e1

TBR=eugenebut@chromium.org

Original change's description:
> Disable WebStateTest.MessageFromIFrame test.
>
> TBR=eugenebut@chromium.org
>
> Bug: 857129
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
> Reviewed-on: https://chromium-review.googlesource.com/1117300
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570882}

Bug: 857129
Change-Id: I62a341ccebb1ceef892a2f07eb0faae4d87476d7
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118685Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571159}

Android is not possible yet because we can't pass flags to the test executable.

BUG=angleproject:2635

Change-Id: I2c8247c9231895a729575229a820f1720d845c6f
Reviewed-on: https://chromium-review.googlesource.com/1117210Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571158}

kCanvas2DImageChromium [0] is a FeatureFlag enabled by default in
Mac and CrOS allowing for using GL CHROMIUM_image extension for HTML
Canvas Contexts.  This CL exposes this flag to chrome:flags so it
can be used for debugging e.g. crrev.com/c/1056168 etc.

In CrOs, the flag goes unused now [1], so nothing changes there.

[0] https://cs.chromium.org/chromium/src/content/public/common/content_features.cc?type=cs&q=kCanvas2DImageChromium&g=0&l=83
[1] https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?type=cs&q=enable_canvas_2d_image_chromium&g=0&l=156

Bug: 839970
Change-Id: I94a3646e996b996f6901d9414734801d1aa2bfab
Reviewed-on: https://chromium-review.googlesource.com/1117328
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571157}

This change implements initiating GATT connections for WinRT. While
currently no GATT discovery is attempted, this will be provided in a
future CL. GATT connections are created by obtaining an instance of
BluetoothLEDevice.

Bug: 821766
Change-Id: I7f20127a84b781859300af18b31da0e9ee24a32b
Reviewed-on: https://chromium-review.googlesource.com/1090217
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571156}

Including Windows.h causes namespace pollution and build-time costs due
to the heavy use of macros and the large size of the headers. This
removes a #include of Windows.h from range.h that is currently causing
problems.

Bug: 855717, 796644
Change-Id: I26abd068ed1c4a5ca65092258dd45ccd076c2b20
Reviewed-on: https://chromium-review.googlesource.com/1117739
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571155}

This is a reland of f824b3a3

Original change's description:
> variations: add client config for ViewsBrowserWindows
>
> Bug: 827247
> Change-Id: Ic09c38f7b658b1f6d79ecec8a6d0895aca44d797
> Reviewed-on: https://chromium-review.googlesource.com/1017460
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565782}

Relanding the CL.

Bug: 827247,851463
TBR: isherman@chromium.org
Change-Id: Ic3b23594fa74b24023924ad4107bf262e641bfb7
Reviewed-on: https://chromium-review.googlesource.com/1106498Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571154}

When migrating [1] formatting logic from ConsoleViewMessage.js to
BrowserConsole.js, we forgot to add the line that tries to show a
localizedFailDescription.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/920541

Bug: 816743
Change-Id: Ic3e6cc49b8634a12fe8667c19fdc4623780075db
Reviewed-on: https://chromium-review.googlesource.com/1115872Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571153}

Currently its using WebLayerTreeViewImplForTesting but it only uses
the cc::LayerTreeHost, not the WebViewImpl things, so it just needs
a LayerTreeHost itself. This helps us toward removing the
WebLayerTreeView interface.

R=chrishtr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia60ea4128ed029f09ee4abe012ee62f315633c88
Reviewed-on: https://chromium-review.googlesource.com/1117656
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571152}

Makes incremental builds of blink_core 31% faster in jumbo builds.
(Non-jumbo builds that use PCHs (i.e. not goma builds at the moment) already
got this speedup without this change.)

reviews.llvm.org/rL335466 made PCH files much more effective in component
builds on windows.  Regular (non-jumbo) component builds of blink_core now build 42%
faster.  In Jumbo builds, full builds are only a bit faster with PCHs enabled
after that change (26m52s instead of 27m33s with just jumbo; jumbo + PCH before
that change was 27m41s), but incremental build time goes from 32s to 22s for
touching one cc file and relinking blink_core.dll, which is a considerable
speed-up.

Reverts https://chromium-review.googlesource.com/c/chromium/src/+/962785

Bug: 809010
Change-Id: I985dd16dacaa9f655ae2a9329b33ad92229a1ab6
Reviewed-on: https://chromium-review.googlesource.com/1116901Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571151}

Events at the RewriteEvent() interface are in raw screen coordinates,
but TouchExplorationController internally uses DIP coordinates.
Some rewritten events were incorrectly generated using DIP coordinates.

Bug: b/73383411
Test: manual
Change-Id: Ib126692e51aaf034a95cd9b50b599e4bd76cbcac
Reviewed-on: https://chromium-review.googlesource.com/1117469
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571150}

Use cc::LayerTreeHost instead, as these tests just need to use cc
APIs for testing painting. They do not use the WebViewImpl etc layer.

NOTRY=true

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide21fc6acdbd4c1171987f964ea6b157e79789e0
Reviewed-on: https://chromium-review.googlesource.com/1117622
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571149}

TBR=jochen@chromium.org
NOTRY=true

Bug: 857488
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36166c547f9c5c5b9d69d01742a20f6673c8f15e
Reviewed-on: https://chromium-review.googlesource.com/1118534
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571148}

The code in FixupURL does not properly handle "about:blank" variants
where some letter in "blank" is uppercase. This CL fixes the issue by
returning "about:blank" when the lowercase of the input URL is
"about:blank".

Bug: 857201
Change-Id: Ia1ff719d142ae8f2a346cbca231e52a811e9b77c
Reviewed-on: https://chromium-review.googlesource.com/1117627Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571147}

Bug: None
Test: None
Change-Id: I5de8c272bb5d82c135e35a210f5c3948befd155f
Reviewed-on: https://chromium-review.googlesource.com/1117848Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571146}

Since cross-thread persistents may be included in the poisoning, but must not
be observed by another thread to be poisoned, the mutex must be held to prevent
them noticing before they are unpoisoned again.

The alternative which would narrow the critical section might be to store away
a copy of the cross-thread persistents and not poison them at all, but this is
consistent with the previous approach and thus seems less risky.

Bug: 857311
Change-Id: Ib0ddee582c6ceea98cce0c0b3844fb363aa3c5be
Reviewed-on: https://chromium-review.googlesource.com/1118286Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571145}

Add WebFeature UseCounters for when env() is used and for when
each safe area inset variable is used.

These should also be exposed to UKM so we can cross reference
with our UKM event.

BUG=855739

Change-Id: Ib5e4f26752a279c9696a050bd42dd5842fe28cb0
Reviewed-on: https://chromium-review.googlesource.com/1112698Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571144}

This is a re-land of an old CL, which was reverted in https://codereview.chromium.org/2977273002
due to a WebView issue. We believe the underlying issue may have been resolved, so should try
re-landing this.

Bug: 715699
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0da6ab6f55d0fb4ba0760378f182217e8c4546c1
Reviewed-on: https://chromium-review.googlesource.com/1112387Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571143}

Also avoid a hop to get own clock via the RealTimeDomain.

Bug: 857101
Change-Id: I0433f8442b061ff2b2f33f839eb08719fb76bc5d
Reviewed-on: https://chromium-review.googlesource.com/1118267Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571142}

The returned status string is only for debug UI (about:sync-internals),
there's no reason why the Java side would have to know of it (and
accordingly, it was unused).

Bug: none
Change-Id: I84c33d32c426e05f9ec04516ca93d6775354548d
Reviewed-on: https://chromium-review.googlesource.com/1116705Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571141}

This is needed as the TraceWriters we create and keep in TLS
keep a reference to the SharedMemoryArbiter object that the
ProducerClient keeps, and during shutdown may still be
used after the ProducerClient previously got deleted.

R=hjd@chromium.org
BUG=844379

Change-Id: Ib27b59b48ce50f88f954618e7eee4f046b3029b7
Reviewed-on: https://chromium-review.googlesource.com/1117776Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571140}

Recent table refactoring means we expose more layout tables. This is
generally a good thing.

It broke some accessibility in Hangouts, where there was a layout table
inside of an ARIA button and the accessible text of the button came from
inside the layout table. Previously the layout table was just exposed as
generic elements, and layout table roles should behave the same way with
regards to how text is exposed to ancestors.

Bug: 856277
Change-Id: I9b30931b306fda09a5408df4dc3b3dd1c54e619e
Reviewed-on: https://chromium-review.googlesource.com/1117628
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571139}

Bug: 836246
Change-Id: I6db06e859468e7ab4d19424a91d8a90bffa23a2e
Reviewed-on: https://chromium-review.googlesource.com/1070658
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571138}

Mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z

Bug: 827376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
Reviewed-on: https://chromium-review.googlesource.com/1100237
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571137}

Feature is landed in M66. Now we can remove the flag in M69.

Bug: 805046
Test: manual

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id98b066228f5f5b45d9d02d405bcc57d41fde20a
Reviewed-on: https://chromium-review.googlesource.com/1113097Reviewed-by: Mitsuru Oshima (OOO 6/27) <oshima@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#571136}

Move key_hit_test_cases into the rendering folder and refactor to
inherit from RenderingStory

Bug: 849392
Change-Id: Iecf8c273fb137b051ab51ee47f4020addef2548d
Reviewed-on: https://chromium-review.googlesource.com/1118279Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571135}

In pathological cases, such as those provided in the relevant bug,
Zucchini could exhibit O(n^2) behavior during seed selection. To remedy
this, this CL adds a quota to limit the total number of bytes covered
in seed selection search. However, as demonstrated in CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1115710
this is insufficient. haungs@ determined that if this is the only
limitation then the ExtendEquivalenceBackward method will perform a
linear time extension resulting in O(n) behvior which when applied
over O(n) offsets results in O(n^2) behavior again. To limit this he
proposed limiting the distance ExtendEquivalenceBackward can search
which is also implemented in this CL.

These parameters are tuned such that they have no noticeable impact
when patching chrome.7z for Windows. For the pathological testcases in
the bug the results are significantly better (refer to the bug for
exact improvements).

This solution results in linear time performance on the pathological
cases. We could get these numbers down even smaller by reducing the
limit on backward extension. However, this had a small, but noticeable
~5 kiB increase in patches for chrome.7z.

Bug: 849471
Change-Id: If7e857884b00daeeae7a4a29b1236c749f0b84e4
Reviewed-on: https://chromium-review.googlesource.com/1117273
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571134}