- 27 Apr, 2018 40 commits
-
-
Clemens Hammacher authored
This allows to enable Liftoff, the baseline compiler for WebAssembly. R=hablich@chromium.org, titzer@chromium.org, jochen@chromium.org Bug: 787421 Change-Id: Ie6877e72db50f4daa55413fabd70aca74ccf0e6c Reviewed-on: https://chromium-review.googlesource.com/1032330Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554372}
-
Reza.Zakerinasab authored
Bug: 836640 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib64f5ca69116badb0b2a5ef84890b51d2742cfaa Reviewed-on: https://chromium-review.googlesource.com/1030811Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554371}
-
Christopher Cameron authored
Because we re-use the same ui::Compositor for several different RenderWidgetHostViewMacs, we can encounter a situation where the following sequence of events happens 1. RWHVMac A draws frame A 2. The GLRenderer does the SwapBuffers for frame A 3. RWHVMac A is hidden, and its ui::Compositor/AcceleratedWidgetMac are put up for recycling 4. RWHVMac B is shown (in a new window or a new tab), and takes the AcceleratedWidgetMac that was recycled by RWHVMac A 5. The CALayerParams from the SwapBuffers gets to the browser, and causes the frame from RWHVMac A to appear in RWHVMac B, which is incorrect. This problem has a long history, and many of its original constraints no longer apply. In viz this becomes more complicated because the timing of Step 2 becomes much more unpredictable (it can happen as late as after Step 4). Remove the methods which are used to skip drawing the framein Step 5 above, and replace them with a direct call Suspend on the AcceleratedWidgetMac, telling it to stop showing new frames until the ui::Compositor does a commit (which it will do because of the new SurfaceId that it will have). With respect to viz - The old interfaces did not solve the problem for viz (when the GLRenderer is in the GPU process), but added lots of complexity. - The new simpler scheme also does not solve this problem completely for viz. - It is likely that the concept of ui::Compositor recycling will be removed entirely before viz ships, making this a moot point. R=fsamuel TBR=yfriedman (content/renderer/android), boliu (android_webview/) Bug: 772576 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia41712f0730947e6f0426aeea5064c818a16f122 Reviewed-on: https://chromium-review.googlesource.com/1031654 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554370}
-
Rune Lillesveen authored
Height and width of ComputedStyle is no longer modified during layout. Remove the reset. Bug: 813068 Change-Id: Iab32d5b0dc2c852f0314013aa2d1d14c87a78c77 Reviewed-on: https://chromium-review.googlesource.com/1032595Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554369}
-
Lukasz Anforowicz authored
This CL moves part of CORB-related UMA code into //services/network. Only the metrics related to content::ResourceType have not been moved and remain only logged from //content/browser/loader code. Bug: 792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic649b587aafa679a0fef98eea5e5d6eb297bc698 Reviewed-on: https://chromium-review.googlesource.com/1028841 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554368}
-
Greg Kraynov authored
It's getting moved to //base, hence, can't use WTF. base::circular_deque seems to be a drop-in replacement to WTF::Deque. Bug: 783309 Change-Id: I3d92842687b1021d69afe98c374e998517daa369 Reviewed-on: https://chromium-review.googlesource.com/1009909Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#554367}
-
Anita Woodruff authored
- Previously the NotificationChannelsProviderAndroid stored the auto-block for notification permission requests made in Incognito mode. - Now we never register this content settings provider for incognito profiles, so the auto-block is now stored by the PrefProvider in memory, as before in the pre-channels world. R=peter@chromium.org Bug: 835232 Change-Id: I2d837f7dcb41de8a6820d3d69a448c3530941bd3 Reviewed-on: https://chromium-review.googlesource.com/1030332Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#554366}
-
Elly Fong-Jones authored
This test is another prime suspect in windowserver deaths on the bots. TBR=jbudorick@chromium.org Bug: 828031 Change-Id: Ia4859124f37b00a9b3d2bf8bc9ba3b5c1acba122 Reviewed-on: https://chromium-review.googlesource.com/1032812Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554365}
-
Olivier Li authored
Add the code to populate the field in the enterprise reporting and create associated test. Bug: 832907 Change-Id: Ia588466539288e17a61846d9ddf675460d1774d2 Reviewed-on: https://chromium-review.googlesource.com/1015240Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554364}
-
vasilii authored
- The string for masked password was using 'Black Circle' symbol instead of 'Bullet'. - The accessibility label wasn't really set. Now 'Hidden, Password' is used in case the password is masked. Bug: 829821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9f87acefbf9289406718701af6c688f0e49424c6 Reviewed-on: https://chromium-review.googlesource.com/1030633 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#554363}
-
tzik authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/ab7b6a7b350d..b7d53a93026d $ git log ab7b6a7b3..b7d53a930 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 tzik Make libc++abi C++17 ready Created with: roll-dep src/buildtools BUG=752720 Change-Id: I225dd038f21b49d34bdf48bfd3fddaf40c1b2fea Reviewed-on: https://chromium-review.googlesource.com/1032130 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#554362}
-
Alessio Bazzica authored
Minor changes required to land https://webrtc-review.googlesource.com/c/src/+/72060/ Bug: webrtc:9076 Change-Id: I767a1b3f735428e7db8a0cbf53f70af4148f27bb Reviewed-on: https://chromium-review.googlesource.com/1030273Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#554361}
-
https://webrtc.googlesource.com/src.git/+log/d4043f69ae76..95141d91d8ab $ git log d4043f69a..95141d91d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia9c5b60bd92580727ee3b90fe87075d88c5ffed0 Reviewed-on: https://chromium-review.googlesource.com/1032261 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554360}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4bcdfad6..bdb814e9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6a167ca799d63455610e6b24c47e147d9b4747cc Reviewed-on: https://chromium-review.googlesource.com/1032374Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554359}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e7d0b02. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" 7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16304 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=foolip No-Export: true Change-Id: Id58a55c0bc34ce53898a2a2ff64918e619ff703c Reviewed-on: https://chromium-review.googlesource.com/1032474 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554358}
-
Takuto Ikuta authored
R=mkwst@chromium.org Bug: 428099 Change-Id: Ice6a3365769fe40b81100ac216a4066424955119 Reviewed-on: https://chromium-review.googlesource.com/1032459Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#554357}
-
Gustav Sennton authored
To properly support per-method feature detection we need to allow converting back and forth between support library and frameworks classes. This CL adds support for converting between webkit and support library objects for already implemented post-L classes: 1. ServiceWorkerController 2. ServiceWorkerWebSettings 3. WebResourceError Bug: 836339 Change-Id: I334d17153eb8d71834e1fafc43676bc2c706b4e2 Reviewed-on: https://chromium-review.googlesource.com/1027815 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554356}
-
Timothy Loh authored
Add support for searching in the App List for Crostini Apps. This only does a search over app names, not e.g. executable names or keywords in the desktop file. As we use the AppSearchProvider, this also makes apps show up in the app list's list of recently launched apps. Prior to first use, the Terminal app will only show up upon searching for exactly the string "terminal" (case insensitive). The app list is also updated to have the Terminal not appear if it hasn't been used yet. Bug: 836137 Change-Id: I72b1f530d8e4812f0d13ba1fd45a0967458393ab Reviewed-on: https://chromium-review.googlesource.com/1025496 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554355}
-
Ramin Halavati authored
Running with no filter test is activated on traffic annotation auditor FYIbot. Bug: 690323 Change-Id: I13c8c3eda25d8203fee2412fa6160db56515b139 Reviewed-on: https://chromium-review.googlesource.com/1026731Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#554354}
-
https://webrtc.googlesource.com/src.git/+log/6a8f30e5a36f..d4043f69ae76 $ git log 6a8f30e5a..d4043f69a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaa731d3b9c959e766000774011adf4565f45e062 Reviewed-on: https://chromium-review.googlesource.com/1032259 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chrome://webrtc-logsElad Alon authored
Before this CL, refreshing had no effect; the page tab would have to be closed and reopened for the list to actually be refreshed. This CL fixes the issue. Piggy-backed on this CL is also a fix of a problem where base::Unretained was used instead of a WeakPtr. Bug: 826206 Change-Id: I49e6f5bb7e62487d71a0816a7faaf8538fb04363 Reviewed-on: https://chromium-review.googlesource.com/1028070Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554352}
-
jdoerrie authored
This change deprecates arraysize in favor of base::size(array) and adds a corresponding PRESUBMIT warning to discourage further usage. Bug: 837308 Change-Id: Iedd676f691cb46ca4a108462cedefbe91690240b Reviewed-on: https://chromium-review.googlesource.com/1030333Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#554351}
-
Mikel Astiz authored
This reverts commit 664491ff. Reason for revert: the underlying issue is believed to be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1029853 Original change's description: > Disable a crashing TwoClientBookmarksSyncTest. > > BUG=836426 > TBR=skym@chromium.org > NOTRY=true > > Change-Id: Ie9c07c1417ab693d517e1ac4ee3dc8082465a58a > Reviewed-on: https://chromium-review.googlesource.com/1026790 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553299} TBR=thestig@chromium.org,skym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836426 Change-Id: I53b2cac1ee6720cbbbd9d2650292cac6cc551bfe Reviewed-on: https://chromium-review.googlesource.com/1032411Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554350}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24871c6b..4bcdfad6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0083f8a64dda1e213e2677f4f7b0f1d4830dabf5 Reviewed-on: https://chromium-review.googlesource.com/1032470Reviewed-by:
-
Noel Gordon authored
Disable this test on MSAN. Bug: 837551 Change-Id: I8e5f6480ab4e274420f5b2f339dc1b44ec49454e Reviewed-on: https://chromium-review.googlesource.com/1032455Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554348}
-
Fredrik Hubinette authored
... for Pixel_Video_VP9 Bug: 754986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5fd7742ca773d8a5abbb8ad8326f559af246f19c Reviewed-on: https://chromium-review.googlesource.com/1024497Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#554347}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51249958. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" 7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight" a8385691 "Make web font timeouts work for preloaded fonts" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16303 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/service-workers/cache-storage yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: I367f0de0fbd437f27a73e28e21efc7a16b17f0a4 Reviewed-on: https://chromium-review.googlesource.com/1032370 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Just replaced by LayoutBlockFlow. Change-Id: I7ad382af6078de151fb906ca3a65e16d423c29bd Reviewed-on: https://chromium-review.googlesource.com/1032391Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/ad7f6e5ccf77..6a8f30e5a36f $ git log ad7f6e5cc..6a8f30e5a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib3465d9adba3ff1dd42c002acf0135324752b7b1 Reviewed-on: https://chromium-review.googlesource.com/1032256 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Kouhei Ueno authored
I couldn't find any occurrence in tests that attempt to dynamically reconfigure this. This CL just makes them use constants to reduce complexity. Bug: 689702 Change-Id: I431aaec674a439d82499a1b4099d4de64e75f5c1 Reviewed-on: https://chromium-review.googlesource.com/1032313 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/414be9b332f7..a886544a7bf7 $ git log 414be9b33..a886544a7 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 angle-skia-autoroll Roll third_party/externals/angle2/ 1633663b3..467c15f97 (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ibe6f00425fb3f8d701ace6e1f3146407eaf2237b Reviewed-on: https://chromium-review.googlesource.com/1032290 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554342}
-
Yoav Weiss authored
Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: https://github.com/whatwg/fetch/issues/658 PR: https://github.com/whatwg/fetch/pull/659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f Reviewed-on: https://chromium-review.googlesource.com/1029858 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554341}
-
Yoichi Osato authored
Since we don't paint list marker selection today, the override is no longer needed(return null Rect as default). Bug: 837521 Change-Id: Ic31f773b82c08c5d758441e6dd15fd33c33e6bd8 Reviewed-on: https://chromium-review.googlesource.com/1032351Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#554340}
-
Jonas Olsson authored
|session_id| used to be passed to AudioCapturerSource::Initialize, then on to AudioInputIPC::CreateStream, and finally into the stream creation callback. Change that to pass it into AudioInputIPCFactory::CreateAudioInputIPC at AudioInputDevice creation time, and bind it into the callback at that point. We don't pass it to factory_->CreateAudioCapturerSource branch, as that one is only used for testing. This means that the caller has to provide the session id at IPC creation time, instead of the call to Initialize. Note that we currently don't currently support calling Initialize more than once, so we don't need to support changing the session_id later. BUG=834704 TBR=bbudge@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibfaaa80e1552e7166fc18b6c935ac1c03a2cef00 Reviewed-on: https://chromium-review.googlesource.com/1024170 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#554339}
-
Tetsui Ohkubo authored
This CL fixes Screenshot notification to be shown on UnifiedSystemTray. Screenshot notification is the easiest example to reproduce, but it could happen on other notifications. MessageListView scroller's Layout() should be explicitly called before UnifiedMessageCenterView's PreferredSizeChanged is called, as the result of the layout affects the preferred size of UnifiedMessageCenterView. TEST=manual BUG=836699 Change-Id: I1f6c519052f8bd0561a26a40943acaffdb6e586f Reviewed-on: https://chromium-review.googlesource.com/1027392Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#554338}
-
Yutaka Hirano authored
At https://crrev.com/08d9e1d29b685f8bc5da44d14727751d3f29f7be I forgot to add a reference from DetachedClient to DocumentThreadableLoader to keep it alive. This CL fixes that. Bug: 837511 Change-Id: Ie9549e6a7789bfbc6783cbfcd8fb4951ea78de40 Reviewed-on: https://chromium-review.googlesource.com/1032272Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554337}
-
Kent Tamura authored
The main change of this CL is that MakeNamesWriter.__init__() sets a qualified header path and a correct include guard to _template_context. In order to do it, - json5_generator.Writer.__init__() takes output_dir argument, and stores a directory name relative to "gen/". - Introduce json5_generator.Writer.make_header_guard(). Bug: 836071 Change-Id: I75a8ce8849071cb5a32e19f4304dc070937a8554 Reviewed-on: https://chromium-review.googlesource.com/1025351 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#554336}
-
Hitoshi Yoshida authored
Before this CL, the main thread is set up only for core module. i.e. In V8ContextSnapshot::EnsureTemplate, it creates V8Window function template for modules, and it is used for default contexts. After this CL, those elements are set with modules component. Bug: 834642 Change-Id: I94bb23376d8138abbf9806b7bbad4f59eaee6d8f Reviewed-on: https://chromium-review.googlesource.com/1030530 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Traffic annotation auditor is updated as follows: 1- It ignores clang tool's errors if the tool has been able to produce outputs. This is done because we might pass files to clang tool that belong to other platforms, and the tool's errors on these files should not prevent processing of the other returned results. 2- safe_list.txt is updated and all tests are excluded. 3- A bug in usage of safe listed exception type ALL is fixed. If a file that is in safe list type ALL is processed by the clang tool, its outputs are ignored when clang tool results are parsed. Bug: 690323 Change-Id: I61334f2bc5170bc04b399439daac6f6b6f20bc0a Reviewed-on: https://chromium-review.googlesource.com/1024010 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: -
Tetsui Ohkubo authored
According to UX prototype, label texts of Feature Pod buttons will fade out when UnifiedSystemTray is collapsed. UX prototype: http://shortn/_EAeqJNHpAg Design doc: go/cros-qs-restyling (See "Support animation" section) TEST=manual BUG=826999 Change-Id: I5d65897d071522cb78c9a707a7daf3da33a1fc8b Reviewed-on: https://chromium-review.googlesource.com/1029938Reviewed-by:
-
