- 06 Dec, 2017 40 commits
-
-
Balazs Engedy authored
Every RenderFrameHost exposes an InterfaceProvider to its corresponding RenderFrame, which is used by content/renderer/, Blink and WebUI JS code to access frame-scoped services implemented by the RenderFrameHost. Previously, for each frame, there was just a single InterfaceProvider interface connection that was used throughout the entire lifetime of the RenderFrame. The client end of this connection was passed in to the RenderFrame synchronously at construction time, and was then bound to |RenderFrameImpl::remote_interfaces_|. As of this CL, this primordial InterfaceProvider interface connection will only service interface requests originating from the initial empty document in the frame. For each subsequent cross-document navigation, a new message pipe is created, with its client end being bound to the RenderFrame's |remote_interfaces_| when the navigation commits, and its request end sent to the browser process as part of the DidCommitProvisionalLoad message. The one and only exception to this rule is when a browsing context is navigated from the initial empty document to another same-origin document, in which case the global object (i.e. the Window instance) associated with the initial document is reused for the new Document corresponding to the first real navigation committed. This is to support the following use-case: 1) Parent frame dynamically injects an <iframe>. 2) The parent frame calls `child.contentDocument.write(...)` to inject script that may stash objects on the child frame's global object (LocalDOMWindow). Internally, these objects may be using Mojo services exposed by the RenderFrameHost. The InterfaceRequests for these will be en-route to the RenderFrameHost for some time. 3) The `child` frame commits a first real load that is same-origin. 4) The global object in the child frame's browsing context is re-used. 5) When the InterfaceRequests arrive to the browser process, the RenderFrameHost should not discard these requests, so that JS objects stashed on the global object will continue to work. On the browser process side, when the RenderFrameHost receives an InterfaceProvider request along with DidCommitProvisionalLoad, it immediately breaks the old InterfaceProvider connection. Pending interface requests on the old connection are dropped, if any. Interface requests possibly pending on the new InterfaceProvider connection are only dispatched after WebContentsObserver::DidFinishNavigation fires. This ensures that interface requests racing with navigation commit will be either ignored, or correctly serviced in the security context of the document they originated from. In other words, when an interface request is dispatched, the invariant will hold that calling GetLastCommittedURL on the RenderFrameHost will return a URL that matches that of the document from which the interface request actually originated from. Note that |remote_interfaces_| remains a non-Channel-associated interface. Also note that it remains the responsibility of individual features using |remote_interfaces_| to close interface connections already established through the InterfaceProvider when a cross-document navigation commits, if needed in particular use-case. Bug: 729021 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1eb4aa78be9627f70fdf6e18af570f083b9e306d Reviewed-on: https://chromium-review.googlesource.com/735686Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522198}
-
Benjamin C. Wiley Sittler authored
Tests multipart form POSTs with file inputs where the selected "file" was constructed using the `File` constructor and added to a `DataTransferItemList` (this avoids the user gesture requirement which otherwise would consign this to manual testing.) For the non-ASCII filenames with non-UTF-8 accept-charsets this also verifies fallback encoding/replacement of unrepresentable characters using numeric character references. https://github.com/whatwg/html/issues/2861 Coverage for fallback encoding is still tentative because filename fallback encoding is not yet standardized. https://github.com/whatwg/html/issues/3223 Bug: 661819 Change-Id: Ic646f76b0c8a0792d1214a7848d2238bcc3a76e7 Reviewed-on: https://chromium-review.googlesource.com/811625Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Cr-Commit-Position: refs/heads/master@{#522197}
-
Xi Han authored
In this CL, we use Notification.Builder.recoverBuilder() to create a Builder from the notification sent by Chrome, and reset the notification's channel ID when necessary. Bug: 700228 Change-Id: I34cfa00ee2cb93935053020da487242709fbb36e Reviewed-on: https://chromium-review.googlesource.com/810984 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522196}
-
Xiaochu Liu authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5c4b603461a7..304b21ef6d91 $ git log 5c4b60346..304b21ef6 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 xiaochu add UnmountComponent method constant 2017-12-01 ljusten authpolicy: Add GetUserStatusRequest and OU errors Created with: roll-dep src/third_party/cros_system_api chromiumos/platform/system_api.git Bug=chromium:769970 TEST=None Change-Id: Id85f7273a891b93370d1d4c2e79a73715242dbc8 Reviewed-on: https://chromium-review.googlesource.com/811628Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522195}
-
Takumi Fujimoto authored
Set the provider ID for Cast/Dial sinks discovered in browser, so that it's not UNKNOWN. We will remove UNKNOWN as the default argument for the ctor param in a separate patch to avoid bugs like this. Bug: 792586 Change-Id: Ia43a3e451908f8a8e3c902b7869196f2ff6a7b2a Reviewed-on: https://chromium-review.googlesource.com/811666Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#522194}
-
Yuzhu Shen authored
Bug: 699569, 718047 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e2d9e55cac52b392bd31c96c51cc94a361b618b Reviewed-on: https://chromium-review.googlesource.com/809545Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522193}
-
Bence Béky authored
Stop using SpdySession instances in Http2PushPromiseIndexTests. This makes tests much simpler. Rename SpdySessionKey::Equals() to SpdySessionKey::operator==() so that it can be tested by gMock. This conforms to the style guide "prefer to define == [...] rather than Equals()", see https://google.github.io/styleguide/cppguide.html#Operator_Overloading Define struct UnclaimedPushedStream instead of using std::pair or std::tuple. Named members are much nicer than first, second, or get<>. Define CompareByUrl in conformance with the same section of the style guide "if your type doesn't have a natural ordering [...] use a custom comparator rather than overloading <". The next CL will merge SpdySession::UnclaimedPushedStreamContainer into Http2PushPromiseIndex. For this, two sets of UnclaimedPushedStream entries will need to be maintained with identical contents but different ordering. The other will be done by CompareByDelegate and will allow efficient lookup of entries for a given Delegate. Bug: 776415, 791054 Change-Id: I0c1912e9932b102e17528f9319163232860a8813 Reviewed-on: https://chromium-review.googlesource.com/809187Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522192}
-
Brian Anderson authored
Adds LatencyInfo entries for 5 frame sources: 1) Renderer main. 2) Renderer compositor. 3) UI main. 4) UI compositor. 5) Display compositor. These will be used to calculate metrics in followup patches. This patch also: * Discards LatencyInfos that don't result in damage in the Display, which is consistent with what we do earlier in the pipeline. The exception being snapshot requests to keep them working. * Adds a LatencyInfo::TraceIntermediateFlowEvents helper. * Fixes LayerTreeHostImpl::DrawLayers so it only adds INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT in the Renderer. Bug: 790759 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I478db123d536654acf3633ca5efb4e4d20132e78 Reviewed-on: https://chromium-review.googlesource.com/783849 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:vmpstr <vmpstr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#522191}
-
Morten Stenshorne authored
The Ahem font doesn't behave reliably at any given size. Multiples of 5px is supposed to work better. So use 20px instead of the default (16px). Bug: 788337 Change-Id: Ifd803008c6780a32fbeb5609faf23270ed4e8066 Reviewed-on: https://chromium-review.googlesource.com/811485 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522190}
-
Jinho Bang authored
Change-Id: Ic7eebc07a3fec115130c7de70b8571385bdd04f0 Reviewed-on: https://chromium-review.googlesource.com/812024Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#522189}
-
Katie Dektar authored
BUG=none NOTRY=true Change-Id: I78b082eae5c8033dee3bc2684a8d176034d7857e Reviewed-on: https://chromium-review.googlesource.com/811687Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522188}
-
chrome://interventions-internalsThanh Le authored
Decision log messages are grouped so that they don't flood the logs table. Log messages can be grouped by page_id retrieved from PreviewsIOData. The messages that don't need grouping can use 0 as page_id, since the generated IDs start at 1. Screenshot: https://drive.google.com/a/chromium.org/file/d/17mp8fIHWIJjbZp_t711PGLEaWuZoG1v2 Screenshot: https://drive.google.com/a/chromium.org/file/d/1KI_f1XCYVSk2hLqq2LGaTr0g7LZ6oQcd Bug: 791637 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5eff89d6a8ffc38209819d8787fdac30caaa939a Reviewed-on: https://chromium-review.googlesource.com/806758Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Lily Houghton authored
Per https://bugs.chromium.org/p/chromium/issues/detail?id=755727, as of C++14, std::make_unique provides the same functionality as Base::MakeUnique, and is preferred. Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaac534f4598872f56ddad67afcfaac4318883edf Reviewed-on: https://chromium-review.googlesource.com/806595 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#522186}
-
gogerald authored
TBR=rouslan@chromium.org Bug: 787837 Change-Id: I86e4e239329a93d4e1e2b28ac83d3732c447f47d Reviewed-on: https://chromium-review.googlesource.com/811747Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Sébastien Marchand authored
This reverts commit 88125134. Reason for revert: Breaks the Windows build This breaks the Windows build (in some situation), https://chromium-review.googlesource.com/c/chromium/src/+/810787 fix some issue but it's not sufficient, e.g. https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/60438 failed with the following stack trace: FAILED: gen/chrome/test/data/media/engagement/preload/test.pb C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../tools/media_engagement_preload/make_dafsa.py ../../chrome/test/data/media/engagement/preload/test.json gen/chrome/test/data/media/engagement/preload/test.pb Traceback (most recent call last): File "../../tools/media_engagement_preload/make_dafsa.py", line 17, in <module> import media_engagement_preload_pb2 File "C:\b\c\b\win\src\tools\media_engagement_preload\media_engagement_preload_pb2.py", line 8, in <module> from google.protobuf import descriptor as _descriptor File "C:\b\c\b\win\src\third_party\protobuf\python\google\protobuf\descriptor.py", line 37, in <module> import six ImportError: No module named six Original change's description: > Media Engagement: Add DAFSA generator and reader > > Add a tool to generate preload data in DAFSA format and > add a MediaEngagementPreloadedList class to read it. > > BUG=787464 > > TBR=dpranke@chromium.org > > Change-Id: If0d99a2e1091d0b23699f2173d8146582173ee54 > Reviewed-on: https://chromium-review.googlesource.com/803994 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522068} TBR=dalecurtis@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org Change-Id: I1b5bbaf0dc435a28905bfdaf15142115e8636d2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787464 Reviewed-on: https://chromium-review.googlesource.com/811945Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#522184}
-
Sébastien Marchand authored
This reverts commit 3946a6ad. Reason for revert: This is breaking the Windows build. https://chromium-review.googlesource.com/c/chromium/src/+/803994 broke the Windows build and needs to be reverted, and as this CL is depending on it it need to be reverted too. Original change's description: > Media Engagement: Histograms for preloaded list. > > This adds two histograms to MediaEngagementPreloadedList. The first is > used when the list is loaded and will allow us to see if the loads are > failing and why. The second is used when the list is checked and will > allow us to see if the list has not been loaded or is empty, as well > as how often the list is matching. > > BUG=787464 > > Change-Id: I935405ef56aa197a2f32fbd85df7c9ae4851b12a > Reviewed-on: https://chromium-review.googlesource.com/808305 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522085} TBR=jwd@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org Change-Id: Id6f811e28c70063467a0ce1e97da59a2dc0e6c14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787464 Reviewed-on: https://chromium-review.googlesource.com/812044Reviewed-by:
-
Biao She authored
Previously, we create a GvrDevice even if VrShellDelegate thinks VR is not available. This GvrDevice may works for magic window but can't present as Vr presentation depend on VrShellDelegate. However, the returned GvrDevice marks itself as a device which set canPresent to true. This leads to confusion. This CL gate GvrDevice creation on the same criteria as VrShellDelegate. Bug: 790770 Change-Id: I686eda152418b71ad5c5344aed593903db2b70f7 Reviewed-on: https://chromium-review.googlesource.com/809227Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#522182}
-
Jay Civelli authored
Moving PdfRenderSettings from pdf_to_pwg_raster_converter.mojom to its own mojom/typemap/traits files as it will soon be used by other interfaces. Bug: 766451 Change-Id: Ib50ceeefa62a56c91048d6a346323b4cad601359 Reviewed-on: https://chromium-review.googlesource.com/811448Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Tom Sepez authored
Remove unused argument |policy| from callbacks. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id9f314616b55d774bd0b3af5b66abfa14683c788 Reviewed-on: https://chromium-review.googlesource.com/809919Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#522180}
-
Nick Carter authored
Bug: 792546, 786505 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id8ff7999115ca602c929b8c8e691121894ed94b7 Reviewed-on: https://chromium-review.googlesource.com/811744Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#522179}
-
Xianzhu Wang authored
Bug: 777259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id10b46d54508fc3332c2a20336deaa0f74027554 Reviewed-on: https://chromium-review.googlesource.com/806441 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522178}
-
Julia Tuttle authored
Bug: Change-Id: Iab20bd4453111727924d9eb7de040e6a48c13909 Reviewed-on: https://chromium-review.googlesource.com/811825Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#522177}
-
Dianna Hu authored
This CL was intended to change ssize() to size(), but the change to use ssize() was not merged, so this CL is mostly a no-op (except for some minor convergence opportunities). This CL lands server change 177314606 by sbenza. BUG=488484 Change-Id: I14358dc6888026ad59fd0a8e48b52147637b6c51 Reviewed-on: https://chromium-review.googlesource.com/809846 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Stefan Zager authored
A few more layer tree dumps. BUG=711468 Change-Id: I8648cd7070f43a0bddc0bde24f7a30cfe93b0433 Reviewed-on: https://chromium-review.googlesource.com/809847Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#522175}
-
Devlin Cronin authored
The AutomationInternal API currently passes the RenderView routing ID to the API implementation for enableTab and enableDesktop. This routing ID is then stored, and used to "route" a response IPC (ExtensionMsg_AccessibilityEvent or ExtensionMsg_AccessibilityLocationChange) back to the renderer. However, the listener in the renderer is, in fact, just an IPCListener that attaches itself to the main RenderThread. It doesn't look at the routing at all. Thus, we don't need the routing ID for the browser to send the message, and, since that's the only place it was used, don't need to send it in the API params. Remove the routing ID parameter from both automationInternal.enableTab and automationInternal.enableDesktop, and update the IPC messages. Bug: 304341 Change-Id: I3a82ab3193c70e7cf8694277e28c82c47f431ce4 Reviewed-on: https://chromium-review.googlesource.com/721268Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522174}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I41e47e5c6e6ed7ad350dfb0d5ddf79dd4774e3a5 Reviewed-on: https://chromium-review.googlesource.com/810011Reviewed-by:
Krishna Govind <govind@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#522173}
-
Lukasz Anforowicz authored
The LazyInstance::operator== removed by this CL is undesirable, because 1) it didn't have a corresponding operator!= 2) it was only used to compare against nullptr (i.e. to check if the lazy instance was created already or not) This CL removes LazyInstance::operator== and replaces it with LazyInstance::IsCreated() method. Bug: 789738 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idfbb4a9f0699cb10f3f861860070b7f316a16ad6 Reviewed-on: https://chromium-review.googlesource.com/792124Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Charles Harrison authored
This CL abstracts some logic for "click position" to be shared by both the popup tab helper, and the framebust tab helper. Additionally, it stores a closure on the framebust tab helper to be associated with each individual entry. This is used to collect metrics for tab-under blocking on desktop. Bug: 661629 Change-Id: Ibdc043c1d3068c38dad304be42b2d48133b3f21e Reviewed-on: https://chromium-review.googlesource.com/809098 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#522171}
-
Doug Arnett authored
There is an issue with not having the previews state bits cleared per server previews response headers in the UI thread. This causes an issue for an HTTP->HTTPS redirection that preforms NoScript preview - the previews state confused the PreviewsInfoBarTabHelper. This is a patch to fix M64 Dev channel. The proper fix (setting previews state consistently is a separate change in progress for M65). Bug: 792275 Change-Id: I28788c608ef37f208edbc72df7602294f56995f5 Reviewed-on: https://chromium-review.googlesource.com/811626Reviewed-by:
-
Derek Cheng authored
Move screen availability logic PresentationDispatcher into Blink code. A new class, blink::PresentationAvailabilityState, is introduced to keep track of the availability and listening states of PresentationAvailability objects. PresentationAvailabilityState is owned by blink::PresentationController and shares its PresentationService mojo ptr to communicate with the browser. Also rename PresentationServiceClient Mojo interface to PresentationController (in parallel with PresentationReceiver). With the rename, we also move its implementation from PresentationDispatcher into blink::PresentationController. This allows us to remove WebPresentationController and WebPresentationAvailabilityObserver. This patch also fixes a bug (which also leads to layout test flakiness) where Mojo message pipes for PresentationService/PresentationController are not removed on navigation. This is fixed by resetting the bindings and mojo ptrs in PresentationServiceImpl::Reset. We also reset the PresentationService mojo ptr in PresentationDispatcher::DidCommitProvisionalLoad as a temp fix while PresentationDispatcher still remains. Bug: 749327, 761561 Change-Id: I8834f130fdc70879119ee81eeaf5b5965fec9098 Reviewed-on: https://chromium-review.googlesource.com/724724Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#522169}
-
Maks Orlovich authored
This concerns the following scenario: Suppose you have a transaction t1, with a cache entry e1. Then t2, with entry e2 comes in, becomes definitive for the same URL, and gets t1 to doom its entry. The following sort of interleaving of events is possible: doom(e1) t2.writeInMemoryCacheHints() t1.writeInMemoryCacheHints() At this point a cache read later will have memory hints based on t1, but cache contents based on t2. Bug: 787958 Change-Id: I8c42d975fdbf8f6d1fb76238a71ee383842a8576 Reviewed-on: https://chromium-review.googlesource.com/791154Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
-
gogerald authored
TBR=khushalsagar@chromium.org,chrishtr@chromium.org Bug: 792540 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0fb45968230846c0ffb8168d8d31a87bad06fcb5 Reviewed-on: https://chromium-review.googlesource.com/811588Reviewed-by:
-
Vincent Scheib authored
Comment only changes to explain the different Bluetooth testing APIs. TBR: scheib@chromium.org Change-Id: I04329dd47f485c2e1042f7287ac05b160599ead4 Reviewed-on: https://chromium-review.googlesource.com/810087Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#522166}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/12a18ad357bc..10a4d43462fa $ git log 12a18ad35..10a4d4346 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 xinghua.cao ES31: Enable some dirty bits and dirty objects for compute pipeline Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Iece21897477d2beb8aafb5846545737a151cbba0 Reviewed-on: https://chromium-review.googlesource.com/811449Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522165}
-
Morten Stenshorne authored
It's unclear what it attempted to test. The file name suggests something with margins, but there are no margins in the test. Furthermore, the ref assumes a buggy intrinsic width calculation: There are four words of column content. The max-content-width should be so that the multicol container can hold all the four words on the same line. There are four columns too, so the multicol container actually has to be rather wide. If column-gap is 1em and each character and non-collapsable whitespace also is 1em wide, the width of the line of text will be 4+1+4+1+4+1+4em = 19em. That's the column width we want. But we have 4 columns, so multiply that by 4 -> 76em. Add the 3 gaps between the 4 columns -> 79em. I.e. 1264px if the font-size is 16px. The ref assumes way less than that (22em). Bug: 788337 Change-Id: I076af29bf53914557c40b5e438b5eebfb8439e42 Reviewed-on: https://chromium-review.googlesource.com/811645Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Reilly Grant authored
When SensorProviderProxyImpl receives a connection error on its SensorProvider pipe it should forward that upstream to its clients so that they observe the error instead of never receiving a callback to their GetSensor requests. Bug: 792222 Change-Id: I36f11df4b4ec58631ffd67f07dc1143d65a809f5 Reviewed-on: https://chromium-review.googlesource.com/809922Reviewed-by:
-
Katie Dektar authored
Fixed positioned elements are not clipped by their ancestors, except by the rootWebArea. Similarly with absolutely positioned elements, except if they have an ancestor with some non-static positioning. Bug: 792124 Change-Id: I9c31c90fed89179434ae7f89aa18528e929348da Reviewed-on: https://chromium-review.googlesource.com/809828 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
-
Matthew Jones authored
This change refactors much of the progress bar code in an effort to simplify the logic that has grown out of control. The significant changes are as follows: - The smooth progress animator runs until progress is finished instead of ending when progress reaches the current complete percentage. - 'finish(...)' is blocked until the progress animators are complete unless it is called with 'fadeOut' set to false (see todo in code). - 'updateVisibleProgress' has been removed as its function had become unclear. - More complete tests to exercise the different functionality. BUG= Change-Id: I95ff4c5918bccaac5bc1ef025254caea13a862c2 Reviewed-on: https://chromium-review.googlesource.com/769772 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522161}
-
Yuzhu Shen authored
It is only used by the old-style Mojo JS bindings, which have been removed. Bug: 718047 Change-Id: Ib3e112f8b2a9cd772bb15146ee52eb1de63b2eff Reviewed-on: https://chromium-review.googlesource.com/809772 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
-
Sandra Sun authored
The failure is likely caused by the scrollbar thickness varied across platforms. So I use MaiximumScrollOffset as expected value in test. This patch also check nullptr when getting ScrollableArea to fix a clusterfuzz failure in the previous patch. This is a reland of a9783e12 Original change's description: > Snap at GestureScrollEnd on main thread. > > As the first step of ScrollSnapPoints, this patch implements it on main > thread at GestureScrollEnd. It introduces necessary data structures: > SnapAreaData and SnapContainerData, updates the data after style change > and layout, implements a naive algorithm to select snap points at > intended-end-position, adds unit-tests for logic and adds sim-tests for > behavior. > > Bug: 778257 > Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47 > Reviewed-on: https://chromium-review.googlesource.com/756887 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521840} TBR=bokan@chromium.org,jbroman@chromium.org,majidvp@chromium.org,shend@chromium.org Bug: 778257 Change-Id: I437e7491c4a98c8ecaa5b15124c48e97e60fa57a Reviewed-on: https://chromium-review.googlesource.com/810059 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#522159}
-
