GitLab

This is a reland of e6db40d9

Reason for reland: All bots should now have libuuid1 installed (bug 853048).

Original change's description:
> Update fontconfig to 6cc99d6a
>
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
>
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
>
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
>
> BUG=831146,822737,787020,829890,847323
> TBR=thestig,dnicoara
>
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

TBR=thestig,dnicoara

Bug: 831146, 822737, 787020, 829890, 847323, 853048
Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
Reviewed-on: https://chromium-review.googlesource.com/1104759Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568221}

This operation attempts to connect to a remote device over BLE via the
listener role via BleConnectionManager.

Bug: 824568, 752273
Change-Id: Ie6be7b139b8234049df4d1f1c2535254a1b962a0
Reviewed-on: https://chromium-review.googlesource.com/1103009
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568220}

This reverts commit 08410d56.

Reason for revert: 
This appears to be causing build failures due to a DEPS issue:
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943347677136985328%2F%2B%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

BUG=853968

Original change's description:
> Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2.
> 
> Previously MixerOutputStreamFuchsia was using media_client library,
> which is deprecated now. Update it to use AudioRenderer2 FIDL interface
> directly.
> 
> Bug: 851733
> Change-Id: I72a43369d16ecd626aa7294a6f3500b57bb3731e
> Reviewed-on: https://chromium-review.googlesource.com/1100376
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568159}

TBR=wez@chromium.org,sergeyu@chromium.org,kmackay@chromium.org

Change-Id: I9b5b2262d8ddc2edb706fb6fbec3d1fdc6d19563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851733
Reviewed-on: https://chromium-review.googlesource.com/1105320Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568219}

The surface sync APIs are used in views mode (becaused we use a single
ui::Compositor).

Delete some of the now-dead code from RWHVMac (it has deep roots which
still need to go).

Change-Id: I6f065288c27d3ebecf113494751bfc8dfd199fd7
Reviewed-on: https://chromium-review.googlesource.com/1105024Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568218}

Update the TestDelegate:
- Add RunUntilRedirect() and RunUntilAuthRequired() APIs.
- Create a clean separation between "legacy" and new API closures.
- Call the on_<event> closures in-line, rather than via PostTask.
- Use OnceClosures for new APIs instead of RepeatingClosure.
- Remove set_quit_on_redirect() and set_quit_on_auth_required().

Related changes to tests, including:
- Add necessary RunUntilIdle() calls after e.g. RunUntil*(), in
  various tests that were relying on QuitWhenIdle behaviour.
- Update FakeExternalProtocolHandlerDelegate,
  ExternalProtocolHandlerTest, EmbeddedTestServerTest,
  CancelRequestDelegate and SSLClientAuthTestDelegate to use
  QuitClosure.

Bug: 850145
Change-Id: I9320e5b7dc3e4aac883fa49dcdcd6384bc7d3ce9
Reviewed-on: https://chromium-review.googlesource.com/1094209Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568217}

Add the default selectable item background to the bookmarks/downloads
shortcuts on the "simplified NTP".

BUG=852392

Change-Id: Iebf2dce9d36d458d566a15ee2e9eeb8b1362bdee
Reviewed-on: https://chromium-review.googlesource.com/1105192Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568216}

BUG=778749

Change-Id: I0f3cfea90ffefa739c82a673a4e2e8abd5dfba00
Reviewed-on: https://chromium-review.googlesource.com/1104582Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568215}

TBR=bauerb
NOTRY=true

Bug: 847341
Change-Id: If94212431798176fc4b692088930c9c35d36074d
Reviewed-on: https://chromium-review.googlesource.com/1105406
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568214}

Change-Id: I6e391fadbbf47aa6427a16495bdca3c88d456b05
Reviewed-on: https://chromium-review.googlesource.com/1105041Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568213}

Follow up to crrev.com/c/1104308

Bug: 828031
Change-Id: I6ebb02a2c1d0aae83c8db9d7c3e13e2c154d965a
Reviewed-on: https://chromium-review.googlesource.com/1105121Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568212}

[LayoutNG] Stop NGInlineFragmentTraversal::SelfFragmentsOf() from collecting descendants of already collected inline fragments

The above function is used to compute rects of a LayoutInline, and is
especially useful when the LayoutInline doesn't generates its own boxes.

However, currently the function may collect a fragment even if there's
an inline ancestor fragment collected. For example:

<span id="culled">
  <span id="preserved" style="border: 1px solid black">
    text
  </span>
</span>

When calling SelfFragmentsOf() on SPAN#culled, it collects both the box
fragment of SPAN#preserved and the text fragment. This results in wrong
calculation of rects of culled inline elements, and also some failures
in client-rect-related tests.

This also conflicts with the legacy behavior, where if a LayoutInline has
already has an InlineBox, the legacy rect generation functions no longer
collect the descendant InlineBoxes.

This patch fixes the issue by storing a stack of currently entered
inline box fragments, and collect a fragment only if none of its
ancestor inline fragments is entered (which means all of them, if any,
are culled).

While being a standalone fix, this patch also helps preserving more inline
fragments to make hit testing inline elements easier.

Bug: 851075
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8567f1258221c78806be1bb1628b8a63c7ea3281
Reviewed-on: https://chromium-review.googlesource.com/1091921
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568211}

The following tests are failing on Mojo Linux Perf:
* loading.desktop.network_service/AirBnB_cold
* loading.desktop.network_service/AirBnB_warm
* loading.desktop.network_service/Kenh14_cold
* loading.desktop.network_service/Kenh14_warm
* loading.desktop.network_service/Taobao_cold
* loading.desktop.network_service/Taobao_warm

See bug for deailed reports.

This patch also cleaned up platform filters (only have Linux bot).

(TBR since it's Mojo Linux Perf bot only)
TBR=kouhei@chromium.org

Bug: 853835
Change-Id: Idaf3487bd8933b93cd8f4e93c81645dcc8712ade
Reviewed-on: https://chromium-review.googlesource.com/1105023Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568210}

This reverts commit 5cf1517a.

Reason for revert: this change won't work as explained in https://bugs.chromium.org/p/chromium/issues/detail?id=808775#c9 and on clusterfuzz-dev@chromium.org

Original change's description:
> Increase memory size for media_vpx_video_decoder_fuzzer
> 
> The maximum frame size in VP8 is 16,384 x 16,384, which uses most of the
> default 2048 Mb allowed. Bumping up the size to 4096 Mb to handle the larger
> frame size.
> 
> BUG=808775
> TEST=fuzzer test case passes
> 
> Change-Id: I8e1e56bbd0936e745792f34106c7e638ff5a1c2b
> Reviewed-on: https://chromium-review.googlesource.com/1100004
> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
> Commit-Queue: John Rummell <jrummell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567355}

TBR=jrummell@chromium.org,chcunningham@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 808775
Change-Id: I47d8005442d6b81dcd023a1071e344c2e09304e5
Reviewed-on: https://chromium-review.googlesource.com/1104826Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568209}

https://chromium.googlesource.com/media_router.git/+log/50d927e72030..9f9f41bdd831

$ git log 50d927e72..9f9f41bdd --date=short --no-merges --format='%ad %ae %s'
2018-06-14 mfoltz First step to deprecate and remove test: URLs from mr.TestProvider.
2018-06-05 mfoltz [Media Router] Associate issues with sink IDs
2018-03-20 mfoltz [DIAL MRP] Use the correct URL for DELETE.

Created with:
  roll-dep src/chrome/browser/resources/media_router/extension/src

Change-Id: Icfc0e013d228a0e3456e0e98c0c69c85af8ee7b8

TBR=imcheng

Change-Id: Icfc0e013d228a0e3456e0e98c0c69c85af8ee7b8
Reviewed-on: https://chromium-review.googlesource.com/1103440Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568208}

Old implementation of NGInlineFragmentTraversal traverses all descendants
of an NGPhysicalFragment, and uses a filter to decide which fragments to
emit. As a result, the implementation is convoluted.

This patch rewrites it by using a visitor that can decide the traversal
process, and also when/what to emit. As a result, the implementation
is greatly simplified.

Bug: 851075
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I67a1331f906981e48cc366697234f8d5996c02ea
Reviewed-on: https://chromium-review.googlesource.com/1097877
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568207}

Add a test that checks if the BrowserTouchBar's
BookmarkTapHelperObserver gets removed when it's destroyed.

Follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1099483

Bug: 852222
Change-Id: I60c08a195a8b8adb1848d120c3492783fa615ba9
Reviewed-on: https://chromium-review.googlesource.com/1101484
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568206}

This CL removes the unused network_dropdown.js and related C++
support classes including network_menu.cc.

It also includes some related cleanup.

Bug: 689198, 728806
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ieb1e97ce4c4308874f8c977f4d6290a0d91bf15d
Reviewed-on: https://chromium-review.googlesource.com/1083173
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568205}

This behavior will now match UKMPageLoadMetricsObserver, which is key
to keeping the metrics in sync.

Change-Id: Ic92efc53e8c68d8f298ebdb8c9059c4e0604afb0
Reviewed-on: https://chromium-review.googlesource.com/1101700
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568204}

In the Android horizontal tab switcher, we determine which tab thumbnails to
render based on the index of the currently-centered tab, as determined by
NonOverlappingStack#computeReferenceIndex() (this is a virtual method called by
Stack since the logic for updating visibility is shared between the overlapping
and non-overlapping tab switchers). We currently have a bug where the tab
thumbnails are becoming blank during quick scrolling. This is because the
current implementation of this method uses mScrollTarget instead of
mScrollOffset to determine the centered tab (basically, mScrollTarget is where
we're going and mScrollOffset is where we are, and is actually used for
rendering).

This CL fixes this bug by updating this method's implementation to use the value
returned from getCenteredTabIndex(), which uses mScrollOffset instead of
mScrollTarget.

Bug: 853879,831359
Change-Id: I129c03ca80297c15b670d223bfc6630b6d8de68c
Reviewed-on: https://chromium-review.googlesource.com/1105021Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568203}

BUG=628650

Change-Id: Ia78bfe6ad2d12362cb85bcc4580d907fe1ed6b47
Reviewed-on: https://chromium-review.googlesource.com/1105181Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568202}

This is a reland of edb91802

Original change's description:
> Add an interface to communicate between the fake openvr and tests
> 
> This change creates a way for tests to control the behavior of
> the fake OpenVR, and allows devices to send information up to
> tests.
> 
> BUG=801034
> 
> Change-Id: Ie0fe035ada9553114c054717f52788d375d5c62f
> Reviewed-on: https://chromium-review.googlesource.com/1100157
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567725}

Bug: 801034
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic4c1b4891df8ba1de9d7bf07863d4b696ec81de0
Reviewed-on: https://chromium-review.googlesource.com/1104761
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568201}

This commit reenables ClickingContextMenuDoesNotDismiss but moves it
into Ash.

Bug: 733662
Change-Id: If176458fd07d949c8d21082b40ed06f4f571b3d5
Reviewed-on: https://chromium-review.googlesource.com/1100675
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568200}

The layout test's baseline somehow got one "PASS" line missing, making
it incorrectly marked as failure. This patch corrects it.

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia0281dd694b72103b97858bfc3104766c5f4ef4c
Reviewed-on: https://chromium-review.googlesource.com/1104720
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568199}

Bug: 714018
Change-Id: I9ecc53ebb303b1c08ca4f21f9b948fdbfa02598c
Reviewed-on: https://chromium-review.googlesource.com/1104387Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568198}

This CL adds EventListenerBreakPoints for the AudioContext constructor,
AudioContext.close(), AudioContext.resume() and AudioContext.suspend().

Bug: 848473
Change-Id: Ifbbccfd1e21dc8b5b444993c7143e869a56d7e6c
Reviewed-on: https://chromium-review.googlesource.com/1089200
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568197}

Floats and out-of-flow objects need to be true layout siblings of the
inlines, or rendering will be wrong. This means that such objects should
never be siblings of anonymous blocks, but rather inside them. This
already works correctly for initial layout tree building, and also for
many DOM manipulations. However, code was missing to satisfy this
requirement if we removed a regular block that was a sibling of an
anonymous block and either a float or out-of-flow positioned object.

This even caused a crash triggered by ruby code, which ended up mixing
inline and block children within the same container. That is not
allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call
inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to
MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix);
When moving children from one container to another, either both or none
of the containers must have inline children.

This is a reland of https://chromium-review.googlesource.com/1102690
with some modifications to avoid bug 853552.

Bug: 852640
Change-Id: I0f8a0aa5523e8fe60c841164d25aad088f4b728f
Reviewed-on: https://chromium-review.googlesource.com/1104900
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568196}

Splits code that loops over accessibility events from the code that
loops over dirty nodes that need to be serialized. Keeps track of
duplicate ids and avoids serializing the same node twice.

This is a different approach than crrev.com/c/1063007
"Avoid serializing the same accessibility node twice in the
same message" which tried to put all of the nodes in
the same AXTreeUpdate. That approach could fail in rare cases when
multiple updates both tried to set node_id_to_clear.
Now we've refactored the event message so that it can
contain multiple AXTreeUpdates, so it's safe to just skip
an entire update if it's a node we've already serialized
in this event bundle.

Bug: 651614, 845778

Change-Id: I3cc859e7a63d9c8b8beeb930d96aa53898940485
Reviewed-on: https://chromium-review.googlesource.com/1097423
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568195}

https://chromium.googlesource.com/catapult.git/+log/d994c8643744..f13bae2df0b8


git log d994c8643744..f13bae2df0b8 --date=short --no-merges --format='%ad %ae %s'
2018-06-18 dtu@chromium.org [pinpoint] Update Swarming server API path.


Created with:
  gclient setdep -r src/third_party/catapult@f13bae2df0b8

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:852184
TBR=sullivan@chromium.org

Change-Id: I47ed58f73a0c6e4072c160ec9810def812ec17b6
Reviewed-on: https://chromium-review.googlesource.com/1104920Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568194}

Prevents DCHECK failure when turning on MD Refresh by default in tests
ToolbarActionsBarUnitTest.TestHighlightMode/{0,1}. This was due to an
inconsistent MD mode in the test as the browser window gets constructed
and initialized with the default mode before it's overridden with
ToolbarActionsBarUnitTest::GetParam().

Bug: chromium:846410
Change-Id: Id1fc1a0137d27cb4be7c5ddc32f2a2c9c203e117
Reviewed-on: https://chromium-review.googlesource.com/1102992
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568193}

This CL supports manually scale of ImageSkia for different
representations, which could deliver good visual effect for reps other
than 1x and 2x.

Bug: 840641
Test: manual
Change-Id: I7c131a76297dd565065ff67213b90349ff00206d
Reviewed-on: https://chromium-review.googlesource.com/1081408Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#568192}

Bug: 852617
Change-Id: I3d0e485ac5660e485bc23ffbf7b9069a9187ca72
Reviewed-on: https://chromium-review.googlesource.com/1100195
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568191}

Using the approach suggested in [1].

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1100235

Test: manual
Bug: 845686
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I66a8cb687463c30ba2414c29245797338a49d60f
Reviewed-on: https://chromium-review.googlesource.com/1103280
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568190}

For a little while we have been recording startup metrics based on main
entry point time using two techniques:
* (old way) by converting process creation wall time using
  StartupTimeToTimeTicks()
* (new way) by calling base::TimeTicks::Now()

The new way is theoretically cleaner and removes a few possible skews
(see details in the bug). During a few months of overlap we have been
computing these two histograms for the identical time interval:
* (old way) Startup.BrowserMessageLoopStartTimeFromMainEntry2
* (new way) Startup.BrowserMessageLoopStartTimeFromMainEntry3

On Windows the skew between the two is super tiny (2-3 UMA samples with
difference during the day).

On Android the difference is between 0.5% and 0.7% for the same day for
various quantiles. The overflow bucket (1 hour and more) for the new
histogram is 3.5x smaller - nice. Also the new histogram looks a tiny
bit smoother on Android. Overall the shape of the distribution does not
change our subjective perception of the startup metrics on Android.

Based on these observations this change proposes to:
* Switch the remaining calculations based on the main entry point to the
  new way - calling base::TimeTicks::Now() (no conversion to ticks, not
  using the wallclock)
* Avoid renaming the histograms because the expected difference is
  likely not worth worrying
* Celebrate cleanup :)

Bug: 797762
Change-Id: I5c32541280c359d6571cbcc5c6e7500b79002011
Reviewed-on: https://chromium-review.googlesource.com/1104696Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568189}

BUG=angleproject:1618

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id680ec102ea40bb2117b276e0ffa002956a750d2
Reviewed-on: https://chromium-review.googlesource.com/1101514Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568188}

Bug:853907,853915
TBR=reillyg
NOTRY=true

Change-Id: Ib8e489de591b014a3f33da233bd55cddb56abb59
Reviewed-on: https://chromium-review.googlesource.com/1105302Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568187}

These test verifies that a session will migrate immediately to the alternate network when the default network disconnects.

Bug: 818259, 843299
Change-Id: Id8be7a79db09cf6ec5e706e8bf6442351bdd11cc
Reviewed-on: https://chromium-review.googlesource.com/1103608
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568186}

It is a per-process Mojo interface, since the browser side never
did anything per-frame, and the renderer actually caches this data
process-wide anyhow.

Bug: 846722
Change-Id: I8e0300749b0d1c2b055b512f0d8906c1fcd3e403
Reviewed-on: https://chromium-review.googlesource.com/1073648Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568185}

Once Signal()ed, OneShotEvent should drop all the references to
the tasks, otherwise OneShotEvent::tasks_ would continue to hold
references to users of OneShotEvent::Post(), for the lifetime
of OneShotEvent.

This CL clears |tasks_| once Signal() is called, dropping those
references correctly. In future, OneShotEvent::Post() will take
OnceClosure instead of (repeating) Closure.

This CL also adds a regression test for the same.

Bug: 853649
Change-Id: I10270318ff8393a9af0b8da299a1866df936b273
Reviewed-on: https://chromium-review.googlesource.com/1103606
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568184}

All of these conditions must be true for the current PaintLayer:
1. The layer is not under a non-root composited scroller, or there are no
fixed/sticky descendants.
2. There are no non-contained absolute position descendants (i.e. ones whose containing
block skips the current layer).
3. The current layer has overflow clip.
4. There are no direct compositing reasons on any descendant.
5. There is no currently-composited descendant.

Bug:814439

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74c1ad25ec1c5c20ec3629140b6555c89676a3ac
Reviewed-on: https://chromium-review.googlesource.com/1099972Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568183}

This reverts commit 7f596585.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 568084 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdmNTk2NTg1YTM4MmI3ZDIzNDQ3NDAxOTY4OTU4OGUxOTE5ZDU2OWYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27973

Sample Failed Step: unit_tests

Original change's description:
> cros: Make LoginDisplayHost own LoginDisplay
> 
> Instead of this ownership model
> 
>   LoginDisplayHost owns ExistingUserController owns LoginDisplay
>   LoginDisplayHost owns WebUIScreenLocker owns LoginDisplay
> 
> switch to
> 
>   LoginDisplayHost owns ExistingUserController, LoginDisplay
> 
> This makes it clear that the LoginDisplay instance has one owner, and
> that it shares the same lifetime as LoginDisplayHost.
> 
> Bug: 851012
> Change-Id: I80cb56d8fc244ce5331046ba31defba4cd77c45f
> Reviewed-on: https://chromium-review.googlesource.com/1093741
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568084}

Change-Id: I144f702fc39267db2ef830b276ca3c77c2c3c262
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851012
Reviewed-on: https://chromium-review.googlesource.com/1105240
Cr-Commit-Position: refs/heads/master@{#568182}