GitLab

The process of extracting the TabState from a Tab does not need to be
coupled with the definition of the TabState entity.

Bug: 1090048
Change-Id: I1aad14c0263fd560f4d538fb8eb26b1e0bfa219e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243537
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Maunder <davidjm@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780012}

At the beginning of this refactor there were 2 SharedImageBacking
classes: passthrough vs not-passthrough.

This is towards having 2 SharedImageBacking: GLImage vs normal
GL texture. The classes still inherit from a single Common class.
This moves some of the common code into static methods in the
Common class. In particular
* Make separate InitializeGLTexture functions, and move much of
  the common code into SharedImageBackingGLCommon::
  MakeTextureAndSetParameters.
* Make SharedImageRepresentationSkiaImpl have a method to take a
  callback to make on BeginReadAccess, rather than calling a
  method on SharedImageBackingGLCommon.
  - De-common-ize SharedImageBackingGLCommon::ProduceSkia.
  - Change it to have the caller create the SkPromiseImageTexture.
* Add SharedImageBackingGLImage::InitializePixels
  - For now this just calls glTexSubImage2D
  - In the future this will write to the GpuMemoryBuffer.

Bug: 1092155
Change-Id: If5f60356d683673e610192b7c851664a138a9951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248413
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780011}

aw_browser_terminator.cc was including the JNI header file for
AwBrowserProcess so that it can call TriggerMinidumpUploading, but this
prevents any native methods being added to AwBrowserProcess since each
JNI header can only be safely included by one source file.

Move the JNI header include to aw_browser_process.cc and expose a C++
function for AwBrowserTerminator to call instead of calling the Java
method directly.

Change-Id: If230bfc3d1fb8c3c1eeb7efa2f01b0b45c4d32a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252282
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780010}

If RemoveFrameContainerForReason() successfully removes a frame, the
|this| pointer will become invalid. This CL removes a member function
invocation that occurs when |this| might be invalid.

Bug: 1088187
Change-Id: I5abc6f03ff326ebbcfb696205deb5058ec977c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250580
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780009}

This CL affects debugging UI only.
It extracts the Network State related UI to a new component,
network-state-ui.

Bug: 921726
Change-Id: I8df48464a6604e1b605d97df21e498927f582b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240236Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780008}

TBR=govind@chromium.org

Change-Id: Id5d9e05cbb783022c7cfca42a4756a37c260815d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252689Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780007}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

(This doesn't add direct includes for all uses of CHECK etc, only the
ones that will be broken by subsequent CLs to cleanup includes.)

Bug: 1031540
Change-Id: Ie8e24df57a4ca317a7932b13aee4ea8f39c84d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248577
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780006}

We had this feature to better support Query in Omnibox.

Now that Query in Omnibox has been deleted this is no longer needed,
since plaintext URLs are generally handled somewhat better than links.

This CL also removes some stale references to Query in Omnibox in
some comments.

Bug: 874592
Change-Id: Ia1cf70d0a0598897202e3241a90e459d470d3620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250831Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780005}

Reset the baselines for:
compositing/masks/mask-with-added-filters.html
compositing/masks/mask-with-removed-filters.html

TBR=jonross@chromium.org

Bug: 1096568
Change-Id: I4527a0b6868a7e9112330ab05e6fdb108e08b26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252679Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780004}

An EXCEPTION_ACCESS_VIOLATION_READ crash was reported in
CaptionBubble::GetNumLinesInLabel. I believe the cause is that
CaptionBubble::GetNumLinesInLabel calls Label::GetRequiredLines, which
is a const function. To fix this, I mark
CaptionBubble::GetNumLinesInLabel as const.

While I am here, I am also performing a check that observer_ is not
null in CaptionBubbleModel::CommitPartialText, which would cause a
different crash.

Bug: 1055150, 1096366
Change-Id: Ic039de789f4ce5dc34b3dff0ee11e38bcfabb4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252198
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780003}

This is equivalent to the existing DeleteFile(path, false). It will help
migrate the existing callers to the 2-parameter function incrementally,
and remain after the 2-parameter function goes away.

Also put this and DeleteFileRecursively() above the 2-parameter
function, so readers will see them first and hopefully use them.

Convert the unit tests to use this new version of DeleteFile().

Fix a few pieces of code that have trouble distinguishing between the
two variations of DeleteFile().

Bug: 1009837
Change-Id: I8befdc95dc9ed4d9da501126bf545334011b048a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952387
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780002}

Roll Chrome Win32 PGO profile from chrome-win32-master-1592492320-3ab827aecaa4186da1d1047a6b75e711e06263db.profdata to chrome-win32-master-1592495797-0ce2a459124ac0074ced31c25e7b4057cfe18bea.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I37a330d56053d370e4490c5a5f72ae44dc90e833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780001}

The actual flag was removed a while ago, but traces of it remained:
- in flag_descriptions
- in flag-metadata.json
- in fieldtrial_testing_config.json

This CL cleans them all up.

Bug: 1010397
Change-Id: I300b7808788ff873249ec62935cc9870a91712f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250105Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780000}

Test fast/canvas/canvas-composite-text-alpha.html keep failing due to
timeout. Add it to the slow test list.

Bug: 1093836
Change-Id: I636b75378855af72869fbc5c1295fa0f8aafd3f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252683Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779999}

This will help move its tests over to LMY48M from LMY48I, for
consistency with the the release tester.

Bug: 1091539
Change-Id: Icbf74b9c766e836f74cf61abafb92861a8e62871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252840Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779998}

Ideally, if an event is associated with a compositor frame, it means
that the event was created before the compositor frame is submitted to
viz for presentation. So, the time stamp of the event should be smaller
than the start time of viz stage in CompositorFrameReporter. However, it
seems that it's not the case all the time (see the associated bug). For
now, let's silently ignore such cases instead of a DCHECK. Hopefully,
our work on investigating discrepancies between the new EventLatency and
the old Event.Latency would reveal the cause of the issue. If not, we
should reconsider this case.

Bug: 1093698
Change-Id: I4ce943fe2c9ed69caba82b34b652fa14e027d549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252678Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779997}

Bug: chromedriver:3376
Change-Id: I88f1ea001b600743be4f158a44cc4ac68652c257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250082
Auto-Submit: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779996}

Also add screenshots for these to aid translators.

Bug: b/158618555
Change-Id: Ia41fcbc18b36f42b050c790fb9d71e1097245376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252651
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779995}

This will help translators come up with an appropriate localized string
in their languages.

Bug: b/158612775
Change-Id: I807363055ffe36d1416a9f92e0a12a1e28160612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252843Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779994}

... instead of WebMediaStreamTrack.

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

BUG=704136
R=guidou@chromium.org

Change-Id: I20c6b61c96f12319f1b81f19b16a94bd025993d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248220Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#779993}

Remove reading from command line to obtain cast display rotation from
CastDisplayConfigurator. The display rotation is now read from kernel
for https://chromium-review.googlesource.com/c/chromium/src/+/2229725

Bug: b/77900197
Test: build and run on device.
Change-Id: I8d1f4c49c4a0ae12ea01c982d72af7f2c8617f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252938Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Yuanyao Zhong <yyzhong@google.com>
Cr-Commit-Position: refs/heads/master@{#779992}

This allows LaCrOS crashes to be triaged separately from
Chrome_Linux crashes.

Change-Id: I1b441519dffb508593915a93d5ccbc44e83f0dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252625Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779991}

TBR: szager@chromium.org
Bug: 1096612
Change-Id: Ia9d5df25ff3bcf59ac0fb1b169572e73b2436014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252648Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779990}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I4a1e3c4bfe1e1bdf32f1dc9078aed46e5c885c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249838
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779989}

This reverts commit a4a3a1a6.

Reason for revert: Suspected of failing dozens of CrSettings* tests in browser_tests and interactive_ui_tests, on multiple bots. See comment in https://chromium-review.googlesource.com/c/chromium/src/+/2246157

Original change's description:
> [b4p/Settings] Display removal dialog
>
> This CL starts displaying the dialog from crrev.com/c/2248180. Moreover,
> RemovePasswordBehavior is deprecated. The more elaborate logic of
> removing different copies of a password can live directly in the dialog,
> while PasswordsListHandler can use simple logic for the case when a
> single copy must be removed. In particular, it felt strange that
> PasswordListItem has this Polymer behavior but never used any of its
> functionalities (it was PasswordsListHandler that used it instead).
>
> We also use the occasion to fix an aspect of crrev.com/c/2235850. If
> the entry is moved, there's no element to reset the focus to, so the
> focusWithoutInk() call is removed. The same is done for removal dialog.
>
> Bug: 1049141
> Change-Id: I06fe35b8bd14ee27873b6a56849e755c02cbc1bb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246157
> Commit-Queue: Victor Vianna <victorvianna@google.com>
> Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779757}

TBR=fhorschig@chromium.org,aee@chromium.org,victorvianna@google.com

Bug: 1049141
Change-Id: I429f8f5507fbc5e2784d78b3bfd3bed897f59d89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252612
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779988}

[Sheriff] Set expectations for flaky fast/canvas/OffscreenCanvas-MessageChannel-transfer.html on Linux

TBR=smcgruer@chromium.org

Bug: 1095969
Change-Id: I277858b1c557269874f1b2e338741674f411c313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249998Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779987}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d438a6023a21..477818f5075f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC smcgruer@google.com,atotic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1052567,chromium:1093981,chromium:1093993
Tbr: smcgruer@google.com,atotic@google.com
Change-Id: Icdfd087e279bc60db1fba122c0f3a21fe5264888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252520Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779986}

https://skia.googlesource.com/skia.git/+log/81454dfaa92a..c950e05bafcd

2020-06-18 mtklein@google.com clean up old idea about nullptr/sRGB
2020-06-18 adlai@google.com Consolidate GrDrawingManager <-> GrRenderTask lifecycle
2020-06-18 egdaniel@google.com Revert "Don't release vk memory allocator until context is deleted."
2020-06-18 mtklein@google.com runtime shader children on skvm backend
2020-06-18 egdaniel@google.com Don't release vk memory allocator until context is deleted.
2020-06-18 nigeltao@google.com Reland "Allow building with Wuffs v0.3, not just v0.2"
2020-06-18 bsalomon@google.com Merge ShaderMode and FilterLogic enums in GrTextureEffect
2020-06-18 johnstiles@google.com Fix stack-buffer overrun in appendVAList.
2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98d0f30c4393 to fa3d64bf72d6 (41 revisions)
2020-06-18 rmistry@google.com Change URL in skia_css3gradients_desktop.py
2020-06-18 bsalomon@google.com Make Clip test FP use texture effect child
2020-06-18 bsalomon@google.com Use child effects for LUTs in perline noise effects
2020-06-18 bsalomon@google.com Update generated file
2020-06-18 bsalomon@google.com GrRRectBlurEffect uses child for nine patch
2020-06-18 dmazzoni@chromium.org Get rid of deprecated API to add children to PDF tag nodes.
2020-06-18 egdaniel@google.com Fix perspective fragcoord value in d3d.
2020-06-18 brianosman@google.com Support sample() in ByteCodeGenerator (but not the interpreter)
2020-06-18 bsalomon@google.com Use child effect for integral in GrRectBlurEffect
2020-06-18 djsollen@google.com Manually update ANGLE DEPS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1078330,chromium:1081806,chromium:1085996,chromium:1091259,chromium:1092743,chromium:1094634,chromium:607777
Tbr: djsollen@google.com
Test: Test: Test: Build/CQTest: Test: angle_end2end_testsTest: Test: angle_end2end_tests.exe --gtest_filter=ImageRespecificationTest*Test: Test: dEQP-GLES31.functional.image_load_store.*.format_reinterpret.*
Change-Id: I5aecf7ec290346781fa50d5ddd3817088aa62326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252523Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779985}

https://android.googlesource.com/platform/external/perfetto.git/+log/9c7a8fbc5977..28c801fc37b8

2020-06-18 treehugger-gerrit@google.com Merge "Add an optional fake system tracing backend"
2020-06-18 chiur@google.com Merge "Move Specification to InternedData"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ib781c457d05d63d74e7e1ba266912770c6e4e3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252521Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779984}

Bug: 1094350
Change-Id: Id0f2d6318e5f34d9278a766d5f5cde736b16abd9
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243259
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779983}

The ordering between the destruction of each WorkerTaskProvider and
the ProfileManager/g_browser_process instance is not guaranteed.
This means that it's necessary to check if the ProfileManager still
exists before unregistering from it, which preclude us from using
ScopedObserver.

This is a common pattern for other ProfileManager observers
instances.

Bug: 1094235
Change-Id: I35369d8938c95dcc6ef5204ea15b5f4dfa4d000e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248073
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779982}

Since this value is false on most platforms, only set the flag when true
to reduce the stored UMA log size
see https://chromium-review.googlesource.com/c/chromium/src/+/2245893
for changes to the OmniboxEvent.

BUG=1090911

Change-Id: I766fc8d0f07eb4ff237b137b51806373005267f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250558Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779981}

ScopedFeatureLists are supposed to be initialized in text fixture
constructors to avoid data races.

Bug: 1095832
Change-Id: Ifd4a290cd4cf49421df99c5c0338e0fa8633d2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250084
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779980}

Change-Id: I95c2de6a9924eabaf149cb982a3e3e756a022f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238381
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779979}

In Child lock screen, set time to 24 hour clock format if the
child user turn on "Use 24-hour clock" in preference.

Bug: 945186
Change-Id: I760387e8e58041f23529c24641362eec5de6a9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225864
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779978}

This reverts commit 03df4919.

Reason for reland: Found a way not to regress cc memory.

This time we keep partial layout invalidation on LayoutText and
LayoutInline only. In this way we still need to relayout everything
else (blocks and etc) but at least we can reuse the old shape result,
which should be still better than before.

Original change's description:
> Revert "Enable full testing of CSSReducedFontLoadingLayoutInvalidations"
>
> This reverts commit 5aba5002.
>
> Reason for revert: Causing crbug.com/1092431
>
> Let's stop messing up the perf bots while debugging.
>
> Original change's description:
> > Enable full testing of CSSReducedFontLoadingLayoutInvalidations
> >
> > This is preparation for enabling finch experiments of the feature on M85
> >
> > Note: though M85 hasn't reached Beta, we'd like to have it covered by
> > test bots first to catch any breakage. We'd also like it to be tested
> > by perf bots, since this "feature" is a performance optimization.
> >
> > Bug: 441925
> > Change-Id: I3ef98ffcfa960381efd034cd1cd63e55fbda4b01
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231269
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#775847}
>
> TBR=asvitkine@chromium.org,chrishtr@chromium.org,xiaochengh@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 441925, 1092431
> Change-Id: Ife4aa822dda70d88249306b63e30d3d39df7a560
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242383
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778044}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 441925, 1092431
Change-Id: Ib0986810a9c516f33a900dc91b91e2689f586f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245373
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779977}

R=harringtond@chromium.org

Bug: 1060399
Change-Id: Iff4a8b59a3f7ac1ec79a8adb9d16877a3fbbcbae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252460Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779976}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I67be0e52108c7bbd69ab3fba06160c54c820a11c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252838Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779975}

This CL makes sure an OverConstrainedError is returned in getUserMedia
if constraints require PTZ and system does not support PTZ.

Bug: 934063
Change-Id: Ia17167bce8eac0d45f4c97d30edbebb032fa55d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247820Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#779974}

Move Print Preview specific PDF resources to a separate grd file from
other resources for Print Preview.

This is in preparation for adding an assert in unpack_pak.py to prevent
unpacking any files in a pak file that are not under the root
directory.

Change-Id: I8145621439e5814383a33e837c6503d0f040eb4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251100Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779973}