- 03 Apr, 2019 40 commits
-
-
Reilly Grant authored
As long as there is an active connection between a frame in a tab and a serial port the tab should display an indicator. This is accomplished by adding an additional Mojo pipe that is kept open between the device service and the browser processes for as long as the render process has a connection to the port. Bug: 917204 Change-Id: I6441070f3473bd6b4a98dae98844a89ee4eb2329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546502Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#647109}
-
Austin Eng authored
This patch adds the WebGPU enums and empty WebGPU interfaces Change-Id: I3e016188924f313f8258dcaf2682c6dcb2d9ee60 Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547347Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#647108}
-
Dominick Ng authored
An ARC app may begin as a non-web app, but then be upgraded to be a web app. The opposite may also happen: an ARC app may be a web app, and then be upgraded to not be a web app. For each of these scenarios, we need to ensure that the browser-side web app is appropriately installed or uninstalled. This CL adds a new override of ArcAppListPrefs::OnPackageModified to listen for apps that are upgraded into or from being web apps, and trigger the appropriate installation or uninstallation. A new test is added to verify the behaviour. BUG=944972 Change-Id: I9e8cd04c0ceb87ca678eac0896ebdf6dde48938b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536041Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#647107}
-
Karan Bhatia authored
Add a new histogram Extensions.DeclarativeNetRequest.UpdateDynamicRulesStatus to log the result of updating dynamic rules. This should help reflect the various ways in which updating dynamic rules can fail. BUG=930961 Change-Id: I3af32853d507ad56c8aed425a808c1e49a10af5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546647 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#647106}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cb851311e16f..a883e5f9c100 git log cb851311e16f..a883e5f9c100 --date=short --no-merges --format='%ad %ae %s' 2019-04-02 eseckler@google.com Attempt to fix chromium roll - take 2 2019-04-02 treehugger-gerrit@google.com Merge "Attempt to fix chromium roll" 2019-04-02 fmayer@google.com Merge "Collect package versions in heap_profile script." 2019-04-02 treehugger-gerrit@google.com Merge "trace_processor: ParsePowerRails: skip huge power rail indices" 2019-04-02 treehugger-gerrit@google.com Merge "heapprofd: start task duration watchdog (default of 30s)" 2019-04-02 lalitm@google.com Merge "trace_processor: create metrics folders for trace processor" 2019-04-02 fmayer@google.com Merge "Add data source parsing packages.list." 2019-04-02 hjd@google.com Merge "perfetto-ui: Add logs panel" 2019-04-02 hjd@google.com trace_processor: Add unsorted json test data 2019-04-02 treehugger-gerrit@google.com Merge "Add a new TrustedPacket for received triggers." Created with: gclient setdep -r src/third_party/perfetto@a883e5f9c100 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7a8fa7f98a6ac81a5dffaa767c5bd89d7186c634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647105}
-
Hao Zhang authored
Change-Id: Ifd7ba15733df360dfa52afa30d5feac8d68a0494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549990Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#647104}
-
Nate Fischer authored
This removes one disabled Safe Browsing test. This test has been disabled for over a year (the functionality never truly worked, but the original version of the test cheated with a helper method, see http://crbug.com/733815). Safe Browsing has been enabled for over a year, and no one has requested that back-to-safety (for malicious subresources) create a network error (for the top frame). I think we can safely remove the test and give up on the related functionality. Bug: 737820 Test: None Change-Id: I3a569419ff932683c2a8ca1c4cde4a01aadd5132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549987 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#647103}
-
Oystein Eftevaag authored
Some of these metrics count up the duration of all trace events of a specific type contained in the trace, and v8_browsing enables enough categories that the default sized trace buffer gets overrun (>100MB). Requires https://chromium-review.googlesource.com/c/catapult/+/1546568 from catapult to roll into Chrome before landing. R=perezju@chromium.org,hpayer@chromium.org Bug: 946517 Change-Id: I1c2b5136dba70d419cd5cbeb721c8e2a539f1002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548561Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#647102}
-
Wei-Yin Chen (陳威尹) authored
Bug: 944750 Change-Id: I2385e30f7f5c2b4ae76758387a2edb5e2677a146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549953Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647101}
-
David Bokan authored
This makes it easy to tell from a trace how much scroll delta goes into each compositor frame, diagnosing smoothness and jank issues easier. Bug: 943294 Change-Id: I40133adc683c1cf87ce9f665bc312a77c8573588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547053Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647100}
-
Sergey Ulanov authored
LocalFontFaceSource was expecting to FontUniqueNameLookup implementation on all platforms except Mac, but it's implemented only on Android, Linux and Windows, which was crashing the renderer on Fuchsia. TBR=drott@chromium.org Bug: 948938 Change-Id: I5557a37c2cdbf2dd5a8c0a1cb08e847b31bafd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549831 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#647099}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a292fcdb49f..555cf74e75b4 git log 7a292fcdb49f..555cf74e75b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-02 saklein@chromium.org presubmit: remove the proto check for the time being. 2019-04-02 chrome-bot@chromium.org Update config settings by config-updater. 2019-04-02 dburger@chromium.org Add default for GE build config configs, fix config-updater. Created with: gclient setdep -r src/third_party/chromite@555cf74e75b4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Icbcf0ad9d593e8e88c00614f7d5f10b43a4745db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550020Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647098}
-
Devlin Cronin authored
Custom bindings in JS files used to require guards around getInternalApi, since it was only set if native extension bindings were used. Now that native extension bindings are the only form of bindings, we can remove the guards and JS versions of the same invocations. Bug: 938998 Change-Id: Id8c0046cde6ff602a458064689058e16f8ad76ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543462Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a9952abf1d0..5a4f0383cc9a Created with: gclient setdep -r src-internal@5a4f0383cc9a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=alexmos@chromium.org,calamity@chromium.org,adithyas@chromium.org,grunell@chromium.org Change-Id: Idf2d876dcba56d4ab2def2c5d9a8c0195708a60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547964Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647096}
-
Zhenyao Mo authored
1) auth() step is unnecessary since all data are public 2) verbose through logging APIs BUG=948442 TEST=manual R=kbr@chromium.org NOTRY=true Change-Id: Ic0cfb2ed80d6c1f7923c83ac699226faf630f1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550007 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#647095}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/422c432dd25d..52f1494ca34d git log 422c432dd25d..52f1494ca34d --date=short --no-merges --format='%ad %ae %s' 2019-04-02 vadimsh@chromium.org [lucicfg] Bump lucicfg version v1.5.12 -> v1.6.0. 2019-04-02 ehmaldonado@chromium.org gclient_scm: Simplify fetching refs. Created with: gclient setdep -r src/third_party/depot_tools@52f1494ca34d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:874501,chromium:942229 TBR=agable@chromium.org Change-Id: I94ca0f688461891e0b792a1d18bedbe30619ad19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647094}
-
Dirk Pranke authored
When we run a gtest-based test under swarming, if we only want to run one shard of a test (as opposed to all of the tests), we set GTEST_SHARD_INDEX and GTEST_TOTAL_SHARDS as environment variables. Prior to this CL, we wouldn't actually log the values of those, meaning that if you were only looking at the output of the test, you wouldn't know that they were set at all, let alone what they were set to. And that made it hard to reproduce the test run. This CL changes test_env.py to print out the two variables if they are set, to address that. Change-Id: Ic1009152b8f0cb7867379a2badfcf471718a60d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549898Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#647093}
-
Giovanni Ortuño Urquidi authored
Also adds test to PendingBookmarkAppManager and BookmarkAppInstallationTask unit tests. If for some reason we can't load the URL for an app, we will install a "placeholder app" if the client specified that option. The placeholder app has the default Chrome Apps icon, the URL as the name of the app, and the launch container specified by the client. Bug: 844278 Change-Id: Ia29ff33ffed05b6f7f89e7f439b55db8346e72b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546740 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#647092}
-
Becky Zhou authored
Explicitly set navigation bar icon colors for the dark mode settings fragment to work around issue on OMR1. Bug: 942551 Change-Id: I165119f92b78dd59167e480987754fb74ff1d5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549923 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#647091}
-
Eliot Courtney authored
This handles the case where the client changes the size of the PIP window after restore-bounds are saved for it. We just want to restore the position, not the size after, for example, showing and hiding the virtual keyboard. Bug: b/129385430 Test: added unit test Change-Id: If34134a69b4ea9698b302de10c6a1d8371e9ecaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547612 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#647090}
-
Lukasz Anforowicz authored
Bug: 947498 Change-Id: I4925f5209e507f8e39ea324de3a9c6f48e1747f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546671Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#647089}
-
Julie Jeongeun Kim authored
This CL removes js-test.js and applies testharness.js from tests in web_tests/clipboard. Bug: 936364 Change-Id: I37b2f10685790112519a711c9d68a4874fad20be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548960Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#647088}
-
rajendrant authored
Also fixes a webdriver test when QUIC availability status of data saver proxy is recorded. Bug: 934875 Change-Id: I1320fb26b284bd23ae431f045e3e8724aa814cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549927 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#647087}
-
Chris Harrelson authored
for inline flow boxes. This was missed in the refactor in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1366767 Before that CL, InlineFlowBox would recurse into InlineFlowBox descendants and then add their results to the current InlineFlowBox Bug: 944257 Change-Id: I722111f2f6d6e2ad95539aa5f4f052ef7224ac8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546850 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#647086}
-
Hiroshi Ichikawa authored
Bug: 932099 Change-Id: I13aae8bc53156a07133169e45be2eafc70785618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547546 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#647085}
-
Karan Bhatia authored
r645865 added support for dynamic rules to the Declarative Net Request API. This changed the conditions under which the histogram Extensions.DeclarativeNetRequest.LoadRulesetResult is logged. Update the histogram description to reflect the same. Using the same histogram should be fine since the API is still in beta and has seen minimal usage. BUG=930961 Change-Id: I3c8aaa82a459ccfc0d33553d8688f79a4540f286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548556 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647084}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71c0e9422038..c9eeab3d85b9 git log 71c0e9422038..c9eeab3d85b9 --date=short --no-merges --format='%ad %ae %s' 2019-04-02 bungeman@google.com Remove Skia version number. 2019-04-02 mtklein@google.com update some FM flags 2019-04-02 michaelludwig@google.com Do not lose existing paint shaders when drawing alpha images 2019-04-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c9eeab3d85b9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: If235ea3d381769cda7f130fa246b5a5e342af6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647083}
-
Karan Bhatia authored
This CL changes the flatbuffer schema to store a vector of URLPatternIndex instead of storing each index corresponding to an action individually. This will help to make the code more concise once more actions are added. This CL introduces no behavior change. BUG=947591 Change-Id: I65ca96c8f5dc17fa6e464783eee6ab53c78c2d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545362 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647082}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c88f3d7. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296 "Revise tests for datachannel ID handling" 80389713 "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Icf8dd67e51f993229d29e3c539b83b389c09f23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549571Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647081}
-
Dan Beam authored
Screenshots: https://imgur.com/a/r7vGHp9 R=rdevlin.cronin@chromium.org BUG=937159 Change-Id: I6c2ed201928cbe9a7974797a1aced1d049387a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546763 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#647080}
-
rajendrant authored
Bug: 935010 Change-Id: I5f8011a0564527b6ceb095a4e0a05534085088c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547962Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#647079}
-
Owen Rodley authored
This was added in https://crrev.com/c/1534342 for use by codesearch, and the script added in https://crrev.com/c/1542379 will process the resulting annotations. Bug: 615202 Change-Id: Ie6d3157361e01991693b6255f62a93ed4b91b33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546793Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Owen Rodley <orodley@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#647078}
-
Jinsuk Kim authored
Moves the app ID associated with a Tab out to manage it as UserData. It also observes IME event to update the present id, so helps break down the ImeEventObserver into more relevant classes. Bug: 925242 Change-Id: I16637e98b52a07bf5199240c780c62990315b7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532137 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#647077}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2884953d..ba99d428 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2279849aa09e4d5f6e79cd20ddd9be61ae45c516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647076}
-
Alex Cooper authored
There were a couple of things that were happening that were blocking our ability to return inline sessions. The first thing that was happening was that initial promises would end up hanging. This is because while we have a mojo reference to the server, the browser side had nothing so we would get a disconnect error, which we didn't notify any pending promises after. The second issue was that we were always rejecting sessions if we didn't have a service (i.e. because we hit an error earlier and caused it to get disconnected). Finally, we weren't guarading against the service being null, and could therefore crash after receiving a disconnect error. Bug: 944285,936264 Change-Id: I252361877243e9762ba438763ca54b902ee05b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548365 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#647075}
-
Anand K. Mistry authored
If the dropdown only contains a few (1 or 2) elements, the dropdown's height prevents any element below the dropdown items from being clicked on. BUG=943417 Change-Id: I8aa8446317a2aecb4ca33f2ba17415818e922710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535926Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#647074}
-
Karan Bhatia authored
This CL fixes an incorrect DCHECK in OnDynamicRulesFetched. The DCHECK ignores the possibility that ReadJSONRulesResult::Status::kSuccess can be returned together with an empty rules list. Also add tests for the same. BUG=930961 Change-Id: I9570e406b885baa8dfc5ee9973edfdfac7cdaddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546870Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647073}
-
Brandon Wylie authored
Switching from having each ImageFetcher-derived class owning its own singleton to a factory pattern. Moved resizing logic to the bridge. Bug: 944520 Change-Id: Ib4315d042aa4b38f46469c8b6367fb77e5dfb34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534793 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#647072}
-
Collin Baker authored
When the frame color changes, a tab strip repaint is scheduled. When the new tab button is not painting to its own layer, this indirectly results in a repaint of the new tab button. However, when it has its own layer, it won't get repainted since layers paint independently. This adds a SchedulePaint() call on the new tab button for this case. Bug: 946777 Change-Id: Id8c9ec016bffb81a69332b5199ae116e3816f68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549928 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#647071}
-
Dominic Mazzoni authored
Promote katie to an owner of nearly all accessibility code. She's always free to delegate or decline if she's not the best reviewer. Add jamescook as an owner of the aura and views accessibility code, because we need an additional reviewer for mash accessibility work who's familiar with both mash and accessibility. Bug: none Change-Id: I1f820bf186538a5a3eb92d05603497f21bb53bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549883Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#647070}
-