- 31 Jan, 2018 22 commits
-
-
Min Qin authored
These files are moved: download_danger_type.h download_save_info.h download_save_info.cc download_source.h We are gradually moving all download related files from content/ to components/download. This allows us to make download a standlone component, and finally making it a service under services/download BUG=803135 Change-Id: Id5be2a98beabd8bbd8be000a0fd1a36d633c6f7b Reviewed-on: https://chromium-review.googlesource.com/891686 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533119}
-
Yoshifumi Inoue authored
This patch changes "smart-delete-across-editable-boundaries-2.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: If0c815668d80ebfed826f4efd5e4bf9a428a627e Reviewed-on: https://chromium-review.googlesource.com/892556Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533118}
-
Yoshifumi Inoue authored
This patch changes "move-by-word-001.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: I197c5cdf3ef6848855f8c2e4257f67cc7574874a Reviewed-on: https://chromium-review.googlesource.com/890882Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533117}
-
Yoshifumi Inoue authored
Utilize GetSelectionTextInFlatTreeFromBody() in VisibleSelectionTest.ExpandUsingGranularityWithEmptyCell This patch changes |VisibleSelectionTest.ExpandUsingGranularityWithEmptyCell| to use |GetSelectionTextInFlatTreeFromBody()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: Id4212be8044fe05a15abd77d72fd8bf9524fa646 Reviewed-on: https://chromium-review.googlesource.com/892800Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533116}
-
Yoshifumi Inoue authored
This patch changes "extend-by-word-001.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: I5144d907927a936b5e7712d3fa404a2167b7e44d Reviewed-on: https://chromium-review.googlesource.com/892580Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533115}
-
Eric Lawrence authored
2x printer PNG images were checked in without optimization, and contain metadata bloat. This CL removes the metadata and optimizes the compression. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica542a73e9735c06a444c1413175a36340a218aa Reviewed-on: https://chromium-review.googlesource.com/894264Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#533114}
-
John Abd-El-Malek authored
Their content dependencies have been removed in previous changes. Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62 Reviewed-on: https://chromium-review.googlesource.com/893651 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533113}
-
Karan Bhatia authored
The method PermissionsSet::HasScriptableAccessToURL is currently not being used. Remove it. Any access by clients should ideally be made through the PermissionsData class or through the PermissionsSet::scriptable_hosts() method. BUG=None Change-Id: I22ca956315bb19de8e19dcd00f33baed460dd610 Reviewed-on: https://chromium-review.googlesource.com/894170Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533112}
-
Christopher Cameron authored
Move the logic for calling NSDisableScreenUpdates into BrowserCompositorView from RenderWidgetHostViewMac. This is needed because we no longer will be getting SubmitCompositorFrame in RWHVMac -- the new equivalent is BrowserCompositorMac::OnFirstSurfaceActivation. Simplify the logic of pausing during resize in RenderWidgetHostImpl and its interactions with RenderWidgetHostViewBase. R=sdy TBR=avi (content/) Change-Id: I5276abade510b16b0b2c583b915ab248b48e5446 Reviewed-on: https://chromium-review.googlesource.com/890220 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533111}
-
Michael Moss authored
This reverts commit 6d438d70. Reason for revert: Causing errors in release scripts which is blocking canary release. BUG: 807318 Original change's description: > Add variable to conditionally fetch ios_internal. > > Add variable checkout_ios_internal to conditionally fetch ios_internal. > Use pinned revision to ensure build stays hermetic and reproducible. > > Bug: 803846 > Change-Id: Id8ba650400b283645f8c00629dd269739d813195 > Reviewed-on: https://chromium-review.googlesource.com/880903 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532437} TBR=rohitrao@chromium.org,mmoss@chromium.org,dpranke@chromium.org,sdefresne@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 803846 Change-Id: I15afba5e030ccd58b80a78c60ad452657c89169a Reviewed-on: https://chromium-review.googlesource.com/894242Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533110}
-
Tarun Bansal authored
Update the http-equiv and preload scanner code path as well. The client hints are provided only on secure contexts if ClientHintsPersistentEnabled() feature is enabled. Bug: 782381 Change-Id: I28d75b6bfd14f36accdba8f87488ae687df049d7 Reviewed-on: https://chromium-review.googlesource.com/887924 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533109}
-
kylechar authored
There was a rule that let anything components/viz/service have a dependency on anything else. This wasn't intended. Invert that rule and explicitly allow DEPS where they should exist. Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida5c3f86487807b8ae2ad9bee01cdd8227b6ed9d Reviewed-on: https://chromium-review.googlesource.com/892101 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#533108}
-
bsheedy authored
Adds a Python script for automatically bisecting VR perf regressions. This is a temporary solution while we wait for automatic bisects on the perf dashboard to support devices outside of the Telemetry lab. This is only meant to run on a developer's workstation, not as part of any automatation/on bots/etc. Change-Id: I6887210cc2d83823c4a09efc9b5581578f5d1c7e Reviewed-on: https://chromium-review.googlesource.com/894283Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533107}
-
Klaus Weidner authored
The nested code section was not rendering correctly on the live Markdown server, and didn't match the tools/md_browser preview. Simplify the layout to avoid inconsistencies. Bug: 801929 Change-Id: Id8f84f24407d39dd2d125d8f349d214fccbe254a Reviewed-on: https://chromium-review.googlesource.com/892478Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533106}
-
Zhongyi Shi authored
outstanding sent packets. This was accidentally removed for QUIC versions greater than 33 when introducing new ack format. Manually merge internal change: 183736634 Bug: 806109 Change-Id: I60a86ebda2dbb45646221c40b393b5f825c99fe2 Reviewed-on: https://chromium-review.googlesource.com/892206 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533105}
-
Theresa authored
BUG=802935 Change-Id: I7e935c623fc70e51e9989a80bde32135b0f0a1b8 Reviewed-on: https://chromium-review.googlesource.com/894643Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533104}
-
Yixin Wang authored
Merge flag changes. https://chromium-review.googlesource.com/c/chromium/src/+/892464 Support serializing and parsing QUIC Transport Parameters QUIC Transport Parameters are put in a TLS extension and used by each endpoint to unilaterally inform the other peer what parameters it supports. This change adds code to serialize them into the wire format suitable to be passed into SSL_set_quic_transport_params, and to parse the wire format that comes from SSL_get_peer_quic_transport_params. currently unused support code for TLS 1.3 in QUIC Merge internal change: 183139434 https://chromium-review.googlesource.com/c/892460/ In QUIC, replace is_unackable with an enum SentPacketState. No functional change expected. Not protected. Merge internal change: 183132907 https://chromium-review.googlesource.com/c/892208/ Make some QUIC dlogs more informative. Merge internal change: 182957865 https://chromium-review.googlesource.com/c/892358/ Refactor socket creation logic for quic client to take in receive/send buffer size as arguments. And take flag value for that in quic to backend connection. n/a, refactor only. Modified code is not used in production, not flag protected. Merge internal change: 182940277 https://chromium-review.googlesource.com/c/892120/ Deprecate FLAGS_quic_reloadable_flag_quic_allow_multiple_acks_for_data2. Merge internal change: 182923175 https://chromium-review.googlesource.com/c/892207/ Deprecate FLAGS_quic_reloadable_flag_quic_strict_ack_handling. Merge internal change: 182826376 https://chromium-review.googlesource.com/c/892281/ deprecate FLAGS_quic_reloadable_flag_quic_enable_hq_deframer. Merge internal change: 182818920 https://chromium-review.googlesource.com/c/892105/ Change-Id: I54f0b3b28ec7b126904cb5da1cce59bccd66e0ae Reviewed-on: https://chromium-review.googlesource.com/892401 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533103}
-
Eric Willigers authored
For context see https://github.com/w3c/csswg-drafts/issues/2140 Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/BLsXXiukAgAJ Bug: 804187 Change-Id: I8a430943a5d873a55055654bcef2365d40dd71e3 Reviewed-on: https://chromium-review.googlesource.com/892838 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533102}
-
Nicolas Pena authored
This CL changes the buckets for the Expected Queueing Time histograms in microseconds. The reasoning behind this is to try to capture the 99.9 percentile in Windows, which currently sometimes overflows, as shown by: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=6158e596fecaa96afaca0f52ed21ece5 The max bucket value is changed from 4 seconds to 30 seconds, and the number of buckets is kept the same. Due to the exponential nature of the buckets, having the same number of buckets is reasonable and increasing the number of buckets does not really provide a huge advantage: https://gist.github.com/npm1/7f530e176c66258e83fc27a62b6032ec Change-Id: Id4a4efeb3f8921ef05028c8fb88a6d1de1ff64cf Reviewed-on: https://chromium-review.googlesource.com/893704 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533101}
-
Dmitry Gozman authored
Attaching by default now. Bug: none Change-Id: I76a440a99d194ad64f77e8b39b541ed0836b351d Reviewed-on: https://chromium-review.googlesource.com/894184 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533100}
-
Jialiu Lin authored
Add a new experiment with warn_on_low_reputation set to true. Change-Id: Iac7a2c1d1e91d2696011bb60beed2c81f1e2b1c7 Reviewed-on: https://chromium-review.googlesource.com/893905 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533099}
-
Ilya Sherman authored
This reverts commit 92ffe77a. Reason for revert: I suspect that the original revert was inappropriate – more detailed reasoning left as a review comment on the revert CL. Original change's description: > Revert "[Variations] Avoid duplication of the safe seed value stored in prefs." > > This reverts commit 4db68ed9. > > Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712). > > Original change's description: > > [Variations] Avoid duplication of the safe seed value stored in prefs. > > > > When the safe seed and the latest seed have identical contents, use a sentinel > > value to avoid storing a duplicate value for the two seeds. This is purely a > > storage space optimization; no difference in observed functionality is expected. > > > > R=asvitkine@chromium.org > > > > Bug: 727984 > > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb > > Reviewed-on: https://chromium-review.googlesource.com/880482 > > Commit-Queue: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532027} > > TBR=isherman@chromium.org,asvitkine@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 727984, 806712 > Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456 > Reviewed-on: https://chromium-review.googlesource.com/891119 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532401} TBR=isherman@chromium.org,asvitkine@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 727984, 806712 Change-Id: I1627111dacc8d59bc43aa7b1b7ed76db8f165ee2 Reviewed-on: https://chromium-review.googlesource.com/894622Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533098}
-
- 30 Jan, 2018 18 commits
-
-
Misha Efimov authored
- Extract global state initialization code into common API. - Get cronet::EnsureInitialized to work properly if initialized from Cronet_Engine native API. - Add accept_language to URLRequestContextConfig[Builder], but don't expose it to Java. Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I60b9cdd31837e1b15d4c2479427d5d0a77999536 Reviewed-on: https://chromium-review.googlesource.com/868076Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#533097}
-
https://chromium.googlesource.com/catapult.git/+log/3f8c43b79487..9fd18084bd44 $ git log 3f8c43b79..9fd18084b --date=short --no-merges --format='%ad %ae %s' 2018-01-29 dtu [pinpoint] Decrease questionable threshold as repeats increase. 2018-01-30 benjhayden [results.html] Auto Show All when empty search results. 2018-01-30 perezju [Telemetry] Improve GetChildPids on android platform 2018-01-30 eakuefner [Telemetry] Add benchmark_duration histogram 2018-01-30 perezju [Telemetry] Improve GetPsOutput for android platform backend Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I69b5efbd55abb44970d8199d2ac3b7da38adc306 Reviewed-on: https://chromium-review.googlesource.com/894495Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533096}
-
Sammie Quon authored
Test: ash_unittests CustomFrameViewAshTest.HeaderVisibilityInSplitview Bug: 800498 Change-Id: I8bbf318cf1406d788c0b48d9812ca3f15d74c4ae Reviewed-on: https://chromium-review.googlesource.com/858217 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#533095}
-
François Degros authored
This method used to be a template. But since it's not anymore, it doesn't need to be defined in the header file anymore. Change-Id: I5e3b769ff4e7fced01524ddb39bf163b8e82f66f Reviewed-on: https://chromium-review.googlesource.com/892184 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533094}
-
Morten Stenshorne authored
Also avoid scientific notation; see https://codereview.chromium.org/1202773002 for a similar change to the gdb script. Change-Id: I07ddccd91ddefc1f57abbaabaaecb5e786a052e4 Reviewed-on: https://chromium-review.googlesource.com/894062Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#533093}
-
Darren Shen authored
During parsing, we want to store tokens in a vector. This vector is frequently cleared, so to get the best performance, we want to clear the contents of the vector without reallocating the memory. Previously, we used a bespoke TokenBuffer class as a way of doing this, but it turns out that WTF::Vector::Shrink clears the vector without changing the capacity, which is exactly what we want. This simplifies the code, and speculatively fixes a crash which is happening in TokenBuffer. Bug: 806444 Change-Id: I40df0de370511fc7022af3bd7af856a930a210c6 Reviewed-on: https://chromium-review.googlesource.com/892781Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533092}
-
Daniele Castagna authored
We recently changed hw video frame buffer usage to SCANOUT_CPU_READ_WRITE from GPU_READ_CPU_READ_WRITE. SCANOUT_CPU_READ_WRITE/format should be added to the list of supported native gmbs when native gmbs are enabled. Bug: b/71837407 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d73adf88e47fd612a2b955b6f60aa5703fdb71d Reviewed-on: https://chromium-review.googlesource.com/894306 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533091}
-
Alexander Alekseev authored
Bug: 806913 Change-Id: I57a57c860097187d24c5a9727e5cee2ffc591b31 Reviewed-on: https://chromium-review.googlesource.com/894494Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#533090}
-
Alexander Alekseev authored
Bug: 806038 Change-Id: If82af4835f2870acf37cc902e3e2f125f4b10f7c Reviewed-on: https://chromium-review.googlesource.com/894200 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#533089}
-
Eric Willigers authored
We add a use counter for basic shapes (e.g. they appear in clip-path, shape-outside). We add a use counter for the CSS paint() function (CSS Paint API). We add a use counter for CSS gradients. We add a use counter for -webkit-cross-fade. Use counters for gradients and basic shapes requested in https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/j8HSFsZDAgAJ Change-Id: Ie609997946b97cbde1e5040076ee2a527554c8fb Reviewed-on: https://chromium-review.googlesource.com/892550 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533088}
-
François Degros authored
Passed PrefRegistry and PrefRegistrySyncable by raw pointer instead of reference to scoped_ptr. PrefRegistry and PrefRegistrySyncable have an internal reference count. There is no need to use a double indirection when passing them around. Used base::MakeRefCounted instead of naked 'new' operator. Change-Id: I53a0fdfc99b7ef3dd32b191664520659c2585fa5 Reviewed-on: https://chromium-review.googlesource.com/892582Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#533087}
-
Lei Zhang authored
If this target is always a static_library, then in component builds it gets linked into multiple .so files and produces ODR violations. As a result, base::FeatureList would have trouble keeping track of the features in services/network/public/cpp/features.h when DCHECKs are turned on. Thus features.h is currently in a component all by itself. Instead of doing that, make the entire cpp target a component, and merge the features component into it. TBR=nasko Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I61f83087bc87b0ccfc4d4884e41adf39524d46e6 Reviewed-on: https://chromium-review.googlesource.com/885914 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533086}
-
Nico Weber authored
No behavior change. Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie21f59f1b5b18663d29c3fae5c331184ae90b9b9 Reviewed-on: https://chromium-review.googlesource.com/894302Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533085}
-
Trent Apted authored
features::kTouchableChrome gets more creative, but the narrow dropdown is a good starting point. That is, features::kTouchableChrome may imply a narrow dropdown regardless of kUIExperimentNarrowDropdown. Consolidate the logic under c/b/ui/views before it gets more complex. See linked bugs for context and links the the big picture CL. Bug: 801583, 728844 Change-Id: I0b6ca6f8f9c6cded9ee2b1ccf0e2b8b34e737cd9 Reviewed-on: https://chromium-review.googlesource.com/892603Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533084}
-
Owen Min authored
This test verifies the policy value is read and copied to local_state properly in the early stage of browser launch on Windows. It's a test for the patch: crrev.com/615e458c. Bug: 806538 Change-Id: I5b150f7429f968312692123d5d40525c3ddbd9c6 Reviewed-on: https://chromium-review.googlesource.com/892043 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#533083}
-
Misha Efimov authored
Bug: 807283 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia61bdc85b5f700d58f88cc3093826d0a7e0ce014 Reviewed-on: https://chromium-review.googlesource.com/893681 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533082}
-
Scott Graham authored
Per discussion on https://chromium-review.googlesource.com/884822, this is easier to work with for V8. Bug: 707030 Change-Id: Ida09715f35280652408e209a408c2012a5648479 Reviewed-on: https://chromium-review.googlesource.com/894042 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#533081}
-
Tien-Ren Chen authored
The contents clipping mask layer on the main graphics layer needs to be updated unconditionally because otherwise we can have dangling pointer to a destroyed mask when both the mask and the contents layer are destroyed at the same time. BUG=807240 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ica51387507232c20f1deacf9572546490f587eb9 Reviewed-on: https://chromium-review.googlesource.com/894194 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533080}
-