- 23 Jun, 2020 40 commits
-
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I9486e42b29ffd00cf8d1ec0f214f5bcb9a273fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254324 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#781424}
-
Torne (Richard Coles) authored
In the browser process, store the current process name (i.e. the app's process name) in a crash key, so we can see which app process the crashes originate from in apps with multiple processes. In renderer processes this isn't relevant since the process name is always our own sandboxed process. Change-Id: I4e0ecb20c064cb06c8905938646c8927aa36b9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252942 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781423}
-
Brian Sheedy authored
Removes usage of //third_party/pymock from //tools in favor of the version provided by vpython. This is so that //third_party/pymock can eventually be removed. Bug: 1094489 Change-Id: I0d4b6484c9c44b93fb76613a3e194c3da811550d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255136Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781422}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-20. TBR=chromium-metrics-reviews@google.com Change-Id: Idd7bda836d27f35b773cd0b7f6cdafbb0891513a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261053Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#781421}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/47124be594aa..e6867ba7c785 2020-06-23 jonross@chromium.org Peak Gpu Memory Ablation Telemetry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:908462 Tbr: nuskos@google.com Change-Id: Ia8639c3485fc00177cf06b4ddd22efaff69a9292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60aab5ad138e..ead457578785 2020-06-23 aerotwist@chromium.org [Performance] Retime markers against nav start records 2020-06-23 sigurds@chromium.org [issues] Add Heavy Ads issue 2020-06-23 kimanh@chromium.org Enable e2e test for wasm debugging after bugfix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1091116,chromium:1095617,chromium:974550 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0966fd01b03af4010ffb6f277486fb27540951f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260833Reviewed-by:
-
Maggie Chen authored
1. Vulkan and DX12 info was automatically collected when the browser starts. Now we only collect and record DX12 info for UMA. 2. Dx12VulkanVersionInfo structure is removed. Vulkan and DX12 data and functions are now separated. 3. We still detect Vulkan version for about:gpu. 4. DX12 and Vulkan info is still tested in the info collection test of the gpu integration tests. Bug: 850881,863086 Change-Id: Idaabed2d572fa1dd0387cb04781a457843eb8416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252818Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781418}
-
Mike West authored
We think that COOP and COEP are important isolation primitives that might give us the ability to expose more interesting APIs to developers without putting user data at risk. This CL adds a brief description and some links to the post-Spectre threat model doc to make that clear. Change-Id: I8657cbe158c46acf426b99c1b79643646604dd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260655Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#781417}
-
Brandon Jones authored
This particular feature is moving more slowly than the rest of the lighting features, so we'll want to be able to toggle it separately. Bug: 1070819 Change-Id: I94af3008e347023d342296f0a96380139855b33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252841Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781416}
-
sczs authored
In order to properly handle the life cycle of the DiscoverFeedVC the following changes are made: - Makes the DiscoverVC a ChildVC of the ContentSuggestionsVC and removes it on dealloc. - ContentSuggestionsCoordinator now owns the DiscoverFeedVC. - Adds isDiscoverItem method in ContentSuggestionsCollectionUpdater. Without these changes the DiscoverFeedVC is not properly dealloc-ed and might lead to some crashes. Bug: 1085419 Change-Id: If4b7c1e2ada6876c036527ac5eefdae020339327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258367 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#781415}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592913526-aa0369974c74051e60d9fc3c83a0a362a402bc87.profdata to chrome-win32-master-1592917001-0fc7f1d9ca8aa2b3be882f696f21c14836e980c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7f69d087650e174cbf91649764982f5e622bb435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260912Reviewed-by:
-
Danil Chapovalov authored
Bug: None Change-Id: I89c105a652db701c083a03f1c0c891e00d2e6776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260754Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#781413}
-
Gavin Williams authored
- Change the dropdown input field to read only. Need to explicitly override the cr-input readonly opacity to keep the text readable. - Prevent the printer name from overflowing in the input field. - Align the printer names in the dropdown with the printer name in the input field. - Add a thin black border around the dropdown - Remove the rounded corners on the bottom of the dropdown - Remove black outline around printer item in dropdown when right-clicked. Screenshot: http://screen/cdf0xxtWGHT Bug: 1059607 Change-Id: I0d555ab7a1671ff36006ebfab648a84346c76834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240586 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#781412}
-
Eugene But authored
This is a monitoring histogram which should never expire. Bug: 1084098 Change-Id: I78e4378a20d2ddde48f89dd1f7cb35cd9e793dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258344Reviewed-by:
-
Kevin McNee authored
Currently, we're showing a Safe Browsing interstitial just within the portal. Safe Browsing treats embedders of dangerous iframes as dangerous themselves. The same should presumably be the case for portals. Now when a portal loads dangerous content, we load a post commit error page in the top level contents to show the Safe Browsing interstitial. Bug: 1077016 Change-Id: I8f6f47df91c41747c663a7def21512d6e73d7469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231858 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781410}
-
Joe Mason authored
R=siggi Bug: 1080672 Change-Id: I2cd82daf00ca8bccfe15c25393d215f2dc5e47ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246548 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781409}
-
Maggie Chen authored
Returning a failure in the Direct Composition functions will trigger a context lost in GL Renderer and Direct Composition will be reinitialized. If the same Direct Composition function keeps failing, it will cause an infinity loop of restart and the result is a blank screen or a blank video. If a DXGI or D3D11 call fails due to out of memory or a bad graphics driver, most likely the same call will fail next time. We should disable Direct Composition or Overlay to prevent the same failure. Bug: 1091958 Change-Id: I3ac7d9bac0fdf5938302583b072e7bda5839d2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247390 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#781408}
-
Michael Ershov authored
Check existing certs in UpdateOneCert to avoid creating a worker for certificate profile that already has a provisioned certificate. Also add a unit test for UpdateOneCert method. Bug: 1045895 Test: CertProvisioning* Change-Id: I284bec0c90766673b6ba3a2c1ac69f28303258ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245150 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781407}
-
Robert Ogden authored
The ServiceWorker API is changing, so adding a quick test to ensure nothing regresses. TBR=ryansturm@chromium.org Change-Id: I4d4364ccde83e5b0c44a87965abb3bfd44004a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261033Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#781406}
-
David Bokan authored
Page based scrolling is used in three situations: 1. PageUp/PageDown keys 2. Main thread scrollbar scrolling using the track 3. Wheel when a scroll-by-page setting is enabled The first two are explicitly main thread only. The last use is a niche use case and was simply never implemented in the compositor. With recent additions related to percent based scrolling this becomes trivial to handle so this CL allows LayerTreeHostImpl to handle scrolls using a page granularity. Bug: 1082589 Change-Id: I35fc7c4fa3c57ba2c8c86c89fed314c516f8b4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241131 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781405}
-
Meilin Wang authored
Bug: 159382866 Test: covered by unittests. Change-Id: I47295da3c1aacd00b649a5175d5f01eccd8c9e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253363 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781404}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dfc4c1d4..39d00b97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id6861b40cffcc7ed86bb948d10005b3c49568c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260853Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781403}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I0f59e454a8abd6f9674b6335a588594c2d2dd265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257422Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#781402}
-
Andre Le authored
Old UI: https://screenshot.googleplex.com/1twKi3vamGm New UI: https://screenshot.googleplex.com/5o2mTDpZQyn New UI works with long string: https://screenshot.googleplex.com/M3yV8qPdsbL Change-Id: Ic7fdb33f4e3d8f091ddef36a4ca6e5bea57e4fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255500Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#781401}
-
Xianzhu Wang authored
run_web_tests.py --iterations=100 [--exit-after-n-failures=1] is very useful for running a slightly flaky test [until it fails]. Previously results.html failed to display actual and expected results for a test with multiple results like "PASS PASS PASS PASS PASS FAIL". Now when collecting artifacts of a test, if the normal loop fails to find any artifact, we'll use the last found artifacts. Change-Id: I6de2be6eafcd0b0295b21df5b8d69866f55b9c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259514Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781400}
-
Joe Downing authored
The core use case being addressed is the case where a user connects to a CrOS device in Kiosk mode which is used as signage (no user interaction). In this scenario, the mouse cursor becomes visible when we inject mouse input and remains visible after we disconnect. This change checks the cursor visibility prior to any input injection and then hides the cursor when the input injector is torn down. Bug: 1072886 Change-Id: I7e534ffbb3a078b0f90f5d79bdf2212fb2769f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258780 Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#781399}
-
Sinan Sahin authored
Currently, the browser controls height change animations are driven in browser_controls_offset_manager.cc if we have web contents. For other cases, we simply don't animate the browser controls. This CL adds animations for the browser controls for cases where we can't drive the animation in native, e.g. NTP, tab switcher. These browser side animations are run in ChromeFullscreenManager, similar to the existing browser-driven-show-animation. We will animate the changing margins and layouts in a separate CL. Bug: 1075640 Change-Id: I4a90479e6ff6a350b72bfb5a83fc9c10e6aaf133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247244 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#781398}
-
Swapnil authored
InstallStageTracker::Observer::OnExtensionInstallationFailed may remove the observers and thus change the object. Immediately after calling this method, OnExtensionDataChangedForTesting method is called which might result in a crash. The observers list is traversed again after calling the method OnExtensionInstallationFailed so that only the updated observers are used. Bug: 1097700 Change-Id: I0c0721179d8b737e14748b2d5965926ad6a1bf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257318 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#781397}
-
Charlie Hu authored
bartekn@ is planning to remove custom hash support for LinkedHashSet. To unblock him, use HashCountedSet for DocumentPolicyFeatureSet for now. Bug: 1069021 Change-Id: I94218dbd29eb59f26d67bdd52d990f21a7af26ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259484 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#781396}
-
Bruce Dawson authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/87616f7ce2ea..fd20fafa8ec1 $ git log 87616f7ce..fd20fafa8 --date=short --no-merges --format='%ad %ae %s' 2020-06-22 brucedawson Use clang-cl to preprocess nacl assembly files 2020-06-03 fabiansommer Change ARM trybot up/download directory 2020-05-27 fabiansommer Rename CI ARM hw bots 2020-04-27 fabiansommer Enable debug build mode on debug builders. Created with: roll-dep src/native_client Bug: chromium:1097510 Change-Id: I56fac21b50062f726b8f8309999c678f0f097fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260933 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781395}
-
dpapad authored
- Change parseUrlParams_() implementation to use URLSearchParams, instead of manually extracting key/value pairs from the URL. - Replace getUiUrlParams() with shouldShowToolbar(). The former was too generic for its current usage. It can be re-generalized if/when that is actually needed. - Add some missing JS externs for OpenPDFParamsParser in pending.js externs, until the JS compiler externs are updated accordingly. Bug: None Change-Id: I3ce47d06332a61db5be93bd86f032d2db6e78c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254716 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Right now, a policy being "deprecated" can mean one of 2 things: (a) The policy still works, but it'll get removed soon. (deprecated) (b) The policy doesn't work anymore. (removed) Right now, They both get placed in a "Deprecated Policies" group, in the ADM/ADMX files. This patch creates a new group: "Removed Policies". The old group is for (a), and the new group is for (b). Bug: 1086425 Change-Id: I728f78f52e114340cadb166b62d54f9bb43c3efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255139 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#781393}
-
Marijn Kruisselbrink authored
https://github.com/WICG/native-file-system/pull/185 changed the API surface exposed to websites for showing file/directory pickers. This CL implements those changes. Bug: 1096225 Change-Id: Idd17d7383c959f90cf5cecf729ad26e65af7ce34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248488 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781392}
-
Hongbo Song authored
Change-Id: I9ef48728586e7809ec38af243b21bc0393d30822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258774Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#781391}
-
Kushagra Sinha authored
Cleanup all usages of test fixture member access from tests. They should go through member methods instead of being accessed directly. Change-Id: I7b8730d470ae051a2ca4e4b9768fc16ac84179ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255079 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781390}
-
John Williams authored
This change also factors out functionality from CastActivityRecordTest into ActivityRecordTestBase so it can be shared. Bug: b/155649299 Change-Id: I84ff6c2527e7bcb0da53ffa86078f1c09278b6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244125 Auto-Submit: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781389}
-
Ted Choc authored
This does the conversion of content/public tests. As part of this transition, Criteria.equals is being replaced in tests to allow its removal. BUG=1071247 Change-Id: I27f336db7e66e01834945b7fa1df073093641b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255658 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781388}
-
Colin Blundell authored
Neglected in the initial wiring up of infobars in WebLayer. Bug: 1093846 Change-Id: I5fff123f3948c930ec78cfe80de3ed31785d287b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257218Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#781387}
-
David Van Cleve authored
Currently, we have three places where we compute requests' referrers, nominally according to [1, Algorithm 8.1]. This change makes a couple alterations to SecurityPolicy::GenerateReferrer (one of the places) to bring it in line with the behavior in content::Referrer::SanitizeForRequest (another implementation of the algorithm). After this change, SecurityPolicy::GenerateReferrer will: - truncate requests with referrers longer than 4096 bytes to the initiating origin, as specified in [1, Alg. 8.1, step 6]; - strip URLs for use as referrers as part of the referrer generation process [step 4]; and - explicitly return "no referrer" when given an invalid URL (motivation: this will align the behavior with the other two implementations of the algorithm once they also strip URLs for use as referrers as part of the referrer generation process, because this is how GURL::GetAsReferrer behaves). In order to implement the second of these in a manner consistent with the non-Blink code, this change alters KURL's referrer stripping logic to move from "return a default value if the URL is not http(s)" to "return a default value if the scheme is not suitable for use in a referrer", bringing it in line with GURL::GetAsReferrer. [1]: https://w3c.github.io/webappsec-referrer-policy/#parse-referrer-policy-from-header Bug: 1094526 Change-Id: I515fd9e832e99c1fdd2ca207560b865d06edc39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246987Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781386}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf296fb827fe..fc5464c325c9 2020-06-23 ahassani@chromium.org cros_update: Remove quick provision code 2020-06-23 ahassani@chromium.org auto_updater_transfer: Fix issue with GetPayloadSize() 2020-06-23 ahassani@chromium.org auto_updater_transfer: Fix issues with ssh fallback 2020-06-22 pprabhu@chromium.org commands: Delete dead code 2020-06-22 pprabhu@chromium.org config: Introduce constants for quota accounts 2020-06-22 pprabhu@chromium.org config: Delete dead code 2020-06-22 pprabhu@chromium.org config: Delete unused constants 2020-06-22 pprabhu@chromium.org config: Update default HWTest pool and quota_account 2020-06-22 pprabhu@chromium.org config: Explicitly set Skylab quota account for tryjobs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I41d50d42b062041b1ede751fba7f1b4745842fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260832Reviewed-by:
-
