GitLab

Allows a callback to be registered that will be invoked once the
LogDnsClient has stopped throttling queries.

BUG=624894

Review-Url: https://chromiumcodereview.appspot.com/2380293002
Cr-Commit-Position: refs/heads/master@{#426472}

R=mkwst@chromium.org,yhirano@chromium.org
BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2433363002
Cr-Commit-Position: refs/heads/master@{#426471}

Sign in is not allowed until the FRE is completed, but the sign in
promo is initialised and shown before that. Observing these changes
allows showing the promo if the user doesn't sign in during the FRE.

Adds a SelfRegistrable type that objects can implement, and when
sent to the NTPManager, their unregister() method will be called when
the page is destroyed.
Used to take care of the cleanup of the above observers.

BUG=656501

Review-Url: https://chromiumcodereview.appspot.com/2439443002
Cr-Commit-Position: refs/heads/master@{#426470}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be0bfc84..9a5ffe0a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2434193002
Cr-Commit-Position: refs/heads/master@{#426469}

The Files app's color scheme should be more consistent with chrome://md-settings etc.

BUG=650488
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2433263002
Cr-Commit-Position: refs/heads/master@{#426468}

This shows a ~10% improvement on the TaskQueueManagerPerfTest
micro benchmark.

Alternatives considered: A flat map/set
https://codereview.chromium.org/2396533004/

BUG=

Committed: https://crrev.com/36d98e3b544f310943986dcaa98beabacdbccc96
Committed: https://crrev.com/1e13bd23dd2aac48f6bbcce65a1c56b14d5254ef
Review-Url: https://chromiumcodereview.appspot.com/2419793002
Cr-Original-Original-Commit-Position: refs/heads/master@{#425647}
Cr-Original-Commit-Position: refs/heads/master@{#425930}
Cr-Commit-Position: refs/heads/master@{#426467}

BUG=633626

Review-Url: https://chromiumcodereview.appspot.com/2437573004
Cr-Commit-Position: refs/heads/master@{#426466}

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2435783003
Cr-Commit-Position: refs/heads/master@{#426465}

The Grid Tracks sizing algorithm updates receives the available space
to be used as space for tracks. We hold a variable to store the
remaining free space for each dimension.

When the grid container size is indefinite we can't compute the
available free space after computing track sizes until such indefinite
size is resolved.

BUG=655390

Review-Url: https://chromiumcodereview.appspot.com/2415313003
Cr-Commit-Position: refs/heads/master@{#426464}

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns "".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can return YES and UTF8String return nil.

BUG=656108

Review-Url: https://chromiumcodereview.appspot.com/2434473005
Cr-Commit-Position: refs/heads/master@{#426463}

This reverts commit 89406fe9.

Causing test failures in Deferred Loading

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/96387

Original review: https://codereview.chromium.org/2389023002/

BUG=635105
TBR=isherman,dcheng
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2432933005
Cr-Commit-Position: refs/heads/master@{#426462}

This is similar to printing deeply nested tables, and we have serious
performance issues with this.

Landing the performance test separately from the actual fix, so that we can
observe the improvement when the fix eventually lands.

BUG=487026

Review-Url: https://chromiumcodereview.appspot.com/1695193006
Cr-Commit-Position: refs/heads/master@{#426461}

With upcoming changes the renderer that is used for prefetch will exit early
before tests have a chance to execute javascript there. Fortunately, there is
another way to check whether javascript is executed: requesting a resource from
an inline script in a blocking manner. This is simpler than changing the
lifetime of the renderer specifically for tests.

NoStatePrefetchBrowserTest.CheckJavascript would still be able to run with the
new renderer lifetime, but I decided to still remove it because it is testing
mechanisms that are not used any more.

BUG=643652

Review-Url: https://chromiumcodereview.appspot.com/2438593002
Cr-Commit-Position: refs/heads/master@{#426460}

BUG=657705

Review-Url: https://chromiumcodereview.appspot.com/2438023002
Cr-Commit-Position: refs/heads/master@{#426459}

Merge internal change: 136349092
https://codereview.chromium.org/2435773002/

Move FakeProofSource into its own library
Merge internal change: 13620118
https://codereview.chromium.org/2429173004/

Remove unused primary_orbit arguments in QuicCryptoServerConfig
In addition to being unused, pointers are being passed around in a way
which
all-but-ensures use of this buffer after the stack frame in which it
lives has been torn down.
dead and dangerous code removal only.  No functional change intended,
not flag-protected.
Merge internal change: 136167866
https://codereview.chromium.org/2425073002/

Limit QUIC uncompressed header size per stream to 16K, by default. Protected by FLAGS_quic_limit_uncompressed_headers.
Merge internal change: 136104265
https://codereview.chromium.org/2430513002/

Remove now useless QUIC method AdjustErrorForVersion() which has been a no-op for some time.
Merge internal change: 136086635
https://codereview.chromium.org/2422343002/

Delete unused constants from quic_protocol.h. No behavior change.
Merge internal change: 136075981
https://codereview.chromium.org/2425053002/

Implement a traffic policer in the simulator
Merged internal change: 136068844
https://codereview.chromium.org/2425823002/

Test refactors to allow for delaying response trailers.
Merge internal change: 136041302
https://codereview.chromium.org/2429653002/

Remove references to BalsaHeaders from a number of files and use SpdyHeaderBlock instead.
Merge internal change: 135949023
https://codereview.chromium.org/2422233003/

Refactors for server-side asynchronous handshakes
Merge internal change: 135837166
https://codereview.chromium.org/2427783002/

Allowing the SimpleQuicBackend to send an early response. Test-only change.
Merge internal change: 135821831
https://codereview.chromium.org/2421173003/

Move allow_bidirectional_data_ from QuicSpdyClientStream to QuicSpdyStream, and use in (test-only) QuicSimpleServerStream. No behavior change.
Merge internal change: 135812992
https://codereview.chromium.org/2424953002/

QUIC: only negotiate Token Binding when PrivacyMode is disabled
Merge internal change: 135745087
https://codereview.chromium.org/2422243002/

Eliminate use of StringPiece(nullptr, n) with non zero n. This constructor is unsupported in C++17's 2-arg std::string_view.
Merge internal change: 135733011
https://codereview.chromium.org/2421403002/

Deprecate FLAGS_quic_stream_sequencer_buffer_debug.
Merge internal change: 135720045
https://codereview.chromium.org/2427663003/

Deprecate FLAGS_quic_close_connection_on_huge_frames.
Merge internal change: 135697044
https://codereview.chromium.org/2429533003/

Deprecate FLAGS_quic_allow_server_address_change_for_mapped_ipv4.
Merge internal change: 135694707
https://codereview.chromium.org/2424903002/

refactor only: Move around flag protection.
Merge internal change: 135693757
https://codereview.chromium.org/2426603003/

Deprecate FLAGS_quic_packet_numbers_largest_received.
Merge internal change: 135689518
https://codereview.chromium.org/2428623002/

rollback of internal changelist 134345701
*** Reason for rollback ***
This has a bug that causes busy looping in chromium.
*** Original change description ***
bugfix for forced head of line blocking experiment. Guarded
by ENABLED --FLAGS_FLAGS_quic_bugfix_fhol_writev_fin_only.
Fix bug in FHOL, where fin-only writev caused cpu-spinning in gfe.
Also changes the behaviour of FHOL to limit additional buffering to one
HTTP/2 Data frame.
Merge internal change: 135689007
https://codereview.chromium.org/2424863002/

R=rch@chromium.org
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2430973004
Cr-Commit-Position: refs/heads/master@{#426458}

Dismissing status cards (and sections) now requires the
NTPSuggestionsSectionDismissal feature to be enabled.

Dismissing the Sign In promo is still possible.

BUG=657494

Review-Url: https://chromiumcodereview.appspot.com/2440673002
Cr-Commit-Position: refs/heads/master@{#426457}

The patch adds the write barriers needed to run wrapper tracing incrementally.

Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRkRDFwBc/edit#gid=0&vpid=A3

BUG=chromium:468240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2401893002
Cr-Commit-Position: refs/heads/master@{#426456}

This allows simplifying the TestPrerenderContents and makes the
FINAL_STATUS_APP_TERMINATING more precise. No new tests are added in this chang,
the existing tests cover this path enough IMO.

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2435693005
Cr-Commit-Position: refs/heads/master@{#426455}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327

Review-Url: https://chromiumcodereview.appspot.com/2431393002
Cr-Commit-Position: refs/heads/master@{#426454}

getReader({mode: 'byob'}) failed with a ReferenceError. Make it throw a
TypeError instead.

BUG=657743

Review-Url: https://chromiumcodereview.appspot.com/2432863004
Cr-Commit-Position: refs/heads/master@{#426453}

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648,652698

Review-Url: https://chromiumcodereview.appspot.com/2431583004
Cr-Commit-Position: refs/heads/master@{#426452}

This allows users to handle issues, such as throttling, immediately.
Uses a sync-async DoLoop pattern internally now.

BUG=624894

Review-Url: https://chromiumcodereview.appspot.com/2369373002
Cr-Commit-Position: refs/heads/master@{#426451}

Original issue's description:
> Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle*
>
> * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*|
>   rather than a |void*|
> * ProxyResolver::CancelRequest(void*) has been removed. Requests
>   are instead cancelled by resetting the scoped_ptr<Request>.
>
> This makes for less error prone code as cancellation of
> requests is automatic when the
> scoped_ptr<Request> goes out of scope.
> ProxyResolver::GetLoadState() is removed and replaced
> by Request::GetLoadState().
>
> Also made some renaming, as there were similar class
> named Job or Request. Now they are all Job and this new thing
> is Request.
>
> Referencing by address to object in vector was not wise in net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using scoped_ptrs in that vector.
>
> BUG=478934
>
> Committed: https://crrev.com/a750e126346aa42df1b0cbc2ae6a58abbe7a5069
> Cr-Commit-Position: refs/heads/master@{#377856}

BUG=478934

Review-Url: https://chromiumcodereview.appspot.com/2299963002
Cr-Commit-Position: refs/heads/master@{#426450}

Fixes:
  media/remoteplayback/availability-callback-gc.html

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2434763002
Cr-Commit-Position: refs/heads/master@{#426449}

BUG=657670

Review-Url: https://chromiumcodereview.appspot.com/2432233003
Cr-Commit-Position: refs/heads/master@{#426448}

We inherited WebKit's drag and drop implementation, which has a
threshold of 40px for links, 5px for images, and 3px for text. While
these are very thoughtful defaults, the right behavior for an
application is to use drag thresholds dictated by the platform.

This CL unifies all the drag and drop thesholds, paving the way for
having them read from the underlying platform, which is explored in
https://crbug.com/653490

WebKit also used the term "drag hysteresis" instead of threshold. This
CL switches to threshold to match the documentation of the platforms
that we run on.

BUG=20486

Review-Url: https://chromiumcodereview.appspot.com/2401503002
Cr-Commit-Position: refs/heads/master@{#426447}

There may be a race condition that causes flakiness in the form of timeouts in
several prerender browser tests involving waiting for prerender contents to be
created. As I have not been able to reproduce the flakiness locally, I'm not
sure this is actually a fix for the flakes. Fingers are crossed and wood is
being knocked.

BUG=657025

Review-Url: https://chromiumcodereview.appspot.com/2434813004
Cr-Commit-Position: refs/heads/master@{#426446}

BUG=571056

Review-Url: https://chromiumcodereview.appspot.com/2428573002
Cr-Commit-Position: refs/heads/master@{#426445}

BUG=657081

Review-Url: https://chromiumcodereview.appspot.com/2431353002
Cr-Commit-Position: refs/heads/master@{#426444}

Revert of [Android] Always use devil's adb in the perf recipes. (patchset #2 id:20001 of https://codereview.chromium.org/2431963004/ )

Reason for revert:
Suspect causing mass failure on Android perf bots.
BUG=619189

Original issue's description:
> [Android] Always use devil's adb in the perf recipes.
>
> BUG=623989

TBR=dtu@chromium.org,stip@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623989

Review-Url: https://chromiumcodereview.appspot.com/2437013002
Cr-Commit-Position: refs/heads/master@{#426443}

white-listed computed styles.

BUG=546953

Review-Url: https://chromiumcodereview.appspot.com/2385653003
Cr-Commit-Position: refs/heads/master@{#426442}

BUG=534751

Review-Url: https://chromiumcodereview.appspot.com/2434543004
Cr-Commit-Position: refs/heads/master@{#426441}

This patch mojofies all of browser-side unittests which didn't fail with
--mojo-service-worker flag.

BUG=629701

Review-Url: https://chromiumcodereview.appspot.com/2431313003
Cr-Commit-Position: refs/heads/master@{#426440}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/58df09995b6b..ec142e2a93fe

$ git log 58df09995..ec142e2a9 --date=short --no-merges --format='%ad %ae %s'
2016-10-19 lpy Implement new V8 sampling format.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2431373005
Cr-Commit-Position: refs/heads/master@{#426439}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c1a9ea869dd1608dfd44ad4719739239d2efa06 WebRTC: Remove Dr Memory bots. (ehmaldonado@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2438713002
Cr-Commit-Position: refs/heads/master@{#426438}

This patch gets rid of |VisibleSelection::selectionFromContentsOfNode()| with
introducing |SelectionTemplate<T>::selectAllChildren()| by using
|setSelection()| taking |SelectionTemplate<T>| to simplify |VisibleSelection|
class for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://chromiumcodereview.appspot.com/2432173005
Cr-Commit-Position: refs/heads/master@{#426437}

This patch wraps SWContextTest by MojoServiceWorkerTestP with fixing some
expectations related to IPCs. This also mojofies SWContextRecoveryTest which
already used the parameterized test.

BUG=629701
TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerContextRecoveryTest/*"
TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerContextTest/*"

Review-Url: https://chromiumcodereview.appspot.com/2432083002
Cr-Commit-Position: refs/heads/master@{#426436}

This is no longer needed. In fact, it was causing some trouble.

BUG=534751

Review-Url: https://chromiumcodereview.appspot.com/2438613004
Cr-Commit-Position: refs/heads/master@{#426435}

Preparation for sync with server.

BUG=645078

Review-Url: https://chromiumcodereview.appspot.com/2424983002
Cr-Commit-Position: refs/heads/master@{#426434}

BUG=649558

Review-Url: https://chromiumcodereview.appspot.com/2434173002
Cr-Commit-Position: refs/heads/master@{#426433}