GitLab

BUG=117633
TEST=devtools not counted as a "current page"
R=estade@chromium.org


Review URL: http://codereview.chromium.org/9663044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116932
TEST=Open an incognito window and a normal window.  Check that the icons are different

Review URL: https://chromiumcodereview.appspot.com/9649013

TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9692021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126260 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126259 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asvitkine@chromium.org
CID=103400
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9662021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114288
TEST=SessionStartupChangeTest.*; no user-visible changes.


Review URL: http://codereview.chromium.org/9688002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116932
TEST=Open an incognito window and a normal window.  Check that the icons are different

Review URL: https://chromiumcodereview.appspot.com/9649013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126256 0039d316-1c4b-4281-b951-d872f2087c98

Fix repainting not happening when switching tabs after resizing the browser. I didn't copy this behavior from TCVViews to TCVWin.

BUG=117745,98716
Review URL: https://chromiumcodereview.appspot.com/9695011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126255 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org, phajdan.jr@chromium.org
BUG=88315

Review URL: https://chromiumcodereview.appspot.com/9665027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126254 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126253 0039d316-1c4b-4281-b951-d872f2087c98

Only change:
r126090: Revert a workaround for a yasm warning false positive that's now fixed.

BUG=none
TEST=none
TBR=hbono

Review URL: http://codereview.chromium.org/9694007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126252 0039d316-1c4b-4281-b951-d872f2087c98

Added callback to DownloadUrl() so we can find download failures where the download item isn't created at all.

Added observer class for browser tests, which uses the callback.

BUG=117033
TEST=None

Review URL: http://codereview.chromium.org/9570005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126251 0039d316-1c4b-4281-b951-d872f2087c98

If the list of plugins has updated before PluginLoader gets a
request to load plugins it occasionally fails to load the entire
list. This happens when PluginLoader is serving the last plugin
load request.

To make sure PluginLoader is up-to-date with the latest plugin
list all plugin load requests are served.

BUG=117561
TEST=content_unittests --gtest_filter=PluginLoader*
R=rsesek

Review URL: http://codereview.chromium.org/9665017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114306
TEST=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/9669042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126248 0039d316-1c4b-4281-b951-d872f2087c98

Revert 120593 - Ensure the previously active browser window gets the focus after a browser window is closed on OSX.

Also cleaned up extra orderOut: call since browser shutdown process has improved since that line was added. See crbug 23959 for history.

This CL appears to cause regression issue 117621.

BUG=112038,117621
TEST=Manually open tabbed windows and panels and close them. Watch focus go back to last active window.


Review URL: http://codereview.chromium.org/9310075

TBR=jennb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9692016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126247 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to cleanly revert r120593 to address regression issue 117621.

BUG=113481,117621
TEST=manually shutdown Chrome with a minimized window and restarted. Window was still minimized.


Review URL: http://codereview.chromium.org/9374025

TBR=jennb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9695014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=View uber about page in Chrome build, verify no javascript exceptions occur.
Review URL: https://chromiumcodereview.appspot.com/9677011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126244 0039d316-1c4b-4281-b951-d872f2087c98

of data, in clipboard pickles. (The goal is to remove that method entirely.
Uses that never persist or send pickles over the network are [probably] safe,
but having the method around is waiting for accidental misuses.)

Review URL: http://codereview.chromium.org/9688021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126242 0039d316-1c4b-4281-b951-d872f2087c98

Add unit test for spurious work signal behavior.

Split cond_var_ into multiple condition variables; one for each distinct
condition.  Document exactly when each condition variable is waited on.

Restrict the thread that SWP::Shutdown() can be called from.

Fix brace usage in destructor.

BUG=117469
TEST=

Review URL: https://chromiumcodereview.appspot.com/9651026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126241 0039d316-1c4b-4281-b951-d872f2087c98

This infrastructure allows Google Test-based tests to opt-in to some magic that results in extremely verbose logs appearing in test output for only those tests that fail.  This includes all LOG() messages generated by chrome.exe, npchrome_frame.exe, and the test executable itself, as well as all TRACE_EVENT_*_ETW events.  The interesting entrypoints are in test_log_collector_win.h, file_logger_win.h, and log_file_printer_win.h.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9584017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126240 0039d316-1c4b-4281-b951-d872f2087c98

functions.

R=agl@chromium.org
BUG=116617
TEST=none

Review URL: http://codereview.chromium.org/9663034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126239 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126238 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126237 0039d316-1c4b-4281-b951-d872f2087c98

The bug that forced this hack got fixed, so now we can remove the hack!

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9595028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126236 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for support inter-strip dragging.

BUG=none
TEST=existing tests due to no functionality change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125319

Review URL: http://codereview.chromium.org/9616037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126235 0039d316-1c4b-4281-b951-d872f2087c98

r931 Remove static initializer in linux/guid_creator.cc.
r930 Removing breakpad_exc_server and all references.
r929 Correct various compilation warnings.
r928 Send uptime as milliseconds for Mac and iOS.
r927 Support for .raSearch in the x86 stackwalker
r926 Handle program strings with the assignment operator smashed against the next token.
r925 Modify CrashGenerator::CreateChildCrash to copy proc files.
r924 Fix an invalid cast in PostfixEvaluator<ValueType>::EvaluateInternal().
r923 Add support for @ operator to PostfixEvaluator R=mark at http://breakpad.appspot.com/349002/

BUG=94925
TEST=none


Review URL: http://codereview.chromium.org/9662057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126234 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116616
TEST=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/9668054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126232 0039d316-1c4b-4281-b951-d872f2087c98

TBR=abarth@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9677013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126231 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104346
TEST=Steps to reproduce listed in the bug.

Review URL: https://chromiumcodereview.appspot.com/9514016
Patch from Nasko Oskov <nasko@chromium.org>.

TBR=creis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9691009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126230 0039d316-1c4b-4281-b951-d872f2087c98

If a test aborted (e.g. ASSERT_EQ() failure) with a TemplateURLFetcher running, shutdown would go badly, leading to a DCHECK failure.  In the real browser this isn't an issue because the URLFetchers are shut down correctly, but in the TestingProfile we don't have all the same shutdown machinery so resetting the TemplateURLFetcher explicitly avoids the potential problem.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9665032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126229 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101244
TEST=no


Review URL: http://codereview.chromium.org/9690006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126227 0039d316-1c4b-4281-b951-d872f2087c98

Only change:
r126189: mac: Don't build nss with -fvisibility=hidden when doing a shared build.

BUG=90078
TEST=none
TBR=wtc

Review URL: http://codereview.chromium.org/9696003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126226 0039d316-1c4b-4281-b951-d872f2087c98

- Remove OpenSpecialChannelTo*.
- Make EMS non-refcounted now that Profile is the sole owner.
- Make MessagePorts hold a RenderProcessHost now that processes are the only
types of port. I also changed it to hold a process instead of a RenderViewHost,
which doesn't make a difference from an IPC messaging standpoint.

BUG=104625
TEST=no

Review URL: https://chromiumcodereview.appspot.com/9667015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117407
TEST=


Review URL: http://codereview.chromium.org/9669055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126224 0039d316-1c4b-4281-b951-d872f2087c98

- also remove unused GetGCacheDirectoryPath method.

BUG=chromium-os:27510
TEST=unittest GDataFileSystemTest.GetFromCacheForPath should pass.
Review URL: https://chromiumcodereview.appspot.com/9694008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126223 0039d316-1c4b-4281-b951-d872f2087c98

This test for exception handling in the browser is being added on the
NaCl side, but it won't work yet until support is added on the
Chromium side.  I'm adding a line to disable it so that I can later
enable the test in the same change that adds exception handling
support in Chromium.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2602
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9688017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:116977
TEST=Open network options for a WiFi or Ethernet connection.  The dialog should contain a proxy tab.  If the network is shared, the contents of the tab are enabled/disabled based on whether "enable proxies for shared networks" is checked in the main settings page.


Review URL: http://codereview.chromium.org/9668010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126221 0039d316-1c4b-4281-b951-d872f2087c98

Flash Access broke. Until that's fixed these changes need to be removed.

Reverting: https://src.chromium.org/viewvc/chrome?view=rev&revision=121772
Reverting: https://src.chromium.org/viewvc/chrome?view=rev&revision=121478
Reverting: https://src.chromium.org/viewvc/chrome?view=rev&revision=121286

TBR=cpu@chromium.org
TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/9692001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126220 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126219 0039d316-1c4b-4281-b951-d872f2087c98