- 18 Sep, 2019 40 commits
-
-
Jan Scheffler authored
This patch adds the emacsy shortcuts to the editor again. Bug: chromium:983874 Change-Id: I8423fad0b0fde6ac83487189092edc8f9c66c095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806737Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#697510}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b4e53c4a9938..cbc960899a68 git log b4e53c4a9938..cbc960899a68 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 abennetts@google.com Minimal markdown conversion of Pinpoint Errors doc (https://docs.google.com/document/d/1cuhfQ1peSpz2ts3OMC-O4ALoblamYBaCWWOES8bP8ms/view#) Created with: gclient setdep -r src/third_party/catapult@cbc960899a68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: I32ea130e1c00c8abba9e9d1d87aa781bb6e193ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697509}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca254aeeec6..199cfeb385a2 Created with: gclient setdep -r src-internal@199cfeb385a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3cd8d82fa7aec1ab88cd69551982384d185dd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810179Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697508}
-
Jan Scheffler authored
This patch adds the navigationId to LCP events to allow reporting of LCP for every navigation. Bug: chromium:1001010 Change-Id: If813f679d75c45bbb16a270576f5c9be0f47c772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790445 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Jan Scheffler authored
This fixes the color popover when the contrast details are show and also has a color picker for the background. Bug: chromium:959012 Change-Id: Iddbd397b9417a331397c3e07fd3690ea5e306710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789225Reviewed-by:
-
Gauthier Ambard authored
This CL removes the default VoiceOver action which is reading the title of the item then the content of the badge. Now the accessibility label is the title and a new property, |additionalAccessibilityLabel|, if it is set. Bug: 985764 Change-Id: Ic2c1f0a590f020de0dae1a37cc01f081663c2e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789397Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#697505}
-
Fergus Dall authored
TBR=cmumford@google.com TBR=kinuko@chromium.org Bug: 1005084 Change-Id: I1d22b527d7d5bdaa3f4e7c0b8726258ac43f30db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810442Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697504}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a37ea9246e1e..37cb2b2a47f0 git log a37ea9246e1e..37cb2b2a47f0 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c6edebc2..b1c1d284 (382 commits) 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 30847688f059..61a2765940a7 (7 commits) 2019-09-18 herb@google.com Revert "SkZip - synchronized indexing of several pointers" Created with: gclient setdep -r src/third_party/skia@37cb2b2a47f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None,chromium:None Change-Id: Ie5408a899495ee583d742a659b2fbb2139ce7f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810457Reviewed-by:
-
Fergus Dall authored
TBR=sky@chromium.org Bug: 1005095 Change-Id: I9ab1fe467bc0c8d927f7ba4154674c0a3ca5fcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810498Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da39c6d82324..a467e264db50 git log da39c6d82324..a467e264db50 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 vapier@chromium.org image_lib: add fsync when updating filesystem superblocks 2019-09-18 vapier@chromium.org image_lib/osutils: improve debug output for image mounting Created with: gclient setdep -r src/third_party/chromite@a467e264db50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia2c39da1ce13f72b7b3b39632bbd1841cf781706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810178Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts MultiroomManagerPtr to new Mojo types. It uses Remote and Receiver instead of MultiroomManagerPtr and Binding. Bug: 955171 Change-Id: I6615aff8b7ca9c58748bbd08ee08f38b57b4c202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804947Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697500}
-
Miyoung Shin authored
This CL converts HidConnection{Ptr, Request} in device, services, content, blink and extensions to the new Mojo type, and uses pending_remote<HidConnection> in hid.mojom of blink and hid.mojom of services. Bug: 955171, 978694 Change-Id: I786590ab78d08ebf3b989dea1185e53b0442c568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804944 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697499}
-
Hirokazu Honda authored
VaapiVEA creates VASurface from DmaBuf backed VideoFrame through VaapiPictureFactory. There is no reason to create VASurface with VaapiPicture. This CL retires VaapiPicture in VaapiVEA. Bug: 1001413 Test: tast run video.EncodeAccel* Change-Id: Ib0905ee097bde21aeab37081c43641c48fe83b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786707 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#697498}
-
John Abd-El-Malek authored
This will be added to FYI bots in a followup cl. Change-Id: I8ca2e3ce61e628cf6e342a8ab4fc604975c0d225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809897 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697497}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3877.0-1568022778-benchmark-78.0.3902.0-r1 to 79-3903.0-1568628088-benchmark-78.0.3902.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ic39e133c13d6180aac724f2f7487a70c9c804786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810180Reviewed-by:
-
Hitoshi Yoshida authored
Web IDL does not allow to have null as a constant value. https://heycam.github.io/webidl/#index-prod-ConstValue This CL drops the keyword from parser, and does not change actual behaviors of Chrome. Bug: 839389 Change-Id: Ia22c901fc71517ce74a8859a1fd74994c6c65e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809118Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#697495}
-
Richard Knoll authored
This will hide the settings button for native notifications if they should not have one. This is specific to the feature that displays the notification and is already working for non-native notifications. Additionally, the settings button will now show for extension native notifications, a previous CL (923877) only added it for non-native ones. Bug: 999979,810622 Change-Id: I26d94e275dab76d1748afdfefae78aba77977473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801759Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697494}
-
Alan Cutter authored
Test background installation flag over install_params presence when deciding to open Play store installation for PWAs on Chrome OS This CL updates the logic for checking whether a PWA installation should go via the Play store to branch on the "background installation" bool instead of whether we have install_params_ set. This is in preparation for adding background updating as a new install entry point which breaks the existing expectations. Bug: 926083 Change-Id: I5d0f987fa04bc9dcc02452cc5c1ea5515b6b59ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788781Reviewed-by:
-
Alexei Filippov authored
The class is quite big containing a string and a flat_map. We're observing its copy constructor being called quite extensively at places where it would otherwise be using move. BUG=1003042 Change-Id: I011b267427f8c9790047a5b7adf9c2cd3dd27399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807702Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#697492}
-
Fergus Dall authored
TBR=khmel@chromium.org TBR=malaykeshav@chromium.org Bug: 1005069 Change-Id: I4a9bfbfc683587714eeb960c8d2e58f739932b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810171Reviewed-by:
-
sczs authored
There was a retain cycle per bug 1004690. The ContainerCoordinator had a strong pointer to the Mediator, which in turn had a strong pointer to infobar_container_ios, which had a strong pointer to its consumer (ContainerCoordinator). This would only happen on non Messages, since on the legacy implementation the consumer is the ContainerViewController. Still I think both consumers should be weakly retained since the mediator(infobar_container_ios) don't really own these objects. Bug: 1004690 Change-Id: Ic5d30b444177e216ffe2f8cdce9b0cf7d012383c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809744Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697490}
-
Hitoshi Yoshida authored
Reorders IDL parser's patterns to follow Web IDL grammar[1] as much as possible. This CL is to reduce diffs of follow-up CLs, and does not change any behaviors. [1] https://heycam.github.io/webidl/#idl-grammar Bug: 650150, 839389 Change-Id: I8885016db13f9b9af2fed18eb3e6ccf99c6365b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807652Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3c4a829c64f..a37ea9246e1e git log f3c4a829c64f..a37ea9246e1e --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Use a "decal" domain for filterMaskGPU Created with: gclient setdep -r src/third_party/skia@a37ea9246e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I63d45595957388d31658ae5d2c87e3d4dcb9f148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810357Reviewed-by:
-
Eric Willigers authored
WebDisplayMode was being passes by const reference. It is now passed by value, as usual for enums. Change-Id: I12f192cdd92251a606cec66071445cb875eac0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809133 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Asanka Herath authored
R=qinmin@chromium.org Bug: None Change-Id: I30174f066b72f3f6a7930ebe0509efb06738397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808434Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697486}
-
Toby Huang authored
Currently, GetDialogId() starts out as the empty string, gets set to kChromeUIAddSupervisionURL="chrome://add-supervision" when the Add Supervision dialog is opened, and sometimes gets reset to empty string when the dialog is closed depending on which button is pressed. This CL ensures kChromeUIAddSupervisionURL is always passed to FindInstance() instead of the empty string which can lead to unpredictable behavior and can easily return something other than null. Bug: 1000978 Change-Id: I0287aefdb3451db2e8f388dbff659623d4e7f982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787339 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697485}
-
Fergus Dall authored
This reverts commit 8d32b638. Reason for revert: Broke the build: [56563/84904] CXX obj/third_party/blink/common/common/logging_utils.obj FAILED: obj/third_party/blink/common/common/logging_utils.obj C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../third_party/blink/common/logging/logging_utils.cc(7,10): fatal error: 'third_party/blink/public/mojom/devtools/console_message.mojom-blink.h' file not found #include "third_party/blink/public/mojom/devtools/console_message.mojom-blink.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Reland "Include *.mojom-forward.h instead of .mojom.h from logging_utils.h" > > This is a reland of be56a0b9 > > Fix the build break caused by the missing dependency. > > Original change's description: > > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > > size of logging_utils.h > > > > This CL has no behavior changes. > > > > Bug: 1001360 > > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#697134} > > Bug: 1001360 > Change-Id: I5a8112a21782863c6420eddd2fe717d368419b90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808953 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697475} TBR=haraken@chromium.org,tkent@chromium.org,tikuta@chromium.org,gyuyoung@igalia.com Change-Id: Ie875b1e2e62833b5042444e4f3a1af3400467217 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810169Reviewed-by:
-
Wei Wang authored
In this patch, the helper test utils {StartServiceWorker, StopServiceWorker} are used in other tests. Bug: 930195 Change-Id: Ib163c25eac1ffd13b57e1333084db98ab7ad3e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809969 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697483}
-
Miyoung Shin authored
This CL converts HidManagerClient{AssociatedPtr, AssociatedPtrInfo and AssociatedRequest} in device, services and extensions to the new Mojo type. Bug: 955171 Change-Id: I86e47ad4d6bdb35a89cca8337bd066aa167b2c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803938 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: -
Alan Cutter authored
This is a cleanup refactor, the bookmark star is the last PageActionIconView that isn't contained by OmniboxPageActionIconContainerView. This CL updates its implementation to conform with all the other PAIVs and remove specialised LocationBar methods now that it fits generic interface. Bug: 788051 Change-Id: I5f382b2eddc767e896f7853c3cc27595dacd3f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808940 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#697481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e462ce33b7b..dca254aeeec6 Created with: gclient setdep -r src-internal@dca254aeeec6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I08924e71114945fe6775f8a2a5372ed41fdf907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809968Reviewed-by:
-
Fergus Dall authored
TBR=nhiroki@chromium.org Bug: 1003217 Change-Id: I0f0ea6f8a33dc9a4e9291fbe7cccbe0318a5c3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810165Reviewed-by:
-
Fergus Dall authored
TBR=alexmos@chromium.org Bug: 1005049 Change-Id: If88be75391cc296b8b3f178f74dcb7f5f0c719ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809132Reviewed-by:
-
Khushal authored
We should clear these maps on every navigation to keep them from growing unbounded, and because its safe to clear this state after a navigation. R=ericrk@chromium.org Bug: 1003886 Change-Id: I68dae1d564039c27795e63ac18144ea955bac8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804515 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697477}
-
Timothy Loh authored
This CL extracts the engagement metrics logic from ArcMetricsService into a new class GuestOsEngagementMetrics, to allow it to be used for both Crostini and Plugin VM. TEST=Manually verified chrome://histograms had sensible entries over a couple of days. Bug: 990252 Change-Id: I395bca7dd2c3d4688c33683cd163c18c8ecc90f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738447Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697476}
-
Gyuyoung Kim authored
This is a reland of be56a0b9 Fix the build break caused by the missing dependency. Original change's description: > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > size of logging_utils.h > > This CL has no behavior changes. > > Bug: 1001360 > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697134} Bug: 1001360 Change-Id: I5a8112a21782863c6420eddd2fe717d368419b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808953Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20791fdb3e91..da39c6d82324 git log 20791fdb3e91..da39c6d82324 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 saklein@chromium.org PackagesService: Add HasChromePrebuilt method. Created with: gclient setdep -r src/third_party/chromite@da39c6d82324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I15bc8370e988d2efacd6fdab79a8d590e2b995f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808435Reviewed-by:
-
Fergus Dall authored
TBR=qinmin@chromium.org Bug: 994789 Change-Id: Id9e87e7f424997b8511dfc2a5d2150b35571c201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810145Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of resource.h from 5.01MB to 4.55MB. Bug: 242216 Change-Id: Ica5c80d5c5d645dfe199f5ea4db346324f1439a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809040Reviewed-by:
-
Fergus Dall authored
TBR=malaykeshav@chromium.org Bug: 974349 Change-Id: I7cdc3d945a641ddf8ff42fb10909f99bbd403f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810144Reviewed-by:
-
