- 19 Oct, 2020 40 commits
-
-
Andrew Shulaev authored
Change-Id: I23657194899a2258e39596056b03a53b2082aa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403484 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818436}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f7eab68c0ce..1253aea08e5f 2020-10-19 mbonadei@webrtc.org Revert "Reland "Remove placeholder Obj-C headers and use angle-bracketed headers."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6c116a8e936e7fb25942e47a133f3b7d2de672d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818435}
-
Antia Puentes authored
This CL migrates the legacy IPC message out of view_messages.h to {Local,Remote}MainFrameHost mojo interfaces from Blink. The ViewHostMsg_Focus IPC method has been migrated both into the LocalMainFrameHost and RemoteMainFrameHost interfaces, and Blink will route the message through the correct channel depending on whether the renderer's main frame is a LocalFrame or a RemoteFrame. ChromeClient calls to WebView to send the message, previously this went through the RenderView. Method TakeFocus has been added to the WebView and methods Focus{Next/Previous} were removed from the RenderView and WebViewClient. Bug: 1135180 Change-Id: I6ac1ac344b9863ad685abca369ad14997b27be0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475116Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antia Puentes <apuentes@igalia.com> Cr-Commit-Position: refs/heads/master@{#818434}
-
Kushagra Sinha authored
EduAccountLoginHandler currently uses |signin::ConsentLevel::kSync| for fetching the account to be used for initiating the parental reauth in EDU co-existence flow. Since this account is guaranteed and must be the Device Account, we should use that regardless of Sync consent status. Fix this by supplying |signin::ConsentLevel::kNotRequired| while fetching the access token for the Device Account in EduAccountLoginHandler. Bug: 1123844 Change-Id: I002f20b754dc63378a4b1b086efbf8cd6b7b3485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484698Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#818433}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2320bb8402d66f17f78b5edf68118efe29ca1abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484313Reviewed-by:
-
Fabian Sommer authored
Add two policies that govern behavior for users that authenticate with a security token (e.g., smart card) and remove it while in session. One policy determines what happens then (nothing/logout/lock), the other determines if and how long a notification of this appears. Add SecurityTokenSessionController that monitors those two policies. Actual behavior (such as displaing the notification or locking a session) will be implemented in follow-up CLs. Bug: 1131450 Change-Id: Ibb7827010b1d6af4127406afe61b261e234b7326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426044 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818431}
-
Julie Jeongeun Kim authored
As blink::mojom::ResourceType is deprecated[1], this CL replaces |resource_type_| with |request_destination_| in AppCacheRequestHandler. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I83c4ab2b35c84aad06aab2d79afb6ff83f5d8005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476696 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#818430}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c69ef8bf34ca..e2e37e74709f 2020-10-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7e36b15b to 7501f245 (405 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id5e229b50896b53d4f52488f4b485130697441e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484733Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69e28b68cab8..efd1e44d0df7 2020-10-19 tvanderlippe@chromium.org Remove unstable native heap sampling experiment 2020-10-19 pfaffe@chromium.org TypeScriptify StylesSourceMapping 2020-10-19 pfaffe@chromium.org TypeScriptify DefaultScriptMapping 2020-10-19 tvanderlippe@chromium.org Move remaining legacy files to GN 2020-10-19 alexrudenko@chromium.org Enable TypeScript for TimelineProfileTree.js 2020-10-19 pfaffe@chromium.org TypeScriptify NetworkProject 2020-10-19 alexrudenko@chromium.org Partially revert 'Fix snippet saving and search' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1043121,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icacc1f1a877e687fb027489c5a19c476f6fefa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484731Reviewed-by:
-
vitaliii authored
This was not obvious on the server and led to a confusion. Happy to provide more details in a private discussion. Change-Id: I7214daf5ae0daa7e5213a921846cde0c5c49bf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484693 Commit-Queue: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818427}
-
Omid Tourzan authored
Removing on_removable_device check from validation in the private API as it's not a reliable check. The removable attribute is read from device by inquiry command [1] and it is false for some devices like removable hdd disks, while they are removable. Also on_boot_device removed as cros-disks server filter out boot devices when populating the list of allowed disks. The new validation still complies with the checks in the cros-disks server (isDeviceAllowed). [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/kernel/upstream/drivers/scsi/scsi_scan.c;drc=c5a9707672fe22865d90fc04ac2fbc4f812666f3;l=813 Bug: 1138076 Change-Id: I66546c26bff766610458e58f7d6dfcda422d2d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483983 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#818426}
-
Denis Kuznetsov authored
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#comment-style Bug: None Change-Id: I50a61322104233b1ef358e5fff90be4262ccbc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484792 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818425}
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2475720 R=sigurds@chromium.org Bug: 1011811 Change-Id: I8e17d4863f17398f153d39d4b72e4e7d434098eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484692 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#818424}
-
Roberto Moura authored
Move kBVCHeightTabGrid (height of the BVC that remains visible when the tab grid is visible) to the grid constants file. Correct the Thumb Strip Layout top section inset value that was wrong. Increase the Grid Layout bottom section inset to account for the BVC on the bottom of the screen. Correct the Tab Grid's bottom content inset by increasing it by the same amount that the top content inset was decreased. Bug: 1127604 Change-Id: I843d74f7ade7272f032211162a0bca9054602dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479467 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#818423}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8216043b1fc4..5118dae088e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I0ea95372bd71531840810b95557b7d00f00408e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484331Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818422}
-
Peter E Conn authored
TBR=wychen@chromium.org Change-Id: I8aa9ab8128a2f5b3144bd1a0fc48f90ea4fc5389 Bug: 1139807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484443Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#818421}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I13e054fb89896cf33aa7be5c043a0f6a9418938c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463616Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#818420}
-
Wolfgang Beyer authored
frontend CL: https://crrev.com/c/2475716 re-enable tests CL: https://crrev.com/c/2478991 Bug: chromium:1011811, chromium:1138492 Change-Id: I8caa074b87593e4f7538bd9aef0133f7467e416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479366Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818419}
-
Morten Stenshorne authored
This is a continuation of tkent's work in https://chromium-review.googlesource.com/c/chromium/src/+/2397378 The sub-directories of Blink core depend on each other, and we don't intend to make independent libraries for each of them. We want a single library containing everything. Currently we have build targets in each of them, and it's very difficult to declare their dependencies correctly in BUILD.gn due to the massive amount of circular dependencies. The new approach which this CL introduces: * A core sub-directory doesn't need BUILD.gn in most cases. * It should have build.gni instead, and build.gni should define source lists. * core/BUILD.gn refers to the lists. All dependencies will also be declared here, since there's no way to determine if a sub-directory has successfully declared all necessary dependencies (since it's part of one big target now). * Some of core sub-directories apply optimization flags different from others. core/BUILD.gn has 'core_hot' target for them. There are still a handful of sub-directories under renderer/core/ that have a BUILD.gn file, because they have special build flags or special targets. We might want to get rid of those eventually as well. typed_arrays/BUILD.gn is kept because it has no difficult dependencies, so it deserves to be a target on its own. Bug: 800764 Change-Id: I92cd5bac949fe4c541f21131309cfc66743edb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463919Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#818418}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForEndOfLine()| to use first or last item in line instead of hit-testing at inline end offset[1] of line box to handle hanging spaces[2] and position:relative[2], numerical saturation in line box size, e.g. width:1e10, correctly. [1] inline end offset: right-bottom offset for horizontal writing mode with left-to-right direction. [2] hanging space: Spaces at end of line not counted for line size https://drafts.csswg.org/css-text-3/#spaces [3] position:relative items can be outsize of line box or any point in line to place first item at last item. Bug: 1136740 Change-Id: I32e46d88617a870944b56f72796902968b216583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467046Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818417}
-
Frédéric Wang authored
When a service worker intercepts a page that is later registered as a handler for a custom scheme via navigator.registerProtocolHandler, and if one clicks a link with this custom scheme, then the service worker is only able to intercept the page after reload. This CL fixes that bug by allowing the service worker to intercept the page after registering the custom scheme. A new browser unit test is added to verify this fix. This also makes the following manual WPT tests pass (*): protocol-handler-fragment-manual.https.html protocol-handler-path-manual.https.html protocol-handler-query-manual.https.html (*) https://w3c-test.org/html/webappapis/system-state-and-capabilities/the-navigator-object/ Bug: 522370 Change-Id: I95eda9025885838665e9735ac9f47a3d65d89aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379672 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818416}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd534e877e72..502e98295625 2020-10-16 afdx@google.com spirv-fuzz: Fix to TransformationInlineFunction (#3913) 2020-10-16 afdx@google.com spirv-fuzz: Wrap early terminators before merging returns (#3925) 2020-10-16 jaebaek@google.com Add DebugValue for function param regardless of scope (#3923) 2020-10-16 afdx@google.com Temporary fix to make GoogleTest compile. (#3922) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I5dd3fb19e37d70be1c87c20f73ae61fb38cd9f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484327Reviewed-by:
-
chrome://cryptohomeYi Chou authored
BUG=b:155063317 TEST=Build ok. TEST=open chrome://cryptohome and check the permission Cq-Depend: chromium:2460975 Change-Id: I81aa0ba7a899d63a62528a7d0592132d9e2d8908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461977Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: joe Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#818414}
-
Reda Tawfik authored
This CL allows keyboard accessory icons to be always shown on username fields if AllPasswordsBottomSheet is enabled. Bug: 1133351, 1104132 Change-Id: I835481caa89d8fc0823f7e00f11375d7729485c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438396 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818413}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/93ed90e6..9e706198 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53c0d5b3e5a3ac6665d57144f670fcff566c21ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818412}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91f276e903b3..d384f3643dbe 2020-10-19 jleconte@google.com Revert "Move Monorail projects list from Python to Javascript." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: rmhasan@google.com Change-Id: I43e446c2bf88382ae5c23d5432e0c7b30f714ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484306Reviewed-by:
-
Luciano Pacheco authored
This is a preparation to migrate to JS modules. Bug: 1133186 Change-Id: I92b0e8c2078a1ecdb3ef814c5c6479c5b97df592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469653 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818410}
-
sandromaggi authored
This adds integration tests for our current input actions. Once we start experimenting, these should ensure that we are not breaking currently working behaviour. Bug: b/168107066 Bug: b/169924567 Change-Id: I141f4033e0080e8c99e0b1280e8521d2bc45e837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484422 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#818409}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ecad5261a1f..4c45ca0dd90a 2020-10-19 yyanagisawa@chromium.org Roll out new goma client binary VERSION=207 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ie5fb838dff049df2cf7285c6a89b06c0f1f95c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483535Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c7e96aec1132..69e28b68cab8 2020-10-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f00359e20dc59551d36b865657e73b901f4d43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483536Reviewed-by:
-
Alice Wang authored
This CL tests the metric recording for the bottom sheet dismiss button in the web sign-in flow. Bug: 1139333 Change-Id: Iafb7fe0528bd5149657a9d92ea3a218fbd9d1228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484424Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818406}
-
Alice Wang authored
This CL tests the error metrics recording in the web sign-in flow. Bug: 1139244 Change-Id: I2c5254afafb71388eeb86d1759e8c808331124e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484652Reviewed-by:
-
arthursonzogni authored
Before fetching the default URL, make sure it won't be blocked by CSP. The webpage didn't requested "/favicon.ico", it is automatic. Developers shouldn't suffer from any errors provoked by Chrome. Fixed: 820846 Bug: 820846 Change-Id: I427bd1bce2230d57339127e8efb6fbe24bb319a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438388Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818404}
-
Kent Tamura authored
* Share the logic of LayoutTextControl::StyleDidChange() by making it a static member function. * Make LayoutTextControlTest a parameterized test for LayoutNGTextArea flag and LayoutNGTextField flag. This CL has no behavior changes yet. Bug: 1040826 Change-Id: I290bf46c86219052eaf9133d3382ff769e56a47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484039 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818403}
-
David Jean authored
Add enum histogram for ios multi-window configuration recording. Each minute one bucket from the enum will be increased by 1. Bug: 1134568 Change-Id: I2f5a031c7430d4b8344adbb06806a3c75803263f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445415Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#818402}
-
Anders Hartvoll Ruud authored
It's now in the spec, so it should be fair to remove the .tentative tag. Bug: 568705 Change-Id: I527632906e49f6d4f9909c75750acbc6e5e91c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479364 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#818401}
-
Philipp Hancke authored
BUG=chromium:1139052 Change-Id: I7c6449b6569251ac6b2320da5a373f637dd4be00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476376 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
-
Rohit Agarwal authored
Incognito CCT. Ephemeral tabs or Preview tabs were using primary OTR profile to open the bottomsheet and to render the WebContents in the Incognito CCT. This CL ensures that we use non-primary OTR profile to open preview tabs in Incognito CCT. Bug: 1138948, 1060940 Change-Id: Iec093e7039e7d5c1b5e5729044af965d9eed0104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476281Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#818399}
-
Victor Hugo Vianna Silva authored
One problem with the old MOCK_METHODN/MOCK_CONST_METHODN gmock macros is that they never specify whether the mocked method is an override or not. The consequence is that sometimes, methods are removed from sync interfaces but remain in the mock implementations. Worse, they can even even remain in test code if the test checks something of the form EXPECT_CALL().Times(0). This CL uses a script to migrate all the sync code to the modern MOCK_METHOD macro. For convenience, patchset 1 is a pure application of the script, marking every method as 'override'. Patchset 2 fixes compilation errors, i.e. either removes leftover methods, or removes the override annotation if the method was indeed intended not be an override. Bug: 1139379 Change-Id: Ic5178057afed6d809d52a0d9c8c5d881acfe20ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480762 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chrome://quota-internalsdpapad authored
This is in preparation of migrating chrome://quota-internals to use JS modules. - Replace calls to CallJavascriptFunctionUnsafe with FireWebUIListener. - Replace event handlers on unnecessary custom EventTarget instances with cr.addWebUIListener() calls. Bug: 1028829 Change-Id: Id5a97d5e81a4e920dfe116a4b93cbacbf5ce55fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478847Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#818397}
-
