GitLab

also, add test cases.

Bug: 825684
Change-Id: I0ce0bbbd5b4c218042f934264ab4de288eba9dae
Reviewed-on: https://chromium-review.googlesource.com/997316Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548692}

Having the logic in the SSLConnectJob, while easier on the socket pools,
interacts badly with the proxy tunneling logic, which bypasses the
SSLConnectJob layer and so we lose the state on whether we were
retrying. The end result is, if the origin always resets the connection,
we retry without bound. This doesn't cause connections that would
otherwise succeeded to fail, but it's still not great.

Instead, go back to our tried and true mechanism of trying at
HttpNetworkTransaction, at the cost of more socket pool bifurcation.

Note this comes with a slight change in metrics, due to things shifting
around: Net.SSL_Connection_Error will report the original error code
(e.g. ERR_CONNECTION_RESET) rather than ERR_SSL_VERSION_INTERFERENCE.
Net.ErrorCodesForMainFrame and user-visible errors remain the same.

Additionally, rather than do a lot of work to plumb
Net.SSLVersionInterferenceDetails's information up, I've just removed
that metric. It was useful when we were developing the protocol
workarounds for the various non-compliant enterprise middleboxes, but
now that the workarounds are applied, we don't need it anymore.

On the test side of things, the existing ERR_SSL_VERSION_INTERFERENCE
tests were sufficiently high-level that they cover this new
implementation too. I've additionally added a regression test to cover
this particular issue.

Bug: 823387
Change-Id: Ia0b5b18c4cfa65fed55f7c1d937623ab37ff741d
Reviewed-on: https://chromium-review.googlesource.com/990812Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548691}

This patch introduces a new Page.navigatedWithinDocument event that is
fired whenever a same-document navigation happens.

Same-document navigation might happen due to History API usages or
due to a call to Page.navigate that changes only anchor.

R=dgozman, pfeldman

Change-Id: I1e702606a97f26511806a0d7328490613dc46246
Reviewed-on: https://chromium-review.googlesource.com/999115
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548690}

Bug: 711156
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic2847a86c7ec3671db79e524a25fa15c08193455
Reviewed-on: https://chromium-review.googlesource.com/996768Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548689}

https://chromium.googlesource.com/catapult.git/+log/7b821dff5984..aaeb23e97cd1

$ git log 7b821dff5..aaeb23e97 --date=short --no-merges --format='%ad %ae %s'
2018-04-06 shend Disable testAwaitedEventIsConfigurable on Mac due to consistent failure

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:829346


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Icd104ba687f402acf89f74e17ff83db43c0a1e4c
Reviewed-on: https://chromium-review.googlesource.com/999180
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548688}

Updates docs/network_traffic_annotations.md

Bug: 656607
Change-Id: Ib9381a89f0458bbb99134a976ea96fdad12a3959
Reviewed-on: https://chromium-review.googlesource.com/966222
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548687}

This patch refactors the function by wrapping certain logic into
IsEndOfDifferentDirection(), so that the remaining function body is
symmetric for left and right edge of |inline_box|.

This allows further refactoring, and also eases implementation of NG
version of bidi adjustment.

Bug: 822575
Change-Id: I40874a50fd07592d42afe6f596bc3481b41b9932
Reviewed-on: https://chromium-review.googlesource.com/997135Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548686}

This CL also adds a TODO to fix subframe transition metrics, but does
not actually fix them yet.

Bug: 827592
Change-Id: I95835ad2911046b402a41d3e5dcedf7b7735911a
Reviewed-on: https://chromium-review.googlesource.com/992392Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548685}

https://chromium.googlesource.com/chromium/buildtools.git/+log/3748a2a90871..10d701fce52d

$ git log 3748a2a90..10d701fce --date=short --no-merges --format='%ad %ae %s'
2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build

Created with:
  roll-dep src/buildtools

TBR=glider@chromium.org

Bug: 812974
Change-Id: I69ab175249b68a0b3bc9a1982556ba0305d8a3a4
Reviewed-on: https://chromium-review.googlesource.com/996481Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548684}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 827065
Change-Id: I6b4d582ba9e1d53dfddebacc8baec199eb311271
Reviewed-on: https://chromium-review.googlesource.com/985995
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548683}

https://pdfium.googlesource.com/pdfium.git/+log/14f8897509d9..4862705090a7

$ git log 14f889750..486270509 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 tsepez Make Internal field usage in cfxjs_engine match README.doc
2018-04-05 thestig Combine if/else blocks in CPDF_DIBSource::TranslateScanline24bpp().
2018-04-05 thestig Split CPDF_DIBSource::TranslateScanline24bpp().
2018-04-05 thestig Fix const casts in CPDF_Encryptor.
2018-04-05 thestig Get rid of a const_cast in CPDF_FlateEncoder.
2018-04-05 thestig Remove some const_casts in CPDF_Creator.
2018-04-05 dsinclair Make CXFA_Document::m_rgGlobalBinding private
2018-04-05 dsinclair Remove unused param.
2018-04-05 dsinclair Move document data merge code into CXFA_Document file
2018-04-05 rharrison Remove unused XFA Widget API methods
2018-04-05 thestig Ignore bad data in the shared object hint table.
2018-04-05 thestig Roll pdfium/third_party/freetype/src/ 7109495c5..26ad1acbc (2 commits)

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9f57c5782c3ec5ccaf49232d714bff5308f2cbd9
Reviewed-on: https://chromium-review.googlesource.com/999011Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548682}

This patch is for set the scroll_event_phase_ kNone as default
in ctor. It hits DCHECK in MakeWebMouseWheelEventFromUiEvent()
if the field not set.

Bug: 647140

Change-Id: I3fd523bd84788957d0d05770fa70503be619e4ad
Reviewed-on: https://chromium-review.googlesource.com/998755Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548681}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5e02fa85..3e5f91d2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I85a5e025f2aefecd425af0e9c287eb3a3653d89f
Reviewed-on: https://chromium-review.googlesource.com/998935Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548680}

Fix traffic annotation auditor bug, when no path filter was provided and
--no-filtering switch was passed, no file was processed.

Bug: 690323
Change-Id: I0235a4c30cf985cf68d7f05080c64bc26f4a29d8
Reviewed-on: https://chromium-review.googlesource.com/958503Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548679}

- Remove InitializeRenderer_InvalidConfig, which causes
  deserialization error and test timeout.
- Reenable tests now that http://crbug.com/594977 is fixed.
- Disable InitializeCdm* tests on Android. See Bug.

Bug: 829233
Test: Various test fixes.
Change-Id: Iaa4ac72a8e60a88559fa198e9f3c1da16aa0beb4
Reviewed-on: https://chromium-review.googlesource.com/996959
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548678}

This shows the CT compliance status in the Certificate Transparency section of
the Security Panel origin details view. Showing the SCTs themselves isn't
sufficient because a site could have e.g. not enough SCTs or SCTs from an
insufficent set of logs, and thus might not be CT-compliance even though it has
SCTs.

I also added a message about when a resource was loaded from cache to the origin
details view. This is useful beacuse not all security details are stored in the
cache, so it can explain why some security details (including SCTs and CT
compliance status) can be missing in this view sometimes.

Bug: 695610
Change-Id: Ib9c8b0af5a08dbc5eefcf778fc030c045622505e
Reviewed-on: https://chromium-review.googlesource.com/998445
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548677}

Bug: 828940
Test: Manually tested. See Bug for repro steps.
Change-Id: Id138ebc26ed5dc0b075cc18a67c651b3832077a9
Reviewed-on: https://chromium-review.googlesource.com/999122Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548676}

This is a reland of a776bce4

This updates the utils filepath so the new test passes.

Original change's description:
> [Picture in Picture] Add modern media control.
>
> Currently, there is only a PiP button for the legacy / non-modern
> set of media controls. This adds and enables the modern version.
>
> BUG: 726619 823109
> Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f
> Reviewed-on: https://chromium-review.googlesource.com/966980
> Commit-Queue: apacible <apacible@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548358}

TBR=mlamouri@chromium.org,steimel@chromium.org

BUG: 726619 823109
Change-Id: I311c137f70b8e5f2ee2681ac8ffd022f2a272d8a
Reviewed-on: https://chromium-review.googlesource.com/998078Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548675}

This should be called after native library has been loaded.
Also, using a sparse histogram to avoid having to provide a max value.

In doing so, histogram name 'WebView' is replaced by 'Android.WebView'
to be consistent.

BUG=827653

Change-Id: I5a03415c342e50ff900e0c4e47f5dd8c17e8a2bc
Reviewed-on: https://chromium-review.googlesource.com/987193Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548674}

This is a reland of r548137 which now includes a whitelist to allow
print preview WebUI to fetch cloud print device information directly
from the network. See https://crbug.com/829218 for additional context.
Original CL description follows.

==

Re-enables this test with the Network Service enabled.


This test did some things which the Network Service does not support and
does not need to support, or which otherwise made testing with the
Network Service more complex than necessary. The following changes have
been made:

  * We no longer attempt to load a network resource from a WebUI
    renderer. This will not be supported with Network Service and is no
    longer desirable to have working in production anyway. There should
    no longer be any WebUI pages making network requests.

  * Use http instead of https for the clients1.google.com requests. This
    allows such requests to be handled by the EmbeddedTestServer which
    already exists in BrowserTestBase, which is itself not configured to
    handle HTTPS requests. Since these requests are filtered by
    hostname, the scheme doesn't matter.

  * Switch the test to use a SimpleURLLoader instead of a
    FakeURLFetcher. This allows the test code to exercise the same
    behavior with or without the Network Service enabled.

TBR=karandeepb@chromium.org

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I57bf66dfd7e7e0726ac98c9571f7fa031243e328
Reviewed-on: https://chromium-review.googlesource.com/998449Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548673}

- Only initialize global state (e.g. AtExitManager) in non-Debug builds, so that our component-
  build Debug bots can run cronet_tests.
- Fix memory leaks in a number of unit-tests.
- Disable some StaleHostResolver tests under ASAN, since they have leaks
  that need resolving.

Bug: 812268, 816705, 829097
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5084dd578682b2a8c128487c62de12e437e646f3
Reviewed-on: https://chromium-review.googlesource.com/981787
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548672}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a5f70cc060a..1118a2193b8f

$ git log 2a5f70cc0..1118a2193 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 ehmaldonado gclient_eval: Support unpinned dependencies in SetRevision.
2018-04-05 ehmaldonado gclient_eval: Add more support when adding new variables.
2018-04-05 ehmaldonado gclient setdep: Command line interface nits.
2018-04-05 ehmaldonado presubmit_unittest: Remove redundant tests.
2018-04-05 sergeyberezin Roll mac_toolchain to 496a91484
2018-04-05 borenet roll-dep: Fix behavior for relative DEPS

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:760633,chromium:760633,chromium:760633,chromium:829134,chromium:797051


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ibc387b556140307f5ed87c799cb5318c8c59e631
Reviewed-on: https://chromium-review.googlesource.com/999308Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548671}

* Refactor of the browser test code to make it easier
to add new client hints without repetitve code
* Move the effective connection type names to a common
folder so they can also be accessed from
chrome/browser. This is necessary since we need
to add ECT client hint in the next CL on navigation
requests in chrome/browser.

This CL does not make any functional changes.

Bug: 826950
Change-Id: I7c854fae84738b8d0edece6c6ffd27abcc43bfbc
Reviewed-on: https://chromium-review.googlesource.com/996925
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548670}

The current chrome.management.uninstall api shows the programmatic
uninstall dialog for extensions uninstalling other extensions. Web Store
is treated as a hosted app. Thus in order not to show "Web store wants
to uninstall this extension" I added a check to make sure the uninstall
is not coming from the Web Store. I also added an uninstall source for
web store so we can track which uninstall pings come from the store.

Bug: 823155
Change-Id: I73c1e53ffaadcddd930e34032db2acda6cb9867f
Reviewed-on: https://chromium-review.googlesource.com/966485Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548669}

Currently, we run the PipSurfaceInfoCB callback in WMPI with an empty
viz::SurfaceId, which is not allowed. This change adds a new mojo call
to explicitly exit from Picture-in-Picture mode from the WMPI side.

BUG: 823172
Change-Id: I81bb71a3853325bcf31a56f8929d4aba17f66248
Reviewed-on: https://chromium-review.googlesource.com/996468
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548668}

The state of which buffers (color, depth, stencil) were modified was
not being tracked properly with the introduction of the ES 3.0 / WebGL
2.0 APIs. Generalize DrawingBuffer's tracking, and make these APIs
update the state properly.

Tested with new WebGL conformance test in
https://github.com/KhronosGroup/WebGL/pull/2628 .

Bug: 828262
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d87b1940a73c689c2107d969139ad8c9c265ce5
Reviewed-on: https://chromium-review.googlesource.com/994463
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548667}

Change-Id: Id6c781b5f3d113d6575f314b301f923c4221b83d
Reviewed-on: https://chromium-review.googlesource.com/998675
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548666}

There's been a bunch of crashes where it appears no video frame was returned
even though status = success. This change adds additional logging and converts
some of the DCHECKs to CHECK so that the problem is caught earlier.

BUG=828148
TEST=encrypted media browser_tests pass

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib15465179f4931860b6b6fb4192c320e09a30d7e
Reviewed-on: https://chromium-review.googlesource.com/993711Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548665}

Feed Sizing:
Monochrome.apk_Dex
        +2 entries fields
        +5 entries methods
        +1 entries types
        +1 entries strings
Monochrome.apk_Breakdown (+1,524 bytes)
      -273 bytes Zip Overhead
       -17 bytes Non-compiled Android resources size
       -28 bytes Package metadata size
      +266 bytes Java code size
    +1,576 bytes Compiled Android resources size
Monochrome.apk_Specifics
    +1,908 bytes normalized apk size
      +384 bytes main dex size

(The sizing looks very similar to the last DEPS roll which is to be
expected given that the delta is small)

Change-Id: I5207c2a038034007a4e9353709c607468eb27b44
Reviewed-on: https://chromium-review.googlesource.com/999261Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548664}

NOTRY=true  # CQ flake

Change-Id: I6b85e7836cf0a4921396f7d7066d38f04f1b5598
Reviewed-on: https://chromium-review.googlesource.com/998061
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548663}

Previews in android should not be presented without the full chrome
browser user treatment (eg, PWA launched from homescreen in standalone
mode). This CL blocks previews for navigations that do not originate
from an android Tab in kWebDisplayModeBrowser.

Bug: 818031
Change-Id: I88bbae7954daf503e49720adce094a9111790003
Reviewed-on: https://chromium-review.googlesource.com/953882Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548662}

This splits out purely code health changes from the master patch at
https://chromium-review.googlesource.com/c/chromium/src/+/981845

Change-Id: I0a36ea4a69c38fdbf22b514f1ebc43f3ed70f827
Reviewed-on: https://chromium-review.googlesource.com/999215Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548661}

This was flaking because of crashes in Oilpan. Since then, the WebGL
context's object graph has been redesigned. This test should no longer
be flaky.

TBR=kainino@chromium.org, jdarpinian@chromium.org

Bug: 603168
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibafa9168250094c4b070342a8a08a6bb92002174
Reviewed-on: https://chromium-review.googlesource.com/996965
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548660}

The download button only shows up in the overflow menu so the logic is
now to show the UI anchor to the overflow menu button to suggest the
user to use it to find the download action.

Bug: 781725
Change-Id: Ifce219924ac55c7858ffb1ba8a099cbc96a24e6d
Reviewed-on: https://chromium-review.googlesource.com/998913Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548659}

In order to break-away from the legacy threading model and eliminate the
need for future circular dependencies on src/media/(audio|base), this
change forks AudioOutputController and AudioSyncReader into
src/services/audio.

In addition to the namespace and class naming changes, the following
modifications have been made on the forked code:

1. Removed the ref-counting of audio::OutputController, eliminated the
Create() factory methods, and changed a few heap-allocated objects into
proper class data members (i.e., composition instead of indirection).

2. Removed the XYZ()→DoXYZ() thread-trampoline methods.

3. Updated comments that became misleading or are not otherwise accurate
to how things work in the new Audio Service.

4. Changed the audio::OutputStream to use the forked OutputController
and SyncReader.

5. Updated unit tests.

Further clean-ups and code deletions/refactorings are intentionally
being left TODO in future patches.

Bug: 824019, 803102
Change-Id: If479c63909c252c8fca135c9a51dcac76feeec8c
Reviewed-on: https://chromium-review.googlesource.com/982904
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548658}

This reverts crrev.com/c/952666. That commit was a workaround for a
bug which was fixed in Clang r327557, so the workaround is no longer
needed.

R=depranke,brucedawson

Bug: 818086
Change-Id: I98ba3cea051734da2eef81fe1986c9f9b5d9b617
Reviewed-on: https://chromium-review.googlesource.com/998513Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548657}

After [1], ThreadableLoadingContext::Create() takes ExecutionContext&, so we
don't have to call ToDocument() / ToWorkerGlobalScope() for the function.

[1] https://chromium.googlesource.com/chromium/src/+/87c0b54398ec0f1d48fd4ace777691f4b756c880

Bug: n/a
Change-Id: I253e2d43274fa78014386176e1358716c67c7c2e
Reviewed-on: https://chromium-review.googlesource.com/996836Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548656}

Bug: 754986
Change-Id: I66fafcea2b851e371473893bd23fe36b17354069
Reviewed-on: https://chromium-review.googlesource.com/999041Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548655}

The histogram values for an extension function are used to report
API call activity and related metrics for extension functions. Each
extension function should have a unique histogram value, but some of
them were erroneously copy-pasted. This leads to incorrect metrics, both
with not reporting one function and over-reporting another.

Fix the instances where the histogram values were duplicated, and add a
browser test that ensures each function has a unique histogram value.

Bug: 827601

Change-Id: Ic44519ca83fe0cf4b3a1896a16232f6400b6c79d
Reviewed-on: https://chromium-review.googlesource.com/988227
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548654}

I found the reason that SPv175 has 10% less paint_op_count but about
1% more paint_op_memory_usage: we didn't count ops in sub-records.

Add cc::DisplayItemList::TotalOpCount() to count all ops.

Bug: 803867
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0526ace84cc16775d5691e87b502544e64f5932e
Reviewed-on: https://chromium-review.googlesource.com/996316Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548653}