- 25 Jun, 2019 30 commits
-
-
Nate Chapin authored
Bug: 977520 Test: http/tests/navigation/xmhtml-location-change-crash.xhtml Change-Id: Idbb8718db7de77ddf41dbc62bd102e884d0bfa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674364 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#671872}
-
Natalie Chouinard authored
Migrat the Site Settings preference fragment from the deprecated framework preferences to the support library preferences. Bug: 968592 Change-Id: I127b24977adf8f4091769131f6f554484b149317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668628 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671871}
-
Chris Blume authored
This CL adds another test which has flaked to the filter. Bug: 977669 Change-Id: I740871a457227a21a75834d02fe1da7afd527096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674632 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#671870}
-
Ayu Ishii authored
This change updates the SMS formatting to use "To:" instead of "From:"[1]. This seems more appropriate because there isn't any guarantee that it is actually going to be coming from what the address states. The intent is to direct a message "to" an origin, independently of "where/from" it is coming from. [1] https://github.com/samuelgoto/sms-receiver#formatting Bug: 976346 Change-Id: Iaf1358661b45a5a2066f4d8c3eac2bc294c10511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669985Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#671869}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5dee3e826bed..99b76d1b8fdd git log 5dee3e826bed..99b76d1b8fdd --date=short --no-merges --format='%ad %ae %s' 2019-06-24 natlee@microsoft.com Clear D3D12 texture on first usage if not yet initialized Created with: gclient setdep -r src/third_party/dawn@99b76d1b8fdd The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I54e191a249a14d3e340626b8a0d67feca0e8a974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671868}
-
Jan Wilken Dörrie authored
This change removes the dependency on Hash() in the implementation of StructPtr's and InlinedStructPtr's operator<, and replaces it with a deep comparison. Bug: 735302, 911929 Change-Id: I2d81d1990787e29a1588f3783eb91d0eaa98207b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665934Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#671867}
-
Lukasz Anforowicz authored
The NavigationRequest::base_url_ field used to be populated based on FrameHostMsg_DidCommitProvisionalLoad_Params::base_url, but was never read by production code. Bug: 962643 Change-Id: Ib9e46575f37efc56ca479294ba881919dd934f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670268 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#671866}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd2737e2b572..73c4a7c3567a git log dd2737e2b572..73c4a7c3567a --date=short --no-merges --format='%ad %ae %s' 2019-06-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@73c4a7c3567a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib1c9f8b97e8d255d1521e5fc03d23f5a2d919b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674661Reviewed-by:
-
Kenichi Ishibashi authored
On-the-main-thread script fetch is disabled by default. Add virtual tests for on-the-main-thread script fetch to have better test coverage until we ship off-the-main-thread script fetch. Bug: 967272 Change-Id: If0b50ad557699d57bae70b2972418df5dc91ed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673487Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671864}
-
Peter Kasting authored
* Initializer lists * Range-based for * stack::emplace() * Style fixes * Shorten code * Prefer ++ to +=1 * nullptr * Save result of PositionOf() call instead of recomputing * int -> size_t in TreeNodeIterator * Don't handle DCHECK failure Bug: 956419 Change-Id: I62c658a0b0476a37998aaaec89b91bca0c00ca2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660105 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#671863}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ad6de6a08a66..50710e758168 git log ad6de6a08a66..50710e758168 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 asweintraub@google.com Fix non-standard assignment operator return types. 2019-06-24 asweintraub@google.com Fix 19 ClangTidy - Readability/Naming findings in core/fxge/ 2019-06-24 asweintraub@google.com Fix 31 ClangTidy-Readability/Naming findings in core/fxcrt/. Created with: gclient setdep -r src/third_party/pdfium@50710e758168 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ic3324923596f5accd23fcf8b40843c084f749c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674624Reviewed-by:
-
Karan Bhatia authored
DisplayInfoProvider::Create is declared at the extensions layer but not defined. The expectation is that the extensions embedder will define it. However this is not ideal since any target depending on just extensions gets an undefined function linking error. Correct this by introducing ExtensionsAPIClient::CreateDisplayInfoProvider and introducing appropriate embedder implementations. BUG=976556 Change-Id: I1a9d51ef90d2837ea4bc18cb6df7a629609d7d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666446 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671861}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79519d67783b..967947db0661 git log 79519d67783b..967947db0661 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 hjd@google.com Merge "traced_probes: Add atrace events explicitly" 2019-06-24 fmayer@google.com Merge "Share interning data between ProfilePackets." Created with: gclient setdep -r src/third_party/perfetto@967947db0661 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iacc8fee3de2276bf689ecd041eb8a2cead353354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674303Reviewed-by:
-
James Cook authored
OS settings doesn't control search engine, so don't use a magnifying glass icon. Use the assistant icon instead. See bug for screenshot. Bug: 960937 Change-Id: Icd2929a76572468df4d6615166c4b9d2782c4c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674641 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Eric Willigers authored
RTCRtpReceiver.getParameters() shipped in M73. https://chromestatus.com/feature/5641443221700608 The flag RTCRtpSenderParameter has been stable since https://chromium-review.googlesource.com/1070277 Bug: 803494 Change-Id: I162616cfb572487f9d29954da41e0b490c34a19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616831Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#671858}
-
David Benjamin authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/c8b248039ec1..f564874f4955 $ git log c8b248039..f564874f4 --date=short --no-merges --format='%ad %ae %s' 2019-06-19 davidben Don't opt out of sanitizers in third_party/nasm Created with: roll-dep src/third_party/nasm Bug: 928357 Change-Id: I2a796207721da649f24a84730bfdff3ef39eaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672127Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#671857}
-
Reilly Grant authored
Timeout and pending errors are generated by the chrome.serial API layer and not by the Mojo interface implementation in //services/device. Bug: 893334 Change-Id: Ibde54b35a54db5e7c7c27697eae21bce5b190537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674651Reviewed-by:
-
Istiaque Ahmed authored
Implement the ability to track and retrieve user gesture within an extension Service Worker. Introduce ExtensionInteraction class that provides unified way (for RenderFrames/SWs) to create or retrieve user gesture states. Limitations: * Note that this only works for extension API invocation (e.g. chrome.management.setEnabled), but not for web API invocation (clients.openWindow()). * This CL also does not support user interation retention in API callbacks. That will be tackled in a subsequent CL. RenderFrame based extensions: Make ExtensionInteraction class wrap WebScopedUserGesture and WebUserGestureIndicator to continue to provide RenderFrame/WebFrame based extension's user gesture support. In future this class will also wrap WebUserGestureToken, when necessary. SW based extensions: The interaction is implemented using a counter globally within a worker, in ServiceWorkerData. ExtensionInteraction consults worker local data (ServiceWorkerData) when a user gesture is created, destroyed (ServiceWorkerData::Increment/DecrementInteraction), or retrieved (ServiceWorkerData::interaction_count()). This CL also enables browserAction API for extension SWs. Add a test with browserAction API that ensures the gesture is present when browserAction.onClicked is fired. Bug: 977629 Change-Id: I9c3db7f2b7de67b50e92814b4d6b46060c8f9993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670317 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL informs the clients API about initialization result and list of guids of scheduled notifications. Also some minor polish for the client interface. Bug: 963288 Change-Id: I887f668b0f201583b208497ad4cd782a1679be4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670053 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#671854}
-
Min Chen authored
Bug: None Change-Id: I1fe55628621fa05d4eaa3dead26bc19d38776be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674452Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#671853}
-
Eugene But authored
This histograms are useful beyond their originally set expiration date. Bug: 975332 Change-Id: Id913299c5de2f14bced1d81ff5424046c96958c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663054Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#671852}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I72c695ee6cf66dc02a5f9f9f6145b31ba3fae4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674456 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#671851}
-
Bin Wu authored
1. Net.QuicSession.ClosedByRtoAtClient.SentPacketCount. 2. Net.QuicSession.ClosedByRtoAtClient.ReceivedPacketCount. Change-Id: I5086c828e24ffad970f763cc18cd4a66d5b51ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673569Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#671850}
-
Sunny Sachanandani authored
This is a reland of 62120966 The only change is skipping tests if direct composition isn't supported. Original change's description: > Testing for SwapChainFactoryDXGI > > Updated GLImageDXGISwapChain to use EGL Images instead > of pbuffer surfaces, to avoid creating render target view > for front buffer. > > Bug: 939655 > Change-Id: Iec80f399724ee0509dd95d126c0d3dbb883bb87c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663014 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> > Cr-Commit-Position: refs/heads/master@{#671369} Bug: 939655,978181 Change-Id: Ib2a316081fb60f1208b777f5f5fa767d03df55f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673137 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#671849}
-
Lucas Tenório authored
Bug: 977606 Change-Id: I8dfbd4cfbc77429adde64808be853a7d67113293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669614Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#671848}
-
Joe DeBlasio authored
Previously, the Page Info bubble maintained a single variable to identify all reasons that a page might have a non-standard status. This lead to the display logic making assumptions about, for instance, the validity of a certificate when the page was flagged by Safe Browsing. This CL separates out the Safe Browsing status from the site identity status so that the page info bubble can inform the user that the site's certificate is invalid, even if it's also flagged by Safe Browsing. Bug: 869925 Change-Id: I34107225b4206c8f32771ccd75e9367668d0a72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#671847}
-
Tom Anderson authored
The implementations are now feature-complete and without any bugs in the environments that I tested, so enable the new status icons starting in M77. BUG=419673 R=thestig Change-Id: Ic9275533f60fe28b5dd5fc1555fd9ed1ebbe6045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672570 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#671846}
-
Sean Topping authored
This allows clients to use Channel-associated interfaces provided by the render frame. Bug: internal b/77879457 Test: CQ Change-Id: I6334f1e83bac7666fd2dfa0d92d6239a0ab5a003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674442Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#671845}
-
rbpotter authored
Bug: 977480 Change-Id: I04f9f0c504bbec63c69b671fc5612b1319b3d74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672181Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#671844}
-
Reilly Grant authored
This change implements support for opening and closing a SerialPort object as well as the ReadableStream that will carry data read from the port. This stream is aborted if there is a read error (such as a parity error) and the clearReadError() method will create a new stream to restart the flow of data. Bug: 893334 Change-Id: I66b4d16c004e250fb22ad41eeb59fe47aeee430d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668575 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
- 24 Jun, 2019 10 commits
-
-
Ben Pastene authored
This reverts commit 8b2e4255. Reason for revert: Breaking change reverted (CL:1674444) Original change's description: > Disable failing webgl_conformance test on CrOS. > > Failing consistently after crrev.com/c/1598921 (See bug.) > > Disabling for now. > > TBR=kbr@chromium.org > > Bug: 977830 > Change-Id: Ib5ee0ce7e67ff6def2908d368f3885c0c5c02812 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674326 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671777} TBR=rjkroege@chromium.org,kbr@chromium.org,bpastene@chromium.org NOTREECHECKS=true NOTRY=true Change-Id: Id3a6cd0b964f6949668a257caad14420fa620f2d Bug: 977830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674646Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#671842}
-
Mandy Chen authored
Fixed a grdp message has the wrong IDS key because it was manually modified in https://crrev.com/c/1637046. Another patch will modify the presubmit script to fix wrong ids keys: https://crrev.com/c/1661120 Bug: 941561 Change-Id: I7c1709196275d03383bc773c3126a92180e9d505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670315Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#671841}
-
Avery Musbach authored
The present CL puts the functionality from [1] behind a feature flag. That functionality consists of visuals for dragging an overview item from one display to another. The problem is that these visuals could set user expectations of functionality that will actually be lacking for months. The virtual desks feature is launching soon, and it will make these visuals potentially observable because it enables dragging from overview (not to close) in clamshell mode. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1627910 Test: manual Bug: 961170 Change-Id: Ic247a4f53260bdc5118c1235a3ba66fe7787c7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670114 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#671840}
-
Sky Malice authored
+77,856 bytes main lib size +414,372 bytes main dex size +272,160 bytes secondary dex size +1,101,382 bytes normalized apk size +418,197 bytes APK size +1,221,439 bytes Estimated installed size (Android Go) +3,191,786 bytes Estimated installed size InstallBreakdown (+3,187,812 bytes): +4,079 bytes Native resources (no l10n) size +2,509 bytes Non-compiled Android resources size +77,856 bytes Native code size +781 bytes Package metadata size +3,074,463 bytes Java code size +28,124 bytes Compiled Android resources size +4,388 entries fields +5,884 entries methods +2,036 entries types +4,378 entries strings Specifics: InstallSize: Dex: Change-Id: I7c0ee757658b10fe4418c017f1c11e42e64f7504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672464Reviewed-by:Dan H <harringtond@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#671839}
-
sczs authored
- Creates infobarBannerCurrentlyPresented property, which is now true if a banner is currently presented. - presentingInfobarBanner is now used only to indicate that the Banner is mid presentation. - If the banner is mid presentation, it gets dismissed on userEnteredTabSwitcher because of crbug.com/977761. - Updates the container unit_tests to use infobarBannerCurrentlyPresented Bug: 977017, 911864 Change-Id: Ic668f0723267e5da0f582cb6927c2b931ab0bbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672764 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#671838}
-
Sophie Yang authored
Replaced placeholder icons on the switch access menu with the actual icon assets. Added a copyright header to the top of each icon's image file. Test: With emulated Chrome OS on Linux, launched Switch Access and checked relevant menus to ensure new icons were present. Bug: 973719 Change-Id: I1337bf2fbd9a5fcadc56737886be7ab7d56aca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674193Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Sophie Yang <sophyang@google.com> Cr-Commit-Position: refs/heads/master@{#671837}
-
Karan Bhatia authored
Mark - Extensions.WebRequestAction - Extensions.DeclarativeAPIFunctionCalls as non-expiring. The first is used to monitor usage of web request API and the second is useful to monitor the usage of declarative APIs. BUG=975133 Change-Id: I49a4d1cdecccf12bb7b4fe97eb9bc7e95145fd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666573 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671836}
-
Eugene But authored
CommitPendingItem used to rely on pending item index to check which item to commit (one from context or one from navigation manager). This logic was not correct because it is possible to have back-forward and new navigation simultaniously, so CommitPendingItem should commit item from context if one exists. Bug: 944044 Change-Id: If83bb2427780b56c1a2d24a6811640aa4a3375c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670307 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#671835}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b3523d57461c..16f6e6ab932f git log b3523d57461c..16f6e6ab932f --date=short --no-merges --format='%ad %ae %s' 2019-06-24 zoddicus@users.noreply.github.com Remove SetShaderModel from API (#734) Created with: gclient setdep -r src/third_party/shaderc/src@16f6e6ab932f The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I1a78f3aaad6a6dd49107fe1b6e2f72706c6e7680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673459Reviewed-by:
-
Lucas Tenório authored
Bug: 977566 Change-Id: I7c8983f732a53800f3b32dcb400884ff75266567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673017 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#671833}
-
