- 07 Jun, 2018 40 commits
-
-
Xing Liu authored
The storage summary string under download home title currently uses SpannableString that can expand to multiple lines, and can only apply simple styles defined by Spannale. This CL adds a view for the summary string. Bug: 849973 Change-Id: If01d323022e0cc743540a02ba58801c664957aa4 Reviewed-on: https://chromium-review.googlesource.com/1089815Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565309}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2bd1fab..ea17575 git log 2bd1fab..ea17575 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 lucferron@chromium.org Vulkan: enable invariance dEQP tests Created with: gclient setdep -r src/third_party/angle@ea17575 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie1bfb05d8d242c36d09dd57972cf34e3898719dd Reviewed-on: https://chromium-review.googlesource.com/1090970Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565308}
-
Elad Alon authored
When browsing data is cleared, in addition to deleting pending logs, also cancel ongoing uploads of WebRTC event log files which fit the user profile and time range that is being cleared. To facilitate this change, it was necessary to change the way WebRtcEventLogUploaderImpl gets hold of a URLRequestContextGetter. Instead of thread hopping to get one, it is now given one in the constructor. Since g_browser_process->system_request_context() is not available when WebRtcEventLogManager is constructed, setting the URLRequestContextGetter is deferred to the time when the first user profile is loaded. Bug: 775415 Change-Id: I2b19b95d7acba44c84d0fb72b014b9e4c6e2cdf7 Reviewed-on: https://chromium-review.googlesource.com/1078737 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#565307}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d5c4ab1..5ebfd64 git log d5c4ab1..5ebfd64 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 hnakashima@chromium.org Test to show editing a PageObject and saving the .pdf duplicates it. Created with: gclient setdep -r src/third_party/pdfium@5ebfd64 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I11c01fcce6baf33e4e8a5cb49c6e61beb0c669e3 Reviewed-on: https://chromium-review.googlesource.com/1090763Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565306}
-
Eric Stevenson authored
Removing the reference to BuildHooksAndroidImpl from BuildHooksAndroid shrinks the main dex by ~2000 methods for downstream targets. Bug: 820570 Change-Id: If4051f7a85e387129c65a7a5b927183b5b36bf65 Reviewed-on: https://chromium-review.googlesource.com/1089625 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#565305}
-
Emily Hanley authored
NOTRY=true # CQ flake Bug: 713357 Change-Id: Ib0a4a63c02c78ac3015cef4e03eff07d3a2e9197 Reviewed-on: https://chromium-review.googlesource.com/1090757 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565304}
-
Evan Stade authored
Only support native notifications, i.e. those passed over mojo. Some tests are permanently removed on Chrome OS. Some tests are migrated to message_center_unittests. This relands commit 4da4d1e4 originally reviewed on: https://chromium-review.googlesource.com/1083937 Bug: 578868 Change-Id: I87834ba69bcb37db599e3e046225b793d09b9396 Reviewed-on: https://chromium-review.googlesource.com/1089917Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565303}
-
Robert Ma authored
This CL only increases the default history window size for *landed commits* to 10000, which is about a month's worth of commits. The history window size for GitHub PRs and Gerrit CLs are not changed. Landed commits are scanned locally (using git), which is pretty fast (takes few minutes), so doubling the history window won't affect total run time too much. Bug: 752214 Change-Id: Id2f498aa1d8a8adb8369fe7553c73662e5b02343 Reviewed-on: https://chromium-review.googlesource.com/1085556 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#565302}
-
Chris Lu authored
[ios] Create ClearBrowsingDataManager to hold bulk of ClearBrowsingData logic that can be shared between CollectionVC and TableVC Moves appropriate unit tests to new manager unittest file. Also creates ClearBrowsingDataConsumer for mediator to communicate with view controller. Change-Id: Ia60b78ff49c77b526aff5bf3034c06e35bda7b48 Reviewed-on: https://chromium-review.googlesource.com/1086240 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565301}
-
Fabio Tirelo authored
The current implementation reads "autofill menu opened" for the old dropdown, but only "menu opened" for the new dropdown. Bug: 850094 Change-Id: I825069866462897116dc179f6418a8f87f1c3467 Reviewed-on: https://chromium-review.googlesource.com/1088764Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#565300}
-
chaopeng authored
scroll-position-restored-on-back-at-load-event was fixed in crrev.com/c/207e8662. Bug: 835802 Change-Id: Ic69c2844799d8aa7e2c57c4f952c36fd986b6cee Reviewed-on: https://chromium-review.googlesource.com/1089588Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565299}
-
Sky Malice authored
Bug: 831648 Change-Id: If86282e15d436bfa1e625f38941d59e47e3e5294 Reviewed-on: https://chromium-review.googlesource.com/1089887 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#565298}
-
Kai Ninomiya authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/198d637..25a501c Bug: 828135, 849572 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: If7749e453107880d235109758aebf452ff5a80ab Reviewed-on: https://chromium-review.googlesource.com/1086507 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565297}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/5601bdac1ae594169e56515fe34956ec89bbffbf..5267ef7b4aa6385c0351ae10ce3092828cca4909 BUG=none Change-Id: I9ab8240831532702e6e77ee8faa7c99f0375950c Reviewed-on: https://chromium-review.googlesource.com/1087932 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565296}
-
Moe Ahmadi authored
Also changes canMakePayment() to behave as in normal mode to avoid incognito mode detection as per other platforms Bug: 850078,846698 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icdc3f79dd0a3cbc1d34e7e5d5e5ca2077a096b6c Reviewed-on: https://chromium-review.googlesource.com/1089032 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#565295}
-
vitaliii authored
1) Link non-iOS chrome/browser/consent_auditor/OWNERS to components/consent_auditor/OWNERS. 2) Add markusheintz@ to ios/chrome/browser/consent_auditor/OWNERS. Unrelated: s/msramek@google.com/msramek@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib658046f7742d426adf68f0ae25f7c480d4a7800 Reviewed-on: https://chromium-review.googlesource.com/1090280Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565294}
-
edchin authored
Bug: 849667 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I37bbca1646f3de0534331903b555417ef75fd448 Reviewed-on: https://chromium-review.googlesource.com/1090570Reviewed-by:
-
Peng Huang authored
Bug: 824382, 727775 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If75f42895bfc2a41ec3c4cf1bbe0e24b37743c36 Reviewed-on: https://chromium-review.googlesource.com/1089041Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565292}
-
Henrik Boström authored
With this change, onsignalingstatechange always fires before the setLocalDescription's promise resolves. Before this change, signaling state changes were surfaced with callbacks firing separately from the callback that setLocalDescription or setRemoteDescription had completed. As a result, the result of a SLD/SRD operation was surfaced in two PostTasks instead of one. This could lead to flaky behavior where JavaScript task execeution cycles may or may not execute between PostTasks which lead to undefined order. Also when the signalingstatechange was surfaced to the JS thread the firing of the event was delayed by a task execution cycle due to ScheduleDispatchEvent. - If both PostTasks were handled in the same cycle, the event firing would be scheduled and the promise resolved, such that the promise's then() is invoked just before the event fires (scheduled after promise). This is NOT in accordance with the spec. - If onsignalingstatechange's PostTask was handled in its own cycle, the event would be scheduled such that by the time the setLocalDescription's callback's PostTask occurs resolving the promise, the event would fire before the promise's then(). This IS in accordance with the spec. With this change, the onsignalingstatechange event is fired without delay, and it is processed in by the same observer that handles the SLD/SRD callback, so the order is always guaranteed to be the same. In addition, this CL removes the usage of WebRTCPeerConnectionHandlerClient::SignalingState and relies on the webrtc::PeerConnectionInterface::SignalingState enum directly. This is part of the Onion Souping work (crbug.com/787254). Bug: 848768, 787254 Change-Id: I7bc10439c44c6ff6beab0289975295ff2e051b9c Reviewed-on: https://chromium-review.googlesource.com/1085302 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Amy Qiu authored
Move tough_scheduling_cases into the rendering folder and refactor classes to inherit from RenderingStory Bug: 849392 Change-Id: I247f9aff4fde03cda7ea479a9dcf88c04960c749 Reviewed-on: https://chromium-review.googlesource.com/1089459Reviewed-by:
-
Daniel Bratell authored
Some jumbo builds broke because of too many CappedSizeInKB so moving it to heap.h to unbreak the builds. It's a small inlined method. The moved function is not using std::min to avoid including <algorithm> in heap.h and potentially causing a measurable build time regression. TBR=mlippautz@chromium.org,haraken@chromium.org Bug: 840789 Change-Id: I4e4bf3989235c6e7274a56f5c10823d8bb37a4df Reviewed-on: https://chromium-review.googlesource.com/1090839Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#565289}
-
Gabriel Charette authored
Fixing crbug.com/847501 and adding two regression tests for it. Added SchedulerWorker::GetLastUsedTime() to support this fix and re-used it to suppress the need for the delegate's |is_on_idle_worker_stack_|. Tweaked WaitForWorkersCleanedUpForTesting() to allow being called multiple times. R=fdoray@chromium.org Bug: 847501 Change-Id: I83f814358f679bdbee49778963ff9d05cd240adc Reviewed-on: https://chromium-review.googlesource.com/1086978 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#565288}
-
Mugdha Lakhani authored
This change adds logic to BackgroundFetch Context to observe service worker events, specifically, unregistration, and wiping of SW database, and implements logic for the unregistration case. It also adds a small unit test to verify the appropriate error code is returned when the service worker is unregistered mid-fetch. Bug: 841385 Change-Id: I0a22489ce79bbffb7a5528c8646522c40e59a799 Reviewed-on: https://chromium-review.googlesource.com/1071651 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#565287}
-
Elly Fong-Jones authored
This change adds rounded focus rings to the location icon button and to page action buttons. Bug: 848299 Change-Id: I06b501b664315ad615d334fee23149854550bd06 Reviewed-on: https://chromium-review.googlesource.com/1080889Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565286}
-
Wez authored
These tests mix use of QuitCurrent*Deprecated() with use of the current RunLoop::Quit*Closure() model. Migrate them off the deprecated API so that we can enforce quit-by-closure-only wherever QuitClosure is used. Bug: 844016 Change-Id: Ib93c6419a81642a3d374ec08a3c71ddaacc3cb88 Reviewed-on: https://chromium-review.googlesource.com/1090211Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565285}
-
Randy Rossi authored
For ChromeCast screen reader, getDesktop is needed rather than enableTab. This creates an automation tree for all running cast apps. Added accessor for window tree host to the accessibility manager. Bug: b/73383411 Test: None Change-Id: I79d0be3f9a5e3567ad493e86d1615dcacf9bffe6 Reviewed-on: https://chromium-review.googlesource.com/1086983 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#565284}
-
Ian Clelland authored
This adds a WebOriginTrials interface, which can be used to query the state of an origin trial given a WebDocument. Bug: 845995 Change-Id: Ifbaed167bcfd2588436bd32f6f03d3f57171434c Reviewed-on: https://chromium-review.googlesource.com/1088310 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
-
Wez authored
These tests mix use of QuitCurrent*Deprecated() with use of the current RunLoop::Quit*Closure() model. Migrate them off the deprecated API so that we can enforce quit-by-closure-only wherever QuitClosure is used. Bug: 844016 Change-Id: I5aca4ada0678f0cb1d84ced9fef9495fba751a7b Reviewed-on: https://chromium-review.googlesource.com/1090213Reviewed-by:
-
Max Morin authored
They now log error during creation and error while stream is active separately. The names are changed to Media.Audio.Render.StreamCallbackError2 and Media.Audio.Capture.StreamCallbackError2 to avoid mixing the new and old data. Also, errors are now logged only when they are forwarded to the callback, to better correspond errors in the upper layers. Also drive-by fix some typos. Bug: 836420 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie620c0f5864cdde3f98da1526de1fc0ed9456b66 Reviewed-on: https://chromium-review.googlesource.com/1078312Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565281}
-
Rune Lillesveen authored
Revert "Cleanup no longer used argument in MutableCSSPropertyValueSet::SetProperty." This reverts commit 710b5cc7. This reverts commit 9d45b94d. Reason for reverts: suspected performance regression in 845944. Combined reverts to make it easier to merge to M68. Bug: 845944 Change-Id: Id01bb23981e82e25c26ff54a3970150f082d6878 Reviewed-on: https://chromium-review.googlesource.com/1090835Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#565280}
-
Jeremy Roman authored
Bundle whichever startup snapshot is enabled (on Android, this is presently the pure V8 one). Disable the gin_shell test, which tries to invoke the gin_shell binary (but that doesn't really make sense on Android, which only supports running Android apps packaged as APKs). Works for me locally. Assuming this sticks, a followup will re-enable gin_unittests on the bots. Bug: 843124 Change-Id: Ia69a39263ed01b2d2b2664f58ec4263380a3ef00 Reviewed-on: https://chromium-review.googlesource.com/1089458 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#565279}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62e29b21..d993e197 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic3d30bd0626637481793e331641f4c882041ba42 Reviewed-on: https://chromium-review.googlesource.com/1090816Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#565278}
-
Josh Horwich authored
Adds logging of consent_status::NOT_GIVEN for Play Store if the user turns Play Store off after opting in. Bug: b:79584730 Test: Disable ARC in chrome://settings, unit_tests Change-Id: I42a84fce9219273a0f422174d5ccdcdec6cf0a38 Reviewed-on: https://chromium-review.googlesource.com/1066737 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#565277}
-
Amy Qiu authored
Move tough_texture_upload_cases into the rendering folder and refactor classes to inherit from RenderingStory Bug: 849392 Change-Id: I50dcebcb563e2c50229884a062feb285c0ec4f8d Reviewed-on: https://chromium-review.googlesource.com/1089453 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/93a962f..a02c34c git log 93a962f..a02c34c --date=short --no-merges --format='%ad %ae %s' 2018-06-07 csharrison@chromium.org Fix ChangeSecurityContext command in DeviceUtils Created with: gclient setdep -r src/third_party/catapult@a02c34c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic22968df1954d0a511d0cfd38d506deec9bc494f Reviewed-on: https://chromium-review.googlesource.com/1090890Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565275}
-
Chris Nardi authored
CSSStyleDeclaration::AnonymousNamedGetter currently calls both GetPropertyCSSValueInternal and GetPropertyValueInternal. However, it really only needs to call GetPropertyValueInternal, since GetPropertyValueInternal calls GetPropertyCSSValue interally if needed. Make AnonymousNamedGetter only call GetPropertyValueInternal to reduce duplicated code. Change-Id: I6c63a1089e3b92d7947cf135512854f48ef7b130 Reviewed-on: https://chromium-review.googlesource.com/1089790Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565274}
-
Nico Weber authored
The comment says it's supposed to be the same as chromium_win_clang_gtests and interactive_ui_tests, but https://chromium-review.googlesource.com/c/chromium/src/+/1076594 added interactive_ui_tests to the clang list, and https://chromium-review.googlesource.com/c/1090818/ removed chromium_win_clang_gtests in favor of just chromium_win_gtests since the test lists have become equal. This adds a bunch of tests to chromium_win_10_fast_ring_gtests that have been added to chromium_win_clang_gtests and chromium_win_gtests after chromium_win_10_fast_ring_gtests was forked. From the comment, it sounds like adding these tests is what we should've done in the first place. (I'm asking around if anyone looks at this bot at all since it's red and it looks like it hasn't been touched in a while. Maybe I'll delete it in a follow-up.) Bug: 843511 Change-Id: I1fdb044c666941eb9beb8df0b50438e5a035f063 Reviewed-on: https://chromium-review.googlesource.com/1090819Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565273}
-
Matt Reynolds authored
In a previous CL, WifiDataProvider implementations for other platforms were modified to retain the wifi polling policy state across restarts of the WifiDataProvider. This CL updates the Chrome OS implementation to also retain this information across provider restarts. Relevant commit: https://chromium.googlesource.com/chromium/src/+/abca656dd0f8e7aa02c21754ddb8581ab9e84b54 When the wifi polling policy state is lost, Chrome fails to correctly apply the initial polling delay the next time the WifiDataProvider is restarted. This can result in excessive use of WLAN hardware and the network geolocation service when the geolocation API is called many times in rapid succession. BUG=828547 Change-Id: Iecad5b7f12f2d8fc72196db9e2108a7d2286d7bd Reviewed-on: https://chromium-review.googlesource.com/1089190Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#565272}
-
Aldo Culquicondor authored
This change reverts back to only sending hover events to a clicked element. This is a step towards pinning behavior. Also, the input handling processing order is now the following: 1. Process all end/leave events. 2. Process all update/move events. 3. Process all begin/enter events. This scheme is more robust when handling several events within a single frame. Bug: 848733 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I2d4da5234a4b60a00849bee4462fd676eccd80b6 Reviewed-on: https://chromium-review.googlesource.com/1082601Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#565271}
-
Kevin McNee authored
This reverts commit b79fbf4d. Reason for revert: CrSettingsLanguagesPageTest.Spellcheck is failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/9083 . Findit identified this CL. Original change's description: > Fixes crbug.com/814318 (spellcheck not functional): > - only disables the "spellcheck" section when spellchecking is disabled > by policy, but not if disabled by the user; > - disables the context menu entry if spellcheck is enforced by policy. > > Bug: 814318 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I26e22bbc945b1cfb89a80a362d1ead1503350e42 > Reviewed-on: https://chromium-review.googlesource.com/1087678 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565253} TBR=avi@chromium.org,stevenjb@chromium.org,macourteau@chromium.org Change-Id: I401ffbe57e1c9157c218c623b6fecce4ca00eee7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814318 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1090950Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565270}
-
