- 14 May, 2020 40 commits
-
-
Esmael El-Moslimany authored
Bug: 1082276 Change-Id: I38408bdf2fde98ae3599b5f10b6001f9fdffb1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199995 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768752}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cac6d369. With Chromium commits locally applied on WPT: 59c99fcd "Clipboard API Tests: Automate Web Platform Tests" 7a588d8c "[client hints] Match update behavior to the spec." 46619c73 "[client hints] Enforce the top-frame requirement." 3c2baf64 "[Client-Hints] Fix cross-origin redirect leak" c15bc63c "[EventTiming] Test more event types" 6640d9f9 "[EventTiming] Wrap lines better in event-timing-test-utils" 200214d5 "[client-hints] Ensure by-default&legacy hints behave with XO redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie2afa59ac11d17f54aa001ac2a448123d647923f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201456Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768751}
-
Michael Thiessen authored
Bug: 1081861 Change-Id: Ife8c169371fafdfb5b4b45de8a4f71e28d600310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197150 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#768750}
-
Matt Menke authored
Also make IsolationInfo mandatory for requests using a profile's main NetworkContext. In the future this will be extended to other APIs that take NIKs (WebSockets, DNS lookups, etc). Bug: 1082280 Change-Id: I630f501cfaf57ea01af8af05c37c9bd79bda20ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180542 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#768749}
-
Lukasz Anforowicz authored
In template specializations template parameters (e.g. |T| or |T2| in MyTemplate in tests/template-specializations-original.cc) get substituted with an actual class (e.g. |SomeClass| or |int|). In an *implicit* specialization, these substitutions are "overlaid" / "overimposed" on top of the template definition and this can lead to generating conflicting replacements - for example the same |t_ptr_field| definition can get replaced with: 1. T* t_ptr_field -> CheckedPtr<T> t_ptr_field // expected 2. T* t_ptr_field -> CheckedPtr<SomeClass> t_ptr_field // undesired After this CL, the FieldDecls in an implicit template specialization (i.e. example2 above) are ignored. This avoids generating a conflicting replacement. Bug: 1069567 Change-Id: I8d2487fdece703421ceb08be67bf6f817e44c03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156068 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff46862e0fb2..f348b224a38d Created with: gclient setdep -r src-internal@f348b224a38d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: amraboelkher@google.com Change-Id: I03a50026df7306a420ff7f48aff3b088972c0815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768747}
-
Allen Bauer authored
Bug: 1044687 Change-Id: I71c5a1e0d01be2c8581327cbc3094c464dea8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200087Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768746}
-
Sylvain Defresne authored
As application extension may share private frameworks with the app they are bundled in, the rpath needs to look both in the extension private frameworks and the app private frameworks. Bug: none Change-Id: I5686d20d8e3f131929ec14caa932bda18bf7d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201096Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#768745}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e2f67443e9c..a0a4480f1261 git log 2e2f67443e9c..a0a4480f1261 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tommi@webrtc.org Migrate CallStats and RtpStreamsSynchronizer timers over to RepeatingTask 2020-05-14 nisse@webrtc.org Reland "Delete unused code to handle posix signals in PhysicalSocketServer" Created with: gclient setdep -r src/third_party/webrtc@a0a4480f1261 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I34a0fb1eb033da314968c0286d11bc9f5d8ba749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201303Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768744}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a9098412b8c..c9ed32549988 git log 3a9098412b8c..c9ed32549988 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 64da65bd1bd5..d748e1651af8 (2 commits) Created with: gclient setdep -r src/third_party/angle@c9ed32549988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@chromium.org Change-Id: I8b55f4f0b5b71aa8ce405024c29f9d81b278f3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200746Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ad44a779e85..493b76784ef1 git log 8ad44a779e85..493b76784ef1 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 wolfi@chromium.org Port Script.js to TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@493b76784ef1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2066579b16021c87ac21c38c18dc436223ca120f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201304Reviewed-by:
-
Tanmoy Mollik authored
As SyncAndServicesSettings page is going to deprecated the google services section in that page is going to be shown in a new page. This cl creates that new class mainly by reusing code from SyncAndServicesSettings and sync_and_services_preferences.xml Screenshot: https://crbug.com/1068229#c2 Bug: 1068229 Change-Id: I75fc368d0273476171202bce31f9c5712bd1d719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193664 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#768741}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I31977e7ddd9a6b12c6f1074987c3c48cce0b3a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201300Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9eaf6cc64b84..effa3ad93640 git log 9eaf6cc64b84..effa3ad93640 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 lalitm@google.com ftrace: update descriptors Created with: gclient setdep -r src/third_party/perfetto@effa3ad93640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8fde85419e4ec732de7118249a4aaa9b1d23c1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201297Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1082670 Change-Id: Ib99e5af1d1c637b3ceb6786c121e430d0620f670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201196Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#768738}
-
Anders Hartvoll Ruud authored
A "dependency" for a given CachedMatchedProperties object is defined as a CSS property, whose computed value must be equal for the cached parent style and the incoming parent style in order for a given cache lookup to be considered a cache hit. This CL makes it possible to add such a list of dependencies to a CachedMatchedProperties object, but doesn't actually use this capability yet (except from unit tests). Bug: 1057072 Change-Id: I37cf3b88b6e09d2503865c5d7d9c2c7b2539d13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193682 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#768737}
-
Natalie Chouinard authored
Fixed this lint issue in https://crrev.com/c/2196833 but missed removing the suppression. Bug: 1081236 Change-Id: I2ff8a372483adf3109cd585619d61a4555c85865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200086 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768736}
-
Peter Wen authored
Remove min_sdk_version and android_manifest_for_lint GN variables. Remove the extra not_needed in internal_rules. It allowed time for downstream projects to remove these args from their gn templates. Commit after webrtc CL is merged into chromium: https://webrtc-review.googlesource.com/c/src/+/174983 Previously, min_sdk_version was used to package our apks and to pass to android lint for linting each java target. We've since migrated to minSdkVersion being specified in our AndroidManifest.xml (thus no longer using the GN min_sdk_version variable for apks). Since then it's only been used for linting each java target. I've migrated lint to only lint for apks and bundles, and so min_sdk_version is only necessary for apks and bundles, not for any other java target. Thus these GN variables are no longer used by non-apk/bundle java targets (GN complains about them being unused). Bug: 1017190 Change-Id: Ia75becae168fdd9151c91b14dc22e0c4ac5ca77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198608 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768735}
-
Nidhi Jaju authored
To optimise the code, this change is made to change ServiceWorkerStorage::StoreUserData to take |user_data| so that we do not need to convert it. Bug: 1055677 Change-Id: I68ed640f2957b0849cb4131d453b5f02490e345b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200479Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768734}
-
sandromaggi authored
This prototype implements the design doc. It allows the fallback handler of Autofill actions to click a base element, wait for a specific option to appear and click it. Bug: b/156238665 Change-Id: I4bc61b1dd6036616e09f21b1375aa883154649c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193580 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#768733}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/457095815d1f..8ad44a779e85 git log 457095815d1f..8ad44a779e85 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 caseq@chromium.org Ignore getResourceTree responses with invalid URLs 2020-05-14 tvanderlippe@chromium.org Update TypeScript to 3.9.2 2020-05-14 tvanderlippe@chromium.org Emit fixes for TypeScript 3.9.2 Created with: gclient setdep -r src/third_party/devtools-frontend/src@8ad44a779e85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:10781354,chromium:1081270 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie94d4ab113ca211fa78cc668fdf2fb38dfb994b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200743Reviewed-by:
-
Jinsuk Kim authored
ContextMenuHelper and ContextMenuPopulator refer to each other. This CL breaks the dependency by the populator having its own native layer to process the tasks. This leaves ContextMenuPopulator free of the reference to Context- MenuPopulator, effectively allowing for the definition of a modularized build target chrome/browser/contextmenu:java. Bug: 952703 Change-Id: I2bdabe167e2c98a1d2fef24eb68af993d3beab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172176 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#768731}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b088a952ee9f..2e2f67443e9c git log b088a952ee9f..2e2f67443e9c --date=short --first-parent --format='%ad %ae %s' 2020-05-14 eshr@google.com Add VideoStreamEncoder tests for DegredationPreference switching. 2020-05-14 danilo.bargen@threema.ch docs: Improve Android testing docs Created with: gclient setdep -r src/third_party/webrtc@2e2f67443e9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b6991fcda8a1078b16ad38a171fb5cc12157c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200744Reviewed-by:
-
Stephen Nusko authored
This allows us to base our determination of jank based on how frequently chrome SHOULD be outputting a frame to smoothly have the scroll happen. We fall back to assuming a 60 FPS device if we don't have these trace events. Change-Id: I41c677860c76cc337add8be5df26008c194d7afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199468 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#768729}
-
Maksim Sisov authored
We used to be using complicated logic how to reroute and process events based on the assumption that it must be the toplevel menu window receiving located events, etc. However, there is an easier way to determine what window should receive the events, etc. 1) Remove unnecessary bits in CanDispatchEvent and return true iff the window has focus. 2) Add Grab/UnGrabEvents methods to WaylandWindowManager - it is going to tell WaylandWindows what window should finally get the event. 3) Fix the DispatchEvent so that: - It reroutes all keyboard events to root parent wayland window. - It reroutes events to the event grabber (and fixes the location of the events as it used to be doing) iff it belongs to the same "family" aka the event grabber and original event dispatcher has the same root parent window. 4) Fix the tests verifying that: - WaylandWindows process the events based on the state of the focus. - The dispatcher honors the event grabber and reroutes the events the same way as it used to be before (PlatformWindowDelegate doesn't see any changes in the logic and continues to operate as it used to operate before). - The event grabber doesn't receive events if they were initially sent to another window that doesn't belong to its family. 5) Do not set implicit capture on mouse press events. Also remove the bits related to that. Bug: 1079221 Change-Id: Iaf2fd175f6ede6779d58863832245dca87178d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187313 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#768728}
-
Wei-Yin Chen (陳威尹) authored
Show single-tab tab switcher in Instant start. Bug: 1065314, 1065902 Change-Id: Id4826695fcb9d160b871c1c1b61fd1a11a02841f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167711 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768727}
-
Maria Kazinova authored
Storing and sending unique IDs in AutofillFormData/AutofillFormFieldData as numeric values leads to hard to catch bugs in ObjectiveC/Javascript communication, thus I'm storing them as strings. Bug: 1075444 Change-Id: If55497fd2a130d6222246be62110cabd7c15c822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199459Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#768726}
-
Anders Hartvoll Ruud authored
This CL adds a small test framework for unit testing the MPC, along with some very basic tests. An special Key constructor which accepts a specific hash value is added to make testing reliable. (Otherwise there might be collisions for tests which add multiple entries to the cache). Bug: 1057072 Change-Id: Ibf8da90997ee8fcb4776c7b39aea0f23ae636a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193681 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d8cb80d7a786..9eaf6cc64b84 git log d8cb80d7a786..9eaf6cc64b84 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 primiano@google.com Merge "Content-type for wasm files in tools/dev_server" Created with: gclient setdep -r src/third_party/perfetto@9eaf6cc64b84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I30d39c3bc5f8a38f4e5c6f6a6a7a933ecb59eaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200741Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/a35ef8a62c..f2bc9d11e8 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/a35ef8a62c..f2bc9d11e8 Bug: None Change-Id: Icdc26614abbf81404391ead6a5918d16f09f2914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199348Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#768723}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7d195b7c991..ff46862e0fb2 Created with: gclient setdep -r src-internal@ff46862e0fb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: amraboelkher@google.com Change-Id: Ie5f4b2b41753e869824bc1d9e202ddb974dd6e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200736Reviewed-by:
-
Mark Pearson authored
when Javascript is blocked by default I.e., for the small fraction of users who block Javascript by default, allow them to enable it easily. No need to explicitly go into settings and type or paste in the hostname to add an exception. Tested interactively. Bug: 1054648 Change-Id: I78976cbc353b7108cca180512a54379056e4b0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174597 Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#768721}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b8584478ddff..457095815d1f git log b8584478ddff..457095815d1f --date=short --first-parent --format='%ad %ae %s' 2020-05-14 pfaffe@chromium.org Libraryize the symbol server 2020-05-14 paulirish@chromium.org Audits: Roll Lighthouse 6.0.0 (7e4fa5587) 2020-05-14 kayce@google.com Add WNDT84 Created with: gclient setdep -r src/third_party/devtools-frontend/src@457095815d1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:772558,chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If439e0b4ccdb8da774e580dfe6a065c04c988256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200739Reviewed-by:
-
Omid Tourzan authored
Used existing flex div rule (button-group) to group button(s) and push them to the other end instead of absolute positioning which causes overlap. There is an opportunity to make it more flexible in case of extreme squeezing of window by css ellipsis but leave it now to get UX confirmation. Bug: 1082539 Change-Id: I6257f077ddaab2c6c83e081d3b186371283fbce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198703 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768719}
-
Alex Chau authored
- Introduced new SharingPreferVapid flag in the tiral Bug: 1044607 Change-Id: I0ee1c7109593db923146ea8c8ca317d20fd9f894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198966Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#768718}
-
David Roger authored
The DiceTabHelper is attached to the tab at the beginning of a signin flow that are started from Chrome UI, and can be used to tell whether a signin flow was started in a given tab. This CL now also tracks the end of the signin flow: as the flow progresses and completes, the DiceTabHelper is notified, and now is able to tell if the sync signin flow is currently in progress. This information is then passed to the DiceWebSigninInterceptor, which uses it to decide if the signin is a sync signin or a web signin. Note that this is slightly approximative, as the user can abort the sync signin and do a web signin in the same tab instead. Since the ProcessDiceDelegateImpl now needs to know about the DiceTabHelper, the code can be simplified: parameters of ProcessDiceDelegateImpl are removed and instead the ProcessDiceDelegateImpl gets the information from the DiceTabHelper directly. Bug: 1076880 Change-Id: I0c91c1404f4198d8759b42577accc6b3b7600168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185050 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#768717}
-
Stepan Khapugin authored
New name better matches style guide. Bug: none Change-Id: I8fdf0bf918cb0f2042acebf47ef01d224fe1dd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193074 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/087cffcba472..f80ec7eedf59 git log 087cffcba472..f80ec7eedf59 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 abennetts@google.com pinpoint-ux: Use a Jinja2 template for the "differences found" message. Created with: gclient setdep -r src/third_party/catapult@f80ec7eedf59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1069331 Tbr: nuskos@google.com Change-Id: I926b32378441dd0e0c231100ff2570398d5726ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200600Reviewed-by:
-
Hsin-Yi Wang authored
Skip test cases that fails on elm/hana for kernelnext as well. BUG=b:156319984 TEST=build binary and run on elm-kernelnext Change-Id: I12b55012d8de481d5c4fe93ce81209ce696e8e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196882Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hsin-Yi Wang <hsinyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768714}
-
Yutaka Hirano authored
Print the QuicTransport handshake failure reason to devtools console. To do that, add |reason| parameter to QuicTransportHandshakeClient.OnHandshakeFailed message. The reason string is captured and passed to the devtools in the browser process and blink::QuicTransport doesn't see the reason string in order to avoid security / privacy problems. Bug: 1069744 Change-Id: I3b6250bda9cfa8ba402d53c033d8ede4616c24d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189716 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#768713}
-
