GitLab

Manifest scope checks are enabled by default in M80, and have baked in
stable for quite a bit. This CL removes the flag and cleans up some
conditional logic.

Change-Id: Ie53f0f4b897169e50ab6502c77ff4019a2216db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055695Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742205}

Continues https://chromium-review.googlesource.com/c/chromium/src/+/2045058

Rebased. Moved code to the new chrome/updater/server/mac/server.mm::LaunchServer, addressed more feedback.

Need to create a plist for the xpc service. It is not clear yet what executatble will be used.

Bug: 1048653
Change-Id: Iadbbd7004afa39fcc902f2ec68297845c2f94571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055284
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742204}

This reverts commit de7cd485.

Reason for revert: Fixing issue with Mac tests.

Original change's description:
> Revert "Make PWA titlebar and icons flex and animate properly."
> 
> This reverts commit 8f2f4243.
> 
> Reason for revert: speculative revert for test failures on Mac
> for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g.
> https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700
> 
> Original change's description:
> > Make PWA titlebar and icons flex and animate properly.
> > 
> > Nested layouts now allocate available space properly to their
> > descendents. Also, we consistently use flex layout in the PWA titlebar.
> > 
> > Removed a couple of invalid assumptions that were encoded as DCHECKs.
> > 
> > There are still some inkdrop issues but they are purely cosmetic, see
> > crbug.com/1006162 for more detail.
> > 
> > Bug: 1048061
> > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264
> > Commit-Queue: Dana Fried <dfried@chromium.org>
> > Reviewed-by: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#738874}
> 
> TBR=pbos@chromium.org,dfried@chromium.org
> 
> Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1048061
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738907}

TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org

Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742203}

This separate protocol is in preparation for moving the find bar
coordinator usage code from BVC to BrowserCoordinator. Once there's a
separate protocol, the BrowserCoordinator can implement it instead of
the BVC.

From this, most of the code here is passing the new protocol through
various levels of command handler.

Bug: 1052818
Change-Id: I0d1d3be56632d21851545a47ffb9e6550729d237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060495
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742202}

This feature is counted when a document which has a scroller with
non-default writing mode (horizontal-rl or vertical-rl) is scrolled
with a positive scroll offset.

This counter will be used to reason about the web-compat impact of
shipping spec compliant scroll offsets (gated behind CSSOMViewScrollCoordinates)


1) The collection has been approved by privacy review
2) The feature is rare as measured by UMA (0.0X% of page loads) and
   satisfies <1% of page views requirement for this counter.

For more info see the intent-to-ship thread:
https://groups.google.com/a/chromium.org/g/blink-dev/c/7X2CKPGeEa0/m/PqICcwwMBgAJ

Bug: 721759

Change-Id: I1a49590e5e92657ca8cdf588d2f57991e569cd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055350Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742201}

Bug: 922145
Change-Id: Ic788d110f4a18bb40eaaa1679aa84db3bd36f027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058925Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742200}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8103c827183..8ef17447d64b


Created with:
  gclient setdep -r src-internal@8ef17447d64b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Iba15352501ad53d474205c849b22ca23cea4d900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061207Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742199}

Now that the WindowsSpellChecker class has been reorganized to not rely
on a base::NoDestructor life cycle, it is now safe to re-create an
instance of it every test. The WindowsSpellChecker unit tests were
working around the base::NoDestructor by having a single TEST_F that
tested all methods. This CL splits that test up into multiple tests.
There are no functional changes to the tests.

#Squeegee

Bug: 1035044
Change-Id: I180f8fa6fedec4470a8f8e77c124bf321ba62e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057245Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#742198}

https://skia.googlesource.com/skia.git/+log/c1bb9cba16be..3c4a9d347da1

git log c1bb9cba16be..3c4a9d347da1 --date=short --first-parent --format='%ad %ae %s'
2020-02-18 benjaminwagner@google.com Run fetch-gn in PRESUBMIT if needed
2020-02-18 benjaminwagner@google.com [infra] Merge SwiftShader into CPU dimensions logic
2020-02-18 scroggo@google.com Enable Windows host build for Skia
2020-02-18 yiyix@chromium.org Update SkSurface::ReplaceBackendTexture to take ContentChangeMode

Created with:
  gclient setdep -r src/third_party/skia@3c4a9d347da1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1014246
Tbr: lovisolo@google.com
Change-Id: I1b5f61cca0441b4af9f77403998d55819e99d114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062468Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742197}

Nil-check the URL before feeding it to the Universal Link API.

Bug: 1051802
Change-Id: I357880d0ffbd512de85c50a461f01fdd8ba238a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062253
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742196}

Based on the latest proposal accumulate the overscroll deltas
and expose the accumulation to the js.

Bug: 907601
Change-Id: I28b154799bfa003ad2e206e0742c5b5ab0a73b43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012807Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742195}

Bug: 1045064
Change-Id: I4c3007cea48f7de00180295884d01ee51fab4b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050729Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742194}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fced1b9a3942..ff5ad47b8295

git log fced1b9a3942..ff5ad47b8295 --date=short --first-parent --format='%ad %ae %s'
2020-02-18 tvanderlippe@chromium.org Remove typedefs from {resources,sdk,search,security}-legacy.js
2020-02-18 tvanderlippe@chromium.org Remove typedefs from {source_frame,sources,text_editor,text_utils}-legacy.js
2020-02-18 tvanderlippe@chromium.org Fix screenshot image_diff for Linux

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@ff5ad47b8295

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1051458
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie334d55c7106f8f0af08a37adcd15a6c2e252229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061205Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742193}

1. Implement quick answers native view which supports rich content and
will be placed outside of context menu.
2. Update quick_answer_model to provide QuickAnswers data to
QuickAnswers View.


Bug: 1020004
Change-Id: Id6ee62352e143559170fe58ba1d928f16187d488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026114Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiao Yang <yanxiao@google.com>
Cr-Commit-Position: refs/heads/master@{#742192}

When a source changes for a MediaElementAudioSourceNode, the number of
channels and sample rate can be the same as the previous source.
However, we were skipping updating |is_origin_tainted_| in this case,
which allowed audio through even though we printed a message that CORS
prevented this.

Now always update |is_origin_tainted_| right away.

Bug: 1050996
Change-Id: I82b596993c7b88dbb899e5aeb00294db57a08613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055989Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742191}

Bug: 1053184
Change-Id: I8d0b01a71104c224fd1642a3e52018517d0c2aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060975
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742190}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I6ecfba0a252957c8efcf8ac902029a8029fc42fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062313Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742189}

Bug: 1048365
Change-Id: Ib47da79c4b74d7576636b50fbbe46c5ab20a7578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058085Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742188}

CIPD packages:
  infra_internal/ios/xcode/mac  11c505wk
  infra_internal/ios/xcode/ios  11c505wk

BUG=None

Change-Id: I8b4f9670e22f259877eb7e99e6c76846628d6eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059056Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742187}

Using wpt-import in Chromium ecbb7fc5.
With Chromium commits locally applied on WPT:
acd8a467 "SharedWorker: Use CSP headers to outside settings"
ec83d167 "Update performance.measureMemory to the latest proposal"
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Idbaa749371e12b11f49335a3b9c01f4c23becea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062092Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742186}

This activity has no visible UI, and is to be used for perf tests
so that performance measurements won't be affected by changes to
WebLayerShellActivity. If we don't do this, we're forced to keep
the shell's top chrome the exact same size forever. See linked bug.

Android WebView also has a TelemetryActivity.

Bug: 1045609
Change-Id: I7aa0443ef93a225ed6b594aba09d4c64158408ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052805Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742185}

The context wasn't check for nil before being used, leading to a series
of crashes.

Fixed: 1050771
Change-Id: I5e6d08df1058f75fbf22240aefd3d60951be3ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059990Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742184}

We need to keep them at least until launch of CompositeAfterPaint

Bug: 1043697
Change-Id: I1126a10c751c130bda175891537f51a75bb2fafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060655Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742183}

BrowserSwitcherPolicyMigrator checks if BrowserSwitcherEnabled is true
before doing anything. This avoids doing unnecessary work. However, the
migrator used to run from ConfigurationPolicyProvider, which only sees
the PolicyBundle from a single provider (rather than the merged
policies).

The issue: if BrowserSwitcherEnabled is set through e.g. platform
policies, then only platform policies will migrate. If it's set through
user cloud, then only user cloud policies will migrate, etc.

Now, the migrators will run from PolicyServiceImpl, after merging the
policies from the different providers. This way, BrowserSwitcherEnabled
is in the same PolicyBundle as the LBS extension's policies, even if
they're configured through a different provider.

Bug: 1030607
Change-Id: Ic681fb02eab391664de7135d8f171a0bca812d3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050806Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742182}

Provides a global public metadata interface for setting metadata on
already-recorded samples in active profiles.

Routes the metadata setting via global functions in sample_metadata.h to
provide consistency with the existing interface for setting metadata.

Bug: 1034758
Change-Id: Ie7677efb976a8a035e9bbcf689abe98ad64cf225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036561
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742181}

TBR=rdevlin.cronin@chromium.org

Bug: 1003661
Change-Id: I1d921dcf979ba9956bce1553c8f3a3bd2235dbf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062353Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742180}

The following histograms expire after M81

Bug: 1037241
Change-Id: I97de132f696e802304e171924aec34b8e91f6603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054272
Commit-Queue: Nazih Almalki <nalmalki@google.com>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742179}

This CL adds -nostdinc++ and -isystem flags that point to the Chromium
libc++ to cflags_objcc.

Before this CL, .mm files would use libc++ headers shipped with clang,
while .cc files would use libc++ headers in buildtools. Since libc++ is
(usually) abi-compat to itself, this (usually) works. We we have
detected this problem because it looks like [1] has introduced an
ABI breaking change [2].

[1] - https://reviews.llvm.org/rGf97936fabd263e3b311e3b8e9ffca4920e4fcff0
[2] - http://lists.llvm.org/pipermail/libcxx-commits/2020-February/007865.html

Bug: 1051010, 400091
Change-Id: Icb49aba558a911369962f085f798a112f80d4273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062355
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742178}

The reporting of metrics has been broken by
https://chromium-review.googlesource.com/c/chromium/src/+/1405508

The SHUTDOWN_IN_FOREGROUND_WITH_MAIN_THREAD_FROZEN will now be reported
only if there is no normal crash report (main thread freeze report should
only be seen as an explanation of crashes without real report).

Bug: 1052377
Change-Id: I1aa17d5061735732324448128a005cea4f9d9ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060499Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742177}

Bug: 1052634
Change-Id: Ibcc0f04b6105a7651309e08cf8433828bf80a715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058695
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742176}

The file:
  services/network/public/mojom/content_security_policy-shared.h
doesn't exist, this was a typo. The correct one is:
  services/network/public/mojom/content_security_policy.mojom-shared.h

Bug: None
Change-Id: I37c611c94f05806bf53293972a9371dfe17a561d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062431
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742175}

This test was accessing browser()->window() after it had
already been destroyed. Instead, have the test expect
that there are no remaining windows.

Bug: 1049284
Change-Id: I14c445e528c267ee48ad769289c17ac7270f0e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057447
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742174}

This reverts commit 3051c63a.

Reason for revert: No longer required by goma

Original change's description:
> Android: Split out a "javac" wrapper from compile_java.py for GOMA
> 
> Bug: 726475
> Change-Id: Ia9068d24655c3cff62faeaf6eec7815fec4fdba5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967792
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735504}

TBR=wnwen@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 726475
Change-Id: I768451be2e5e2609fd9d1623f72e3ec71eb106b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061396
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742173}

This CL creates AllWebStateListObservationRegistrar, which can be used
in any case when an object needs to observe all web state lists for a
given BrowserState.

This is a generalized version of the snapshot cache tab model observer,
which this replaces.

For cases where only regular or OTR browsers' WebStateLists should be
observed, AllWebStateListObservationRegistrar has an optional param that
can be set at creation time.

To avoid circular dependencies, one target in web_state_list/ had to
be split from the main target (hence the scattershot BUILD.gn updates).

Change-Id: Ic3977b709d5b089ebf31afd0fa868067833f2249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997306
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742172}

I moved team.

No code change.

Change-Id: I84dd0f3f40f44c7e1cbf9d4516e78d3490f81f0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062291
Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742171}

Bug: b/144075373
Change-Id: I559fb7bd9ad4273e3360604c24c230ce5edc0ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043799
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#742170}

https://skia.googlesource.com/skia.git/+log/78b471760dd9..c1bb9cba16be

git log 78b471760dd9..c1bb9cba16be --date=short --first-parent --format='%ad %ae %s'
2020-02-18 robertphillips@google.com Revert "Manage renderCmdEncoder over lifetime of GrMtlOpsRenderPass."

Created with:
  gclient setdep -r src/third_party/skia@c1bb9cba16be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: lovisolo@google.com
Change-Id: Iecc8baf602bbe90f162ec784b843ad91de4dde16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062309Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742169}

https://swiftshader.googlesource.com/SwiftShader.git/+log/0bbf7ba9f909..2883de942283

git log 0bbf7ba9f909..2883de942283 --date=short --first-parent --format='%ad %ae %s'
2020-02-18 capn@google.com Fix sRGB conversion precision issues

Created with:
  gclient setdep -r src/third_party/swiftshader@2883de942283

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Icf119c6bfe89903416c90e08c8ff473afac2febe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062308Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742168}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/389d9af998f3..1c25d4b5c206

git log 389d9af998f3..1c25d4b5c206 --date=short --first-parent --format='%ad %ae %s'
2020-02-18 ahassani@chromium.org xbuddy: Fix delta_payload artifact
2020-02-18 ahassani@chromium.org nebraska_wrapper: Fix health_check request to nebraska
2020-02-17 achuith@chromium.org vm: Add mocks for system attributes.

Created with:
  gclient setdep -r src/third_party/chromite@1c25d4b5c206

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I05987c5ca5d9d9918860cd642f8300ba87c2ddae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742167}

Also hand over ownership from treib@ to vasilii@

Bug: 1053095
Change-Id: I5511d845c7ac18c400b7f7791e43889777adb7b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061811Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742166}