- 05 Mar, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b56862dc292a..dd98a9a1520a Created with: gclient setdep -r src-internal@dd98a9a1520a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:925042,chromium:932622 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Iabe7ad3305157b55cf2b8cc002c3330328e1f1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503941Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637894}
-
dstockwell authored
This is a contingency for the event that the annotation feature is enabled but form saving is not. * A new field hasUnsavedChanges is added to the save result, this is set when there are edits but form saving is not enabled. * When this field is true, a dialog is shown to the user allowing a choice whether to continue to enter annotation mode or not. * The annotation toggle event is made custom to avoid re-entrancy when entering anntation mode is aborted. Bug: 902646 Change-Id: I885aa9ee76afb500a086097aed08422ececdf052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502255Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637893}
-
Sajjad Mirza authored
The script now assumes GN adds coverage flags to the cflags for each source file. The script removes the flag if the file is in an exclusion list, or if `--files-to-instrument` is set it will also remove flags if the file is not listed in that argument. The script supports multiple exclusion lists that can be selected with the `--target-os` flag. It's expected that GN will set these flags correctly and invoke the script in all coverage builds. http://crrev.com/c/1496002 does that. Bug: 918215 Change-Id: I4454f67067a083581f31a22cfef85368825789f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994 Commit-Queue: Sajjad Mirza <sajjadm@google.com> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637892}
-
danakj authored
Previously the input was physical pixels, so it scaled to DIP when not using zoom-for-dsf. Now the input is DIP, so we must scale the other way. R=piman@chromium.org Bug: 937602 Change-Id: If51e092ffe6e4e7e72da24315f6cc70b2330022a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504224Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637891}
-
Takuto Ikuta authored
I think we don't need this copy here introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1413214 Also this copy caused unnecessary build dependency serialization. Bug: 937723 Change-Id: Ifa0e8466e83fbfe2278b880cb465b025fd22137e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498800Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#637890}
-
Veranika Liaukevich authored
Bug: 724491 Change-Id: I48c5e81f81a20a34974287cfbb67890f355db7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497333Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Auto-Submit: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#637889}
-
Reid Kleckner authored
CrWinASanCov tests an old configuration, and ToTWinASanLibfuzzer is the new configuration. Move it into the "Windows|ASan" category in place of CrWinASanCov. Also add ToTWinASanLibfuzzer to the luci.chromium.clang console. It seems they are supposed to be in sync. R=bpastene@chromium.org, hans@chromium.org, hinoka@chromium.org NOTRY=True Bug: 937465 Change-Id: Ib5d1389bb5dc06d85bdbae522603c42a4acf2d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497356 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#637888}
-
Matt Menke authored
All StreamSocket layers are now beneath the socket pools, so there's no longer any reason for any of them to be on top of ClientSocketHandles instead of other SocketStreams. Bug: 472729 Change-Id: I1b0471c421181eee2c28388bc1b705011d0d3dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495596Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637887}
-
Ayu Ishii authored
Replace deprecated RunLoop::QuitCurrentWhenIdleClosureDeprecated() for CloudPrintURLFetcher Unittest This change replaces base::RunLoop::QuitCurrentWhenIdleClosureDeprecated() call with a call to loop.QuitWhenIdleClosure() call on a local RunLoop instance. Bug: 922118 Change-Id: I44a545bde69b4558f97a29c0eeaafffdcae9420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497177Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#637886}
-
Christian Biesinger authored
ComputePercentageLogicalHeight has the side-effect of calling AddPercentHeightDescendant on the containing block; that is not great when we just want to check if a size is definite, from MainSizeIsDefiniteForPercentageResolution. Add a parameter to make it optional. Also change CrossAxisSizeIsDefinite over to this function. Here, we do not have to worry about AddPercentHeightDescendant because we will later resolve that size through normal mechanisms anyway. Bug: 933931 Change-Id: Id44d15eb546c15bbdece99282550419eb0f8654e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492294 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#637885}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ca31f8de281..e6752606a395 git log 2ca31f8de281..e6752606a395 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 halcanary@google.com SkQP: from skqp_gn_args import SkqpGnArgs 2019-03-05 kjlubick@google.com [particles] Clean up build - remove test deps 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b8cff9e9347c..55959b0bb19f (3 commits) 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 7efede6c3d35..10736f2da359 (2 commits) 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-05 reed@google.com array of unique verts 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b7157d764389..7efede6c3d35 (1 commits) 2019-03-05 robertphillips@google.com Make SkImage_Base::asTextureProxyRef take a GrRecordingContext parameter 2019-03-05 bsalomon@google.com Distinguish between "flushed" and "finished" idle state callbacks on GrTexture. 2019-03-05 robertphillips@google.com Clean up logic in fontregen GM Created with: gclient setdep -r src/third_party/skia@e6752606a395 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I6f61b5ec6def7cde12d3794a41137b3fec17eb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637884}
-
Johann authored
arm_cpudetect.c is not included automatically. BUG=aomedia:2294 Change-Id: Ia3cd70d050faed3ed88f94bb2b0f1e9eaf746a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502453Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#637883}
-
Yuchen Liu authored
This an effort to support per frame encryption pattern. 1. Remove EncryptionScheme from mp2t. 2. Only ready EncryptionMode from CAT. The actual pattern is set in ES parser. Bug: 825041 Test: HLS stream, see per frame encryption pattern from log. Change-Id: I6767937fd3ffd805c082852166b9fc7842ad2911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501334Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637882}
-
Becky Zhou authored
A small fix from CL https://chromium-review.googlesource.com/c/chromium/src/+/1489416 Bug: 934525 Change-Id: Ied35119645b543678562248e2f4d533767b2ce41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504296Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637881}
-
Wenzhao Zang authored
Bug: 888733 Change-Id: I2b847b2a37f666a688336036f02ea08111f5f525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496523Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637880}
-
Kaustubha Govind authored
Reuse ByteString/ByteBuilder APIs for CT parsing and serialization. Added boolean return arguments to EncodeTreeHeadSignature and EncodeSignedCertificateTimestamp, and updated a couple of clients to check return value and handle failure cases as appropriate. Bug: 634570 Change-Id: Id309470e18d0bc7316623c2f5dd7aaf3854527cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1465984 Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#637879}
-
rbpotter authored
These tests have now been moved and/or broken up into tests for the elements actually responsible for the behaviors tested, with the exception of presets and visiblity tests, which are validating the behavior of print-preview-app itself. Move these tests into the print_preview_app_test.js. Trim down PresetCopies and PresetDuplex to test only behavior not already tested in other places, and combine these two tests into one since they are both testing the same event handler. Change-Id: I1167776f437f60f7bd82c3407206331db84de86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501999 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637878}
-
Pavol Marko authored
Clarify in a comment why the source is listed explicitly so future readers are not tempted to remove it. Bug: 933359 Test: none Change-Id: I7f7b70bbe90853674e17c9a5b7ab5cc2016b2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478877Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#637877}
-
Takuto Ikuta authored
To fix following builders: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20cl.exe%20Goma%20Latest%20Client%20LocalOutputCache https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WinMSVC64%20Goma%20Latest%20Client Change-Id: Ic6acb7b8a123165dcda0fc98d3c07c55bd7de38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498746 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Joshua Peraza authored
The original name can easily be mistaken to imply the method only applies to WebView, when it actually applies to all Android. Use base::RandInt() to ensure a properly seeded generator is used. Bug: 923475 Change-Id: I54a4165dca1cd723f304b16a95746adb08613d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503622Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#637875}
-
rbpotter authored
Moving policy tests to new model_settings_policy_test.js, similar to what was done with the availability tests, since almost all the logic tested is in model.js. Also adding 2 small tests verifying that the corresponding settings sections disable their controls when the setting is set by policy. Change-Id: Ife0563e517a002ddd29a3fa62031fcd7ec47136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501948 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Christian Fremerey authored
This is a reland of 86e7aa88 Revert was due to flaky test failures on MacOS 10.12. The flakiness already existed before this CL. The flaky test has been disabled. https://chromium-review.googlesource.com/c/chromium/src/+/1501213 This reland is identical to the original attempt. TBR=emircan@chromium.org, meacer@chromium.org Original change's description: > [Video Capture] Switch usage in Chromium Browser process to the new multi-client API > > The video capture service offers a new API for opening capture devices > in a way that allows them to be shared by multiple clients. This CL > switches one such client, i.e. the Chromium Browser process, over to > that new API. This enables other clients to share access to capture > devices with the Chromium Browser process. > > Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing > > Test: content_browsertests --gtest_filter=WebRtcVideoCaptureSharedDeviceBrowserTest.* > Bug: 783442 > Change-Id: I9c236f03e315cdafdc07429f3213fa4d11b43b34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1399454 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637405} Bug: 783442 Change-Id: I7dca38334bc78e400daa311fa0444173add9548d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504230 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637873}
-
Avi Drissman authored
BUG=936080 Change-Id: Ic1b64913d0594841e7edb521aa0502235e1171fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498615 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637872}
-
Xiaocheng Hu authored
This patch changes all VisiblePositionInFlatTree-typed local variables into PositionInFlatTreeWithAffinity as a preparation to remove unnecessary canonicalizations from SelectionController. Bug: 657237 Change-Id: Ic5603a8fd090d3337c1eb58487e1a6ad1809ae6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501035Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637871}
-
Xiaocheng Hu authored
Flake (https://analysis.chromium.org/p/chromium/flake-portal/flakes) found the 4 web tests as flaky and may fail in all types (fail, timeout, crash). Hence, this patch marks them so. Bug: 894651 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: I8dca99fef9c6babd173631259febe3b7af48c688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503942Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637870}
-
Toni Barzic authored
Changes EULA screen to report exit status using a callback rather than invoking BaseScreen::Finish (which calls BaseScreenDelegate). Encodes whether metrics reporting was enabled into the ACCEPTED exit code, and moves logic to track the last selected usage stats reporting checkbox from WizardController to global variable in eula_screen. This eliminates a need for EulaScreen::Delegate (which WizardScreen was implementing). Affected screens: SCREEN_OOBE_EULA Affected exit codes: EULA_ACCEPTED EULA_BACK BUG=930267 Change-Id: I6a706c8033ad46e876ee06470868ef1630ae8b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498507Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#637869}
-
Alexei Filippov authored
Change-Id: I9db43e0082628297ac8320c6eb34a763c8bb0996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497302 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637868}
-
Xianzhu Wang authored
In BlinkGenPropertyTree (non-CompositeAfterPaint) mode, existence of composited layers is determined by compositing-update-before-paint, so PaintArtifactCompositor should not skip any layer. The bug case is that we skipped a layer containing an animation, causing CompositorAnimations to fall back to main thread animation after fail to find the composited animation by the element id. Bug: 931688 Change-Id: I121c935d2b417058047ccd8967761e28452e5a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497761Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637867}
-
Raymond Toy authored
When requesting to delete handlers on the main thread, we exit early if |rendering_orphan_handlers_| is empty. However, |DeleteHandlersOnMainThread| will also process |finished_tail_processing_handlers_|, so we're not processing them in some cases. Thus, do an early exit only if both |rendering_orphan_handlers_| and |finished_tail_processing_handlers_| are empty. Otherwise, there are things that need to be deleted but aren't. Change-Id: If4515a42253dc87aca25c009fccea69b243a06ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503998 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637866}
-
Ben Pastene authored
Bug: 936957 Change-Id: Id6ab4c33c299aeecf03894124f1d15c2d95d7d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504257Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Maggie Cai authored
Currently in site details page, the focus will be lost after closing the confirming dialog for clear data and reset settings. This CL fixes this issue. BUG=924943,835712 Change-Id: Ia83234f49a25fca0672f3fbe503e620d1002eead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496402Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637864}
-
Ben Pastene authored
It broke again after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1501474 This should make it immune to future relands + reverts of the same change. Bug: 926987, 938211 Change-Id: I99654cc71b1c8a83fdd29defc20b1e35cddb3fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504039Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#637863}
-
Nicolas authored
Also, migrate the BrowserSwitcherEnabled policy in the other direction, as "browser_switcher_enabled". This CL refactors ChromeExtensionPolicyMigrator to make it easier to transform values (e.g. convert types) as they are being migrated. Bug: 909880 Change-Id: I0d49bd9296a096da713a2d6cface9eab724b29d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500203 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
-
Anthony Vallee-Dubois authored
This resets the backoff state in order to re-run the experiment in India Bug: 936028 Change-Id: Id55c80ce6ff3d4b4c824a4c1833a5f5d3c03d202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504129Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#637861}
-
siashah authored
Change the title from "Update expiration date" to "Enter expiration date" Demo: https://screenshot.googleplex.com/N5Lzem5GFFV Bug: 926316 Change-Id: I4ded120187dd31478e19e35f56807e0a97fb2f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504215Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#637860}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Also convert IOSPaymentInstrumentLauncher (and its unit tests) to use the new base::Value API instead of the deprecated one. Bug: 925165, 646113 Change-Id: I74ddfbb9a0752967ead0b73ebe2ce3f06a96d225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503373 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637859}
-
Sammie Quon authored
This is consistently failing. I will try finding a proper owners to diagnose why it is failing but in the meantime disabling to get the bots green. Test: none Bug: 938575 Change-Id: Ib3867bb01c67776ccd5b6aa0db082d485157c759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504252Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#637858}
-
rbpotter authored
Moving: SetLayout/SetMargins/SetPagesPerSheet/SetColor => *_settings_test:'select option' Moving: DisableMarginsByPagesPerSheet => margins_settings_test: 'disabled by pages per sheet' Adding some 'set setting' tests (all are almost identical) validating that setting the setting updates the UI. Also fixing some small issues found due to new individual section tests running on debug builds: - Missing includes - Margins settings -> use an (already existing) enum, not hardcoded values. Change-Id: Ia29beafdfcb66634a33279c2c98fe08f9cea9084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501793Reviewed-by:
-
Jordan Taylor authored
web_tests/animations/animationworklet/scroll-timeline-overflow-hidden.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-overflow-hidden.https.html web_tests/animations/animationworklet/scroll-timeline-overflow-hidden-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-overflow-hidden-ref.html web_tests/animations/animationworklet/scroll-timeline-root-scroller.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-root-scroller.https.html web_tests/animations/animationworklet/scroll-timeline-root-scroller-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-root-scroller-ref.html Bug: 915352 Change-Id: Ia48d26bb3a61e773d6e85a637f53790b568343ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490216Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#637856}
-
Tomasz Wiszkowski authored
This change ensures that currency conversion answers are shortened to offer just final result, eg. instead of: 1,000 United State Dollar = 1,330.75 Canadian Dollar 1000 usd to cad this will show: 1,330.75 Canadian Dollar 1000 usd to cad Bug: 936730 Change-Id: I1222c5fba17e6cca07947e37bc2494f89abec98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500915Reviewed-by:
-
