- 20 Aug, 2019 40 commits
-
-
James Forshaw authored
This CL removes the old renderer appcontainer flag from about:flags. It also removes the old command line switch to enable or disable, instead replacing it with a feature. This feature is disabled by default but the expectation is to enable by default in the next milestone. Bug: 501975 Change-Id: If9b7425624d60243e998958d31e53d5607a3424e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761471Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688552}
-
Robert Ogden authored
Bug: 971918 Change-Id: Icb952b211e066f7c70f283f6156ed4e279b4013b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738676Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#688551}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I05ccc92ea5ccdd70e10ae916cb826bb554ed3eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762233 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#688550}
-
Brian White authored
Updates the expires_after attribute for 316 histograms that show frequent access in the past 90 days. These are the 60% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-02-16. Change-Id: Id9e82848066a4df330e9e185c020bd0916e0c39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762307 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#688549}
-
Alex Chau authored
- Propagate various HTTP error code as SendWebPushMessageResult - Remove device from preference for SendWebPushMessageResult::kDeviceGone - Surface subset of SendWebPushMessageResult as SendMessageResult to UI classes - Actual UI update will be done separately Bug: 966022 Change-Id: Ide932198221fdd854a844a08a32811634179e730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751209 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688548}
-
Niels Möller authored
To enable removal of most default implementations in PeerConnectInterface, see https://webrtc-review.googlesource.com/c/src/+/140860 Bug: webrtc:10716 Change-Id: Ic0480552678fbc5935864b5d36dafecd0e6c2490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753928Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#688547}
-
Nico Weber authored
- The CLs created by this script are mininmal and none of the changes done by the script affect presubmits. - It's a tiny bit faster. - It allows running the script in a checkout that didn't run `gclient sync`; as-is a presubmit tries to read build/config/gclient_args.gni which doesn't exist then. TBR=hans Bug: none Change-Id: I5801810e9f04f3436e84230cd6559f68b0a77451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758910Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#688546}
-
Tricia Crichton authored
Changed test code to use 'browserVersion' instead of 'version' as key to retrieve and compare Chrome versions. Bug: chromedriver:3015 Change-Id: I8f4dc5a26e433f2d0e2adc4f0f088e5d8d7f0316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761474Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#688545}
-
Tricia Crichton authored
This test creates 2 Chrome instances, which is not supported on Android. The functionality is sufficiently tested by desktop tests, so the test was added to the Android negative filter. Change-Id: I5fdcae8e50d6be27ab020d2337daa3f5e35bfca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761611Reviewed-by:
-
Elly Fong-Jones authored
This directory was renamed which broke the old suppressions. TBR=marinaciocea@chromium.org Bug: 783800 Change-Id: Id7ea5283357bca9c277f2cd454b9aae1316b3a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757362Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688543}
-
Konrad Hofbauer authored
Bug: 951299 Change-Id: I5b27fa435bd8c81c1e3a76967a870ee3495f5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762080 Auto-Submit: Konrad Hofbauer <hofbauer@chromium.org> Reviewed-by:
-
Vladislav Kuzkokov authored
Make |PrintingContext::settings_| null before settings are created or after ownership is passed to PrinterQuery. Bug: 964948 Change-Id: I0cff0b5b460ecb3424ff0cb07e5849bed3ffe51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678182Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#688541}
-
Rouslan Solomakhin authored
Before this patch, HasEnrolledInstrumentQueryQuotaTest.QueryQuota would fail or succeed depending on whether per-method quota flag was enabled in the test environment. This patch breaks up the QueryQuota test into several tests, each one explicitly setting the "strict autofill data check" and "per method quota" flags at the start to best replicate all possible execution environments. After this patch, HasEnrolledInstrumentQueryQuotaTest passes in all test environments. Bug: 995728 Change-Id: I1c6812b5ae8b464c7f121bc0ce2ca0fcc5258503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760881 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688540}
-
Yaron Friedman authored
These files don't see much change but we haven't worked on it in a while. Reviews should be handled by sync team. Change-Id: I34bfe50795e65ac1ce87f74eea26c8f42b5b9011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758301 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#688539}
-
Javier Ernesto Flores Robles authored
Screenshot: https://drive.google.com/file/d/1crTpGA9Isl6O4L9I2zPcCqu18fqzpLv6/view?usp=sharing Bug: 976675 Change-Id: Id795ea1896507d3b1e5bbbd5cd84f083e2c0df42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762213 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#688538}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5288d5c6c2d9..b88012e339bf Created with: gclient setdep -r src-internal@b88012e339bf The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9b5f332acad845d83dc1b81fa52f2e595dd400c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762267Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688537}
-
John Delaney authored
This CL implements the per top-frame origin throttling for the heavy ad intervention. Because this intervention leaks some amount of information cross-site, we need to only allow a certain number of triggers per-day so that this intervention does not create an abusable side channel attack. Metrics show that a per-origin per-day cap of 5 interventions covers 90% of heavy ad cases. This CL re-introduces a similar framework used by PageLoadCapping and makes use of the blacklist component to handle the persistent storage to memory. The blocklist is gated behind a different feature than the heavy ad intervention to maintain that field trials are only activated for heavy ads when a user has seen a heavy ad. Change-Id: Iee38eaa3064f37b1b5a7258a31221527345d4b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645142 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#688536}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ida5a058fa81bc1c4ca8a0c40a80cd13e7e9fa5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700906Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688535}
-
Umesh Patil authored
Bug: b/139693028 Change-Id: Ic9c135ce012cdf7b85d81f23824ee6e12ca15553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761648Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Umesh Patil <upatil@google.com> Cr-Commit-Position: refs/heads/master@{#688534}
-
James Cook authored
Make the first row of the People section not clickable when the account manager is disabled (e.g. via flags or Finch). Bug: 950007 Test: added to browser_tests Change-Id: Ib9720f55fb60b526afe3ae40566678f603423320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760463Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#688533}
-
Yann Dago authored
Bug: 995251 Change-Id: I2c268a4def6e1ef8a13bd661b15bc96fe63bde29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761148Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#688532}
-
Henrik Boström authored
This was reported as flaky. I am unable to reproduce, which could mean that the issue is fixed, or it could mean that it only flakes on certain setups (OS, builds, hardware, etc). To aid investigation I am speculatively re-enabling it; worst case it gets disabled again. Bug: 754684 Change-Id: I866679464fce4facde927652751046e062ca1c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761602Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688531}
-
Javier Ernesto Flores Robles authored
Replace brand image and logo with versions containing alpha. Remove unused 1x image. Add dark mode to brand image. This requires to be compiled with Xcode 11 (iOS SDK 13). Bug: 976640 Change-Id: Id19d571d8e6fd85ad616329616c0eb3319867164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713538Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#688530}
-
Henrik Boström authored
This was reported as flaky. I am unable to reproduce, which could mean that the issue is fixed, or it could mean that it only flakes on certain setups (OS, builds, hardware, etc). To aid investigation I am speculatively re-enabling it; worst case it gets disabled again. Bug: 993020 Change-Id: I31920b14d1ec02b8cc0eaeb86d93caa8c6226d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762075Reviewed-by:
-
Saman Sami authored
This will help us compare Skia's readback to GLRendererCopier during the finch trial. Bug: 898595 Change-Id: I94abef58951662480a6e5573fad616bf8724b863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652200Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688528}
-
Alexander Hendrich authored
This CL updates the config dir policy loader to also apply the loaded extension policy to login screen extensions. Bug: 928334 Change-Id: If16447393f05f9d9fb78e885eaa50478d4d342ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728587 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#688527}
-
Peng Huang authored
Bug: 995343 Change-Id: Id9638c41db2c208ba8f12fa0a8d90610aae574f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761062Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#688526}
-
Elly Fong-Jones authored
It is not just flaky on Mac. TBR=marinaciocea@chromium.org Bug: 988248 Change-Id: Iad51b21d0f85900f2fd0fabe3da1f21a6ea21862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761145Reviewed-by:
-
Javier Ernesto Flores Robles authored
Sets the tint color of the cell so when the accessory view is created it is tinted with the right color. Sets the tint color of the table view to blue so the index uses it. Screenshots: https://drive.google.com/file/d/1xfOJVT6ZqqOiSb_pEX_uWqeLeEcxpc2F/view?usp=sharing https://drive.google.com/file/d/1-HwGeIh1d-vk3fSDfsLVxWTm0y64kRfG/view?usp=sharing Bug: 976675 Change-Id: I3f1b4990060a1db29eb119c271d3402c8e1706b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749010 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Ken Buchanan authored
Change the expiry for the flag to turn on BLE support for Web Authentication to M-82, to prevent its removal from chrome://flags. Change-Id: I8c50aeded7a28aea2af4dbbd3460757e59767ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762268 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#688523}
-
Takuto Ikuta authored
Owners file generation took more than 25% of full build times in CQ. Let me enable that only in fuzzing engine build. Bug: 995151 Change-Id: I4f490ef946ddeb729991cafbf21dd21bb5059920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761889 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688522}
-
Connie Wan authored
This was left hanging here: https://chromium-review.googlesource.com/c/chromium/src/+/1717271/7/chrome/browser/ui/views/tabs/tab_strip_layout_helper.cc Bug: 966627 Change-Id: I162ee3a5e0f575fd3b180befbf296b7335f1cdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761290Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#688521}
-
Finnur Thorarinsson authored
Bug: 989210, 860467 Change-Id: I9b4d498d585a67c13175cbaec186fef0959a3dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762077 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688520}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/facebook/fishhook.git/+log/d172d5247aa5..80fe593736ac $ git log d172d5247..80fe59373 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 facebook-github-bot OSS Automated Fix: Addition of Contributing (#58) 2019-03-27 facebook-github-bot OSS Automated Fix: Addition of Code of Conduct (#59) 2018-04-02 jmarg Prevent nullptr derefence on failed allocation 2018-03-31 jmarg Replace #import with #include to compile on VisualStudio 2018-03-31 jmarg Save 2ms at app startup by inlining strlen (from @swolchok) 2018-02-03 rosen0510 fix memory leak in rebind_symbols_image (#49) 2017-03-03 dair Add explicit casts from void*. 2016-08-01 davelee.com Make fishhook symbols hidden by default (#29) 2016-04-25 davelee.com Move symol length check out of rebinding loop (#27) 2016-04-02 ocrickard Improve performance of perform_rebinding_with_section Created with: roll-dep src/ios/third_party/fishhook/src Bug: 992021 Change-Id: Ia8c72aaa1a1b23d629ed2956e24910b9e1c8951e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758432Reviewed-by:
-
Xida Chen authored
Some functions in this class calls APIs in cc::TransformOperations, which all take floats. But those functions provide doubles, and that causes float-cast overflow. This CL solves the problem by using SkDoubleToMScalar, and layout tests are added. Bug: 995038 Change-Id: Ic1b73c31d6090f38c7c6f342d9e953c58567604c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761733 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688518}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9781db33..5c6b118c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14fb9279a90260b571b58ce3736068d9276e9ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688517}
-
Oleh Lamzin authored
Document that for the Custom setting of DeviceBatteryChargeMode, the Start value must be at least five percentage points below the Stop value. BUG=b:138795980 TEST=none Change-Id: Ie9580bab609598dba10bec916a3867d6ab33ed9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761595Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#688516}
-
gogerald authored
The tabs are ordered from the most recent to the least recent ones in the tab grid and carousel in start surfaces. Bug: 982018 Change-Id: I974c492555751c5f2d7eebe8c6d871d05a41fb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746907Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#688515}
-
Jeremy Roman authored
Changed NULL to nullptr where the presubmit complained (due to new line wrapping). Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Tbr: gab@chromium.org Change-Id: I9c7ea90816e2a2418981108f657bc52cee8c06ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703541 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688514}
-
Xida Chen authored
Currently in this function, we apply a roundf on a double value. We should never do a roundf on a double value, it should just be round. Bug: 994800 Change-Id: I6208d9db51661b2587ba54f949b9945ec47dcf3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761690 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
