GitLab

This is just moving:
https://codereview.chromium.org/2800813006/

TEST=No change in behavior.
BUG=708453

Review-Url: https://codereview.chromium.org/2813403002
Cr-Commit-Position: refs/heads/master@{#464346}

core/html/forms/OWNERS should be responsible for these files.
This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2815263002
Cr-Commit-Position: refs/heads/master@{#464345}

{EventHandler,MouseEventManager} is storing a {clicked,tapped} node as Node*,
instead of Element*, that would be a bad practice. Actually, that has been the
cause of several wrong behaviors in Blink, such as:

1. Blink does NOT fire a click event when a clicked text node has been removed
   in mouseup.  This is wrong because a click event should be fired on an
   element node.  See [1] for details. This bug was just tentatively fixed at
   another CL [2].

2. Blink DOES fire a touch event on a non-element node.  This is wrong because
   TouchEvent specification says all kinds of touch events' event target types
  are limited to Document and Element [3].

To prevent these wrong behaviors, this CL does:
- Have EventHandlingUtil::ParentElementIfNeeded and use it everywhere so that
  we surely adjust a node to the appropriate element, at which an event should be
  fired.
- Replaces the usage of Node* to Element* as much as possible so that it rejects
  the wrong code at type level check.

- [1]: topmost event target;
  https://www.w3.org/TR/uievents/#topmost-event-target
- [2] https://codereview.chromium.org/2812613004
- [3]: Trusted proximal event target types are: Document and Element;
  https://w3c.github.io/touch-events/#list-of-touchevent-types

BUG=708394,710425

Review-Url: https://codereview.chromium.org/2807123002
Cr-Commit-Position: refs/heads/master@{#464344}

This is essentially the result of the following shell command followed by
git cl format:

    find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \;

DEPS is added in order to prevent further introduction of "wtf/".

BUG=691465
R=japhet@chromium.org

Review-Url: https://codereview.chromium.org/2818613003
Cr-Commit-Position: refs/heads/master@{#464343}

And rename files
gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.{cc,h} =>
gpu/ipc/client/gpu_memory_buffer_impl_native_pixmap.{cc,h}

Turn on GpuMemoryBufferImplNativePixmap on OS_LINUX instead of only USE_ZONE.

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
TBR=kbr@chromium.org, piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2710223002
Cr-Commit-Position: refs/heads/master@{#464342}

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814853002
Cr-Commit-Position: refs/heads/master@{#464341}

This CL adds and changes some files in ui/file_manager to build ZIP archiver.
We are going to add ZIP archiver to the list of component extensions
in another CL, so ZIP archiver still won't show up in the context
menu with this patch.

BUG=607078
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2808993003
Cr-Commit-Position: refs/heads/master@{#464309}
Committed: https://chromium.googlesource.com/chromium/src/+/77065d9816b34a5cc7913894b8b756e7c3e6fb79

patch from issue 2808993003 at patchset 80001 (http://crrev.com/2808993003#ps80001)

Review-Url: https://codereview.chromium.org/2814313003
Cr-Commit-Position: refs/heads/master@{#464340}

Revert of Expand Mash Browser Test Coverage (patchset #11 id:220001 of https://codereview.chromium.org/2786583003/ )

Reason for revert:
Some tests are very flaky on ozone try bot.

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng?numbuilds=200

Original issue's description:
> Based on running of the tests locally, along with on the trybots, the filter for mash_browser_tests have been updated with more tests
>
> TEST=mash_browser_tests
> BUG=678687
>
> Review-Url: https://codereview.chromium.org/2786583003
> Cr-Commit-Position: refs/heads/master@{#464015}
> Committed: https://chromium.googlesource.com/chromium/src/+/0190af327299091a9bdd376da2093cd48fe1f993

TBR=sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678687

Review-Url: https://codereview.chromium.org/2820483002
Cr-Commit-Position: refs/heads/master@{#464339}

This CL removes a cross thread malloc/free pair from simple disk cache backend.

After a PostTaskAndReply change in http://crrev.com/e5de8d551e80115b, it
destroys |task| part of the given tasks on the target thread, and that
introduced a number of cross thread malloc/free pairs around net::IOBuffer.
The cross thread malloc/free pair increased the apparent size of memory
usage on some Android perf bots by 2~3%, that is likely due to thread
specific free list caches.

BUG=708644

Review-Url: https://codereview.chromium.org/2815563002
Cr-Commit-Position: refs/heads/master@{#464338}

Revert of Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (patchset #17 id:320001 of https://codereview.chromium.org/2773593005/ )

Reason for revert:
Likely cause of webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4).

BUG=711190

Original issue's description:
> Move logic of recording main thread scrolling reasons from cc to
> blink::ScrollManager
>
> Due to crbug.com/701355, all style related main thread scrolling reasons
> stop being recorded. This patch moves the logic of storing the style
> related reasons to PLSA and move the recording logic to ScrollManager
> because the information on the compositor side is insufficient. The
> disabled test due to the previous bug has been enabled again with minor
> modification.
>
> BUG=704805
> TEST=All/NonCompositedMainThreadScrollingReasonTest.*;
> EventHandlerTest.NonCompositedMainThreadScrollingReason*
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2773593005
> Cr-Commit-Position: refs/heads/master@{#464073}
> Committed: https://chromium.googlesource.com/chromium/src/+/76d0929033d6cd3ec36b96d1b4845166e70c9349

TBR=flackr@chromium.org,ajuma@chromium.org,bokan@chromium.org,tdresser@chromium.org,jwd@chromium.org,yigu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704805

Review-Url: https://codereview.chromium.org/2816973002
Cr-Commit-Position: refs/heads/master@{#464337}

To remove circular deps between file_table and file_table_list,
- Moved filelist namespace from file_table to file_table_list.
- Use observer pattern instead of calling
|updateHighPriorityRange| in FileTable from FileTableList.

BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2807033002
Cr-Commit-Position: refs/heads/master@{#464336}

If used in combination with a transparent setDefaultBackgroundColor,
the background color override applied by setDeviceMetricsOverride is
harmful. The background override does not seem to be beneficial
anymore, as the frontend already doesn't use it.

BUG=689349

Review-Url: https://codereview.chromium.org/2808123004
Cr-Commit-Position: refs/heads/master@{#464335}

BUG=

Review-Url: https://codereview.chromium.org/2811093002
Cr-Commit-Position: refs/heads/master@{#464334}

This CL is a reraise of http://crrev.com/2785943004 PS4.

A null callback posted to PostTask family eventually causes a null pointer
access crash. And its crash report doesn't indicate the culprit directly
without looking into the local variable of the minidump.

After this CL, the crash happens earlier and the crash report will
have meaningful trace.

BUG=711167, 709149

Review-Url: https://codereview.chromium.org/2815573002
Cr-Commit-Position: refs/heads/master@{#464333}

- Add CryptohomeClient::NeedsDircryptoMigration wrapper;
- Check whether a user needs dircryto migration when the relevant
  user pod get focus;
- Show a banner message when the user needs dircryto migration;

BUG=708015

Review-Url: https://codereview.chromium.org/2808423002
Cr-Commit-Position: refs/heads/master@{#464332}

Added null check for the case when arc_custom_notification_item is
already destroyed.

BUG=711149

Review-Url: https://codereview.chromium.org/2812363003
Cr-Commit-Position: refs/heads/master@{#464331}

This adds a new QuickOpenProvider '?' that can be be used to jump to
another provider or search for help.

BUG=662081

Review-Url: https://codereview.chromium.org/2814263002
Cr-Commit-Position: refs/heads/master@{#464330}

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=707185

Review-Url: https://codereview.chromium.org/2785123002
Cr-Commit-Position: refs/heads/master@{#464329}

BUG=537099

Review-Url: https://codereview.chromium.org/2806013002
Cr-Commit-Position: refs/heads/master@{#464328}

This lets a C++ embedder send messages to and from JS on a HeadlessWebContents.
Note for this to work the headless browser context must have been created with
AddTabSocketMojoBindings and the headless web contents must have been created
with CreateTabSocket(true).

This will not affect chrome.exe --headless because only a C++ embedder can set
the above options.

Note that C++ embedders can already do this and more with the current headless API.
At a later date we will remove the more general headless mojo interface in favor of
TabSockets, unless it turns out somebody is actually using them.

BUG=546953

Review-Url: https://codereview.chromium.org/2813953002
Cr-Commit-Position: refs/heads/master@{#464327}

This CL does two things:
1) Replace old pictures with new ones for powerwash page.
2) Rebuild everything using Polymer for material design.

BUG=653269
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2756863002
Cr-Commit-Position: refs/heads/master@{#464326}

GetChildFrameView returns FrameView associated with local Node
if node is HTMLFrameOwnerElement or nullptr.

The method name GetFrameView is already declared in
LayoutObject which returns Document().View(), so a different
name was required.

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2810873007
Cr-Commit-Position: refs/heads/master@{#464325}

This CL just remove a line which depends on libarchive.

BUG=607078
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815083003
Cr-Commit-Position: refs/heads/master@{#464324}

This CL splits UpdateData() function into UpdateResourceData() and
UpdateRedirectData() with less number of arguments.
ResourcePrefetchPredictor uses UpdateData() to update only one of the tables
at the same time so there is no need to pass extra arguments each time.

BUG=631966

Review-Url: https://codereview.chromium.org/2804283002
Cr-Commit-Position: refs/heads/master@{#464323}

Queries to this API have a sleep of 0--8ms, randomly chosen based on a
SHA-256 hash of the app ID, salted with a unique stable device ID. This
prevents websites from being able to determine whether a non-related app
is installed based on the time the query takes.

The website is unable to compare the timing of different apps because
they have different random delays, and unable to predict the random
delay for a given device, because the salt is unknown.

BUG=707071

Review-Url: https://codereview.chromium.org/2802603002
Cr-Commit-Position: refs/heads/master@{#464322}

CL https://crrev.com/2809843002 took  a stab at it but clashed with
the definition in [1]:
   using Position = PositionTemplate<EditingStrategy>;
which is, sadly, used in a bazillion places (see e.g. [2]).

This CL takes a least bad solution by renaming the idl-exposed
Geoposition to Position, but keeping the underlying c++ classes
unchanged.

BUG=708206

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/Position.h?dr&sq=package:chromium&l=224
[2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/WebKit/Source/core/+package:%5Ewebrtc$&type=cs

Review-Url: https://codereview.chromium.org/2816713004
Cr-Commit-Position: refs/heads/master@{#464321}

The MD Settings proxy implementation did not support
proxy configurations that did not include a HTTP proxy.
This is a bug, we should support, e.g., just setting a
FTP proxy.

BUG=708561
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815923002
Cr-Commit-Position: refs/heads/master@{#464320}

BUG=711144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2814123004
Cr-Commit-Position: refs/heads/master@{#464319}

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2817503002
Cr-Commit-Position: refs/heads/master@{#464318}

web-platform-tests for ReadableStream are imported from upstream, so
remove our local copies.

writable-streams and piping tests are not removed in this CL, as the CLs
https://codereview.chromium.org/2772293002/ and
https://codereview.chromium.org/2796633002/ will delete them.

Issue 705125 is referenced because two of the deleted tests were
included in TextExpectations as having non-deterministic results.

BUG=705125

Review-Url: https://codereview.chromium.org/2808853003
Cr-Commit-Position: refs/heads/master@{#464317}

Check the callback counts in all the test cases, and wait for the
fallback navigation to avoid early abortion.

The failures with PlzNavigate are not fixed yet.

BUG=699388

Review-Url: https://codereview.chromium.org/2770193004
Cr-Commit-Position: refs/heads/master@{#464316}

Revert of Build ZIP archiver in ui/file_manager. (patchset #5 id:80001 of https://codereview.chromium.org/2808993003/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 464309 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc3MDY1ZDk4MTZiMzRhNWNjNzkxMzg5NGI4Yjc1NmU3YzNlNmZiNzkM

Original issue's description:
> Build ZIP archiver.
>
> This CL adds and changes some files in ui/file_manager to build ZIP archiver.
> We are going to add ZIP archiver to the list of component extensions
> in another CL, so ZIP archiver still won't show up in the context
> menu with this patch.
>
> BUG=607078
> TEST=manually tested
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2808993003
> Cr-Commit-Position: refs/heads/master@{#464309}
> Committed: https://chromium.googlesource.com/chromium/src/+/77065d9816b34a5cc7913894b8b756e7c3e6fb79

TBR=mtomasz@chromium.org,fukino@chromium.org,hashimoto@chromium.org,takise@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607078

Review-Url: https://codereview.chromium.org/2811183006
Cr-Commit-Position: refs/heads/master@{#464315}

This CL enables content suggestions providers to specify the URL used
to fetch favicon of the suggestion.

To minimize code bloat, this is not needed. If url_with_favicon() is missing, url() is used by ContentSuggestionsService, instead.

BUG=676259

Review-Url: https://codereview.chromium.org/2811123003
Cr-Commit-Position: refs/heads/master@{#464314}

Currently the left, right, top and bottom share the same method for
the initial value: initialOffset(). This makes it difficult to generate
because the generator will generate four copies of initialOffset(),
causing a name conflict.

This patch splits the initialOffset() method into four separate methods,
one for each property.

Diff of generated files:
https://gist.github.com/darrnshn/88a94abf4e37e26b7fdcc4126beb11fa/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2815033002
Cr-Commit-Position: refs/heads/master@{#464313}

The new base_bind_rewriter replaces base::Bind with base::BindOnce where
the resulting Callback is converted to OnceCallback immediately.
E.g.:
  PostTask(FROM_HERE, base::Bind([]{}));
  OnceCallback<void()> cb = base::Bind([]{});
will be replaced to
  PostTask(FROM_HERE, base::BindOnce([]{}));
  OnceCallback<void()> cb = base::BindOnce([]{});

Review-Url: https://codereview.chromium.org/2789153002
Cr-Commit-Position: refs/heads/master@{#464312}

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyAnimationName and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012

Review-Url: https://codereview.chromium.org/2808383008
Cr-Commit-Position: refs/heads/master@{#464311}

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

When Chrome is relaunched, there will be no pending items and somehow a
server side redirect is fired, so a server side redirect item is added
to the chain.

This CL removes the DCHECK.

BUG=710385

Review-Url: https://codereview.chromium.org/2808353007
Cr-Commit-Position: refs/heads/master@{#464310}

This CL adds and changes some files in ui/file_manager to build ZIP archiver.
We are going to add ZIP archiver to the list of component extensions
in another CL, so ZIP archiver still won't show up in the context
menu with this patch.

BUG=607078
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2808993003
Cr-Commit-Position: refs/heads/master@{#464309}

Revert of Enable crashpad for Mac (patchset #4 id:60001 of https://codereview.chromium.org/2816593006/ )

Reason for revert:
mac_chromium10.10_rel_ng buildbot failing in browsertests

Original issue's description:
> Enable crashpad for Mac.
>
> This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
>
> For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
>
> BUG=687407
>
> Review-Url: https://codereview.chromium.org/2816593006
> Cr-Commit-Position: refs/heads/master@{#464289}
> Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

TBR=skyostil@chromium.org,jzfeng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=687407

Review-Url: https://codereview.chromium.org/2819503002
Cr-Commit-Position: refs/heads/master@{#464308}

This patch filters out shorthands from the input of
make_computed_style_base. This is to explictly prevent shorthands being
treated like CSS properties in ComputedStyle.

Currently there are no shorthands being generated as properties, so this
patch does not affect behaviour.

BUG=628043

Review-Url: https://codereview.chromium.org/2809053002
Cr-Commit-Position: refs/heads/master@{#464307}