- 04 Feb, 2020 2 commits
-
-
Darwin Huang authored
Remove ClipboardPromise::system_clipboard(), which was added in https://crrev.com/c/1877532, but doesn't seem to be called at all. Refactoring change, with no functional changes intended. Change-Id: Ie63574cb279e3df1c05b3446202085b72e1a455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033976 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737996}
-
Avi Drissman authored
Bug: 1022821 Change-Id: Id8871a38ea429db3efb1a1f7305eb9e3072f9efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036357 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#737995}
-
- 03 Feb, 2020 38 commits
-
-
Noel Gordon authored
The <dialog> element added in CL:2033012 is too dark. We should restyle its CSS ::backdrop property in quick-view.css to lighten it up dialog#delete-confirm-dialog::backdrop { ... } Add TODO item for that task. Tbr: alex Bug: 803259 Change-Id: Id8f2408f6d9d6cc02f612e1794a52e54dcd2351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035493 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737994}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/664c5603593f..5bbc191e0e57 git log 664c5603593f..5bbc191e0e57 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 janscheffler@chromium.org Add reset columns to DataGrid Created with: gclient setdep -r src/third_party/devtools-frontend/src@5bbc191e0e57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043803 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I217aba7a35c040a59c8e0af1ae8ec30d3f5540df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737993}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: Ifdde0f9e242a3b521e308285b436f657dbf057bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036444Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#737992}
-
nancy authored
Based on the requirement: https://docs.google.com/presentation/d/16He3heqXY5E6IN-OhYcuVe7TGVvZk9kRkWJZvcCP830/edit#slide=id.g638c2bca07_0_38 Paused apps shouldn’t show up in suggested chips. BUG=1011235 Change-Id: I124861da4d888a82060607ade798f9b446eed4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033063 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737991}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2e7ee3cadb3af7f3b2de4b6e3daffc32df838fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737990}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580123479-benchmark-81.0.4044.0-r1 to 81-4028.0-1580726817-benchmark-81.0.4044.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib8dce85df1217433b571c922d437e2dc207fe8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737989}
-
nancy authored
TODO: Add the close item for the new Web apps publisher. BUG=1038487 Change-Id: Ie3063c6cc5bd4bee2f51c0117b832cc8411b06db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032460Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737988}
-
nancy authored
BUG=1016159 Change-Id: I9e80e8f759cc2f96dd15b5a2f5c06eafac92fd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032758Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737987}
-
Donn Denman authored
Fixes the asset for the rounded corners on the top of the Bar of the Overlay panel when in Dark Mode on an mdpi device. The wrong asset was originally uploaded -- white instead of dark. This asset was crushed with optimize-png-files.sh but still ended up substantially larger maybe due to the non-white color that's dominant. BUG=1000792 Change-Id: I60faa1f33c019d2a9f473444a5be11d3eb09fae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036732 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#737986}
-
nancy authored
BUG=1038487 Change-Id: Ib7aa3b9795dc037577086e9d4199b24cdb805a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032698Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737985}
-
Mustafa Emre Acer authored
crrev.com/c/2031936 added javascript_dialogs_android_strings.grd but it's not listed in the expectations. This CL adds it. Bug: 1025256 Change-Id: I8e940e0d4d7759bef2e1a40c50a149dd7ebb4adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033340Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#737984}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ce875a55578..ebf2bec1675c git log 6ce875a55578..ebf2bec1675c --date=short --first-parent --format='%ad %ae %s' 2020-02-03 jbudorick@chromium.org devil: reduce logging verbosity in device_utils and cmd_helper. Created with: gclient setdep -r src/third_party/catapult@ebf2bec1675c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I6e3394cace241108e27ffdc6d0459946e8c0c2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737983}
-
Regan Hsu authored
This CL copies strings used by the OS Search page from browser settings to OS settings, and removes strings unused the browser settings. Bug: 967888 Change-Id: I2a326c91a2aa19b1d83fae11a598029bc6e67a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031166 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#737982}
-
rbpotter authored
- Bundle the autogenerated Polymer 3 settings resources into a new settings.rollup.js file - Include this file in optimized builds - Run Polymer 3 settings browser_tests in optimized builds This will prevent developers from accidentally breaking debug builders that are not run by default in the CQ. Bug: 1026426 Change-Id: I42122e1a4fa2dbc5bfb20dd0586a961e8cbec745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032187 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737981}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. Google Drive isn't tied to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. Bug: 1042400 Test: logging shows access tokens still fetched Change-Id: Ic5b95e0fe7484e373550fa93b87aa9b782aeae05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036380Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737980}
-
Hesen Zhang authored
Bug: 1013685 Change-Id: I2b8fcccb5684d43cfd05d05e618cec16fd21d8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025978 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737979}
-
Avi Drissman authored
It's possible that there's a newer Chrome already installed on the target Mac. In that case, the installer will skip the Chrome app installation, and the postinstall script won't know what brand code to write. Therefore, bake the brand code into the postinstall script. Bug: 1048228 Change-Id: I57857bf5f43804fa4cfb3a552cb3a131e9ee94fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036255Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737978}
-
Regan Hsu authored
* Remove AddWebContentStrings from Browser settings * Move AddWebContentStrings to AddAppearanceStrings * Delete unused IDS_SETTINGS_WEB_CONTENT, IDS_SETTINGS_LOREM_IPSUM, IDS_SETTINGS_LOADING * Move strings in AddWebContentStrings that are shared between different components to AddCommonStrings * Copy strings used by OS settings to OS settings string provider Bug: 967888 Change-Id: I4ff81ab4d6e363e8771748c48ac9802e6b8bc719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013862 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737977}
-
Henrique Ferreiro authored
The different Cursor and CursorInfo objects may hold a custom image and hotspot when their type is ui::CursorType::kCustom. This CL makes changes in several places to ignore those values for non-custom cursors. Bug: 1040499 Change-Id: I504ef36f45bd771c80a2f8b81b828e16eeca0074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035412Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#737976}
-
Takuto Ikuta authored
This was added in crrev.com/b274e87c But I think we can use BQ to do this kind of analysis now. Bug: 984869 Change-Id: Ic4feb37897a6b6fdcac36039aba8d24ae7b3a987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032557 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#737975}
-
Tom Anderson authored
R=sky Bug: None Change-Id: I680cafd25935e59a280e3b2baac754d3d5f13a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036553 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#737974}
-
Jinsuk Kim authored
Removed the overridden color definition in the Preview Tab progress bar. By default, the given style sets the color right both in light and dark mode. Bug: 1047887 Change-Id: I9a5473f9e1f3bf58c83c1f264a4e2ea697b44a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032657Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737973}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6da434932c2e..8f2b5ba75973 git log 6da434932c2e..8f2b5ba75973 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 treehugger-gerrit@google.com Merge "traced_probes: supply shmem size hints when connecting" 2020-02-03 treehugger-gerrit@google.com Merge "Re-enable service worker" Created with: gclient setdep -r src/third_party/perfetto@8f2b5ba75973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id41c9a56f5c4cea586d0e16aa7e97808a8e669e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737972}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580121249-benchmark-81.0.4044.0-r1 to 81-4028.0-1580727432-benchmark-81.0.4044.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I31bc9a824ea9bca6abd0b2c4eaeb17924ee1467b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737971}
-
Michael Crouse authored
This change adds an earlier check for whether a model is included in the PredictionModel proto before validating it. This should resolve the prediction model validation histogram being recording as invalid when the model is not provided by the remote optimization guide as there is not a newer one. Bug: 1046848 Change-Id: I0a974b45883f5940a1a63f77876c615ae420d8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035050 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#737970}
-
Noel Gordon authored
QuickViewParams does not define the |hasTask| property, so the Closure compile can't type-check its value. Define the |hasTask| property. Tbr: alex Bug: 803259 Change-Id: I62e6ad46ca7176298a4d9cd0d5cc466b326d0b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035634Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737969}
-
Mohamed Heikal authored
android-binary-size's 'ForTest' check which looks for symbols in the production apk with 'ForTest' in the name is currently lacking in that it does not track inlined symbols. This change fixes that by having the script parse the proguard mapping file and use that instead of using just the final list of symbols. Bug: 1012373 Change-Id: Ic2752ddc792150f426fb6beac8c9d6553799f6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993623 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#737968}
-
Noel Gordon authored
Tbr: alex Bug: 803259 Change-Id: Ib0872eea67e4d28fc01056c946b48bde04eb5159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035635Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737967}
-
Noel Gordon authored
Change its closure tag to @private. Minor: nix an unneeded extra line. Tbr: alex Bug: 803259 Change-Id: I8b103f26cfa7c8de1e40216b80be3dc47d6d0026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035492Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737966}
-
Noel Gordon authored
Style: do not abbreviate names. Change elems => toolTipElements, being the elements on the quick view toolbar that [has-tooltip]. No need for the |toolTip| intermediate: addTargets(toolTipElements) to the <files-tooltip> handler in one call. Tbr: Alex Bug: 803259 Change-Id: Ic12db7d98ebe95fd07d4d512dd7c657858dc7a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035636Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737965}
-
Charlie Reis authored
SiteInstance and BrowsingInstance should not depend on details of the classes that rely on them (e.g., frame_host/, web_contents/). Bug: 1015882 Change-Id: Ie28ead50ed6c69755d1060330ae3c189ac38dbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029608 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737964}
-
Anand K. Mistry authored
The output of 'lsblk' and 'blkid' are to be added to feedback logs. However, UUIDs from blkid don't necessarily follow the expected UUID pattern. Also, external media can contain user-defined volume labels. Bug: 1045239 Change-Id: I972f1281755a204b0e6e9a554841f1a799c59a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016773Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#737963}
-
Collin Baker authored
InsertIntoFocusOrderAfter inadvertently created focus cycles in some cases. This fixes the implementation and adds DCHECK coverage for the future. Fixed: 942478 Bug: 928905 Change-Id: Ie0d1ceceb56ec07e6d7e2442f925b328607584f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809062 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#737962}
-
Lijin Shen authored
1. rename text styles. Most of them are prefixed by "White". 2. add new text styles. Dark text styles are missing in styles.xml. For more info, see go/clanktext. Bug: 775198 Change-Id: I0f4679d022a671a5080d0a587fef8d4c35f05c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033724 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#737961}
-
John Budorick authored
Bug: 959436 Change-Id: I13d8c704a8f8bf3b0d8c66b8cc55a6dc06793d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032714 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#737960}
-
Marijn Kruisselbrink authored
(or vice versa.) We don't want to re-use the existing permission grant especially in the file->directory case to avoid giving a website access to an entire directory while we only told the user about a single file. However in our logic to guard against this we left the old permission grant dangling, which would result in a DCHECK when it was eventually destroyed. This CL changes the logic in these cases to deny the old permission grants, and updates the DCHECK to make sure it only triggers for non-DENIED grants. Bug: 1047588 Change-Id: I8275d7b3b66ad9b687ca16e4129dba2323f5645e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032236Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba64534cd9d9..7a968e640c5c Created with: gclient setdep -r src-internal@7a968e640c5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:936275 Tbr: jbudorick@google.com Change-Id: Ide936dc11b949a7a282d3fadd44e367f64d227fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737958}
-
Matt Menke authored
Sometimes the write-to-file tests timeout on the bots. Since the other write to file tests all pass (though they write less), and there have been no reports of the code hanging in the wild, seems likely an issue with bot performance, rather than a bug in production code. Just reduce the amount of data the tests write to disk in the write-to-file case. Bug: 1035127 Change-Id: I1199d22c5b65110f070f7c000881a564c8a44649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036630 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737957}
-