- 13 Nov, 2020 40 commits
-
-
Luciano Pacheco authored
This CL fixes some inconsistencies that become larger issues for running with JS modules and within SWA container. Issues: 1. The `window.background` was defined using `var background =`, however for JS Modules this doesn't set in the global `window`. 2. The interface `FileBrowserBackground` is actually used by other apps other than Files app, despite the prefix `FileBrowser`. Fix by renaming the interface to `BackgroundBase` and in turn rename the implementation to `BackgroundBaseImpl`. 3. The implementation `BackgroundBase` doesn't have a `@implements` to its interface, which was confusingly named `FileBrowserBackground`. Fix by adding the `@implements` accordingly. 4. The methods `ready()` and `setLauncherHandler()` were the defined in the wrong interfaces. Fix by moving `ready()` to `FileBrowserBackgroundFull` because it's used only in Files app and move `setLauncherHandler()` to `BackgroundBase` because it's used in all apps. No change in behavior, Closure type-checking and current tests cover all changes. Bug: 1148545, 1133186, 1113981 Change-Id: I4ca90e826faf88b7def3b12d89ae249c091ec973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534551 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827162}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5c5cd3d035d767d2392fe5d2cd17f7979f3994b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827161}
-
Glen Robertson authored
Change-Id: I92b855f231ede21d1263b4147d895864e7961268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536651 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827160}
-
Josiah K authored
AX-Relnotes: Fixes a bug where the full screen and docked magnifiers would jump unexpectedly when using the arrow keys to move up and down through the omnibox results. Also fixes a bug where the full screen and docked magnifiers jump to the center of the omnibox entries, cutting off the left edge with the site icon and text. Now, the left edge of the selected omnibox entry is aligned with the left edge of the magnifier viewport, so that the site icon and text are visible. Fixed: 1147350, 1147354 Change-Id: I8d2dc3515d9cd565e5cdff3ec84903a6f339eccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528613 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827159}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib58a338e0a97e79c44467f56be6d53f92541dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537091Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6a79629904ea..8343d0cf8953 2020-11-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ief5bf6573ba89048528248dab810614a73cae206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537093Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of content_browser_client.h from 3.47MB to 2.85MB. This CL has no behavior changes. Change-Id: I567970cfa113607f9b1e0511cd4fffe6de1256ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535895Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#827156}
-
Leo Lai authored
This is a reland of 23c810e8 Original change's description: > removed unnecessary defderred PrepareTpmDeviceAndFinalizeProfile > > According to the current program flow, this to-be-removed branch seems a > useless special handling. > > This CL might affect how UserSessionManager utilitzes tpm manager client > in the near future. > > BUG=b:172748724 > TEST=unittests. > > Change-Id: I93f05a45409878db1138c8d49d835f1d7f0c427e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525471 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Leo Lai <cylai@google.com> > Cr-Commit-Position: refs/heads/master@{#826319} Bug: b:172748724 Change-Id: Idfb9d74d574e4b2c0510abe87d6d6269960c627c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534554Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#827155}
-
Sunny Sachanandani authored
Swap chain format is used in RecordPresentationStatistics() to emit trace events which are then used in trace tests to verify that the correct format is used. Bug: 1148586 Change-Id: I06bb99afb9cac26bf37a66adf9f0551c879a29a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536720 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#827154}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/696f7382ade0..334494bde984 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1133499,chromium:1137914,chromium:1147369 Tbr: yutak@google.com Change-Id: I44b429a769ae2070d1e2ea9c415b84e69914a9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827153}
-
Koji Ishii authored
This patch replaces two usages of |LayoutObject::PositionForPoint| with |HitTestResult::GetPosition| because the former does not support NG block fragmentation. There are some minor differences in the behavior. But according to yosin@, using |InnerPossiblyPseudoNode| instead of |InnerNode| is most likely more correct. Bug: 829028 Change-Id: I6fda4161f60e2cafb78c12370484bf464331a5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535530 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827152}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/052885405c6c..71d32ad4b83a 2020-11-13 rwkeane@google.com Fix Bug in Cast Core Proto 2020-11-13 shawnq@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I050839ee39d165100921d3edf3386f031eaffa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536895Reviewed-by:
-
Eugene Zemtsov authored
Bug: 1119892, 1146168 Change-Id: Ibb548cd1684f22a0e095c0d0d51654bdd2ea59f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534691 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#827150}
-
Glen Robertson authored
Add missing fields to operator== and operator<<: - downloaded_icon_sizes_monochrome_ - shortcuts_menu_item_infos_ - downloaded_shortcuts_menu_icons_sizes_ Use a separate Tie method to avoid repeating all fields twice. Disable clang-format in the Tie method. Add operator<< for WebApplicationShortcutsMenuItemInfo (required to add it to use it in operator<< of WebApp). Change-Id: I33b96b1209617e280a319d76be1e3e14681a3077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532539 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#827149}
-
Saho Kobayashi authored
Checked state description is not read out because I missed adding checked state description to automation_node.js in CL:2444875 . Add it to plumb checked state description to AutomationNode. Bug: b:154433831 Test: manual (run locally modified arc.AccessibilitySpeech.vm) Change-Id: Id56e0b9229efcfff9dbda13aee542567e86a703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528515Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I5fa77569d93318b6d6b9e15f2f65eca139c63b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537133Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827147}
-
rbpotter authored
Fixed: 1148535 Change-Id: Iab37489f503d07b498e36e1a8c60cd7e3bf7c44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536352 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827146}
-
gogerald authored
Bug: crbug.com/1144732 Change-Id: I02b0f55361cb4211b8862a62be4d841c15e2ad68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536054 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#827145}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fd0d0441ca1e..e4c1a25cc679 2020-11-13 capn@google.com Use LLVM JIT for MemorySanitizer GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b6f6de9e5c74804d9f8b91764e02b4970cdbd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536715Reviewed-by:
-
Kent Tamura authored
This CL applied new downcast helper for the following classes, and remove DEFINE_LAYOUT_OBJECT_TYPE_CASTS(). * LayoutFlexibleBox * LayoutFrame * LayoutFrameSet * LayoutGrid * LayoutTableCol This CL has no behavior changes. Bug: 891908 Change-Id: I49126e739fe4dd11046c08a5929b38c2adbcf7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536413 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827143}
-
Charlie Harrison authored
Was previously an OWNER of all histograms.xml before the split. Now moving to sub-owners of directories I tend to do reviews for. Bug: None Change-Id: I34de0dd4f0a17c014e5f1bcdc96046b78483253b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444029 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#827142}
-
Leo Lai authored
This is a reland of f5684467 Original change's description: > UserSessionManager trigger tpm initialization whenever TPM is enabled. > > we are obsoleting `TpmIsBeingOwned()`, which is not really necessary > anyway; even if `TpmIsBeingOwned()` returns `true`, triggering the TPM > initilaization again is just no-ops at ChromeOS side. > > BUG=b:172775884 > TEST=TBD if untitests needed. > > Change-Id: If4240a0c8a9a7485d77856e1e5c346c89407c09a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532155 > Commit-Queue: Leo Lai <cylai@google.com> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826306} Bug: b:172775884 Change-Id: I0499d47b9962f41bcfa956d6efa73b850a0b2021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534372Reviewed-by:
-
David Lei authored
Change-Id: I6f79c58f93cab4995f6103fe4759c2c9cdbe32ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536570Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: dstockwell <dstockwell@google.com> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#827140}
-
Tal Pressman authored
Regardless of whether we are in "MBI mode" or "legacy mode", the AgentSchedulingGroup and AgentSchedulingGroupHost interfaces should be associated with one another. This is because we want to preserve the current behavior, where all channel-associated interfaces are all bound to the same pipe and not separated by the direction (browser->renderer or renderer->browser). This CL moves the binding of the ASGH interface to the method that was used to bind the RouteProvider interfaces (and renames it appropriately). Bug: 1111231 Change-Id: I4304e00a65b44d11f5dad6fb51ec1bedde76ec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528813 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#827139}
-
Andrew Xu authored
This CL resets the unique pointer to the menu model adapter which runs the multipaste menu. Note that the destruction is called asynchronously. Because the callback of closing the menu is called from MenuRunnerImpl. Meanwhile, MenuRunnerImpl lives in the menu model adapter. So it is risky to destruct the menu model adapter in a synchronous way, although it works fine right now. Bug: 1148591 Change-Id: Ifdd2d526d74b60090eb495cdc3c0309d475e4f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536850Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827138}
-
Sharon Yang authored
Use NavigationPolicyThrottle and NavigationPolicyHandler in FrameImpl and WebEngineContentRendererClient so the new functionality is exposed to clients Tests: NavigationPolicyTest Bug: 1117601 Change-Id: If4b96b72b60792912f071513562bec0d0f920254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504581 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827137}
-
Evan Stade authored
BrowserContext is sufficient and is one step closer to componentizing the class. Bug: 1147276 Change-Id: Ifa05a35c71ca601a52c54d7a428f54f0abdc149e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527856Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827136}
-
Shakti Sahu authored
This CL fixes : 1 - Fixed layout styling for section header 2 - Added plumbing to mark an article as read 3 - Added fix to show the sign-in promo at the top of reading list 4 - Fixed search state to not show any read/unread section headers Bug: 1148472, 1148524 Change-Id: I6269b28bf7146acc684437446686c76c88006892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535616Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827135}
-
Josiah K authored
Bug: 1138781 Change-Id: Ibf8c9594777db2b6f0fd813ac9320962acf62734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535643Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#827134}
-
Clark DuVall authored
Assets were being kept in both the base module and DFM due to the recursive_resource_deps arg which pulls resources into the base module. This change excludes assets, preventing them from being duplicated in the base module. Bug: 1126301 Change-Id: I6dd110c86f5befb7271880fee0c5c2c94740a766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536750Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827133}
-
Kevin Marshall authored
Applies the fuchsia.web.AutoplayPolicy which may be passed in at Frame creation time to the Frame's top-level WebContents. Test: autoplay_browsertest.cc Bug: 1067101 Change-Id: Id3b69ddea474c9b8d6f2a1b05ec195270cad3cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533555 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
David Trainor authored
This is a large patch moving all of the downloads home files to a module. Code in //chrome/android/java/src/.../download/home moved to //chrome/browser/download/internal/android/java/src/.../download/home. Resources were moved to the internal directory as well, except when they were used by other features, in which case they were moved to //components/browser_ui/styles. TBR=bjoyce@chromium.org, ajwong@chromium.org Bug: 1062116 Change-Id: Id4fd950dad81002c85b28be5a71181ecc5c3178d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230199 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827131}
-
Xing Liu authored
backend." Original change's description: > Read later: Add a method to notify update for reading list backend. > > Adds an observer method to notify update for reading list backend. OCL:https://chromium-review.googlesource.com/c/chromium/src/+/2519151 Revert:https://chromium-review.googlesource.com/c/chromium/src/+/2532074 Revert bug:1147311 Difference: None, the ASAN issue is fixed in the previous reland: https://chromium-review.googlesource.com/c/chromium/src/+/2532911 TBR=dtrainor@chromium.org Bug: 1139133 Change-Id: I4911f5e8d30fd0fb7f6e19116b7554f4e78b0a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535019Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827130}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/420f7362d68a..2a9b38f2dacd 2020-11-12 rohpavone@chromium.org Moves Fuchsia platform to Desktop. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: zhanliang@google.com Change-Id: Id4976e61576da5d03d03505e3d3657a58c8bc13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536060Reviewed-by:
-
Josiah K authored
Utilize getNextMagnifierBounds for better end-to-end testing approach. Fixed: 1139939 Change-Id: I65665dcb655f0bf948a36f28c4e5ba396010fbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533678Reviewed-by:
-
Jonathan Freed authored
Bug: 1128169 Change-Id: I423085d3d3f6ac7b9434b72cb794cd7f19ace64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531365 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827127}
-
Devlin Cronin authored
tabs.executeScript() and tabs.insertCSS() are being replaced by methods on the new chrome.scripting API. Restrict the old features to MV2. Bug: 987838 Change-Id: I3bf76ac9cf4821765531d08379bfb8eb21bf92e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535996Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827126}
-
Meilin Wang authored
Updates assets to finalized images. Fixed: 1146563 Bug: 1106937 Change-Id: I6a1f1ccf26f187832a1a7128e96f7d4f1ccb683c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533410Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827125}
-
Evan Stade authored
Provide the CastOptionsProvider in the public AndroidManifest.xml so that no client integration is required. This could cause a conflict with a client that already integrates with GMSCore cast library and has a CastOptionsProvider, but current clients do not. Bug: 1057099, 1148410 Change-Id: I8b342f7515f6b8c5b00b63a5eb86aefe2ea45692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534176Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827124}
-
Evan Stade authored
Bug: 1147276 Change-Id: I3fd1c16cf67eadf27a8ccc8b7f638f4c090a1ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531294Reviewed-by:
-
