- 27 Aug, 2019 40 commits
-
-
Scott Violet authored
Plumbs through the Profile/BrowserController and the start of NavigationController as discussed. The pattern is classes in weblayer/public/java/org/chromium/weblayer trivially calls through to classes in weblayer/browser/android/java/org/chromium/weblayer_private/ . Eventually the calls will be over AIDL. I also introduced a WebLayer java class for one time initialization. This isn't perfect, but a good start. BUG=none TEST=none Change-Id: Ie14cdb3d8a63624fb23c37dbc6187f100b5f20ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772443Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#690902}
-
Lei Zhang authored
Change it to return base::Optional<PP_PrivateAccessibilityTextRunInfo>, instead of returning the individual elements of PP_PrivateAccessibilityTextRunInfo as out parameters. Update the caller of GetTextRunInfo() to std::move() the text run into the vector that holds all the text runs, and simplify calculations for char indices in the caller. Change-Id: I719119935ea201f5aed7d1d41e706831a1696c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769220 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690901}
-
Chris Mumford authored
r472276 renamed two targets: 1) android_webview_apk ==> webview_instrumentation_apk. 2) android_webview_test_apk ==> webview_instrumentation_test_apk. However, there were two local targets which should have been renamed for consistency, but were not: 1) android_webview_apk_assets ==> webview_instrumentation_apk_assets. 2) android_webview_apk_resources ==> webview_instrumentation_apk_resources. Bug: 701938 Change-Id: I09b7f8109472e5ad0c9c2b5639dbb3e4e656cf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772691Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#690900}
-
Rakina Zata Amni authored
Move the tests and change them to use the rendersubtree attribute. Note that the SVG test fails because the rendersubtree attribute is only defined on HTML elements. Bug: 991095 Change-Id: I4515d4db3786d7bcd1863e7b5407d88dbbf3c016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773017Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#690899}
-
Anastasia Helfinstein authored
Use the newly added FocusRingManager. Bug: None Change-Id: If0f98d40eec6a52a1eef5322d5ef05a15690a910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771046 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#690898}
-
Rune Lillesveen authored
We currently store a bool saying if the StyleColor represents currentcolor or not since currentcolor computes to itself and will inherit as currentcolor. If [1] is resolved, we need to do the same for system colors. Store a CSSValueID in preparation for that. This CL should not have any behavioral changes. [1] https://github.com/w3c/csswg-drafts/issues/3847 Bug: 939811 Change-Id: I5908a09b311c549c9d194bdf4180e24ba7baae5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771413Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690897}
-
Rune Lillesveen authored
Make sure RuntimeEnabledFeatures are reset properly in tests. Change-Id: I13541aac18b6c5aa68753fdca560c8d8da0703a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771968Reviewed-by:
-
Jack Lynch authored
This CL adds an aria-label to the select box in the Performance panel Event Log pane that filters by duration in order to make its purpose clearer to screen reader users and meet WCAG 1.3.1. Screenshot of the select in question: https://gyazo.com/9ecb8d9699a05fbb83fcf6f0925f3c47 Bug: 963183 Change-Id: I887f6192b08dbff113d9ac61fa185ffa9ce195ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723804Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690895}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70768f4a8e10..2d5aec56fdf7 git log 70768f4a8e10..2d5aec56fdf7 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision abb1ee24..f706cf73 (690691:690793) Created with: gclient setdep -r src/third_party/webrtc@2d5aec56fdf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I453c8a10f82e8f0edc4384641ae7d7c845ed6a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690894}
-
Becca Hughes authored
Enable the lock screen media controls by default since these are shipping in M78. BUG=965546 Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690893}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c5a91bb269fc..8ba3dcbde46b git log c5a91bb269fc..8ba3dcbde46b --date=short --no-merges --format='%ad %ae %s' 2019-08-27 zoddicus@users.noreply.github.com Rolling 7 dependencies and updating known_failures (#791) Created with: gclient setdep -r src/third_party/shaderc/src@8ba3dcbde46b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ib15a774c6947beb8490cdc85db0d7496bbb0a098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773195Reviewed-by:
-
John Budorick authored
Requires crrev.com/i/1714264 Bug: 994432 Change-Id: I81052b2cddbd4866f70b43993749e570d2a4756e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773214Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690891}
-
Will Harris authored
Previous to this CL, a caller could enable the MITIGATION_DYNAMIC_CODE_DISABLE_WITH_OPT_OUT policy expecting that it would work, but since Win8.1 and before Win10 RS1, ACG with no opt-out would be enabled by the sandbox instead. This would cause subsequent calls to opt a thread out to fail unexpectedly on these OS. This CL changes code to just ignore MITIGATION_DYNAMIC_CODE_DISABLE_WITH_OPT_OUT on unsupported OS as is sandbox convention. BUG=733739 Change-Id: If777ad461de3600c407c7175d283072ac42ab9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773520Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#690890}
-
Daniel Rubery authored
If the verdict from deep scanning is UWS or MALWARE, generate realtime reporting event for the dangerous download. Bug: 980777 Change-Id: I47524dd2eeb7b6a2f4178464390fb78479030b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771820Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#690889}
-
Ian Kilpatrick authored
Previously if we didn't match our "forced" BFC block-offset we'd layout that subtree. This patch adds logic for elements which have clearance past adjoining floats - (this is quite common on facebook.com). Fortunately we can re-use all of the logic if an element is "pushed by floats". However the following invariants must be true: 1. We have a "forced" BFC block-offset set for the old and new constraint spaces. 2. These "forced" BFC block-offset are equal to their respective clearance offsets. Change-Id: I4873bb477a5fa17768943d9dba07d8d65c20d780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773543 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#690888}
-
Vasiliy Telezhnikov authored
This CL add waiting for default icon image to be loaded in the BrowserActionApiTest.BrowserActionWithRectangularIcon tests. It adds TestIconImageObserver for this purpose (instead of local WaitForIconLoaded in MultiActionAPICanvasTest) Bug: 997820 Change-Id: I447d7563cd0bde20f8787f9eb412978addaecab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772128 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690887}
-
Rakina Zata Amni authored
Move the tests & change them to use rendersubtree attribute. Removed some tests around containment, inline, timeout, duplicate from lock-after-append move etc. Note the acquire-clone.html tests failed, will file bug. Bug: 991095 Change-Id: Ia6606706bae235c07bbb78d34f4a6c91afda32ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772816Reviewed-by:
-
Gavin Williams authored
-New sort order is printers with automatic configuration sorted alphabetically first then printers that need manual configuration sorted alphabetically next -Added new test case to confirm nearby printers sorted correctly Bug: 993820 Change-Id: Idf730c8111bc6e835b659e899e3a478d719e04a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767604 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690885}
-
Owen Min authored
Plugin belongs to browser instance. We don't need browser context to get plugin lists. Hence move plugin from ChromeUserProfileInfo to BrwoserReport. 1) Remove Plugin related code from ProfileReportGenerator 2) Because of 1), ProfileReportGenerator does not need to be async. 3) ReportGenerator remains async as Plugin information will be get here. Getting plugin info in ReportGenerator will be added in the following CL. Bug: 956237 Change-Id: I04c5ac519bc5c03e5436e10e98eebcf9a27b11fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764278 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#690884}
-
Stephen Nusko authored
This reverts commit 94d22097. Reason for revert: Tests on the pixel 2 GPU are now fixed. See gpu-fyi-try-android-p-pixel-2-skv-32 trybot. Changes: 1) We now call OnDisconnect if we were already connected when calling SetNewSocketForTesting() this fixes gpu-fyi-try-android-p-pixel-2-skv-32 2) GetDefaultTraceConfig() is now in a unnamed namespace in the .cc file rather then a member function. This was needed for ubsan_vptr as described in crbug/997318 Original change's description: > Revert "Enable a new SYSTEM background tracing mode." > > This reverts commit 9c5df46a. > > Reason for revert: timing out tests > > Original change's description: > > Enable a new SYSTEM background tracing mode. > > > > This mode will allow us to set up a background scenario and deliver > > triggers to the system when something interesting is happening. Which > > will allow us to only upload traces that are of interest. > > > > Bug: 979583 > > Change-Id: Ic48ea08e3f9fafccaf045847cc0ddfa76d11611c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760736 > > Commit-Queue: Avi Drissman <avi@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: oysteine <oysteine@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689563} > > TBR=avi@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 979583,997206 > Change-Id: I51889cecfdc1ac392fb199b1a190b14880801e6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768981 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690047} TBR=avi@chromium.org,enne@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979583, 997206, 997318 Change-Id: Ib7052fbb7f2b67d85657494ab59d111a58213cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768768Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#690883}
-
Karen Qian authored
Bug: 922150 Change-Id: I6df27b4f41583f5231cca5a10277d6ce3bddaa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769347Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Karen Qian <karenqian@google.com> Cr-Commit-Position: refs/heads/master@{#690882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73c58302fc9e..daddc3da9672 Created with: gclient setdep -r src-internal@daddc3da9672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:913074 Change-Id: I01d4c30c9429bd9b844803c6cd7d8a8225b0aa10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773189Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690881}
-
Tao Bai authored
This patch moves chrome/common/page_load_metrics to components/page_load_metrics/common, and is mostly moving the file, no change to feature. README and OWNER file haven't been updated, will do when moving them to components. Bug: 995880 Change-Id: I5f8eb1cdbc9a631fea2fdd6158ea93b35da74271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761729Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690880}
-
Eric Willigers authored
Blink previously used 'auto' as the initial value, but did not accept 'auto' as a specified value. https://drafts.csswg.org/css-scroll-snap-1/#padding-longhands-physical https://drafts.csswg.org/css-scroll-snap-1/#padding-longhands-logical Bug: 921319 Change-Id: Ice01fd6e52ad3abb726fee352488c2423d001f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772716Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#690879}
-
Zhongyi Shi authored
http://crbug.com/c/1769725 forces check the caller does not set options to handle ip address change and connection migration simultaneously. iOS however enables "goaway_sessions_on_ip_change" be default, which caused the migration option setting test fails. Bug: 998156 Change-Id: I8968a257c555b165ecca3aa60138366960c00b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773343 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690878}
-
Dana Fried authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1764942 which restricted vertical alignment of labels to multiline only. It relaxes the restriction, allowing all render text to be top or bottom aligned, though at the expense of the ability to guarantee baseline alignment when mixed fonts are required to render a line (still a feature of the default ALIGN_MIDDLE; a note has been put on the new Label::SetVerticalAlignment() method to this effect). Bug: 996905 Change-Id: I46d60902e91ea202f48ae2952b4c0cb118d80650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772449Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#690877}
-
Khushal authored
Only use wide color gamut color spaces with SurfaceControl if enabled for the GLSurface, which is gated on support from the platform queried using Display.isWideColorGamut(). R=ericrk@chromium.org Bug: 997592 Change-Id: If9d09d04c341c86c414c514e9c069b08f6a9c87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772276 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#690876}
-
Ian Kilpatrick authored
This relaxes a constraint we had previously that we'd never re-use a layout-result if our "forced" BFC block-offset was different. For self-collapsing blocks we can somewhat ignore this rule for the following cases: 1. If the self-collapsing block has no adjoining-objects, it can be placed anywhere. 2. If the self-collapsing block has adjoining-objects, it can be placed anywhere if its old and new expected position doesn't intersect with any floats. Change-Id: Ib2a85455955ed5b207aed64c2d691584437eaa6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769158 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: -
Steven Bingler authored
Add all members to chrome_browser_net namespace. Change IsValidDohTemplate() name to be DoH specific. Change-Id: I68cf5d2ce3a987b2e0f000ebd125a4ef490d7237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764899 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#690874}
-
Alex Ilin authored
ashmem_get_funcs() returns a pointer to a static local variable s_ashmem_funcs that is initialized in a non thread-safe way. It is possible that one thread starts the initialization of s_ashmem_funcs and sets s_ashmem_funcs->create. s_ashmem_funcs->setProt is not initialized yet. Then another thread calls ashmem_get_funcs() and since s_ashmem_funcs->create != NULL, ashmem_get_funcs() returns a pointer to a partially initialized struct. An attempt to call s_ashmem_funcs->setProt fails on the null pointer. This CL fixes the data race by using pthread_once(). pthread_once() guarantees that the initialization function will be called exactly once ans that on return from pthread_once() the initialization has completed. Bug: 985870 Change-Id: I182c3edd43eb2cb58ec9e70d8e03f82742004138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769452Reviewed-by:
-
Hesen Zhang authored
- Changed AddIcons with a map of IconType and UUID as input. - Complete ScheduleNotification logic. - Added unit tests for adding icons. Bug: 963290 Change-Id: Ie51437b08314712707f3b12c857dbfc18182adf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771076 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690872}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fce3bd0cb0a5..51ed66b5cadd git log fce3bd0cb0a5..51ed66b5cadd --date=short --no-merges --format='%ad %ae %s' 2019-08-27 dhaddock@chromium.org Improve logging of AU test failures. Created with: gclient setdep -r src/third_party/chromite@51ed66b5cadd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1b438d1c3b998b408e141c891ca03a62fedf4bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773187Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/be14352b8322..c5a91bb269fc git log be14352b8322..c5a91bb269fc --date=short --no-merges --format='%ad %ae %s' 2019-08-27 zoddicus@users.noreply.github.com Add ToVulkan API methods (#792) Created with: gclient setdep -r src/third_party/shaderc/src@c5a91bb269fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I926d2bc9623f8f4f48f3cd18a40e2ed3957204f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773326Reviewed-by:
-
Min Qin authored
If a navigation is triggered by a cross-origin download initiated by renderer, the navigation should carry the renderer initiated flag. BUG=979443 Change-Id: I0716193768a5473f70e909b7efbb5fc74933d89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768825Reviewed-by:
-
Mike Wasserman authored
The text was incorrectly using a secondary (lighter gray) style. Use the primary (darker gray) style like similar UI surfaces. Bug: 997886 Change-Id: I1bdcf33efce266612c58c80ce564bb2449972915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772447 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#690868}
-
Majid Valipour authored
There test were marked as flaky as part of a mojo change landing. The tests no longer seem to be flaky based on local test! While it is not clear why but this patch changes expectation so they are no longer skipped. Once we confirm they are not flaky we can enable them back. [1] https://crbug.com/922951 Bug: 991565, 986018, 922951 Change-Id: I7fd50531bf23a102bf20d332d40af81953a697ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768668 Auto-Submit: Majid Valipour <majidvp@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#690867}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7cac7cb..0cd38a17 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47020d173ca16923b2a4467575db2c21d898831c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772089Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690866}
-
Jacques Chen authored
-Change protocol.json to be Brotli compressed by grit -Have protocol.json be decompressed by GetDataResourceBytes -Remove brotli.gni that is no longer used Bug: 826858 Change-Id: I2c49715f85508f494a57d65b09ada446c2efefec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728183 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690865}
-
Maggie Chen authored
Some of the functions are allowed to run only on the watchdog thread or the watched GPU thread. DCHECKs are added to these functions to make sure multi-threading is running correctly. For those functions that can run on any threads, no DCHECK is added. Bug: 949839 Change-Id: If451934db201d8544a427c007995900361663768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773436Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690864}
-
Wei Li authored
Since we fetch survey content from a remote server, we have to handle situations such as no internet or slow connections etc. To work around all such problems, this CL creates the web dialog and preload the survey content before showing user the bubble banner. We only show the bubble banner after we already retrieve the survey content. The pros of this approach include 1) avoid handling offline and slow loading scenarios; 2) fast UI -- the dialog will immediately show up once user consents. BUG=979530,996542 Change-Id: I7163c1fd06a479460d4705458c880f5e17ce1b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745710 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
