- 22 Jun, 2018 40 commits
-
-
Ryan Hansberry authored
This injects a ClientChannel into ProximityAuthMonitor, which is used if the chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used to get the current RSSI of the connected remote device. In the future, the "rolling average RSSI" that is calculated in ProximityAuthMonitor will be moved to the SecureChannel API, and returned by it. However, to reduce immediate migration work, that logic is kept in ProximityAuthMonitor for now. This CL was originally submitted as [1], but was reverted [2] due to a subtle bug in a test, which has been fixed at [3]. This CL is unchanged from the original. 1) https://chromium-review.googlesource.com/c/chromium/src/+/1106616 2) https://chromium-review.googlesource.com/c/chromium/src/+/1111937 3) https://chromium-review.googlesource.com/c/chromium/src/+/1112422 Bug: 824568, 752273 Change-Id: I5fba2dcb73fd4b8da08d93cbfa045b6f6888a93b Reviewed-on: https://chromium-review.googlesource.com/1112434 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569785}
-
Karan Bhatia authored
This CL removes two redundant PostTask usages from SandboxedUnpacker. In both the cases, we are already on the correct sequence, hence we can call the function synchronously. BUG=None Change-Id: I42deaad16bce1db2e2e1905aa13253251791c8b6 Reviewed-on: https://chromium-review.googlesource.com/1110839Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569784}
-
wutao authored
This patch updates device_settings' locale when starts the service, which can handle the situtation that user changes preferred language. Bug: b/110094434, b/80431063 Test: manual. Can see updated locale in the log. Change-Id: I0113fc35367fff9298e5bd3c3ec6976726efaa0f Reviewed-on: https://chromium-review.googlesource.com/1111656Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569783}
-
tzik authored
A constructor of base::{Once,Repeating}Callback takes a pointer to BindStateBase, that is intended to be used by base::Bind*. However, the constructor accidentally matches to nullptr parameter, and that requires a null check of |bind_state| in the callback constructor. This CL disables nullptr argument on the callback construction. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic74ca7ce94bc95922e122257d397ff5fbf1fa431 Reviewed-on: https://chromium-review.googlesource.com/1111179 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569782}
-
Fady Samuel authored
We still get the occasional surface invariants violations in the wild and we don't necessarily want to crash the renderer in this case. We will already log things appropriately. Bug: 672962, 828741 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I262850f2cf704cd59366da6dd4d154227aab5220 Reviewed-on: https://chromium-review.googlesource.com/1112491Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569781}
-
Min Qin authored
If browser is running without DownloadManagerImpl, we need InProgressDownloadManager to inform UI when a download is started. This CL introduces DownloadStartObserver, and it can be passed from chrome/ to components/. When a download is started, InProgressDownloadManager can inform the observer about the newly started DownloadItem. BUG=842245 Change-Id: Ie02c0cd7a96d02fbbe689bb7a671ba51da45f6fb Reviewed-on: https://chromium-review.googlesource.com/1109036Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569780}
-
Max Moroz authored
A follow-up for https://chromium-review.googlesource.com/c/chromium/src/+/1112199. These two changes should significantly speed up code coverage builds. Build time, binary sizes and runtime all get improved by ~2x. See the other CL description and the bugs referenced for more precise numbers and targets tested. We already have an assertion against enabling both use_sanitizer_coverage and use_clang_coverage via GN args, but the former still could be turned on indirectly if a fuzzing engine is used (e.g. use_libfuzzer or use_afl). Bug: 846054 Change-Id: Idcd87a4589eda71e519d382ef235b38cc0984ed3 Reviewed-on: https://chromium-review.googlesource.com/1112305Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569779}
-
Ian Clelland authored
Change-Id: Ibfcc3e8bc217aff8782d2aec4c1b73bb4a193e1e Reviewed-on: https://chromium-review.googlesource.com/1053106 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#569778}
-
Kurt Horimoto authored
This encapsulates the context menu functionality that will be shared across the legacy and new implementation of the reading list UI. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie17832216d81a1b243ea45ba0cb7cb98c6805115 Reviewed-on: https://chromium-review.googlesource.com/1101914 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569777}
-
Suproteem Sarkar authored
R=nektar@chromium.org,dmazzoni@chromium.org Bug: 852970 Change-Id: Id20d5bc038c36e9f339737aa18ccdc06d65ba9bb Reviewed-on: https://chromium-review.googlesource.com/1102487 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569776}
-
Matt Wolenetz authored
Adds tests for changeType buffering and playback, for every combination of up to 7 audio-only types, and for every combination of up to 6 video-only types. Sequence mode is used for these because a buffered range gap and playback stall occurs across the boundary of any audio-only combination containing the test MP2TS AAC media in segments mode. Other CLs include changeType chromium impl (pre-requisite for this CL); and blink impl and new web-platform tests. BUG=605134 Change-Id: I34e6afb9ce104497636958ed2892c1bc6134ff73 Reviewed-on: https://chromium-review.googlesource.com/1110521 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569775}
-
Wenzhao Zang authored
1) Moved public functions (which don't have to be public) to private or anonymous namespace. (During the refactoring these functions were made public in order to be used by //chrome). 2) Does not change any logic. 3) May need a follow-up CL to make the anonymous namespace functions to a separate file to make the class slimmer. Bug: NONE Change-Id: Ib67016cef0e8654ed8b8a674c24118a7f2f9b519 Reviewed-on: https://chromium-review.googlesource.com/1111571Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569774}
-
Richard Bustamante authored
The policy "client_test_icaspr" was removed in cl/201053559 Updating the client tests with the new name. Bug: 855730 Change-Id: I337ff743b9205f26649377b30fb15464bfbaabc8 Reviewed-on: https://chromium-review.googlesource.com/1112582Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Richard Bustamante <bustamante@google.com> Cr-Commit-Position: refs/heads/master@{#569773}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fec92a6f89f1..e9c0b262a4e9 git log fec92a6f89f1..e9c0b262a4e9 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 lucferron@chromium.org Vulkan: Add drawQuad to a sampler test 2018-06-22 lucferron@chromium.org Vulkan: Cleanup InstancingTest logic and enable tests for Vulkan Created with: gclient setdep -r src/third_party/angle@e9c0b262a4e9 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iaf3a70a7e034fe98146aee83dff309c311966f82 Reviewed-on: https://chromium-review.googlesource.com/1112220Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569772}
-
Jacob Dufault authored
- drop LoginDisplayHost::default_host(), we're already in the default_host() instance - remove early-return - check if we're currently signing in, in which case do not show gaia (fixes the bug) Bug: 852745 Change-Id: I5e1e7dcfca2c7aca55b9301721ea3499c1a88451 Reviewed-on: https://chromium-review.googlesource.com/1110273Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569771}
-
Stephen Martinis authored
This is a reland of 9b237478 Original CL was reverted just to be safe, due to https://crbug.com/855290. There's a fix to a typo in the unexpected field; it should actually be 'is_unexpected', not 'expected'. Original change's description: > Chromedriver: Make test runner emit proper test results > > The chrome test result format needs failed tests to be marked as > unexpected to be recognized as true failures. Otherwise they're thought > to be acceptable failures, and don't show up as actual failures when > parsed. > > Bug: 533481 > Change-Id: Ica94a18a4503a5553ef5602627643ae526155e1a > Reviewed-on: https://chromium-review.googlesource.com/1109269 > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569341} Bug: 533481, 855290 Change-Id: I502ace9b1f0fd97d569fe6eb6c08f660218acb01 Reviewed-on: https://chromium-review.googlesource.com/1111218Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#569770}
-
sebsg authored
Was causing failures on MSAN bots. Change-Id: Icbffe8066bed645404fa792992f84e62ed1e83ca Reviewed-on: https://chromium-review.googlesource.com/1112064Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569769}
-
Mathieu Perreault authored
The chrome-search://ntpicon source will always return an image that is 40dp: either the local favicon (16dp) drawn in the middle of a circle, or a fallback letter in a circle. This simplifies the css and addresses a potential privacy concern. Bug: 853780 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1eccb79f79ce03434e5af78b48a4ae1ed6fe836f Reviewed-on: https://chromium-review.googlesource.com/1111912Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569768}
-
mark a. foltz authored
A spec change requires that URLs with unknown schemes be ignored by the PresentationRequest ctor, to improve interoperability for vendor-specific schemes. This updates the implementation and adds tests for Blink-specific custom schemes. Bug: 825927 Change-Id: I15c72e54c1c44fa1a12139b6c01e2e460d079310 Reviewed-on: https://chromium-review.googlesource.com/1100488Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569767}
-
Dmitry Guketlev authored
String.fromCharCode function fails on long buffers, so it's better to use TextDecoder api here, which can handle long buffers easely. Bug: 480099 Change-Id: I80ce5f39924def4c81577abb5032bdee15b6567d Reviewed-on: https://chromium-review.googlesource.com/1082991 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569766}
-
Kyle Horimoto authored
The SetAccountStatusChangeDelegate() function previously fired a callback after the delegate was set, but that was unnecessary. All of the clients of the function simply passed base::DoNothing() anyway. This CL removes that unnecessary callback. Bug: 824568 Change-Id: Iea3e6e0c85eedb6e3cfcb0147b81e433cc5babac Reviewed-on: https://chromium-review.googlesource.com/1110600 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569765}
-
Lei Zhang authored
Change-Id: I4a325218a3db80731e1a110e1beab38ecc071530 Reviewed-on: https://chromium-review.googlesource.com/1111678Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569764}
-
Orin Jaworski authored
When multiple tabs are selected, tabs other than the active selected tab are made more opaque to mark selection, but the old opacity of 0.3 was virtually unnoticeable so is here increased. Bug: 848416 Change-Id: I3b833808a77a11b29c00f69f3827c1a60d3f0eb9 Reviewed-on: https://chromium-review.googlesource.com/1112433Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#569763}
-
Mustafa Emre Acer authored
This CL moves decoding code for preloaded data (e.g. HSTS) under net/extras/preload_data so that it can be reused. A future CL will use the net::extras::PreloadDecoder class to extract top 10K domain information from a preloaded data set. Bug: 843361 Change-Id: I3026feaa9034f9c5d09232ea1d43cf1e69c48939 Reviewed-on: https://chromium-review.googlesource.com/1098311Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#569762}
-
Kevin McNee authored
This is to investigate why |last_mouse_move_target_ != last_mouse_move_root_view_| does not guarantee that |last_mouse_move_target_| is a child. Bug: 851958 Change-Id: Ibe2f7aed89d83fa55dbc26af8bf995cd4fce049f Reviewed-on: https://chromium-review.googlesource.com/1112478Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#569761}
-
Quan Nguyen authored
Bug: 836861 Change-Id: I6ac30f0e187750b55cd7f14bd39f5d477497c003 Reviewed-on: https://chromium-review.googlesource.com/1109208 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569760}
-
Ryan Tseng authored
Theres's a working theory that it's just a bad bot. run 2 bots concurrently and check results. Bug: 855396 Change-Id: I44da7322a5302b7d571eff3eb768f926c5cad9c7 Reviewed-on: https://chromium-review.googlesource.com/1112065Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569759}
-
Sebastien Marchand authored
Bug: 773383 Change-Id: Ib67d9922a1fa05074c4036e92c3feddbb00849ce Reviewed-on: https://chromium-review.googlesource.com/1103791 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569758}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a49103801e3..9fff1c76c108 git log 0a49103801e3..9fff1c76c108 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 tsepez@chromium.org Avoid some duplicate const/non-const getters. 2018-06-22 hnakashima@chromium.org Fix overflow in CFX_RenderDevice::DrawFillStrokePath(). Created with: gclient setdep -r src/third_party/pdfium@9fff1c76c108 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853430 TBR=dsinclair@chromium.org Change-Id: I80e5560f05738ff3bc26b3d9d6783621908fe281 Reviewed-on: https://chromium-review.googlesource.com/1112218Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569757}
-
W. James MacLean authored
This CL contains a mitigation for the null pointer dereference that is at the root of the associated bug. Once this mitigation is confirmed, we'll request a merge to M-68. TBR=bokan@chromium.org Bug: 845097 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfffdbe95c5d3b0e340c053f71056d88d75af3ac Reviewed-on: https://chromium-review.googlesource.com/1112483Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#569756}
-
Nico Weber authored
Bug: 855584 Change-Id: I855566a5a9db76b68f2b182ca95b9617c81a6822 Reviewed-on: https://chromium-review.googlesource.com/1112476Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569755}
-
Kyle Horimoto authored
This CL: (1) Initializes the SetupFlowCompletionRecorder and AccountStatusChangeDelegateNotifier classes when the service starts up. Previously, they were not actually integrated into the service. (2) Adds a MultiDeviceSetupInitializer class which initializes the service by waiting until the DeviceSyncClient has loaded the local remote device before continuing. This task must complete before AccountStatusChangeDelegateNotifier is created as that class assumes that the client has been fully initialized. (3) Adjusts ProfileImpl to pass various parameters to the service which are required for the initialization described above. Bug: 824568 Change-Id: I09240f00d29cd44e2768e3068b3284abe16b3801 Reviewed-on: https://chromium-review.googlesource.com/1110953Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569754}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ibbb0b3e981bb7c21a7022ca7b72f2c28e6b70f06 Reviewed-on: https://chromium-review.googlesource.com/1112349Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#569753}
-
Alexei Svitkine authored
Previously, it would clobber state when going out of scope, which is undesirable. Bug: 854812 Change-Id: I2fd2859b28eed5e8247361da3b105068b348813b Reviewed-on: https://chromium-review.googlesource.com/1112481Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569752}
-
Scott Violet authored
And this also changes ws2 to only stop cancelable events. To do otherwise triggers a CHECK in Event. BUG=837686 TEST=covered by tests Change-Id: I6bc3d8b6a02eda1ecf7b7aecec6729a9ef7b1a2e Reviewed-on: https://chromium-review.googlesource.com/1111268 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#569751}
-
Jennifer Apacible authored
These strings will be used for the dialog that appears when the user: - is closing the tab or window that initiated a Picture-in-Picture session, or - is navigating away from a page that initiated a Picture-in-Picture session. Dialog implementation is in progress. Bug: 809982 TBR: grt@chromium.org Change-Id: I060fb2f21fc93361aeb11f4b605b5012d369e28c Reviewed-on: https://chromium-review.googlesource.com/1112304 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569750}
-
inglorion authored
Updates some commands to run try jobs that have moved to LUCI, and adds linux_chromium_chromeos_msan_rel_ng. Change-Id: I9048da9f6dcb897b5125183d3f66b5995e740de8 Reviewed-on: https://chromium-review.googlesource.com/1112347 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569749}
-
Bo Liu authored
There is evidence that android is oom killing strong binding processes while there are still processes with lower importance bindings. So add an UMA to explicit track this. Keep an int array of counts of each binding state in ChildProcessConnection. Also take this opportunity to properly add a lock for cross-thread access. Then pass the counts up through ChildProcessTerminationInfo and CrashDumpObserver::TerminationInfo. The new UMA only records the counts as bools, but can add a histogram of counts later if needed. Bug: 855037 Change-Id: I6c6fe8828d1e571b2fd8fb2404f124377bd19752 Reviewed-on: https://chromium-review.googlesource.com/1108750Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#569748}
-
Niklas Hambüchen authored
Before 0.5, render strings looked like this: Gallium 0.4 on llvmpipe (LLVM 4.0, 256 bits) now they look like this: llvmpipe (LLVM 5.0, 256 bits) Change the regex accordingly to avoid accidentally not matching the llvmpipe renderer string. Bug: 854437 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I14a7a7631880b2dcfcd3af5eeb6c01d5be32edb6 Reviewed-on: https://chromium-review.googlesource.com/1108216 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569747}
-
Eric Stevenson authored
Change-Id: I5fb983c8f31a1b548b4776588e46f49bf5d0aa80 Reviewed-on: https://chromium-review.googlesource.com/1112062Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569746}
-