GitLab

Html viewer is hitting a NOTREACHED due to a missing resource.
Added logging for the resource name so that it can be tracked.

Review URL: https://codereview.chromium.org/1007913002

Cr-Commit-Position: refs/heads/master@{#320759}

BUG=none

Review URL: https://codereview.chromium.org/1014623003

Cr-Commit-Position: refs/heads/master@{#320758}

BUG=466196
TEST=/tools/perf/run_benchmark --browser system gpu_times.gpu_rasterization.top_25_smooth --reset-results --page-filter=Maps

Review URL: https://codereview.chromium.org/1013443002

Cr-Commit-Position: refs/heads/master@{#320757}

This is required for OSS licensing compliance.

BUG=462636
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1012673005

Cr-Commit-Position: refs/heads/master@{#320756}

Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1007293002/)

Reason for revert:
This test is a victim of a bigger issue of main renderer message loop being used after it is deleted. Details are in crbug.com/467369.

I've also run the test with ASAN locally and didn't reproduce after a few runs.

Original issue's description:
> Disable a test that fails under ASan and MSan
>
> It can be flaky in other configurations as well
>
> BUG=467483
> TBR=nasko
>
> Committed: https://crrev.com/992ff715f61e90562983139ac31392b72e716822
> Cr-Commit-Position: refs/heads/master@{#320713}

TBR=timurrrr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467483

Review URL: https://codereview.chromium.org/1018443002

Cr-Commit-Position: refs/heads/master@{#320755}

Adding an easy(ier) to use tool to start legion-based tests. This tool handles all of the isolate archives, building the test controller command line, and running the test controller.

BUG=467618

Review URL: https://codereview.chromium.org/1006383004

Cr-Commit-Position: refs/heads/master@{#320754}

This means each toolchain can declare arguments as it sees fit. Prior to this change each toolchain needed to declare the argument at exactly the same place, which is not always possible. For example, the following triggered an error:

declare_args() {
  foo = 1
  if (xxx) {
    foo = 2
  }

with xxx being specific to one toolchain.

TEST=covered by test
BUG=465029
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/984353002

Cr-Commit-Position: refs/heads/master@{#320753}

R=gunsch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1007413002

Cr-Commit-Position: refs/heads/master@{#320752}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3675874..fdc3108

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/996103004

Cr-Commit-Position: refs/heads/master@{#320751}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/1015463002

Cr-Commit-Position: refs/heads/master@{#320750}

This disallows standalone {} blocks. Fortunately, we did not use these in
the Chrome build.

This eliminates the ambiguity of whether foo("bar") {} is a function that takes
a block (like a target definition) or a standalone function followed by a
standalone block.

Previously we would put the block on the function if a function preceeded it,
or keep the block standalone if there wasn't a function. Additionally,
functions that weren't expecting a block would silently ignore it, which
produced some weird cases.

This additionally adds checks for functions that don't expect blocks.

BUG=434519
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1007963003

Cr-Commit-Position: refs/heads/master@{#320749}

98cca0e5fcb4 compat/mac: SDK compatibility for pre-Xcode 4.2 10.6 SDK
82bebb11de69 Update man pages

TBR=rsesek@chromium.org,dcastagna@chromium.org

Review URL: https://codereview.chromium.org/1011743004

Cr-Commit-Position: refs/heads/master@{#320748}

BUG=427616

Review URL: https://codereview.chromium.org/1010633002

Cr-Commit-Position: refs/heads/master@{#320747}

This reverts commit ee5ad4b1.

Was causing asserts in webkit_unit_tests, e.g.,

[ RUN      ] DeferredImageDecoderTest.drawIntoSkPicture
Received signal 11 SEGV_MAPERR 000000000000

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/45563

BUG=
TBR=reveman

Review URL: https://codereview.chromium.org/1009413002

Cr-Commit-Position: refs/heads/master@{#320746}

This includes data from other net-internals tabs and from pending
URLRequests.  This also changes the semantices of NetLogLogger so
that it takes the input file in StartObserving and closes it in
StopObserving, to make thread restrictions when using the new
capability a little simpler.

This CL also fixes a number of cases where StopObserving either wasn't
being called, or was being called incorrectly by consumers.

BUG=426918

Review URL: https://codereview.chromium.org/976483002

Cr-Commit-Position: refs/heads/master@{#320745}

BUG=444697

Review URL: https://codereview.chromium.org/1007583002

Cr-Commit-Position: refs/heads/master@{#320744}

BUG=NONE

Review URL: https://codereview.chromium.org/1003953007

Cr-Commit-Position: refs/heads/master@{#320743}

R=lcwu@chromium.org,maclellant@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1012793003

Cr-Commit-Position: refs/heads/master@{#320742}

BUG=418375

Review URL: https://codereview.chromium.org/1012483002

Cr-Commit-Position: refs/heads/master@{#320741}

TBR=bbudge@chromium.org
BUG=738729

Review URL: https://codereview.chromium.org/1011783003

Cr-Commit-Position: refs/heads/master@{#320740}

Can't post a task with a ref-counted instance of the watcher from the
destructor.

BUG=467170

Review URL: https://codereview.chromium.org/1006403002

Cr-Commit-Position: refs/heads/master@{#320739}

Move FaviconService and FaviconHandler into //components/favicon/core/browser
as they have no problematic dependencies anymore.

Update DEPS and dependencies of favicon component.

BUG=359514,359513

Review URL: https://codereview.chromium.org/983043003

Cr-Commit-Position: refs/heads/master@{#320738}

This implements support for in-process discardable
memory. Each in-process discardable memory instance is
associated with a discardable shared memory segment. This
is hopefully efficient enough with the limited use of
discardable memory in the browser process.
DiscardableSharedMemoryHeap can be used if this is not
enough.

This also moves the test implementation of the discardable
memory allocator into a TestDiscardableMemoryShmemAllocator
class and requires tests that use discardable memory to
explicitly use this test allocator. Browser tests uses the
real discardable memory allocator.

BUG=422953,463250

Review URL: https://codereview.chromium.org/1004043002

Cr-Commit-Position: refs/heads/master@{#320737}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1e23738..3675874

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012773002

Cr-Commit-Position: refs/heads/master@{#320736}

Root-case of the issue is that GTMCopyLaunchdExports does
not work on 10.10, so we can't resolve socket name
generated for SecureSocketWithKey.

Socket provided by SecureSocketWithKey was used for:
1. Communicate with service from browser.
This solved by using predefined socket name known to browser
and service. Socket just needs to be unique for user_data_dir.
Similar approach is used on Linux.

2. Start temporarily .plist file during service registration.
No we can start just using RunAtLoad.

BUG=428369, 466644

Review URL: https://codereview.chromium.org/982883003

Cr-Commit-Position: refs/heads/master@{#320735}

This flag is not used.
Instead, SetChildrenNeedBeginFrames() will be used to control child compositor's
frame scheduling.

R=brianderson@chromium.org
BUG=467416
TEST=cc_unittests

Review URL: https://codereview.chromium.org/1010623002

Cr-Commit-Position: refs/heads/master@{#320734}

BUG=462294

Review URL: https://codereview.chromium.org/1011753003

Cr-Commit-Position: refs/heads/master@{#320733}

BUG=

Review URL: https://codereview.chromium.org/1012683003

Cr-Commit-Position: refs/heads/master@{#320732}

BUG=466884

TBR=sky@chromium.org for renderer_resources.grd

Review URL: https://codereview.chromium.org/1004233002

Cr-Commit-Position: refs/heads/master@{#320731}

We still only track the main frame and do not share FNEs across
NavigationEntries, but this new TreeNode class will make it possible
to track them for subtrees and share them across entries of a tab.

BUG=236848
TEST=Existing Navigation{Controller,Entry} tests pass.

Review URL: https://codereview.chromium.org/1006693002

Cr-Commit-Position: refs/heads/master@{#320730}

BUG=467528
TBR=hcarmona@chromium.org

Review URL: https://codereview.chromium.org/1013673002

Cr-Commit-Position: refs/heads/master@{#320729}

The old WebSocket implementation did not correctly ignore trailing
whitespace on response headers.

This test ensures that the issue does not regress in the new
implementation.

BUG=180504
TEST=net_unittests

Review URL: https://codereview.chromium.org/1001353002

Cr-Commit-Position: refs/heads/master@{#320728}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/19c25f1..1e23738

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012673003

Cr-Commit-Position: refs/heads/master@{#320727}

BUG=none
TEST=none
R=jamesr@chromium.org, qsr@chromium.org

Review URL: https://codereview.chromium.org/1002033004

Cr-Commit-Position: refs/heads/master@{#320726}

BUG=467529

Review URL: https://codereview.chromium.org/1006333002

Cr-Commit-Position: refs/heads/master@{#320725}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1ab2b16..cb8017b

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1009893002

Cr-Commit-Position: refs/heads/master@{#320724}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b04b0ead..1462eb64

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1007303002

Cr-Commit-Position: refs/heads/master@{#320723}

BUG=466598

Review URL: https://codereview.chromium.org/1003113003

Cr-Commit-Position: refs/heads/master@{#320722}

Many methods in PasswordStore and its backends have a ScopedVector of password forms as an out-argument, into which they put retrieved credentials.
Ideally, those methods would return that vector instead, but that is often not possible, because they already return a bool flag of success.
Keeping the out-argument has one bad consequence: it is not clear, if the retrieved credentials are appended to the vector, or if they replace the contents of the vector.

It looks like those methods are fed empty vectors anyway, so it is natural to make that explicit. This CL adds comments stating that the vectors are erased before anything new is added to them, and also modifies the code to make sure that they are indeed erased, even in failure cases.

The CL also contains some related clean-ups, like moving static methods to anonymous namespace etc.

BUG=324291

Review URL: https://codereview.chromium.org/906973007

Cr-Commit-Position: refs/heads/master@{#320721}

This CL adds handling of the PageActionNotSupported exception for the
test to pass on systems with older browser versions, which does not
support drag gesture yet.

BUG=467090

Review URL: https://codereview.chromium.org/1007953002

Cr-Commit-Position: refs/heads/master@{#320720}