GitLab

The detail view for extensions includes a button to open the extension's
home page (which defaults to the webstore page if an extension doens't
specify one). Hook this up, and add a test.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2522303002
Cr-Commit-Position: refs/heads/master@{#434854}

BUG=667208

Review-Url: https://codereview.chromium.org/2527913002
Cr-Commit-Position: refs/heads/master@{#434853}

Moving milestone to M58.

BUG=605661
TEST=messages logged with EME layout tests

Review-Url: https://codereview.chromium.org/2539573002
Cr-Commit-Position: refs/heads/master@{#434852}

Looks like a possible C&P error.  Compile-tested only.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Review-Url: https://codereview.chromium.org/2540513003
Cr-Commit-Position: refs/heads/master@{#434851}

//base's MRUCache allowed specifying key and value types, like
an underlying std::map<>, but the default base::MRUCache explicitly
specialized the comparator as std::less<>. Rather than require the
caller to overload std::less<> or operator<, allow the comparator
to be specified as a templated argument.

BUG=665735

Review-Url: https://codereview.chromium.org/2532313002
Cr-Commit-Position: refs/heads/master@{#434850}

Adding getCoalescedEvents API to the idl file
of PointerEventInit and getter method to
PointerEvent idl.
Also add the plumbing and creation in EventHandler
layer and PointerEventManager.

BUG=665937

Review-Url: https://codereview.chromium.org/2510133002
Cr-Commit-Position: refs/heads/master@{#434849}

This patch makes |Range::extractContents()| to postpone DOM mutation event
dispatching just before returning value rather than updating C++ variables
which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(),
Node::removeChild(), etc., to avoid running JavaScript code during in
|extractContents()| for simplicity.

For executing script in |RangeTest|, this patch makes |RangeTest| class to
derived from |EditingTestBase|.

This patch removes
"fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes
script error by calling |Range#getBoundingClientRect()| with |null| value and
coverage of this test is as same as newly added gTest.

This patch is similar to http://crrev.com/199383004 which makes
|Range::deleteContents()| to postpone DOM mutation event.

BUG=642537
TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent

Review-Url: https://codereview.chromium.org/2532843002
Cr-Commit-Position: refs/heads/master@{#434848}

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2530483002
Cr-Commit-Position: refs/heads/master@{#434847}

As they evolved to be quite different and the amount of
common code is minimal, it just make sense to define
which member function is used to render borders and which
is used for backgrounds.

BUG=662504

Review-Url: https://codereview.chromium.org/2536883002
Cr-Commit-Position: refs/heads/master@{#434846}

UpdaterState::GetState returns nullptr, if the current platform is
not Windows, and then the test calls at() method on the returned map.

This fixes LTO Linux bot:
https://build.chromium.org/p/chromium.fyi/builders/LTO%20Linux/builds/1560

BUG=615187

Review-Url: https://codereview.chromium.org/2536723004
Cr-Commit-Position: refs/heads/master@{#434845}

This patch makes CompositeEditCommand::moveParagraphs abort in the above
mentioned case, because there is no way to move the contents to a destination
inside itself.

There might be a deeper cause of passing such invalid parameter combination
to the function, which is not covered by this patch.

BUG=585048
TEST=webkit_unit_tests --gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML

Review-Url: https://codereview.chromium.org/2531263002
Cr-Commit-Position: refs/heads/master@{#434844}

Changes the VR Shell unittests to compile when WebVR is enabled and enables
them on chromium.android builders.

BUG=667964

Review-Url: https://codereview.chromium.org/2521883003
Cr-Commit-Position: refs/heads/master@{#434843}

This CL pulls out the content on writing LayoutTests from
layout_tests.md, and does a significant overhaul of it.

BUG=665494

Review-Url: https://codereview.chromium.org/2492733003
Cr-Commit-Position: refs/heads/master@{#434842}

Previously, the icon fill color was gray. This change restores it to
white, as the specs indicate.

BUG=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2528263003
Cr-Commit-Position: refs/heads/master@{#434841}

This test harness is slowing us down, so we are migrating away from it.

BUG=none

Review-Url: https://codereview.chromium.org/2533073003
Cr-Commit-Position: refs/heads/master@{#434840}

Earlier this year the default browser infobar icon was changed to a
stylized blue Chrome icon. This cl, per rpop@, reverts the icon to its
original full-color version.

R=sky@chromium.org
BUG=654340

Review-Url: https://codereview.chromium.org/2537453004
Cr-Commit-Position: refs/heads/master@{#434839}

BUG=668321

Review-Url: https://codereview.chromium.org/2534053002
Cr-Commit-Position: refs/heads/master@{#434838}

BUG=667644

Review-Url: https://codereview.chromium.org/2530253002
Cr-Commit-Position: refs/heads/master@{#434837}

https://pdfium.googlesource.com/pdfium.git/+log/3c0f366daafe..405ac0f09e16

$ git log 3c0f366da..405ac0f09 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 tsepez Use CFX_MaybeOwned<> in fpdf_edit_create.cpp

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2534063002
Cr-Commit-Position: refs/heads/master@{#434836}

Setting the testing build time ensures that the test passes even if the
system clock is incorrect when running the test.

BUG=668539

Review-Url: https://codereview.chromium.org/2532273003
Cr-Commit-Position: refs/heads/master@{#434835}

Only Chrome OS and Windows can choose the language.

BUG=619771
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2528843002
Cr-Commit-Position: refs/heads/master@{#434834}

Implements the "spec" provided as faithfully as makes sense.  This
usually means that values are rounded to the nearest multiple of 8,
but I had to get creative with the definition of the padding above
the "X GB downloaded" TextView because of how Android deals with
top padding for text.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3QTVELWVhSFlHajQ/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZDczcV9aZ0ctLWs/view?usp=sharing

BUG=658246

Review-Url: https://codereview.chromium.org/2540583002
Cr-Commit-Position: refs/heads/master@{#434833}

This CL adds a separator above the sticky header rows when those rows
are not at the top of the list. The visible separator line is drawn by
this separator and is no longer a part of the sub-section header row.
The sticky row decoration is adjusted such that a separator is painted
only when one header is pushing another since in all other cases the
explicitly added separator is painting the line.
Since VPN page is not using sticky headers yet some special treatment
is added there to adjust the height of the header row when it is the
first item in the list.

BUG=668545
TEST=Manual visual inspection

Review-Url: https://codereview.chromium.org/2530763002
Cr-Commit-Position: refs/heads/master@{#434832}

Before this CL, OnMemoryStateChange() only handles "purge" part
of purge+suspend mechanism. Handle "suspend" part as well.

BUG=617492

Review-Url: https://codereview.chromium.org/2529833002
Cr-Commit-Position: refs/heads/master@{#434831}

The Hotword/OK Google section in the existing UI is... fragile.
This is an attempt to simplify and implement the UI without breaking
any existing functionality.
It would benefit from a re-implementation, ideally ising the
existing hotwordingPrivate API (which would may need to be expanded).

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2507363002
Cr-Commit-Position: refs/heads/master@{#434830}

Multisampled render to texture appears to be broken on Android 7.1 and
Adreno 5xx, similar to issues reported in Android < 7.0. This is fixed
in 7.1.1.

We should confirm that this is working in 7.0 if possible. The device
where this issue was reported (Pixel XL / Pixel) didn't ship with 7.0.

This issue appears to result in multisampled rendering failing to
produce output in cases when rendering to a texture that has already
been used in a previous render pass.

BUG=663811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2514283002
Cr-Commit-Position: refs/heads/master@{#434829}

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.

Review-Url: https://codereview.chromium.org/2520753002
Cr-Commit-Position: refs/heads/master@{#434828}

Couple minor visual tweaks to the Add Word row; see screenshots at
https://crbug.com/630982#17.

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2525003006
Cr-Commit-Position: refs/heads/master@{#434827}

BUG=667779,667797

Review-Url: https://codereview.chromium.org/2539583002
Cr-Commit-Position: refs/heads/master@{#434826}

No change in functionality. Expectation lines adjusted to make
ownership clear.

TBR=chrishtr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2535103002
Cr-Commit-Position: refs/heads/master@{#434825}

AMD drivers do not correctly handle the pattern of DX calls generated
by ANGLE for glTexStorage2DExt. We've worked around the known
problematic case in crrev.com/2507963003, so this change removes the
GPU raster blacklist.

It's possible that this issue is still hittable from Skia, and likely
from WebGL2, so it makes sense to try to work around this in ANGLE or
to blacklist glTexStorage2DExt.

Unfortunately, the ANGLE code in this area is quite complex, and a
workaround is a ways out. Additionally, there's no way to disable
glTexStorage2DExt without losing all of WebGL2, which seems non-ideal.

BUG=660897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2521803002
Cr-Commit-Position: refs/heads/master@{#434824}

This adds the SHA-256 of the RSA key that we use to sign CRX packages on
Chrome.

BUG=630420

Review-Url: https://codereview.chromium.org/2509293003
Cr-Commit-Position: refs/heads/master@{#434823}

Follow-up to r433964 to change IndexedDBCallbacks to take its
IndexedDBDispatcherHost argument as a scoped_refptr as suggested by
dcheng@.

BUG=None

Review-Url: https://codereview.chromium.org/2521903004
Cr-Commit-Position: refs/heads/master@{#434822}

Removes DataGrid's hasChildren getter and setters and replaces them with
respective function calls for get and set.

R=dgozman
BUG=None

Review-Url: https://codereview.chromium.org/2536723003
Cr-Commit-Position: refs/heads/master@{#434821}

Reland of Post tasks for sensitive input visibility notifications (patchset #1 id:1 of https://codereview.chromium.org/2531683002/ )

Reason for revert:
Fixing SecuritySTateTabHelperTests

Original issue's description:
> Revert of Post tasks for sensitive input visibility notifications (patchset #5 id:80001 of https://codereview.chromium.org/2515373003/ )
>
> Reason for revert:
> Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10
>
> E.g.
> SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
> SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch
>
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/24682
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/9716
>
> Errors like
>
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
> Value of: security_info.security_level
>   Actual: 0
> Expected: security_state::HTTP_SHOW_WARNING
> Which is: 1
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
> Value of: entry->GetSSL().content_status & content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
>   Actual: false
> Expected: true
>
> Original issue's description:
> > Post tasks for sensitive input visibility notifications
> >
> > If password inputs are hidden and shown multiple times in the same task
> > (as apparently happens when processing a stylesheet), we don't want to
> > the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> > input visibility notifications to the end of the task queue, so that the
> > omnibox warning updates get coalesced.
> >
> > BUG=664194
> > TEST=Visit http://http-password.badssl.com and observe that the omnibox
> > warning does not flicker in and out twice.
> >
> > Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> > Cr-Commit-Position: refs/heads/master@{#434340}
>
> TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664194
>
> Committed: https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
> Cr-Commit-Position: refs/heads/master@{#434400}

TBR=dcheng@chromium.org,haraken@chromium.org,tapted@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664194

Review-Url: https://codereview.chromium.org/2538473002
Cr-Commit-Position: refs/heads/master@{#434820}

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837

Review-Url: https://codereview.chromium.org/2514323008
Cr-Commit-Position: refs/heads/master@{#434819}

Previously TriView child views would be allocated their preferred size
during the TriView layout.  However, if a child view's preferred size
later changed it did not trigger a TriView layout and the child view
would not be allocated space based on its new preferred size.

This change fixes it so that a TriView's child will be reallocated space
if its preferred size changes. This will not cause the TriView
container views to be resized when a child views preferred size changes.

BUG=667955
TEST=ash_unittests --gtest_filter=TriViewTest.ChildViewsPreferredSizeChanged

Review-Url: https://codereview.chromium.org/2538513002
Cr-Commit-Position: refs/heads/master@{#434818}

FontFetcherMojoImplUnittest used to just create the impl object directly
and fire methods at it. In this change, we use the mojo services
framework for service binding and communication.

BUG=

Review-Url: https://codereview.chromium.org/2534033002
Cr-Commit-Position: refs/heads/master@{#434817}

BUG=615242
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2518763002
Cr-Commit-Position: refs/heads/master@{#434816}

d8b550c7 introduced a JNI wrapper for
base::UnguessableToken. This change uses the wrapper to send parcelled
tokens when fulfilling a ScopedSurfaceRequest, instead of two jlongs.

BUG=
TEST= verified we could still play HLS.

Review-Url: https://codereview.chromium.org/2535923003
Cr-Commit-Position: refs/heads/master@{#434815}