GitLab

This CL is to build the libshared_memory_support_nacl.a for nacl_helper_nonsfi.
The library is not used yet, but will be used soon in following CLs.
Also, it should be built successfully now.

BUG=358465
TEST=Ran trybots. Implement nacl_helper_nonsfi on top of this CL, and made sure it works.

Review URL: https://codereview.chromium.org/656063003

Cr-Commit-Position: refs/heads/master@{#300459}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/671513005

Cr-Commit-Position: refs/heads/master@{#300458}

This change expands the example policy value to demonstrate how bookmark
folders can be configured.

BUG=424181

Review URL: https://codereview.chromium.org/658393002

Cr-Commit-Position: refs/heads/master@{#300457}

BUG=417463
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/666133002

Cr-Commit-Position: refs/heads/master@{#300456}

BUG=NONE

Review URL: https://codereview.chromium.org/658413002

Cr-Commit-Position: refs/heads/master@{#300455}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/666733003

Cr-Commit-Position: refs/heads/master@{#300454}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=tzik@chromium.org

Review URL: https://codereview.chromium.org/666143002

Cr-Commit-Position: refs/heads/master@{#300453}

The media player now won't seek after load when there is no actual
pending seek.

BUG=420645

Review URL: https://codereview.chromium.org/654203005

Cr-Commit-Position: refs/heads/master@{#300452}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/663333002

Cr-Commit-Position: refs/heads/master@{#300451}

BUG=413621

Review URL: https://codereview.chromium.org/662353002

Cr-Commit-Position: refs/heads/master@{#300450}

Tested with chrome://histograms and verified that values from webrtc propagated to histograms.

BUG=419657

Review URL: https://codereview.chromium.org/609353002

Cr-Commit-Position: refs/heads/master@{#300449}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/669603008

Cr-Commit-Position: refs/heads/master@{#300448}

BUG=417463
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/668783004

Cr-Commit-Position: refs/heads/master@{#300447}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/667923002

Cr-Commit-Position: refs/heads/master@{#300446}

eglCreateWindowSurface() in mesa egl driver needs mincore() system call, so
allow gpu process to call mincore().

BUG=423674

Review URL: https://codereview.chromium.org/656023003

Cr-Commit-Position: refs/heads/master@{#300445}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7a9281..b312e40

TBR=aboxhall@chromium.org,kochi@chromium.org

Review URL: https://codereview.chromium.org/649683008

Cr-Commit-Position: refs/heads/master@{#300444}

BUG=417463
TBR=sorin@chromium.org

Review URL: https://codereview.chromium.org/663323002

Cr-Commit-Position: refs/heads/master@{#300443}

BUG=417463
TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/668903002

Cr-Commit-Position: refs/heads/master@{#300442}

BUG=417463
TBR=vsevik@chromium.org

Review URL: https://codereview.chromium.org/669873002

Cr-Commit-Position: refs/heads/master@{#300441}

BUG=417463
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/648653003

Cr-Commit-Position: refs/heads/master@{#300440}

BUG=417463
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/645853008

Cr-Commit-Position: refs/heads/master@{#300439}

On Linux, we have keys with keycode=VKEY_UNKNOWN, for example, ISO_LEVEL3_LATCH key.  We have to emit keydown/up events appropriately even if keycode=VKEY_UNKNOWN.

Just FYI: Firefox also fires keyevents with keycode=0, so the behavior will be compatible.  Compared to IE and Chrome on Windows, it's still compatible because there is no such key as ISO_LEVEL3_LATCH, etc. on Windows.

BUG=402320
TEST=Done manually.

Review URL: https://codereview.chromium.org/665863002

Cr-Commit-Position: refs/heads/master@{#300438}

BUG=425034

Review URL: https://codereview.chromium.org/669593002

Cr-Commit-Position: refs/heads/master@{#300437}

Depends on https://codereview.chromium.org/474013004.

BUG=415074

Review URL: https://codereview.chromium.org/577943002

Cr-Commit-Position: refs/heads/master@{#300436}

Currently when pdf is scaled to fit to page mode, both page down and
page up keys do not move pdf by page size. This is because both
the keys are not handled in HandleInputEvent().

This patch updates HandleInputEvent() to factor in key codes for
page up and page down to move pdf by page size in fit to page mode.
Similar to left and right arrow keys.

BUG=390599

Review URL: https://codereview.chromium.org/573523002

Cr-Commit-Position: refs/heads/master@{#300435}

Oooh. I am stupid, and I have no idea how this compiled. :)

BUG=420994
TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/660473003

Cr-Commit-Position: refs/heads/master@{#300434}

BUG=339101

Review URL: https://codereview.chromium.org/637243004

Cr-Commit-Position: refs/heads/master@{#300433}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/659943004

Cr-Commit-Position: refs/heads/master@{#300432}

BUG=397019

Review URL: https://codereview.chromium.org/658393003

Cr-Commit-Position: refs/heads/master@{#300431}

This bug is introduced by https://codereview.chromium.org/647953003.
The error status must be passed to script_cache_map.
It will be checked in ServiceWorkerRegisterJob::OnStartWorkerFinished() and use to handle the error in JS.

BUG=425430
TBR=dmurph

Review URL: https://codereview.chromium.org/663293004

Cr-Commit-Position: refs/heads/master@{#300430}

BUG=397019

Review URL: https://codereview.chromium.org/647083003

Cr-Commit-Position: refs/heads/master@{#300429}

BUG=404355

Review URL: https://codereview.chromium.org/661423002

Cr-Commit-Position: refs/heads/master@{#300428}

This feature is in active development.

BUG=224781

Review URL: https://codereview.chromium.org/671533003

Cr-Commit-Position: refs/heads/master@{#300427}

In continuation of the CL https://codereview.chromium.org/589113002/
this CL removes deprecated class WebContentsObserverAndroid and
cleans up existing usage of this class where ever it is occured.

This patch will be landed when external repositories has renamed
WebContentsObserverAndroid to WebContentsObserver

BUG=396118

Review URL: https://codereview.chromium.org/650333003

Cr-Commit-Position: refs/heads/master@{#300426}

BUG=chromedriver:946
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/667823003

Cr-Commit-Position: refs/heads/master@{#300425}

In the current implementation, the helper function DoMakePathAbsolute
may rewrite the input even in the case of failure,
which makes the warning log less readable.

BUG=none
TEST=./chrome --app --app-id=someapp --enable-logging=stderr non/existing/path

Review URL: https://codereview.chromium.org/665053002

Cr-Commit-Position: refs/heads/master@{#300424}

The CL does the following things:

1. Add GesturePropertyProvider which parses xorg-conf files under
/etc/gesture/ upon chrome starts and sets the property values according
to the device touchpad/mouse type and the file content.

2. Provides GesturesPropProvider APIs so that libgesture can expose
its property values and allow Chrome to access it.

Contributed by sheckylin@chromium.org

BUG=400022
TEST=link_freon ChromeOS build
put appropriate xorg-conf files under /etc/gesture
restart chrome and check that:
1. the property values get loaded by manually logging.
2. the touchpad gesture is now smoother than before.

Review URL: https://codereview.chromium.org/545063006

Cr-Commit-Position: refs/heads/master@{#300423}

Previously, the Service class was responsible for saving and restoring state,
as well as managing file systems. Testing it became problematic.

This patch separates it into two classes Service and Registry, which can
be both tested separately.

TBR=pam@chromium.org
TEST=unit_tests: *FileSystemProvider*Registry*
BUG=248427

Review URL: https://codereview.chromium.org/661393002

Cr-Commit-Position: refs/heads/master@{#300422}

* We've moved application_runner_chromium.
* None of the header files should include .../cpp/utility (in
  particular, use RunLoop), since the implementations are meant to be
  replaceable (e.g., by a "Chromium" implementation).
* Allow the implementation of ApplicationRunner to use RunLoop. (We
  could allow it for everything in .../cpp/application/lib, but none of
  the other things need RunLoop, hence don't need to be replaced.)

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/665223002

Cr-Commit-Position: refs/heads/master@{#300421}

Using the tile-size for the tile-grid-size isn't effective, since
these have different scales etc.

This patch adds a new setting such that we can start to tune this
independantly of other settings.

BUG=365877

Review URL: https://codereview.chromium.org/666573002

Cr-Commit-Position: refs/heads/master@{#300420}