- 29 Jan, 2020 40 commits
-
-
Owen Min authored
Don't show any notification when the policy is disable and close any exist notification. Re-show the notification once the policy is enabled again. Bug: 1006899 Change-Id: I4fa530890d1be26ef17bfd56d81216444b381a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025828Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736389}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7fade5738e7..26b4cb3fc56c git log d7fade5738e7..26b4cb3fc56c --date=short --first-parent --format='%ad %ae %s' 2020-01-29 danilchap@webrtc.org Detach RtpFrameReferenceFinder from RtpGenericFrameDescriptor 2020-01-29 eshr@google.com Remove task_queue dependency for QualityScaler 2020-01-29 ivoc@webrtc.org Expose run function to NetEqSimulator 2020-01-29 danilchap@webrtc.org Pass and store PacketBuffer::Packet by unique_ptr Created with: gclient setdep -r src/third_party/webrtc@26b4cb3fc56c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7f46cfbd876310310e06459c530262046a6eb4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027748Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736388}
-
Yuki Shiino authored
Bug: 1035171 Change-Id: Idb771d4dc8052733559f883ba59a05bfe487e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027767Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736387}
-
David Van Cleve authored
I wasn't able to see my LOG(INFO) output when running the test binary with `logcat -v` added, but a colleague suggested `adb logcat`, which worked. This CL updates the Android debugging docs to suggest `adb logcat` for viewing printed log lines. Change-Id: Iec2152b9fb5ca265239e7515482ff7be823eddca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023390 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736386}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityManager::GetPrimaryAccount() assumes the user has consented to browser sync. Switch to using the "unconsented" primary account, which exists whether or not the user has consented to browser sync. Bug: 1042400 Test: updated existing unit_tests Test: assistant OOBE flow still works Test: assistant works with --use-unconsented-primary-account Change-Id: I9e5d9bbb185b03c37543f5c517fdbcb99e37f359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025639 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#736385}
-
Sam Maier authored
Change-Id: I4ce96aa73a4377be2deb08060564f2ff7718d976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025924 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736384}
-
behdad authored
- The name, MissedFrame is misleading in compositor latency metrics, as we are using it for describing the dropped frames. - Unused GetStateNormalUpperLimit method is removed. This has been used before for reporting the MissedFrameLatencyIncrease which is already removed. - Comments are updated to explain the reported metrics better. Bug: none Change-Id: I98b31fc4a1c3aa6c7dedd79b28aa87616a78d2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024333Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736383}
-
Laís Minchillo authored
Add metrics for AndroidX methods usage, similar to what's already implemented to measure usage of Android APIs. Bug: 1031188 Change-Id: Ie103fee2f3cd8134ed59090eb298b5b9612eb953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953215 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736382}
-
Fredrik Söderquist authored
When the timing update needs to process a large "jump" in time, after for instance the page having been suspended for a significant amount of time, it is possible to get into a state where a lot of new intervals are generated (essentially all the intervals within the elapsed time interval). New intervals in turn can generate additional, future (relative to the current time in the elapsed time interval), intervals. Intervals that are not yet started can be discarded and resolved again when new instance times arrive. In this case we would start the interval resolution from the earliest possible time, meaning that any such (re)resolve would devolve into a linear search through all the previous intervals. For animations with short cycles (and cyclic dependencies) this could turn into a lot of work. When we've resolved the/a first interval, and it's not the actual first interval we're (re)resolving, we can use the end of the previous interval as the basis for computing the "begin after" ("start of search") time passed to ResolveInterval(), since this should provide an accurate lower bound for the new interval. This limits the search space greatly thus reducing the amount of time spent resolving intervals in the "catch-up" scenarios described above. Bug: 1039243 Change-Id: Ibd5586336b56b0ccb3d61a92f1a4f09a7af5eaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026977Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#736381}
-
Marc Treib authored
If the account-scoped storage for passwords is enabled, then the user doesn't need to enable the full Sync feature to get their account passwords, so suppress the promo in this case. Bug: 1045919 Change-Id: I5bc23e67a98ddcb9843b2847111e71dcb35ee533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022768Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736380}
-
Nico Weber authored
TBR=hans@chromium.org Bug: none Change-Id: I0a2cb7a3e995acd5504a894148aee684d4c8a4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028207Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#736379}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e5630eb3b47..c6f9fe7ca38a git log 1e5630eb3b47..c6f9fe7ca38a --date=short --first-parent --format='%ad %ae %s' 2020-01-29 fmayer@google.com Make assertion explicit. Created with: gclient setdep -r src/third_party/perfetto@c6f9fe7ca38a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibb2f81b2f5f0a62b2c9824cdab1e8caa4f3d7fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736378}
-
Yi Gu authored
This test also flakes on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyQAsSBUZsYWtlIjVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEFwcEJhY2tncm91bmRQYWdlQXBpVGVzdC5CYXNpYww TBR=karandeepb@chromium.org Bug: 1044265 Change-Id: I378a3cea097f8a03457ec085bbe451f9395f3bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027888Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736377}
-
Roman Sorokin authored
Fixed: 1013083 Change-Id: Ieb37ce9a658d94d08aeed7d3e6198da96491d5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953003Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736376}
-
Wez authored
IntlHash is no longer a valid DOM |code| value, so has been removed from the DomCode table. However, since the IntlHash code is still distinct from Backslash at the USB level, but real keyboards only have one or the other, the remapping is still valuable when dealing with real USB Usage codes. Bug: 952051 Change-Id: I25a1fa5a5d182bca2a99025b7cc4289c24ed2121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025408 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736375}
-
Wez authored
Providing memory pressure information to the GPU process to allow it to manage caches, etc more effectively. Bug: 1020698 Change-Id: Ie92c5cb59cfff80a851a65867a8320ad2bcf8917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024853 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736374}
-
Tim Volodine authored
This reverts commit 5d840711. Reason for revert: the previous breakage and revert was due to an internal patch not having rolled into chromium. It has now, so relanding this CL. (crbug.com/1046775) Original change's description: > Revert "Move AwMetricsServiceClient logic into components for reuse by WebLayer" > > This reverts commit 43e5153c. > > Reason for revert: > broke some build bots, see https://bugs.chromium.org/p/chromium/issues/detail?id=1046775 > > https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/20782 > > > Original change's description: > > Move AwMetricsServiceClient logic into components for reuse by WebLayer > > > > The corresponding WebLayer changes are in a follow on CL. The TBR is for > > the new DEP file which needs content/public/browser. > > > > TBR=jam@chromium.org > > > > Bug: 1025781 > > Change-Id: Ie895ba7246761416d52c98ae3d4b241fed62fa45 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926505 > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#736313} > > TBR=jam@chromium.org,boliu@chromium.org,asvitkine@chromium.org,blundell@chromium.org,alexclarke@chromium.org,tobiasjs@chromium.org,ntfschr@chromium.org > > Change-Id: I2e52f5da2c62f769cedbcaa4671f1a0ebe193be5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1025781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028047 > Reviewed-by: Tim Volodine <timvolodine@chromium.org> > Commit-Queue: Tim Volodine <timvolodine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736366} TBR=jam@chromium.org,boliu@chromium.org,asvitkine@chromium.org,blundell@chromium.org,timvolodine@chromium.org,alexclarke@chromium.org,tobiasjs@chromium.org,ntfschr@chromium.org Change-Id: I24cbdc73208dcc78040ca1e5a2904cf0d06c6e52 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028127Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736373}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc49b0ca9816..45c948791441 git log dc49b0ca9816..45c948791441 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 robertphillips@google.com Add SkImage::MakeTextureFromCompressed and deprecate MakeFromCompressed Created with: gclient setdep -r src/third_party/skia@45c948791441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I443804772083768a2000332fe0b740b61503564f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736372}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a086532c..bf682ef3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2f7d9e686ce4605e285773bf4d19529d17c8ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027594Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736371}
-
Eric Seckler authored
Previously, we were relating the microsecond-granularity sequence-local clocks to CLOCK_MONOTONIC, which meant that trace processor has to find a 2-step path via CLOCK_MONOTONIC to CLOCK_BOOTTIME, which is rather slow. Instead, tie the sequence-local monotonic clocks directly to CLOCK_BOOTTIME in their ClockSnapshots. Bug: 928738, b/148506711 Change-Id: I8247d0ca1acb76e661675cd9a732942b4d2401f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027369 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736370}
-
Jeremy Roman authored
Since this can lead to a WebContents with no committed entries, deal with that case in the browser-side Activate logic, by rejecting activations which occur before we can say with certainty that we will load a page (i.e. navigation commit). Bug: 1046121,1034740,942198 Change-Id: Icd219dc0bb1e4a9ab6fdc433f8644c14e69964e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015768Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736369}
-
Maksim Ivanov authored
This CL disables the immediate installation of updates for forced sign-in screen extensions. Before this CL, the running sign-in screen extensions would be stopped in case an updated CRX is fetched, which would potentially break the behavior on the login screen. After this CL, updates don't get installed immediately by default. The sign-in screen extensions have the possibility for explicitly supporting this (see the chrome.runtime.onUpdateAvailable event). By default, in the worst case, the update will be installed after Chrome restarts. Bug: 1012892 Tbr: rdevlin.cronin@chromium.org Change-Id: I8ebe8967ec29bfb51b729d7cb747ed7dae93b162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007711 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736368}
-
Sylvain Defresne authored
The implementation of WebStateList is non-reentrant and has sequence affinity so document this in the class comments and add DCHECK to enforce this (split the function causing mutation of the instance in two, a public interface that does the locking and an internal impl method that expect the list to be locked; this way the impl can call the other methods without releasing the lock). Bug: none Change-Id: I53aa4b6d45eb13c00e375b945dc947a5015bf4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023501 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736367}
-
Tim Volodine authored
This reverts commit 43e5153c. Reason for revert: broke some build bots, see https://bugs.chromium.org/p/chromium/issues/detail?id=1046775 https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/20782 Original change's description: > Move AwMetricsServiceClient logic into components for reuse by WebLayer > > The corresponding WebLayer changes are in a follow on CL. The TBR is for > the new DEP file which needs content/public/browser. > > TBR=jam@chromium.org > > Bug: 1025781 > Change-Id: Ie895ba7246761416d52c98ae3d4b241fed62fa45 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926505 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736313} TBR=jam@chromium.org,boliu@chromium.org,asvitkine@chromium.org,blundell@chromium.org,alexclarke@chromium.org,tobiasjs@chromium.org,ntfschr@chromium.org Change-Id: I2e52f5da2c62f769cedbcaa4671f1a0ebe193be5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028047Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736366}
-
Avi Drissman authored
base/mac/sdk_forward_declarations.h is not needed for these files any more, so remove its inclusion. Fix inclusion for files that accidentally relied on it for definitions they used. BUG=1044828 Change-Id: Ia9c7aeb9492b682c278de095aef226a258f775cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020222 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736365}
-
Gauthier Ambard authored
This reverts commit 1d0d9774. Reason for revert: It was probably failing because of the landscape device Original change's description: > [iOS] Disable failing NTP tests > > Disables failing tests on iphone-device: > > NTPHomeTestCase/testOmniboxPinnedWidthRotation > NTPHomeTestCase/testTapFakeOmniboxScrollScrolled > NTPHomeTestCase/testOmniboxWidthRotation > NTPHomeTestCase/testFavicons > NTPHomeTestCase/testTapOmniboxSearchButtonLogsCorrectly > NTPHomeTestCase/testCollectionShortcuts > NTPHomeTestCase/testTapSearchButtonFakeOmniboxScrolled > NTPHomeTestCase/testOmniboxWidthRotationBehindSettings > > TBR=gambard@chromium.org > > Bug: 1046253 > Change-Id: I7fd7a7b0f524ad9614f0f83fac0a4426ac28f7c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023527 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735813} TBR=gambard@chromium.org,javierrobles@chromium.org Change-Id: Ie438801555ee67537c0b991a5f9edb75900da518 Bug: 1046253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027450 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736364}
-
Christian Biesinger authored
Per the CSSWG resolution in https://github.com/w3c/csswg-drafts/issues/4531 This CL does no other change; in particular it does not limit the property to when contain: size is applied. That will be in a future change. Bug: 991096 Change-Id: I77eaa0ac611c8195e122095c6f5f42f6a8acd12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027286 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#736363}
-
vitaliii authored
Bug: 1034926 Change-Id: I3a13142619cc872f9c5312dc1e554e4208d4e964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025348 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736362}
-
Jan Krcal authored
Revert "[Sheriff] Disable SingleClientPreferencesSyncTest.ShouldRemoveBadDataWhenRegistering on Windows" This reverts commit f86c4c9a. Reason for revert: re-enabling the test to gather more debug logs from failures. Original change's description: > [Sheriff] Disable SingleClientPreferencesSyncTest.ShouldRemoveBadDataWhenRegistering on Windows > > TBR=jkrcal@chromium.org > > Bug: 930482 > Change-Id: Ifbb07226d94f8b42cbdf7487d20bd8d72811d96b > Reviewed-on: https://chromium-review.googlesource.com/c/1462897 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630729} TBR=jkrcal@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930482 Change-Id: I89eab360c7588fb628c94ec89e3876a7da4447c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026731 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736361}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7867592b4950..ab04f241b080 git log 7867592b4950..ab04f241b080 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 bmeurer@chromium.org Roll upstream changes. Created with: gclient setdep -r src/third_party/devtools-frontend/src@ab04f241b080 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba2c93e17d8235f874ac538629ca807e12ba0a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736360}
-
Marian Fechete authored
Metric added here: https://chromium-review.googlesource.com/c/chromium/src/+/1825358 Bug: b/148451568 Change-Id: I54ac75b118b32b3608931b53defa53e905fa5d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023895 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Auto-Submit: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#736359}
-
Rushan Suleymanov authored
Remove all callbacks from the bridge after sync stopped. Check if sync is running while sending new message. Bug: 1045953 Change-Id: I6483ef246c6b521092dcfa837f66e9d524aae549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022711 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736358}
-
Himanshu Jaju authored
Tracks the type of routing used by local device for p2p connection with other device for sharing data. Types are kept consistent with spec defined in https://w3c.github.io/webrtc-pc/#dom-rtcicecandidatetype Bug: 1021984 Change-Id: I5336e3dd50f9fbac0107b32b363d5ab9eeba7ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023495Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#736357}
-
Yuki Shiino authored
Builds the bindings of IDL enumeration generated with the new bindings generator in prod, despite that the bindings is not yet used. This patch makes it available for real use. Bug: 839389 Change-Id: Id5cafd53ab043f75c5244f8fb6a0e134c5ce861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022124 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#736356}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71a77c4b3b31..d7fade5738e7 git log 71a77c4b3b31..d7fade5738e7 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 srte@webrtc.org Makes all units and operations constexpr 2020-01-29 lundmark@webrtc.org Fix spelling. 2020-01-29 yvesg@webrtc.org Activate event tracing for unit tests. For good! 2020-01-29 philipel@webrtc.org Don't condition the time_controller target on rtc_include_tests. Created with: gclient setdep -r src/third_party/webrtc@d7fade5738e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I31945048f4505853e64b230e64b611e36e2759ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736355}
-
Hitoshi Yoshida authored
Without this forward declaration, pointer_event.h and v8_pointer_event.h make a cyclic inclusion. It triggers a compile error in definition of PointerEventInit because we don't have declarations of PointerEvent class. This error happens when we use the new code generator. Bug: 839389 Change-Id: I202d1c15dcc82c5800cc4ab8135784135f280086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026838Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#736354}
-
Ovidio Henriquez authored
This change extends the expiration by a year for: * Geolocation.AuthorizationActionExistingUser * Geolocation.AuthorizationActionNewUser * Geolocation.LocationUpdate.ErrorCode Bug: 1036861 Change-Id: I1098db07f38811886e2c2b39486fd6c5f4f73b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025580 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#736353}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c57d8970ed0e..2ee95beaf33d Created with: gclient setdep -r src-internal@2ee95beaf33d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025781 Tbr: jbudorick@google.com Change-Id: I5d2a44015a36144603a59d107986cbd4bbec7231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027574Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736352}
-
Avi Drissman authored
This conditional is true if Chromium is being built with the macOS 10.11 SDK or newer. This has been true for years. Bug: 1044838 Change-Id: Ia504b0a1b6270d31d445f2c1507716ab514cc160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025948 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736351}
-
Dominique Fauteux-Chapleau authored
See crrev.com/c/2025578 for test failure. The issue was that file_info_ was read by tests without being initialized. Change-Id: I2c7839fc5d1aa59f07ce1a46a5ca562c6dc86da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024497 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#736350}
-