- 10 Mar, 2014 40 commits
-
-
wjia@chromium.org authored
The test WebRtcGetUserMediaBrowserTest.TraceVideoCaptureDeviceAndroidPerformanceDuringGetUserMedia is not supported since content_browsertests always use faked capture device. BUG=181069 R=mcasas@chromium.org Review URL: https://codereview.chromium.org/191713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255995 0039d316-1c4b-4281-b951-d872f2087c98
-
sgurun@chromium.org authored
relevant downstream link: https://chrome-internal-review.googlesource.com/#/c/156479/ BUG=344057 Review URL: https://codereview.chromium.org/184343013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255994 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
https://codereview.chromium.org/184433003/ adds the khronos headers as the first headers to be used by EGL. Since we have Ozone platform typedefs in the khronos headers the cast is not necessary. TBR=piman@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/192823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255992 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
DISALLOW_COPY_AND_ASSIGN expands to copy constructor and assignment operator, which are spelled using an unqualified name. No functionality change, but makes clang happier. BUG=82385 R=hans@chromium.org TBR=grt@chromium.org, xhwang@chromium.org Review URL: https://codereview.chromium.org/192953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255991 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
Rewrite ProcessManagerTest to eliminate the TestingProfile dependency and switch to TestBrowserContext. This requires an ExtensionsBrowserClient that knows how to associate an incognito context with a non-incognito context. I added this in hopes it would be useful for converting other tests away from TestingProfile. BUG=315855 TEST=unit_tests ProcessManager* Review URL: https://codereview.chromium.org/189683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255990 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
chromeos::WallpaperManager::Get() either returns true or it returns not at all, thus the if(...) can be safely removed. BUG=none Review URL: https://codereview.chromium.org/189913011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255989 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Fix the the regression by providing a more reasonable default value for platform apps' default offline_enabled value: Apps default to being offline enabled unless webview permission is requested. BUG=349200,350129 TEST=ExtensionManifestOfflineEnabledTest.* and KioskTest.*LaunchAppNetworkDown Review URL: https://codereview.chromium.org/181233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255988 0039d316-1c4b-4281-b951-d872f2087c98
-
wangxianzhu@chromium.org authored
- Remove DCHECK in non-official-release build by default - Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK in release build - Remove flag --enable-dcheck Other effects/notes: - Now allow "buildtype=Official dcheck_always_on=1" (which will enable DCHECK in official build) combination. - Gyp variable logging_like_official_build no longer has an effect - Leave DCHECK_IS_ON() unchanged. May deal with it in a later change if needed. This won't affect bots which use dcheck_always_on=1. BUG=350462 TEST=LoggingTest.Dcheck R=thakis@chromium.org TBR=darin,sehr (command line changes in components/nacl and mojo) Review URL: https://codereview.chromium.org/189603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
Gather separate histograms for for first 100 received, and for missing (NACKed) packets. We should be able to take the ratio, and see any correlation of packet loss with position in the server transmitted stream. r=rch BUG=349314 Review URL: https://codereview.chromium.org/180833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255986 0039d316-1c4b-4281-b951-d872f2087c98
-
yiyaoliu@chromium.org authored
However, a lot user at under version 33 or lower, which means they don't auto-update Chrome? I'm not sure if this new piece of code will get to the affected users. BUG=334675 Review URL: https://codereview.chromium.org/177843009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255985 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=305024 For chrome/browser/sync R=jennyz@chromium.org, tapted@chromium.org TBR=zea@chromium.org Review URL: https://codereview.chromium.org/187813006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255982 0039d316-1c4b-4281-b951-d872f2087c98
-
https://developer.chrome.com/apps/tags/webviewpaulmeyer@chromium.org authored
Review URL: https://codereview.chromium.org/188743005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255977 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
No longer needed. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/191723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255976 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
Then other clients of MEDIA_TAB_AUDIO_CAPTURE, MEDIA_TAB_VIDEO_CAPTURE, MEDIA_LOOPBACK_AUDIO_CAPTURE won't have the audio processing unless the users explicitly turn on the constraints. NOTRY=true BUG=264611 Review URL: https://codereview.chromium.org/190713004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255975 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Start is deferred in relation to Stop, and when they're both called within the Start interval, the end result was started. Relands crrev.com/255322, fixing race condition in the test. BUG=347887,349987 Review URL: https://codereview.chromium.org/188653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255974 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255973 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
Please see https://codereview.chromium.org/189143008/ for trybots. R=fmalita@chromium.org Review URL: https://codereview.chromium.org/192573007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255972 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
As far as I can tell, nothing ever sets them. Remove them and the ant code that runs only when library_manifest_paths is set. No intended behavior change. BUG=177552 R=cjhopman@chromium.org Review URL: https://codereview.chromium.org/177923012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255971 0039d316-1c4b-4281-b951-d872f2087c98
-
dongseong.hwang@intel.com authored
The blacklist is the way we make features available or not. The control of accelerated video decode should rely on GPU blacklist. After this CL, Linux and Mac will output following error message when using --ignore-gpu-blacklist. "[(pid):ERROR:gpu_video_decode_accelerator.cc(303)] Not implemented reached in void content::GpuVideoDecodeAccelerator::Initialize(media::VideoCodecProfile, IPC::Message*) HW video decode acceleration not available." In addition, match macro style in video_decode_accelerator_unittest.cc to gpu_video_decode_accelerator.cc BUG=N/A Review URL: https://codereview.chromium.org/176883018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255968 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
When successfully importing a supervised user, close both the supervised user import overlay and the create new profile overlay. BUG=343723 Review URL: https://codereview.chromium.org/192573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255967 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
I'm now very familiar with the MetricsService code and believe it makes sense for me to become an OWNER here. BUG=none Review URL: https://codereview.chromium.org/191003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255966 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/191713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255965 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
R=jbauman@chromium.org, piman@chromium.org, jbauman, piman BUG=350141 Review URL: https://codereview.chromium.org/191563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255962 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Add a meaning tag to IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY to disambiguate it from IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT, which has the same text but is used in a different plural case. BUG=342370 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/192773005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255961 0039d316-1c4b-4281-b951-d872f2087c98
-
wittman@chromium.org authored
Separates bookmark UI overrides from settings overrides to avoid future conflict in requirements/goals of the two different pieces of functionality. Retains deprecated support under chrome_settings_overrides for backwards compatibility. This will be removed for the M36 release. BUG=349049 R=kalman@chromium.org, pkasting@chromium.org, vasilii@chromium.org Review URL: https://codereview.chromium.org/183883033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255959 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
fixed issue 349227: Uninit error due to DuplicateHandle failure - add check on DuplicateHandle and assign duped to be NULL on failure BUG=349227 R=sky@chromium.org, wfh@chromium.org, jschuh@chromium.org TEST=manual+drmemory Review URL: https://codereview.chromium.org/181013016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255955 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@google.com authored
Main changes: 1. Adding an IntializeAudio and InitializeVideo to CastSender. 2. Separating FrameInput to audio and video which enables initializing each separately. 3. Changing the CastSender and CastReceiver Create functions to return a scoped_ptr. These changes better align Cast with the Chromium pipeline. BUG=346822 R=hclam@chromium.org Review URL: https://codereview.chromium.org/163553006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255954 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
> Always broadcast one last "tab not blocked" notification before closing a tab. > > BUG=336386 > TEST=as in bug > > Review URL: https://codereview.chromium.org/132103005 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/192913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255952 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@google.com authored
This CL moves ChromeSigninClient from being created in SigninManagerFactory and owned by SigninManager into being a BCKS. The motivation is that other core Signin classes (e.g., *ProfileOAuth2TokenService) will need access to the SigninClient instance as well. ChromeSigninClient being a BCKS enables such access, as the respective factories can simply get the ChromeSigninClient instance from the ChromeSigninClientFactory in order to pass it in to the core classes that are being created. BUG=350710 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/192313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255951 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=348915 R=oshima@chromium.org Review URL: https://codereview.chromium.org/191073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255946 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
This CL replaces the usage of content::BrowserThread by base::Thread in a straightforward fashion. It also removes now-unneeded includes and DEPS temporary allowances relating to core Autofill test code. BUG=303083 R=joi@chromium.org Review URL: https://codereview.chromium.org/190213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255944 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Notable changes: * Replace the num-lock related methods with a single DisableNumLock(), since num-lock LED is always turned off in chromeos (more details at crbug.com/124189) * Remove SetLockedModifiers(), since DisableNumLock() and SetCapsLockEnabled() are sufficient. * Remove GetLockedModifiers(), since only CapsLockIsEnabled() is useful. BUG=none R=derat@chromium.org, yukishiino@chromium.org Review URL: https://codereview.chromium.org/189663009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255943 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255941 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
> Only notify V8 once per timezone change > > The timezone is a global property. No need to notify V8 for every single > frame. > > As a side-effect, we don't have a race with context creation. > > BUG=348856 > R=marja@chromium.org, kalman@chromium.org > > Review URL: https://codereview.chromium.org/190763008 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/190953007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255939 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
Rename to reflect what this actually does. BUG=350832 TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/192613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255937 0039d316-1c4b-4281-b951-d872f2087c98
-
beaufort.francois@gmail.com authored
Screenshot: http://i.imgur.com/6hrYh1c.png Review URL: https://codereview.chromium.org/191143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255936 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255935 0039d316-1c4b-4281-b951-d872f2087c98
-
haraken@chromium.org authored
TBR=morrita1 Review URL: https://codereview.chromium.org/189413013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255934 0039d316-1c4b-4281-b951-d872f2087c98
-
primiano@chromium.org authored
This introduces the final piece to the classifier which are able to do basic parsing for mmap and native heap traces. BUG=340294 NOTRY=true Review URL: https://codereview.chromium.org/184043006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255933 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
As ContentAutofillDriver is the //content-based driver implementation for the PasswordManager component, it belongs within the component itself rather than in the //chrome embedder of the component. BUG=348515 R=dubroy@chromium.org TBR=darin Review URL: https://codereview.chromium.org/192633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255932 0039d316-1c4b-4281-b951-d872f2087c98
-