GitLab

Changes:
Use Roboto-regular, 13px font size, 20px line height for the app title.

Demo: https://drive.google.com/open?id=10sYR2tFWezxuUYp-IpKoozHIZtMS4u-q

Bug: 869349
Change-Id: Ic5b14b3cf1df9aeaab722d04d59720c3184d731b
Reviewed-on: https://chromium-review.googlesource.com/1174898
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584106}

R=jsbell@chromium.org

Bug: 720919
Change-Id: I88447c05f40937eb7f73cc2399ce5b1a025e1911
Reviewed-on: https://chromium-review.googlesource.com/1179942Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584105}

Test: manual
Bug: 872106
Change-Id: I7c1e1f7f29ed1fac749b0ed5808d7f753cad7de5
Reviewed-on: https://chromium-review.googlesource.com/1179973Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584104}

This CL fixes the referenced bug by getting rid of the
VaapiJpegDecodeAccelerator::NotifyErrorFromDecoderThread function
entirely and ensuring that VaapiJpegDecodeAccelerator::NotifyError
notifies the client on the expected thread regardless of the thread
from which VaapiJpegDecodeAccelerator::NotifyError is called

Also, adds some documentation.

Bug: 874930
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id0556da800dd8d93e0c993d69aaa2ae041abf67d
Reviewed-on: https://chromium-review.googlesource.com/1178805
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584103}

The ability to filter out tests is vitally important when diagnosing
regressions or otherwise attempting to root out the cause of
performance degradations. Support wasn't present for the gtest_filter
flag beforehand, so this CL adds it, as well as updating the relevant
documentation.

Bug: 839491
Change-Id: I5ebb098f247b2c26d667fcfb3c699b5c27791a09
Reviewed-on: https://chromium-review.googlesource.com/1179061
Commit-Queue: Stephan Stross <stephanstross@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584102}

A comment wound up in the wrong place is CL 1141327, this moves it to
the correct location.

Bug: 211405
Change-Id: I2b7ce75d5e94764f4b577171f0804ed135a36644
Reviewed-on: https://chromium-review.googlesource.com/1178114Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584101}

Bug: 832676
Change-Id: I696021ef9b7db702eb3c7389f46dadf4cf264d4f
Reviewed-on: https://chromium-review.googlesource.com/1177961Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584100}

- Before registering the fetch make sure there is enough quota to
  complete the fetch.
- Abandon the fetch if there is no quota to persist the response.

TBR=avi@chromium.org

Bug: 872735
Change-Id: I2a8348209989f85722e20bd8a5bccc75015fbf51
Reviewed-on: https://chromium-review.googlesource.com/1169202
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584099}

It's flaky and blocking try-bots on unrelated CLs.

TBR=sandersd@chromium.org
NOTRY=true (disabling a test)

Bug: 875301
Change-Id: I8e09e1bf5d8a8f64457d49d7c5e8274719da2b32
Reviewed-on: https://chromium-review.googlesource.com/1179896Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584098}

Bug: 875268
Change-Id: I4ee6c9c2df2974d2d6e009ee03e5914832ccf4d5
Reviewed-on: https://chromium-review.googlesource.com/1179614
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584097}

Now that components/update_client/* have moved away from URLFetcher
and friends (see [1] and [2]), we can remove these helper classes.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1118646
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1160725

BUG=844973

Change-Id: I362f135a913aba9bdddaa47a6c51a282c261a900
Reviewed-on: https://chromium-review.googlesource.com/1179941Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584096}

https://chromium.googlesource.com/catapult.git/+log/c7e7bd382c39..6cef7cac8d71


git log c7e7bd382c39..6cef7cac8d71 --date=short --no-merges --format='%ad %ae %s'
2018-08-17 wangge@google.com Add `ChromeVersion` Class to Long Term Health Tool


Created with:
  gclient setdep -r src/third_party/catapult@6cef7cac8d71

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863390
TBR=sullivan@chromium.org

Change-Id: Idb6c5e26957f14785150a2b704beed6d36851ded
Reviewed-on: https://chromium-review.googlesource.com/1179335Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584095}

credit to jamescook@ for the fix

Bug: 875031
Change-Id: I4f1f0c10e45d768da0515400d0666a08937c004b
Reviewed-on: https://chromium-review.googlesource.com/1178935Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584094}

This adds web-platform-tests for Network Error Logging.  They should be
suitable to upstream into the cross-platform WPT repo.

Bug: 748549
Change-Id: I24098aeec8488c34a5f9239309264e9534dca6e4
Reviewed-on: https://chromium-review.googlesource.com/1106518Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584093}

CL https://chromium-review.googlesource.com/1144813 prevents ownerless
RefCounted receiver on base::Bind.

The class AwLoginDelegate does a PostTask in its constructor using
'this'. This violate a CHECK(...).

The CL makes the constructor private. It introduces the static method
Create(). It wraps the raw pointer in the scoped_refptr class first and
THEN call base::Bind on it.

Bug: 870479
Change-Id: Iebbd51e3136fb1a52962b8f5a0951f6b89145742
Reviewed-on: https://chromium-review.googlesource.com/1179758Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584092}

Create separate class FieldDataManager for managing user typed and
autofilled values in PasswordAutofillAgent to replace
FieldValueAndPropertiesMaskMap.

Bug: 849291
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I42e4ab99254f1551209a3c4452d5b769efd794af
Reviewed-on: https://chromium-review.googlesource.com/1126889Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584091}

To make losing bauerb@ a bit less painful.

Bug: none
Change-Id: I5e40bd22ed61266b9979bfe6c57c7aa6ff768d6c
Reviewed-on: https://chromium-review.googlesource.com/1179823Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584090}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4e86b694..a3d09098

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibb0c8f9dec0d2c27f48e73c30b9fd8b0f7ed8bd0
Reviewed-on: https://chromium-review.googlesource.com/1179806Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584089}

This CL has been put together by
1. Going to flakiness dashboard for site_per_process_webkit_layout_tests
   (see the links at the top of https://crbug.com/874695)
2. Grabbing flaky tests with slowest_run >= 3 and adding them
   to SlowTests (unless they've been already present)

Bug: 874695
Change-Id: I96c7befd3a654b1be8291921c51d539b5f6fbfb8
Reviewed-on: https://chromium-review.googlesource.com/1178226Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584088}

This reverts commit 9ca72e1a.

Reason for revert: Suspected cause of crbug.com/863361 - it seems that scrolling the viewport is still possible.

Bug: 715699, 863361

Original change's description:
> Don't promote position: fixed elements with composited descendants if they don't scroll
> 
> This is a re-land of an old CL, which was reverted in https://codereview.chromium.org/2977273002
> due to a WebView issue. We believe the underlying issue may have been resolved, so should try
> re-landing this.
> 
> Bug: 715699
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I0da6ab6f55d0fb4ba0760378f182217e8c4546c1
> Reviewed-on: https://chromium-review.googlesource.com/1112387
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571143}

TBR=flackr@chromium.org,smcgruer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 715699
Change-Id: I6a9e969a4118b75819dcd297d18d9a2ae1c9abca
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1179921Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584087}

It looks like some of the changes to ThrottlingURLLoader in
http://crrev.com/c/1157549 caused some perf regressions on mobile. This
fixes the regressions. Something with how StartInfo was created and
passed around before was causing problems.

See bugs for more info. Confirmed regressions fixed with this CL using
pinpoint.

Bug: 874902, 873881, 874918
Change-Id: I34397b8f97cffa82857f87ed19ac6ef5b61a7cac
Reviewed-on: https://chromium-review.googlesource.com/1178576Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584086}

It's been crashing flakily on various platforms, and is blocking
try-bots on unrelated CLs.

TBR=sandersd@chromium.org
NOTRY=true (disabling a test)

Bug: 875278
Change-Id: I93ebe231e45bdc813e39f465056dfc6bd1cde920
Reviewed-on: https://chromium-review.googlesource.com/1179892
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584085}

This is a PE fix for the CVC dialog.

The current credit card number obfuscation approach uses U+2006
(SIX-PER-EM SPACE) to add a small space between bullets and between
the last bullet and the first unobfuscated digit. However, that
character works as a simple space and allows line breaks inside the
obfuscated number on multiline dialog titles.

This CL adds U+2060 (WORD-JOINER) characters between bullets and
spaces in the obfuscated strings, so they can't be broken into
separate lines. A previous version tried to use U+202F (NARROW
NO-BREAK SPACE), but unfortunately the result looked too spacey on
Android. The new character is invisible, so the only visual change
is that now obfuscated numbers can't be broken.

Screenshots in the bug.

Bug: 873816
Change-Id: I927be848d2f63a5a76486668baebe64e7eb304f6
Reviewed-on: https://chromium-review.googlesource.com/1173338Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584084}

Currently, in previews, we match the document URL with the the
provided hints using substring matching. This CL changes the
matching algorithm to a wildcard matcher instead of substring
matcher.

Change-Id: I3cf827d094ee5e15a64737d9691743b29d4c0bf3
Bug: 870039
Reviewed-on: https://chromium-review.googlesource.com/1176594Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584083}

Bug: none
Change-Id: I156a2d2b7d8569e3a8fe7a17e09d52c859710ae6
Reviewed-on: https://chromium-review.googlesource.com/1179607Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584082}

This CL also refactors the method to generate the story set from benchmark into
tools/perf/core/benchmark_utils.py for better code sharing

Bug:874940
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I2a551840fd852162a4743eac769d92c6ee499bc4

NOTRY=true  # all tests passed in patch set 3

Change-Id: I2a551840fd852162a4743eac769d92c6ee499bc4
Reviewed-on: https://chromium-review.googlesource.com/1179603
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584081}

A single detector for both multiple and triple tap events on cast, as
part of the effort so that the triple tap for the magnification
gesture and the double tap inside the TouchExplorationController do
not conflict.

Bug: internal b/112634029
Test: manual and unit test

Change-Id: Ifd23bbc40eb9cfd710acce7ca387eaae137c7ba1
Reviewed-on: https://chromium-review.googlesource.com/1178640Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584080}

This is required so that the public and internal AR module can have
different names.

Bug: 863063
Change-Id: If0151c862efa2074f00868519c7f68d39836c538
Reviewed-on: https://chromium-review.googlesource.com/1178882Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584079}

Test: added test
Bug: 850630
Change-Id: I50796ab56aa2888bd77d98389a7de876f42aa0d8
Reviewed-on: https://chromium-review.googlesource.com/1179303Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584078}

Bug: 864748, 829084
Change-Id: I164d3a83345ca9fe02a31f6a09d7fc646299a436
Reviewed-on: https://chromium-review.googlesource.com/1141105Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584077}

This CL adds a feature flag to enable/disable communication with the
autofill server. It further adds a feature parameter by which the
autofill server URL can be controlled.

This functionality is to support:

  - routing a % of users to exercise a staging server environment
    to ensure better server validation before rollout.

  - turning off or rerouting autofill server traffic from the test
    bots.

By default, autofill server communication is enabled and will send
traffic to the existing autofill server.

Bug: 874553, 866940
Change-Id: I8a425c76d483731fce9ef0ef8e10ac0cc145cb1d
Reviewed-on: https://chromium-review.googlesource.com/1176287
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584076}

This patch matches to the changes in the base expectations
when flag-specific rebaselines were needed for space-only
differences.

TBR=eae@chromium.org, xiaochengh@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie93864457ba5ac3ff2d73fdc1783623a53b967e3
Reviewed-on: https://chromium-review.googlesource.com/1179735
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584075}

When calling SnackbarManager#dismissSnackbars with a persistent
snackbar, you get an IllegalStateException from Iterator#remove.

This is because we attempt to remove the persistent Snackbar from
the list of non-persistent Snackbars.

This CL splits out the logic so we iterate through the persistent
and non-persistent Snackbar deques separately.

Bug: none
Change-Id: I620ba14fd1eaa75ab5ba6a34870655218bd3fd22
Reviewed-on: https://chromium-review.googlesource.com/1179672
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584074}

Obj-c model for the manual fallback passwords view controller. Also adds
a convenience initializer from a password form.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0bdd704eb9cfa075f7cd78bdea2eaed191cd5bd0
Reviewed-on: https://chromium-review.googlesource.com/1172348Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584073}

This CL removes the image property of the ShareToData class, as it is
never set.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idd71cfe674e27705ac674c6e815e790f25a13755
Reviewed-on: https://chromium-review.googlesource.com/1179830Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584072}

Remove all references to CollectionsUIReboot flag.

Bug: 875063

Change-Id: I5222da0ba5ec50da282a434f8e075758feebb59a
Reviewed-on: https://chromium-review.googlesource.com/1178932Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584071}

Bug: 862694
Change-Id: I4ab7cb60c8e397964f88449c31ff4fd0d6f4e253
Reviewed-on: https://chromium-review.googlesource.com/1173252Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584070}

In https://crrev.com/c/833751 we stopped to create new baselines for
testharness.js tests without existing baselines. This behaviour is in
fact undesired: if a testharness.js test used to pass (and hence didn't
have a baseline), we'd like to be able to create a new baseline for it
using --reset-results if it starts to fail.

The comment is improved so hopefully that is clear enough.

Bug: 864410
Change-Id: I9b21a6e8d909585f8eb44e53dd90b488f383ea1a
Reviewed-on: https://chromium-review.googlesource.com/1179363
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584069}

The test that used to be disabled on Win only is now disabled on Mac as
well. Recent flake:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14961

Flakiness dashboard confirming the flakiness:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=components_unittests&tests=SslCastSocketTest.TestConnectEndToEndWithRealSSL

TBR=wjmaclean@chromium.org

Bug: 874491
Change-Id: Ida63c17fc4618d1944f947c3fcf0a0247bc04d57
Reviewed-on: https://chromium-review.googlesource.com/1179882Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584068}

The 'params.name == HTMLNames::classAttr' condition will never be true,
because the if-block just above it will catch that case. The
|class_name_| SVGAnimatedProperty object is registered in the attribute
map. Retain and update the comment about the somewhat special handling
of the 'class' attribute.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9928fb6f9c29d5db961b7f937fe4b1c0fb3fde82
Reviewed-on: https://chromium-review.googlesource.com/1179749Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#584067}